Fix whitespace in last change in top.c
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
15b07e4f
EZ
12019-12-21 Eli Zaretskii <eliz@gnu.org>
2
3 * top.c (print_gdb_configuration): Print "--with-xxhash" or
4 "--without-xxhash" according to HAVE_LIBXXHASH.
5
1c7148dd
WP
62019-12-20 Weimin Pan <weimin.pan@oracle.com>
7 * ctfread.c (ctf_file_key): Change type to objfile_key.
8 (struct ctf_context): Remove typedef.
9 (get_objfile_text_range): Use ANOFFSET to get text base.
10
d0922fcf
TBA
112019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
12
13 * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
14 New function.
15 (read_subroutine_type): Validate the parsed
16 DW_AT_calling_convention value before assigning it to a
17 subroutine's calling_convention attribute.
18 * gdbtypes.h (struct func_type) <calling_convention>: Use
19 an enum bitfield as its type, instead of plain unsigned.
20
099a6354
TBA
212019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
22
23 PR gdb/25054
24 * infcall.c (call_function_by_hand_dummy): Update the argument-
25 passing section for call-by-value parameters.
26 (struct destructor_info): New struct.
27 (call_destructors): New auxiliary function.
28
62bf63d7
TBA
292019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
30
31 * gnu-v3-abi.c (enum definition_style): New enum type.
32 (get_def_style): New function.
33 (is_user_provided_def): New function.
34 (is_implicit_def): New function.
35 (is_copy_or_move_constructor_type): New function.
36 (is_copy_constructor_type): New function.
37 (is_move_constructor_type): New function.
38 (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
39 for a given type.
40
9d084466
TBA
412019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
42
43 * language.h (struct language_pass_by_ref_info): New struct.
44 (struct language_defn)<la_pass_by_reference>: Change the signature
45 to return a language_pass_by_ref_info instead of an int.
46 (language_pass_by_reference): Ditto.
47 (default_pass_by_reference): Ditto.
48 Adjust the users listed below.
49 * arch-utils.c (default_return_in_first_hidden_param_p):
50 Update.
51 * cp-abi.c (cp_pass_by_reference): Update.
52 * cp-abi.h (cp_pass_by_reference): Update declaration.
53 (struct cp_abi_ops)<pass_by_reference>: Update.
54 * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
55 * infcall.c (call_function_by_hand_dummy): Update.
56 * language.c (language_pass_by_reference): Update.
57 (default_pass_by_reference): Update.
58 * tic6x-tdep.c (tic6x_return_value): Update.
59
e35000a7
TBA
602019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
61
62 * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
63 and DW_AT_deleted attributes of a function.
64 (read_structure_type): Read the DW_AT_calling_convention attribute
65 of a type.
66 (is_valid_DW_AT_defaulted): New function.
67 (is_valid_DW_AT_calling_convention_for_type): New function.
68 * gdbtypes.h: Include dwarf2.h.
69 (struct fn_field)<defaulted>: New field to store the
70 DW_AT_defaulted attribute.
71 (struct fn_field)<is_deleted>: New field to store the
72 DW_AT_deleted attribute.
73 (struct cplus_struct_type)<calling_convention>: New field to store
74 the DW_AT_calling_convention attribute.
75 (TYPE_FN_FIELD_DEFAULTED): New macro.
76 (TYPE_FN_FIELD_DELETED): New macro.
77 (TYPE_CPLUS_CALLING_CONVENTION): New macro.
78 * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
79 to the .h file.
80 (print_cplus_stuff): Likewise.
81
b4b49dcb
TT
822019-12-20 Tom Tromey <tom@tromey.com>
83
84 * tui/tui.c (tui_show_source): Remove.
85 * tui/tui.h (tui_show_source): Don't declare.
86 * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
87 tui_show_source.
88
eb390f49
TT
892019-12-20 Tom Tromey <tom@tromey.com>
90
91 * tui/tui-stack.h (tui_show_frame_info): Return bool.
92 * tui/tui-stack.c (tui_show_frame_info): Return bool.
93 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
94 Update.
95
fc9d2d72
TT
962019-12-20 Tom Tromey <tom@tromey.com>
97
98 PR tui/18932:
99 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
100 Rename parameters. Handle the not-from-stack-frame case.
101 (from_stack, from_source_symtab): New globals.
102 (tui_before_prompt, tui_normal_stop): Update.
103 (tui_context_changed, tui_symtab_changed): New functions.
104 (tui_attach_detach_observers): Attach new observers.
105
a75cd9a2
TT
1062019-12-20 Tom Tromey <tom@tromey.com>
107
108 * source.c (struct current_source_location) <set, symtab, line>:
109 New methods.
110 <m_symtab, m_line>: Rename. Now private.
111 (get_current_source_symtab_and_line)
112 (set_default_source_symtab_and_line)
113 (set_current_source_symtab_and_line)
114 (clear_current_source_symtab_and_line, select_source_symtab)
115 (info_source_command, print_source_lines_base)
116 (info_line_command, search_command_helper): Update.
117 * observable.h (current_source_symtab_and_line_changed): Declare
118 observable.
119 * observable.c (current_source_symtab_and_line_changed): Define
120 observable.
121
2dfd3df4
TT
1222019-12-20 Tom Tromey <tom@tromey.com>
123
124 * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
125 (tui_before_prompt, tui_normal_stop): Update.
126
54217b84
TT
1272019-12-20 Tom Tromey <tom@tromey.com>
128
129 * tui/tui-winsource.c
130 (tui_source_window_base::update_source_window_as_is): Don't call
131 set_current_source_symtab_and_line.
132
0ab92974
TT
1332019-12-20 Tom Tromey <tom@tromey.com>
134
135 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
136 Take a symtab_and_line.
137 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
138 symtab_and_line.
139 (tui_show_frame_info): Update.
140
ae4393e2
TT
1412019-12-20 Tom Tromey <tom@tromey.com>
142
143 * tui/tui-stack.c (tui_show_frame_info): Don't call
144 update_exec_info.
145
77b97e00
TT
1462019-12-20 Tom Tromey <tom@tromey.com>
147
148 * tui/tui.c (tui_enable): Call tui_display_main.
149
52469d76
TT
1502019-12-20 Tom Tromey <tom@tromey.com>
151
152 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
153 get_current_source_symtab_and_line, and main_name.
154
5d49bf1b
TT
1552019-12-20 Tom Tromey <tom@tromey.com>
156
157 * tui/tui.c (tui_show_source): Update.
158 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
159 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
160 a symtab_symbol_info, not a separate symtab and line. Simplify.
161
88180c08
TT
1622019-12-20 Tom Tromey <tom@tromey.com>
163
164 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
165 Simplify.
166
9f7540a5
TT
1672019-12-20 Tom Tromey <tom@tromey.com>
168
169 * tui/tui-winsource.h (struct tui_source_window_base)
170 <set_contents, update_source_window_as_is, update_source_window>:
171 Take a sal, not a separate symtab and tui_line_or_address.
172 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
173 (tui_source_window_base::update_source_window_as_is): Take a sal,
174 not a separate symtab and tui_line_or_address.
175 (tui_update_source_windows_with_addr)
176 (tui_update_source_windows_with_line)
177 (tui_source_window_base::rerender)
178 (tui_source_window_base::refill): Update.
179 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
180 a sal, not a separate symtab and tui_line_or_address.
181 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
182 not a separate symtab and tui_line_or_address.
183 (tui_source_window::maybe_update): Update.
184 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
185 a sal, not a separate symtab and tui_line_or_address.
186 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
187 not a separate symtab and tui_line_or_address.
188 (tui_disasm_window::do_scroll_vertical)
189 (tui_disasm_window::maybe_update): Update.
190
57e4b379
TT
1912019-12-20 Tom Tromey <tom@tromey.com>
192
193 * tui/tui-winsource.c (tui_source_window_base::refill): Use
194 start_line_or_addr.
195 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
196 start_line_or_addr.
197 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
198 start_line_or_addr.
199
61c33f10
TT
2002019-12-20 Tom Tromey <tom@tromey.com>
201
202 * tui/tui-winsource.h (struct tui_source_window_base)
203 <set_contents>: Return bool.
204 * tui/tui-winsource.c
205 (tui_source_window_base::update_source_window_as_is): Update.
206 * tui/tui-source.h (struct tui_source_window) <set_contents>:
207 Return bool.
208 * tui/tui-source.c (tui_source_window::set_contents): Return
209 bool. Simplify.
210 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
211 Return bool.
212 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
213 bool.
214
469b0731
TT
2152019-12-20 Tom Tromey <tom@tromey.com>
216
217 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
218 (tui_update_source_windows_with_line): Call update_source_window.
219 * tui/tui-source.h (struct tui_source_window)
220 <show_symtab_source>: Don't declare.
221 * tui/tui-source.c (tui_source_window::show_symtab_source):
222 Remove.
223
855f89b3
TT
2242019-12-20 Tom Tromey <tom@tromey.com>
225
226 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
227 update_source_window directly.
228 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
229 * tui/tui-disasm.c (tui_show_disassem): Remove.
230
d4669c0f
TT
2312019-12-20 Tom Tromey <tom@tromey.com>
232
233 * tui/tui-winsource.c
234 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
235 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
236
1ae58f0c
TT
2372019-12-20 Tom Tromey <tom@tromey.com>
238
239 * tui/tui-winsource.h (struct tui_source_window_base)
240 <maybe_update>: Remove line_no and addr parameters.
241 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
242 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
243 Update.
244 * tui/tui-source.c (tui_source_window::maybe_update): Remove
245 line_no and addr parameters.
246 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
247 Update.
248 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
249 line_no and addr parameters.
250
039298ec
TT
2512019-12-20 Tom Tromey <tom@tromey.com>
252
253 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
254 (tui_source_window_base::update_breakpoint_info): Remove asserts.
255
8acfefcc
TT
2562019-12-20 Tom Tromey <tom@tromey.com>
257
258 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
259 tui_show_disassem.
260 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
261 declare.
262 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
263
5ebd5402
TT
2642019-12-20 Tom Tromey <tom@tromey.com>
265
266 * tui/tui.h (tui_show_source): Remove parameters.
267 * tui/tui.c (tui_show_source): Remove parameters.
268 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
269
c1b167d7
TT
2702019-12-20 Tom Tromey <tom@tromey.com>
271
272 * tui/tui.c (tui_show_source): Update.
273 * tui/tui-winsource.c (tui_display_main): Update.
274 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
275 to symtab.
276 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
277 to symtab.
278 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
279
364d7104
TT
2802019-12-20 Tom Tromey <tom@tromey.com>
281
282 PR tui/23619:
283 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
284 (tui_redisplay_readline): Use rl_display_prompt.
285 (tui_prep_terminal): Update.
286
0ad6b8ee
CB
2872019-12-19 Christian Biesinger <cbiesinger@google.com>
288
289 * configure: Regenerate.
290 * configure.ac: Quote variable arguments of test.
291 * gdbsupport/common.m4: Likewise.
292
d411762c
CB
2932019-12-19 Christian Biesinger <cbiesinger@google.com>
294
295 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
296 2 to pow ().
297
1cd4a20a
CB
2982019-12-19 Christian Biesinger <cbiesinger@google.com>
299
300 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
301 log10 to double to fix Solaris 11 with gcc 5.5.
302
aa989b27
CB
3032019-12-19 Christian Biesinger <cbiesinger@google.com>
304
305 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
306 "sun" to "saddr_un".
307
2032eb7e
TT
3082019-12-19 Tom Tromey <tromey@adacore.com>
309
310 * ui-out.h (enum class field_kind): Fix comment.
311
f69656d0
TT
3122019-12-11 Tom Tromey <tromey@adacore.com>
313
314 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
315
27e4fac7
TT
3162019-12-18 Tom Tromey <tromey@adacore.com>
317
318 PR build/25268:
319 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
320 type on macOS. Add comment.
321
e623f035
SM
3222019-12-18 Simon Marchi <simon.marchi@efficios.com>
323
324 * c-lang.c (c_get_string, asm_language_defn): Remove space
325 before tab.
326
28ce7b07
TT
3272019-12-18 Tom Tromey <tromey@adacore.com>
328
329 PR build/25250:
330 * ui-out.c (ui_out::vmessage): Update.
331 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
332 Rename.
333 (string_field): Update.
334 (signed_field): Update.
335
bbde7025
SM
3362019-12-18 Simon Marchi <simon.marchi@efficios.com>
337
338 * top.c (print_gdb_configuration): Adjust indentation.
339
e3169fe0
CB
3402019-12-17 Christian Biesinger <cbiesinger@google.com>
341
342 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
343
9b30da15
SM
3442019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
345
346 * tui/tui-layout.h (class tui_layout_base): Add virtual
347 destructor.
348
4a4c04f1
BE
3492019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
350
351 * infcmd.c (prepare_one_step): Step over skipped inline functions.
352 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
353 (process_event_stop_test): Keep stepping over skipped inline functions.
354
0394eed1
SM
3552019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
356
357 * jit.c (struct gdb_block) <next>: Remove field.
358 (struct gdb_symtab) <~gdb_symtab>: Remove.
359 <blocks>: Change type to std::forward_list<gdb_block>.
360 (compare_block): Remove.
361 (jit_block_open_impl): Adjust to std::forward_list. Place the new
362 block at the beginning, don't mind about sorting.
363 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
364 before using it.
365
b6112117
SM
3662019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
367
368 * jit.c (struct gdb_block): Add constructor, initialize
369 real_block and next fields.
370 <name>: Change type to gdb::unique_xmalloc_ptr.
371 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
372 (jit_block_open_impl): Allocate gdb_block with new.
373 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
374
1b61f46d
SM
3752019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
376
377 * jit.c: Include forward_list.
378 (struct gdb_symtab) <next>: Remove field.
379 (struct gdb_object) <symtabs>: Change type to
380 std::forward_list<gdb_symtab>.
381 (jit_object_open_impl): Allocate gdb_object with new.
382 (jit_symtab_open_impl): Adjust to std::forward_list.
383 (finalize_symtab): Don't delete symtab.
384 (jit_object_close_impl): Adjust to std::forward_list. Free
385 gdb_object with delete.
386
89867184
SM
3872019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
388
389 * jit.c (struct gdb_symtab): Add constructor, destructor,
390 initialize fields.
391 <linetable>: Change type to unique_xmalloc_ptr.
392 <file_name>: Change type to std::string.
393 (jit_symtab_open_impl): Allocate gdb_symtab with new.
394 (jit_symtab_line_mapping_add_impl): Adjust.
395 (finalize_symtab): Adjust, call delete on stab.
396
d043f8c8
SM
3972019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
398
399 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
400
d9fa87f4
TT
4012019-12-16 Tom Tromey <tromey@adacore.com>
402
403 * windows-nat.c (windows_nat_target::attach): Update.
404 * remote.c (extended_remote_target::attach): Update.
405 * procfs.c (procfs_target::attach): Update.
406 * nto-procfs.c (nto_procfs_target::attach): Update.
407 (nto_procfs_target::create_inferior): Update.
408 * inf-ptrace.c (inf_ptrace_target::attach): Update.
409 * gnu-nat.c (gnu_nat_target::attach): Update.
410 (gnu_nat_target::detach): Update.
411 * darwin-nat.c (darwin_nat_target::attach): Update.
412 * corefile.c (get_exec_file): Constify result. Remove extraneous
413 return.
414 * bsd-kvm.c (bsd_kvm_target_open): Update.
415 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
416
c0c3707f
CB
4172019-12-16 Christian Biesinger <cbiesinger@google.com>
418
419 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
420 (we no longer need to include time.h before pathmax.h)
421
d3ecddab
CB
4222019-12-15 Christian Biesinger <cbiesinger@google.com>
423
424 * ada-exp.y (write_ambiguous_var): Update.
425 * coffread.c (process_coff_symbol): Update.
426 * ctfread.c (ctf_add_enum_member_cb): Update.
427 (new_symbol): Update.
428 * dwarf2read.c (fixup_go_packaging): Update.
429 (new_symbol): Update.
430 * language.c (language_alloc_type_symbol): Update.
431 * mdebugread.c (new_symbol): Update.
432 * minsyms.c (minimal_symbol_reader::record_full): Update.
433 * psymtab.c (add_psymbol_to_bcache): Update.
434 * stabsread.c (define_symbol): Update.
435 (read_enum_type): Update.
436 * symtab.c (symbol_set_language): Make this a member function...
437 (general_symbol_info::set_language): ... here.
438 * symtab.h (struct general_symbol_info) <set_language>: New function.
439 (SYMBOL_SET_LANGUAGE): Remove.
440 (symbol_set_language): Remove.
441
c1b5c1eb
CB
4422019-12-15 Christian Biesinger <cbiesinger@google.com>
443
444 * ada-lang.c (ada_add_block_symbols): Update.
445 (ada_collect_symbol_completion_matches): Update.
446 * ax-gdb.c (gen_expr): Update.
447 * block.c (block_lookup_symbol): Update.
448 (block_lookup_symbol_primary): Update.
449 (block_find_symbol): Update.
450 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
451 * dbxread.c (process_one_symbol): Update.
452 * dictionary.c (insert_symbol_hashed): Update.
453 (collate_pending_symbols_by_language): Update.
454 (mdict_add_symbol): Update.
455 * dwarf-index-write.c (write_psymbols): Update.
456 * dwarf2read.c (fixup_go_packaging): Update.
457 * findvar.c (read_var_value): Update.
458 * ft32-tdep.c (ft32_skip_prologue): Update.
459 * go-lang.c (go_symbol_package_name): Update.
460 * language.h (scoped_switch_to_sym_language_if_auto::
461 scoped_switch_to_sym_language_if_auto): Update.
462 * linespec.c (find_method): Update.
463 (find_label_symbols_in_block): Update.
464 * mdebugread.c (parse_symbol): Update.
465 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
466 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
467 (minimal_symbol_reader::install): Update.
468 * moxie-tdep.c (moxie_skip_prologue): Update.
469 * parse.c (parse_exp_in_context): Update.
470 * psymtab.c (psymbol_name_matches): Update.
471 (match_partial_symbol): Update.
472 (lookup_partial_symbol): Update.
473 (psymbol_hash): Update.
474 (psymbol_compare): Update.
475 * python/py-framefilter.c (extract_sym): Update.
476 (py_print_single_arg): Update.
477 * stabsread.c (define_symbol): Update.
478 * stack.c (print_frame_arg): Update.
479 (find_frame_funname): Update.
480 (info_frame_command_core): Update.
481 * symfile.c (set_initial_language): Update.
482 * symtab.c (symbol_set_demangled_name): Update.
483 (symbol_get_demangled_name): Update.
484 (symbol_set_language): Update.
485 (symbol_find_demangled_name): Update.
486 (symbol_set_names): Update.
487 (general_symbol_info::natural_name): Update.
488 (general_symbol_info::demangled_name): Update.
489 (general_symbol_info::search_name): Update.
490 (symbol_matches_search_name): Update.
491 (eq_symbol_entry): Update.
492 (iterate_over_symbols): Update.
493 (completion_list_add_symbol): Update.
494 (completion_list_add_msymbol): Update.
495 (completion_list_add_fields): Update.
496 * symtab.h (struct general_symbol_info) <language>: New function.
497 <language>: Rename to...
498 <m_language>: ...this.
499 (SYMBOL_LANGUAGE): Remove.
500 (MSYMBOL_LANGUAGE): Remove.
501 (struct symbol) <ctor>: Update.
502 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
503
747cfc8c
CB
5042019-12-15 Christian Biesinger <cbiesinger@google.com>
505
506 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
507 set the language of sym.
508 * language.c (language_alloc_type_symbol): Likewise.
509
ff8577f6
SDJ
5102019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
511
512 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
513 PR gdb/23613
514 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
515 * corelow.c: Include 'gdbsupport/pathstuff.h'.
516 (core_target_open): Use 'gdb_abspath'.
517 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
518 'current_directory == NULL' case.
519 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
520 explain what happens when 'current_directory' is NULL.
521 * go32-nat.c (go32_nat_target::wait): Check if
522 'current_directory' is NULL before call to 'chdir'.
523 * source.c (add_path): Use 'gdb_abspath'.
524 * top.c: Include 'gdbsupport/pathstuff.h'.
525 (init_history): Use 'gdb_abspath'.
526 (set_history_filename): Likewise.
527 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
528 (tfile_target_open): Use 'gdb_abspath'.
529
234c3068
TT
5302019-12-13 Tom Tromey <tromey@adacore.com>
531
532 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
533 warning or error.
534
93537683
TT
5352019-12-13 Tom Tromey <tromey@adacore.com>
536
537 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
538
63456183
TT
5392019-12-13 Tom Tromey <tromey@adacore.com>
540
541 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
542
98f9338a
TT
5432019-12-13 Tom Tromey <tromey@adacore.com>
544
545 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
546
3cb5a3a1
TT
5472019-12-13 Tom Tromey <tromey@adacore.com>
548
549 * gdbsupport/common-utils.c (string_printf, string_vprintf)
550 (string_vappendf): Add ARI comment.
551
c6cbf900
TT
5522019-12-13 Tom Tromey <tromey@adacore.com>
553
554 * contrib/ari/gdb_ari.sh: Remove "fix" call for
555 floatformat_to_double.
556 * target-float.c (host_float_ops<T>::from_target): Add ARI
557 comment.
558
036003a6
TT
5592019-12-13 Tom Tromey <tromey@adacore.com>
560
561 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
562 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
563 ARI marker to abort.
564 * event-top.c (handle_sigsegv): Add ARI marker to abort.
565
8aaaf757
TT
5662019-12-13 Tom Tromey <tromey@adacore.com>
567
568 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
569
fe56157f
TT
5702019-12-13 Tom Tromey <tromey@adacore.com>
571
572 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
573
a15a95ed
TT
5742019-12-13 Tom Tromey <tromey@adacore.com>
575
576 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
577 checks.
578
a5513db2
TT
5792019-12-13 Tom Tromey <tromey@adacore.com>
580
581 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
582 end>: No longer "const".
583
3a90f266
SM
5842019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
585
586 * jit.c: Fix indentation, replace spaces with tabs where
587 applicable.
588
b3f4b80f
JL
5892019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
590
591 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
592
e671856c
TT
5932019-12-12 Tom Tromey <tom@tromey.com>
594
595 * objfiles.h (struct objfile) <partial_symtabs>: Now a
596 unique_ptr.
597
7d7167ce
TT
5982019-12-12 Tom Tromey <tom@tromey.com>
599
600 * progspace.h (objfile_list): New typedef.
601 (class unwrapping_objfile_iterator)
602 (struct unwrapping_objfile_range): Newl
603 (struct program_space) <objfiles_range>: Change type.
604 <objfiles>: Change return type.
605 <add_objfile>: Change type of "objfile" parameter.
606 <objfiles_list>: Now a list of shared_ptr.
607 * progspace.c (program_space::add_objfile): Change type of
608 "objfile". Update.
609 (program_space::remove_objfile): Update.
610 * objfiles.h (struct objfile) <~objfile>: Make public.
611 * objfiles.c (objfile::make): Update.
612 (objfile::unlink): Don't call delete.
613
343cc952
TT
6142019-12-12 Tom Tromey <tom@tromey.com>
615
616 * symfile.c (symbol_file_clear): Update.
617 * progspace.h (struct program_space) <free_all_objfiles>: Declare
618 method.
619 * progspace.c (program_space::free_all_objfiles): New method.
620 * objfiles.h (free_all_objfiles): Don't declare.
621 * objfiles.c (free_all_objfiles): Move to program_space.
622
d0801dd8
TT
6232019-12-12 Tom Tromey <tom@tromey.com>
624
625 * progspace.c (program_space::add_objfile)
626 (program_space::remove_objfile): Update.
627 (program_space::multi_objfile_p): Remove.
628 * objfiles.h (struct objfile) <next>: Remove.
629 * objfiles.c (objfile::objfile): Update.
630 (put_objfile_before): Update.
631 (unlink_objfile): Update.
632 * progspace.h (object_files): Remove.
633 (struct program_space) <objfiles_head>: Remove.
634 <objfiles_list>: New member.
635 <objfiles_range, objfiles_safe_range>: Change type.
636 (objfiles): Change return type.
637 (objfiles_safe): Update.
638 (multi_objfile_p): Rewrite and inline.
639 (object_files): Remove macro.
640
13bff726
TT
6412019-12-12 Tom Tromey <tom@tromey.com>
642
643 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
644 second constructor.
645 (basic_safe_range): New class.
646
deeafabb
TT
6472019-12-12 Tom Tromey <tom@tromey.com>
648
649 * progspace.c (program_space::multi_objfile_p): New method.
650 * printcmd.c (info_symbol_command): Update.
651 * maint.c (maintenance_translate_address): Update.
652 * objfiles.h (MULTI_OBJFILE_P): Remove.
653 * progspace.h (struct program_space) <multi_objfile_p>: New
654 method.
655
23452926
TT
6562019-12-12 Tom Tromey <tom@tromey.com>
657
658 * progspace.h (struct program_space) <remove_objfile>: Declare.
659 * progspace.c (program_space::remove_objfile): New method.
660 * objfiles.c (unlink_objfile): Remove.
661 (objfile::unlink): Call remove_objfile.
662 (objfile): Don't call unlink_objfile.
663
7cac64af
TT
6642019-12-12 Tom Tromey <tom@tromey.com>
665
666 * progspace.h (struct program_space) <add_objfile>: Declare
667 method.
668 * progspace.c (program_space::add_objfile): New method.
669 * objfiles.c (~objfile): Don't unlink objfile.
670 (put_objfile_before): Remove.
671 (add_separate_debug_objfile): Don't call put_objfile_before.
672 (objfile::make): Call add_objfile. Set new_objfiles_available on
673 the per-program-space data.
674
268e4f09
TT
6752019-12-12 Tom Tromey <tom@tromey.com>
676
677 * symfile.c (syms_from_objfile_1): Use objfile_up.
678 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
679 method.
680 (reread_symbols): Use objfile_up.
681 * solib.c (update_solib_list, reload_shared_libraries_1): Call
682 unlink method.
683 * objfiles.h (struct objfile) <~objfile>: Now private.
684 <unlink>: New method.
685 (struct objfile_deleter): New.
686 (objfile_up): New typedef.
687 * objfiles.c (objfile::unlink): New method.
688 (free_objfile_separate_debug, free_all_objfiles)
689 (objfile_purge_solibs): Use it.
690 * jit.c (jit_unregister_code): Remove.
691 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
692 objfile.
693 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
694 objfile.
695 * compile/compile-object-load.c (compile_object_load): Use
696 objfile_up.
697
f65fe570
TT
6982019-12-12 Tom Tromey <tom@tromey.com>
699
700 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
701 objfile::make.
702 * objfiles.h (struct objjfile) <make>: No longer inline.
703 (add_separate_debug_objfile): Don't declare.
704 * objfiles.c (add_separate_debug_objfile): Now static.
705 (objfile::make): Move from objfiles.h. Call
706 add_separate_debug_objfile. Add "parent" parameter.
707
bda13cdc
TT
7082019-12-12 Tom Tromey <tom@tromey.com>
709
710 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
711 * objfiles.h (struct objfile): Make constructor private.
712 <make>: New static method.
713 * jit.c (jit_object_close_impl): Update.
714
7190276c
SM
7152019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
716
717 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
718 gdb::byte_vector.
719
d61df897
TT
7202019-12-12 Tom Tromey <tromey@adacore.com>
721
722 * xml-support.c (xml_fetch_content_from_file): Don't call
723 malloc_failure.
724 * utils.h (class gdb_argv): Remove malloc_failure comment.
725 * utils.c (gdb_argv::reset): Don't call malloc_failure.
726
db3ad2f0
TT
7272019-12-12 Tom Tromey <tromey@adacore.com>
728
729 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
730 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
731 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
732 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
733 * riscv-ravenscar-thread.c: New file.
734 * riscv-ravenscar-thread.h: New file.
735 * riscv-tdep.c (riscv_gdbarch_init): Call
736 register_riscv_ravenscar_ops.
737
2ffe5b9c
TT
7382019-12-12 Tom Tromey <tromey@adacore.com>
739
740 * gdbsupport/thread-pool.c (set_thread_name): Use
741 ATTRIBUTE_UNUSED.
742
39f34d7b
LM
7432019-12-12 Luis Machado <luis.machado@linaro.org>
744
745 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
746 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
747 macros.
748
d4eeccfe
TT
7492019-12-11 Tom Tromey <tom@tromey.com>
750
751 * tui/tui-win.c (tui_set_win_height_command): Call
752 tui_adjust_window_height.
753 (tui_adjust_win_heights, new_height_ok): Remove.
754 * tui/tui-layout.h (tui_adjust_window_height): Declare.
755 * tui/tui-layout.c (tui_adjust_window_height): New function.
756
3d979945
TT
7572019-12-11 Tom Tromey <tom@tromey.com>
758
759 * tui/tui-win.c (tui_resize_all): Remove code, call
760 tui_apply_current_layout.
761
2192a9d3
TT
7622019-12-11 Tom Tromey <tom@tromey.com>
763
764 * tui/tui-layout.h (tui_apply_current_layout): Declare.
765 * tui/tui-layout.c (standard_layouts, applied_layout): New
766 globals.
767 (tui_apply_current_layout): New function.
768 (show_layout): Set applied_layout. Call
769 tui_apply_current_layout.
770 (show_source_command, show_disasm_command)
771 (show_source_disasm_command, show_data)
772 (show_source_or_disasm_and_command): Remove.
773 (initialize_layouts): New function.
774 (_initialize_tui_layout): Call initialize_layouts.
775
389e7ddb
TT
7762019-12-11 Tom Tromey <tom@tromey.com>
777
778 * tui/tui-layout.h (class tui_layout_base)
779 (class tui_layout_window, class tui_layout_split): New.
780 * tui/tui-layout.c (tui_get_window_by_name)
781 (tui_layout_window::clone, tui_layout_window::apply)
782 (tui_layout_window::get_sizes, tui_layout_window::add_split)
783 (tui_layout_split::add_window, tui_layout_split::clone)
784 (tui_layout_split::get_sizes)
785 (tui_layout_split::set_weights_from_heights)
786 (tui_layout_split::adjust_size, tui_layout_split::apply): New
787 functions.
788 (tui_layout_split::add_split, tui_layout_split::add_split)
789 (tui_layout_split::set_weights_from_heights)
790 (tui_layout_split::set_weights_from_heights): New functions.
791
fb3184d8
TT
7922019-12-11 Tom Tromey <tom@tromey.com>
793
794 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
795 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
796 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
797 * tui/tui-data.h (struct tui_point): Remove.
798 (struct tui_gen_win_info) <origin>: Remove.
799 <x, y>: New fields.
800 * tui/tui-command.c (tui_cmd_window::resize): Update.
801
dc7ff8a6
TT
8022019-12-11 Tom Tromey <tom@tromey.com>
803
804 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
805 Implement.
806 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
807 Implement.
808 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
809 method.
810 (struct tui_win_info) <min_height>: Implement.
811
1431937b
TT
8122019-12-11 Tom Tromey <tom@tromey.com>
813
814 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
815 (struct tui_win_info) <can_box>: Update.
816
c8ec2f43
TT
8172019-12-11 Tom Tromey <tom@tromey.com>
818
819 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
820 method.
821 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
822 method.
823 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
824 method.
825 (struct tui_win_info) <max_height>: Now override.
826
4decd62b
JB
8272019-12-11 Joel Brobecker <brobecker@adacore.com>
828
829 * NEWS: Create a new section for the next release branch.
830 Rename the section of the current branch, now that it has
831 been cut.
832
d746744e
JB
8332019-12-11 Joel Brobecker <brobecker@adacore.com>
834
835 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
836 * version.in: Bump version to 10.0.50.DATE-git.
837
2e744276
TT
8382019-12-11 Tom Tromey <tromey@adacore.com>
839
840 PR build/25268:
841 * gdbsupport/thread-pool.c (set_thread_name): New function.
842 (thread_pool::set_thread_count): Don't call pthread_setname_np.
843 (thread_pool::thread_function): Call set_thread_name.
844
aac4760f
TT
8452019-12-11 Tom Tromey <tromey@adacore.com>
846
847 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
848 bfd_get_signed_8.
849
d8edc8b7
PW
8502019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
851
852 * NEWS: Document -raw-values option and the related setting commands.
853 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
854 only set it on when /r is given.
855 * valprint.c (value_print_option_defs): New element raw-values.
856 * Makefile.in: Add the new file.
857
cb511130
CB
8582019-12-10 Christian Biesinger <cbiesinger@google.com>
859
860 * gdbsupport/safe-strerror.c: Supress the unused function warning
861 for select_strerror_r.
862
ab7d13f0
CB
8632019-12-10 Christian Biesinger <cbiesinger@google.com>
864
865 * config.in: Regenerate.
866 * configure: Regenerate.
867 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
868 safe_strerror instead of strerror.
869 * gdbsupport/common.m4: Don't check for strerror.
870 * gdbsupport/safe-strerror.c: Support both the glibc version
871 of strerror_r and the XSI version.
872
6c71eb7d
TT
8732019-12-10 Tom Tromey <tromey@adacore.com>
874
875 * ada-typeprint.c (print_choices): Use a single "?".
876 (print_variant_part): Print "?" if the discriminant name
877 is not known.
878
bac7c5cf
GB
8792019-12-10 George Barrett <bob@bob131.so>
880
881 Fix scripted probe breakpoints.
882 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
883 declaration forward.
884 (breakpoint_ops_for_event_location_type)
885 (breakpoint_ops_for_event_location): Add function definitions.
886 (break_command_1, trace_command): Use
887 breakpoint_ops_for_event_location.
888 * breakpoint.h (breakpoint_ops_for_event_location): Add function
889 declarations.
890 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
891 breakpoint_ops_for_event_location.
892 * python/py-breakpoint.c (bppy_init): Use
893 breakpoint_ops_for_event_location.
894
330f1d38
TBA
8952019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
896
897 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
898 when ranking an lvalue argument for an rvalue parameter.
899
b1f0c0b9
WA
9002019-12-08 Wataru Ashihara <wataash@wataash.com>
901
902 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
903 template argument for scoped_restore_tmpl from bool to int.
904
aa2d5a42
KS
9052019-12-07 Keith Seitz <keiths@redhat.com>
906
907 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
908 (build_id_to_debug_bfd): Make static, rewriting to use
909 build_id_to_bfd_suffix.
910 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
911 adding `suffix' parameter. Append SUFFIX to file names
912 when searching for matching files.
913 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
914 (build_id_to_exec_bfd): Likewise.
915 * build-id.h (build_id_to_debug_bfd): Clarify that function
916 searches for BFD of debug info file.
917 (build_id_to_exec_bfd): Declare.
918 * corelow.c: Include build-id.h.
919 (locate_exec_from_corefile_build_id): New function.
920 (core_target_open): If no executable BFD is found,
921 search for a core file BFD using build-id.
922
dfb65191
CB
9232019-12-06 Christian Biesinger <cbiesinger@google.com>
924
925 * bcache.c: Put in namespace gdb.
926 * bcache.h: Likewise.
927 * gdbtypes.c (check_types_worklist): Update.
928 (types_deeply_equal): Update.
929 * macrotab.c (struct macro_table) <bcache>: Update.
930 (new_macro_table): Update.
931 * macrotab.h (struct bcache): Put this forward declaration
932 inside namespace gdb.
933 (new_macro_table): Update.
934 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
935 Update.
936 <macro_cache>: Update.
937 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
938
93e55f0a
TV
9392019-12-06 Tom de Vries <tdevries@suse.de>
940
941 PR symtab/24971
942 * block.c (best_symbol, better_symbol): New function.
943 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
944 decl.
945
06acc08f
TBA
9462019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
947
948 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
949 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
950 for ranking see-through reference cases.
951
e0fad1ea
PW
9522019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
953 * stack.c (faas_command): Check a command is provided.
954 * thread.c (taas_command, tfaas_command): Likewise.
955
908641f5
PW
9562019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
957 * inferior.c (prune_inferiors): Only call delete_inferior,
958 Do not modify the inferior list.
959
b858499d
SM
9602019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
961
962 * c-exp.y: Update calls to lookup_typename,
963 lookup_signed_typename and lookup_unsigned_typename.
964 * c-lang.c (evaluate_subexp_c): Likewise.
965 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
966 Likewise.
967 * eval.c (binop_promote): Likewise.
968 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
969 (lookup_unsigned_typename): Likewise.
970 (lookup_signed_typename): Likewise.
971 * gdbtypes.h (lookup_unsigned_typename): Likewise.
972 (lookup_signed_typename): Likewise.
973 (lookup_typename): Likewise.
974 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
975 lookup_typename, lookup_signed_typename,
976 lookup_unsigned_typename.
977 * m2-exp.y: Likewise.
978 * printcmd.c (printf_wide_c_string): Likewise.
979 (ui_printf): Likewise.
980 * python/py-type.c (typy_lookup_typename): Likewise.
981 * python/py-xmethods.c (python_xmethod_worker::invoke):
982 Likewise.
983 * rust-exp.y: Likewise.
984
3a8fa228
CB
9852019-12-04 Christian Biesinger <cbiesinger@google.com>
986
987 * configure.nat (obsd64): Add missing files x86-nat.o and
988 nat/x86-dregs.o.
989
2dbc041e
TT
9902019-12-04 Tom Tromey <tom@tromey.com>
991
992 * valprint.c (val_print_string): Use metadata_style.
993 * go-valprint.c (print_go_string): Use metadata style.
994 * p-valprint.c (pascal_object_print_static_field): Use metadata
995 style.
996 * cp-valprint.c (cp_print_static_field): Use metadata style.
997
36c8fb93
AB
9982019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
999 Chris January <chris.january@arm.com>
1000
1001 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
1002 tokens.
1003 (typebase): New patterns for complex, single/double precision, and
1004 single/double complex.
1005 (f77_keywords): Change token for complex keyword, and add single,
1006 double, and precision keywords.
1007
c6170c2c
SM
10082019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1009
1010 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1011 "info io_registers".
1012
894ecaf4
SM
10132019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1014
1015 * regcache.c (cooked_read_test): Initialize thread list of
1016 mock_inferior.
1017
be155ebb
SM
10182019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1019
1020 * aarch64-linux-tdep.c: Remove includes.
1021
c577cdd7
SM
10222019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1023
1024 * aarch64-tdep.c: Remove includes.
1025
610cfd61
SM
10262019-12-04 Simon Marchi <simon.marchi@efficios.com>
1027
1028 * filtered-iterator.h (filtered_iterator) <operator==,
1029 operator!=>: Compare wrapped iterators, not wrapped pointers.
1030 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1031 unittests/filtered_iterator-selftests.c.
1032 * unittests/filtered_iterator-selftests.c: New file.
1033
a05cf17a
TT
10342019-12-04 Tom Tromey <tromey@adacore.com>
1035
1036 * gdbtypes.c (create_range_type): Inherit endianity
1037 from base type.
1038
d5a22e77
TT
10392019-12-04 Tom Tromey <tromey@adacore.com>
1040
1041 * ada-lang.c (decode_constrained_packed_array)
1042 (ada_value_assign, value_assign_to_component): Update.
1043 * dwarf2loc.c (rw_pieced_value, access_memory)
1044 (dwarf2_compile_expr_to_ax): Update.
1045 * dwarf2read.c (dwarf2_add_field): Update.
1046 * eval.c (evaluate_subexp_standard): Update.
1047 * gdbarch.c, gdbarch.h: Rebuild.
1048 * gdbarch.sh (bits_big_endian): Remove.
1049 * gdbtypes.h (union field_location): Update comment.
1050 * target-descriptions.c (make_gdb_type): Update.
1051 * valarith.c (value_bit_index): Update.
1052 * value.c (struct value) <bitpos>: Update comment.
1053 (unpack_bits_as_long, modify_field): Update.
1054 * value.h (value_bitpos): Update comment.
1055
7ab4a236
TT
10562019-12-04 Tom Tromey <tromey@adacore.com>
1057
1058 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
1059 endian-ness.
1060
103a685e
TT
10612019-12-04 Tom Tromey <tromey@adacore.com>
1062
1063 * dwarf2read.c (dwarf2_init_float_type)
1064 (dwarf2_init_complex_target_type): Add byte_order parameter.
1065 (read_base_type): Compute byte order earlier.
1066 * gdbtypes.c (init_float_type): Add byte_order parameter.
1067 * gdbtypes.h (init_float_type): Add byte_order parameter.
1068
7a9e9f9f
TT
10692019-12-04 Tom Tromey <tromey@adacore.com>
1070
1071 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1072
feee869b
TT
10732019-12-04 Tom Tromey <tromey@adacore.com>
1074
1075 * dwarf2read.c (process_structure_scope): Initialize
1076 "discr_offset".
1077
c2512106
AB
10782019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1079
1080 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1081 add it into the search spec.
1082 (parse_max_results_option): New function.
1083 (mi_info_functions_or_variables): Parse -max-results flag and pass
1084 it to mi_symbol_info.
1085 (mi_cmd_symbol_info_modules): Likewise.
1086 (mi_cmd_symbol_info_types): Likewise.
1087 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1088 return type to bool, change result container into a set, and don't
1089 add new results if we have enough already.
1090 (global_symbol_searcher::add_matching_msymbols): Change return
1091 type to bool, and don't add new results if we have enough already.
1092 (sort_search_symbols_remove_dups): Delete.
1093 (global_symbol_searcher::search): Early exit from search loop when
1094 we have enough results. Use a std::set to collect the results
1095 from calling add_matching_symbols.
1096 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1097 member function.
1098 (global_symbol_searcher) <m_max_search_results>: New member
1099 variable.
1100 (global_symbol_searcher) <add_matching_symbols>: Update header
1101 comment and change return type to bool.
1102 (global_symbol_searcher) <add_matching_msymbols>: Update header
1103 comment and change return type to bool.
1104
f97a63c5
AB
11052019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1106
1107 * symtab.c (symbol_search::compare_search_syms): Update header
1108 comment.
1109 (global_symbol_searcher::is_suitable_msymbol): New function.
1110 (global_symbol_searcher::expand_symtabs): New function.
1111 (global_symbol_searcher::add_matching_symbols): New function.
1112 (global_symbol_searcher::add_matching_msymbols): New function.
1113 (global_symbol_searcher::search): Move most of the content
1114 into the new functions above, and call them as needed.
1115 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1116 function.
1117 (global_symbol_searcher) <add_matching_symbols>: New member
1118 function.
1119 (global_symbol_searcher) <add_matching_msymbols>: New member
1120 function.
1121 (global_symbol_searcher) <is_suitable_msymbol>: New member
1122 function.
1123
293b38d6
AB
11242019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1125
1126 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1127 -symbol-info-module-variables entries.
1128 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1129 (mi_cmd_symbol_info_module_variables): Declare.
1130 * mi/mi-symbol-cmds.c
1131 (module_symbol_search_iterator): New typedef.
1132 (output_module_symbols_in_single_module_and_file): New function.
1133 (output_module_symbols_in_single_module): New function.
1134 (mi_info_module_functions_or_variables): New function.
1135 (mi_cmd_symbol_info_module_functions): New function.
1136 (mi_cmd_symbol_info_module_variables): New function.
1137 * NEWS: Mention new MI command.
1138
4cbd39b2
CB
11392019-12-03 Christian Biesinger <cbiesinger@google.com>
1140
1141 * bcache.c (hash): Remove.
1142 (hash_continue): Remove.
1143 * bcache.h (hash): Remove.
1144 (hash_continue): Remove.
1145 (struct bcache) <ctor>: Update.
1146 * psymtab.c (psymbol_hash): Update.
1147 * stabsread.c (hashname): Update.
1148 * utils.h (fast_hash): Add an argument for a start value,
1149 defaulting to zero.
1150
82f910ea
PW
11512019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1152 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1153 (destroy_block_symbol_cache): New function.
1154 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1155 (resize_symbol_cache): Likewise.
1156
de2396d0
TT
11572019-12-02 Tom Tromey <tom@tromey.com>
1158
1159 * unittests/tui-selftests.c (run_tests): Make conditional.
1160 (_initialize_tui_selftest): Make conditional.
1161
638d85bc
CB
11622019-12-02 Christian Biesinger <cbiesinger@google.com>
1163
1164 * aix-thread.c (debug_aix_thread): Change type to bool.
1165
7532a164
LM
11662019-12-02 Luis Machado <luis.machado@linaro.org>
1167
1168 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1169
216a7e6b
AB
11702019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1171
1172 * dwarf2read.c (read_tag_string_type): Read the fields required to
1173 make a dynamic string, and possibly create a dynamic range for the
1174 string.
1175 (attr_to_dynamic_prop): Setup is_reference based on the type of
1176 attribute being processed.
1177 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1178 (resolve_dynamic_array): Rename to...
1179 (resolve_dynamic_array_or_string): ...this, update header comment,
1180 and accept TYPE_CODE_STRING.
1181 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1182
11a8b164
AB
11832019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1184
1185 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1186 of its implementation from...
1187 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1188 the new function.
1189
5bbd8269
AB
11902019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1191
1192 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1193 create a range with stride where appropriate.
1194 * f-valprint.c: Include 'gdbarch.h'.
1195 (f77_print_array_1): Take the stride into account when walking the
1196 array. Also convert the stride into addressable units.
1197 * gdbtypes.c (create_range_type): Initialise the stride to
1198 constant zero.
1199 (create_range_type_with_stride): New function, initialise the
1200 range as normal, and then setup the stride.
1201 (has_static_range): Include the stride here. Also change the
1202 return type to bool.
1203 (create_array_type_with_stride): Consider the range stride if the
1204 array isn't given its own stride.
1205 (resolve_dynamic_range): Resolve the stride if needed.
1206 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1207 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1208 (TYPE_BIT_STRIDE): Define.
1209 (TYPE_ARRAY_BIT_STRIDE): Define.
1210 (create_range_type_with_stride): Declare.
1211 * valarith.c (value_subscripted_rvalue): Take range stride into
1212 account when walking the array.
1213
82e3b564
TT
12142019-12-01 Tom Tromey <tom@tromey.com>
1215
1216 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1217 specially.
1218
517d261d
TT
12192019-12-01 Tom Tromey <tom@tromey.com>
1220
1221 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1222 \0.
1223 * unittests/tui-selftests.c: New file.
1224 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1225
484c9b64
TT
12262019-12-01 Tom Tromey <tom@tromey.com>
1227
1228 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1229
a2a7af0c
TT
12302019-12-01 Tom Tromey <tom@tromey.com>
1231
1232 * NEWS: Document new settings.
1233 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1234 * tui/tui-win.c (_initialize_tui_win): Add border style
1235 observers.
1236 * tui/tui-io.h (tui_apply_style): Declare.
1237 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1238 longer static.
1239 (apply_ansi_escape, tui_set_reverse_mode): Update.
1240 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1241 Add "skip_intensity" parameter.
1242 <changed>: New member.
1243 <do_set_value>: Declare.
1244 (tui_border_style, tui_active_border_style): Declare.
1245 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1246 globals.
1247 (cli_style_option): Initialize "changed".
1248 (cli_style_option::do_set_value): New function.
1249 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1250 parameter. Update.
1251 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1252 (_initialize_cli_style): Update. Create TUI border style
1253 commands.
1254
d1da6b01
TT
12552019-12-01 Tom Tromey <tom@tromey.com>
1256
1257 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1258 parameter.
1259 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1260 parameter.
1261 * tui/tui-win.h (compact_source): Declare.
1262 * tui/tui-win.c (compact_source): New global.
1263 (tui_set_compact_source, tui_show_compact_source): New functions.
1264 (_initialize_tui_win): Add "compact-source" setting.
1265 * tui/tui-source.c (tui_source_window::set_contents): Handle
1266 compact_source setting.
1267 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1268 * NEWS: Document new setting.
1269
489dbda6
TT
12702019-11-30 Tom Tromey <tom@tromey.com>
1271
1272 * dwarf2read.c (dwarf2_add_field): Include field offset when
1273 computing variant part length.
1274
bf498525
PW
12752019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1276 * NEWS: Mention define-prefix. Tell that command names can now
1277 contain a . character.
1278
be09caf1
PW
12792019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1280
1281 * command.h (valid_cmd_char_p): Declare.
1282 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1283 the check of valid command char.
1284 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1285 valid_cmd_char_p.
1286 * cli/cli-script.c (validate_comname): Likewise.
1287 * completer.c (gdb_completer_command_word_break_characters):
1288 Do not remove . from the word break char, update comments.
1289 (complete_line_internal_1): Use valid_cmd_char_p.
1290 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1291 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1292
c6ac7fc9
PW
12932019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1294
1295 * cli/cli-script.c (do_define_command): Ensure a redefined
1296 prefix command is kept as a prefix command.
1297 (define_prefix_command): New function.
1298 (show_user_1): Report user defined prefixes.
1299 (_initialize_cli_script): Create the new 'define-prefix' command.
1300 Add completers for 'define' and 'document'.
1301 * top.c (execute_command): If command is a user-defined prefix only
1302 command, report the list of commands for this prefix command.
1303
a992a3b0
TBA
13042019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1305
1306 * valops.c (find_oload_champ): Improve debug output.
1307
e9194a1a
TBA
13082019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1309
1310 * valops.c (find_oload_champ): Print part of debug messages
1311 before the badness vector is std::move'd.
1312
53a008a6
TT
13132019-11-28 Tom Tromey <tom@tromey.com>
1314
1315 * value.c (creal_internal_fn): Fix comment.
1316
bab05c83
TT
13172019-11-28 Tom Tromey <tom@tromey.com>
1318
1319 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1320 flag_bound_evaluated>: Now unsigned.
1321
2522f049
TT
13222019-11-28 Tom Tromey <tom@tromey.com>
1323
1324 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1325 declare.
1326
38b49e22
MS
13272019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1328
1329 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1330 debug output.
1331 * jit.c (jit_unregister_code): Add debug print to match
1332 `jit_register_code`.
1333
35125921
CB
13342019-11-27 Christian Biesinger <cbiesinger@google.com>
1335
1336 * NEWS: Mention the new multithreaded symbol loading.
1337
62e77f56
CB
13382019-11-27 Christian Biesinger <cbiesinger@google.com>
1339
1340 * maint.c (n_worker_threads): Default to 0.
1341 (worker_threads_disabled): New function.
1342 * maint.h (worker_threads_disabled): New function.
1343 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1344 here if worker_threads_disabled () is true.
1345 (minimal_symbol_reader::install): Skip all threading if
1346 worker_threads_disabled () is true.
1347
f29d7f6b
CB
13482019-11-27 Christian Biesinger <cbiesinger@google.com>
1349
1350 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1351 hash code if possible.
1352 (add_minsym_to_demangled_hash_table): Likewise.
1353 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1354 on the background thread.
1355 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1356 Add these fields.
1357
e76b2246
CB
13582019-11-27 Christian Biesinger <cbiesinger@google.com>
1359
1360 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1361 of the mangled name on the background thread.
1362 * symtab.c (symbol_set_names): Allow passing in the hash of the
1363 linkage_name.
1364 * symtab.h (symbol_set_names): Likewise.
1365
8d9a2568
KB
13662019-11-27 Kevin Buettner <kevinb@redhat.com>
1367
1368 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1369 physnames are computed for inherited DIEs.
1370
fad03f6e
TT
13712019-11-27 Tom Tromey <tromey@adacore.com>
1372
1373 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1374 backslashes.
1375 * cp-support.c: Remove unnecessary backslashes.
1376
43678b0a
CB
13772019-11-27 Christian Biesinger <cbiesinger@google.com>
1378
1379 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1380 with sym->set_linkage_name.
1381 * coffread.c (coff_read_enum_type): Likewise.
1382 * mdebugread.c (parse_symbol): Likewise.
1383 * stabsread.c (patch_block_stabs): Likewise.
1384 (define_symbol): Likewise.
1385 (read_enum_type): Likewise.
1386 (common_block_end): Likewise.
1387 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1388 function.
1389 (SYMBOL_SET_LINKAGE_NAME): Remove.
1390 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1391 with sym->set_linkage_name.
1392
db5960b4
AB
13932019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1394
1395 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1396 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1397 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1398 * NEWS: Mention new MI command.
1399
7dc42066
AB
14002019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1401
1402 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1403 '-symbol-info-types', and '-symbol-info-variables'.
1404 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1405 (mi_cmd_symbol_info_types): Declare.
1406 (mi_cmd_symbol_info_variables): Declare.
1407 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1408 (output_debug_symbol): New function.
1409 (output_nondebug_symbol): New function.
1410 (mi_symbol_info): New function.
1411 (mi_info_functions_or_variables): New function.
1412 (mi_cmd_symbol_info_functions): New function.
1413 (mi_cmd_symbol_info_types): New function.
1414 (mi_cmd_symbol_info_variables): New function.
1415 * NEWS: Mention new commands.
1416
5f512a7d
AB
14172019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1418
1419 * symtab.c (symbol_to_info_string): New function, most content
1420 moved from print_symbol_info, but updated to return a std::string.
1421 (print_symbol_info): Update to use symbol_to_info_string and print
1422 returned string.
1423 * symtab.h (symbol_to_info_string): Declare new function.
1424
470c0b1c
AB
14252019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1426
1427 * python/python.c (gdbpy_rbreak): Convert to using
1428 global_symbol_searcher.
1429 * symtab.c (file_matches): Convert return type to bool, change
1430 file list to std::vector, update header comment.
1431 (search_symbols): Rename to...
1432 (global_symbol_searcher::search): ...this and update now its
1433 a member function of global_symbol_searcher. Take account of the
1434 changes to file_matches.
1435 (symtab_symbol_info): Convert to using global_symbol_searcher.
1436 (rbreak_command): Likewise.
1437 (search_module_symbols): Likewise.
1438 * symtab.h (enum symbol_search): Update comment.
1439 (search_symbols): Remove declaration.
1440 (class global_symbol_searcher): New class.
1441
57357d9d
TT
14422019-11-26 Tom Tromey <tromey@adacore.com>
1443
1444 * cp-support.c (_initialize_cp_support): Conditionally initialize
1445 gdb_demangle_attempt_core_dump.
1446
3ea16160
TT
14472019-11-26 Tom Tromey <tom@tromey.com>
1448
1449 * python/py-function.c (fnpy_init): Update.
1450 * value.h (add_internal_function): Adjust declaration.
1451 * value.c (function_destroyer): Remove.
1452 (do_add_internal_function): Don't set destroyer or copy name.
1453 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1454 Set name_allocated.
1455 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1456 (cmdpy_init): Set name_allocated.
1457 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1458 member.
1459 (~cmd_list_element): Free "name" if needed.
1460
1a6d41c6
TT
14612019-11-26 Tom Tromey <tom@tromey.com>
1462
1463 * value.h (add_internal_function): Add new overload. Move
1464 documentation from value.h.
1465 * value.c (do_add_internal_function): New function.
1466 (add_internal_function): Use it. Add new overload.
1467 (function_destroyer): Don't free doc.
1468 * python/py-function.c (fnpy_init): Update.
1469
8318f3c3
TT
14702019-11-26 Tom Tromey <tom@tromey.com>
1471
1472 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1473 (cmdpy_init): Set "doc_allocated".
1474
4da8c3a8
TT
14752019-11-26 Tom Tromey <tom@tromey.com>
1476
1477 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1478 name of worker thread.
1479 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1480 pthread_setname_np.
1481 * configure, config.in: Rebuild.
1482
971db5e2
TT
14832019-11-26 Tom Tromey <tom@tromey.com>
1484
1485 * python/python.c (class gdbpy_gil): New.
1486 (struct gdbpy_event): Add constructor, destructor, operator().
1487 (gdbpy_post_event): Use run_on_main_thread.
1488 (gdbpy_initialize_events): Remove.
1489 (do_start_initialization): Update.
1490
22138db6
TT
14912019-11-26 Tom Tromey <tom@tromey.com>
1492
1493 * NEWS: Add entry.
1494 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1495 commands. Call update_thread_pool_size.
1496 (update_thread_pool_size, maintenance_set_worker_threads): New
1497 functions.
1498 (n_worker_threads): New global.
1499
d55c9a68
TT
15002019-11-26 Christian Biesinger <cbiesinger@google.com>
1501 Tom Tromey <tom@tromey.com>
1502
1503 * minsyms.c (minimal_symbol_reader::install): Use
1504 parallel_for_each.
1505 * gdbsupport/parallel-for.h: New file.
1506 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1507
a0b57563
CB
15082019-11-26 Christian Biesinger <cbiesinger@google.com>
1509 Tom Tromey <tom@tromey.com>
1510
1511 * gdbsupport/thread-pool.h: New file.
1512 * gdbsupport/thread-pool.c: New file.
1513 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1514 (HFILES_NO_SRCDIR): Add thread-pool.h.
1515
3b3978bc
TT
15162019-11-26 Tom Tromey <tom@tromey.com>
1517
1518 * event-top.h (thread_local_segv_handler): Declare.
1519 * event-top.c (thread_local_segv_handler): New global.
1520 (install_handle_sigsegv, handle_sigsegv): New functions.
1521 (async_init_signals): Install SIGSEGV handler.
1522 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1523 thread-local.
1524 (report_failed_demangle): New function.
1525 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1526 handler-setting code, instead use segv_handler. Run warning code
1527 on main thread.
1528
9411c49e
TT
15292019-11-26 Tom Tromey <tom@tromey.com>
1530
1531 * run-on-main-thread.c: New file.
1532 * run-on-main-thread.h: New file.
1533 * unittests/main-thread-selftests.c: New file.
1534 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1535 main-thread-selftests.c.
1536 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1537 (COMMON_SFILES): Add run-on-main-thread.c.
1538
c3efb965
TT
15392019-11-26 Tom Tromey <tom@tromey.com>
1540
1541 * main.c (setup_alternate_signal_stack): Remove.
1542 (captured_main_1): Use gdb::alternate_signal_stack.
1543 * gdbsupport/alt-stack.h: New file.
1544
21987b9c
TT
15452019-11-26 Tom Tromey <tom@tromey.com>
1546
1547 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1548 Remove comment.
1549 (save_original_signals_state, restore_original_signals_state): Use
1550 gdb_sigmask.
1551 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1552 (_initialize_linux_nat): Use gdb_sigmask.
1553 * guile/guile.c (_initialize_guile): Use block_signals.
1554 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1555 * gdbsupport/gdb-sigmask.h: New file.
1556 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1557 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1558 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1559 pthread_sigmask.
1560 * configure, config.in: Rebuild.
1561 * gdbsupport/block-signals.h: New file.
1562
5e030278
TT
15632019-11-26 Tom Tromey <tom@tromey.com>
1564
1565 * acinclude.m4: Include ax_pthread.m4.
1566 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1567 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1568 (CLIBS): Use PTHREAD_LIBS.
1569 (aclocal_m4_deps): Add ax_pthread.m4.
1570 * config.in, configure: Rebuild.
1571 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1572
5a79c107
TT
15732019-11-26 Tom Tromey <tom@tromey.com>
1574
1575 * symtab.h (struct minimal_symbol) <name_set>: New member.
1576 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1577 Don't call symbol_set_names.
1578 (minimal_symbol_reader::install): Call symbol_set_names.
1579
aa369509
PW
15802019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1581
1582 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1583 restore_active_ext_lang, as GIL is needed for (indirectly)
1584 called PyOS_InterruptOccurred.
1585
cadc9cb8
SM
15862019-11-26 Simon Marchi <simon.marchi@efficios.com>
1587
1588 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1589 definition.
1590
d04afd58
SM
15912019-11-26 Simon Marchi <simon.marchi@efficios.com>
1592
1593 * remote-sim.c (simulator_command): Make static, remove
1594 declaration.
1595
dd694d77
SM
15962019-11-26 Simon Marchi <simon.marchi@efficios.com>
1597
1598 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1599 static.
1600 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1601 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1602 (main): Likewise.
1603 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1604 (main): Likewise.
1605 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1606 (main): Likewise.
1607 * unittests/basic_string_view/element_access/char/1.cc (test01):
1608 Likewise.
1609 (main): Likewise.
1610 * unittests/basic_string_view/element_access/char/empty.cc (main):
1611 Likewise.
1612 * unittests/basic_string_view/element_access/char/front_back.cc
1613 (test01): Likewise.
1614 (main): Likewise.
1615 * unittests/basic_string_view/inserters/char/2.cc (test05):
1616 Likewise.
1617 (main): Likewise.
1618 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1619 (test01): Likewise.
1620 (main): Likewise.
1621 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1622 (test01): Likewise.
1623 (main): Likewise.
1624 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1625 Likewise.
1626 * unittests/basic_string_view/operations/compare/char/1.cc
1627 (test01): Likewise.
1628 (main): Likewise.
1629 * unittests/basic_string_view/operations/compare/char/13650.cc
1630 (test01): Likewise.
1631 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1632 Likewise.
1633 (main): Likewise.
1634 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1635 Likewise.
1636 (main): Likewise.
1637 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1638 Likewise.
1639 (main): Likewise.
1640 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1641 Likewise.
1642 (main): Likewise.
1643 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1644 Likewise.
1645 (main): Likewise.
1646 * unittests/basic_string_view/operations/find/char/4.cc (main):
1647 Likewise.
1648 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1649 Likewise.
1650 (main): Likewise.
1651 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1652 Likewise.
1653 (main): Likewise.
1654 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1655 Likewise.
1656 (main): Likewise.
1657 * unittests/basic_string_view/operations/substr/char/1.cc
1658 (test01): Likewise.
1659 (main): Likewise.
1660 * unittests/basic_string_view/operators/char/2.cc (main):
1661 Likewise.
1662 * unittests/optional/assignment/1.cc (test): Likewise.
1663 * unittests/optional/assignment/2.cc (test): Likewise.
1664 * unittests/optional/assignment/3.cc (test): Likewise.
1665 * unittests/optional/assignment/4.cc (test): Likewise.
1666 * unittests/optional/assignment/5.cc (test): Likewise.
1667 * unittests/optional/assignment/6.cc (test): Likewise.
1668 * unittests/optional/assignment/7.cc (test): Likewise.
1669 * unittests/optional/cons/copy.cc (test): Likewise.
1670 * unittests/optional/cons/default.cc (test): Likewise.
1671 * unittests/optional/cons/move.cc (test): Likewise.
1672 * unittests/optional/cons/value.cc (test): Likewise.
1673 * unittests/optional/in_place.cc (test): Likewise.
1674 * unittests/optional/observers/1.cc (test): Likewise.
1675 * unittests/optional/observers/2.cc (test): Likewise.
1676
3b5c1d49
SM
16772019-11-26 Simon Marchi <simon.marchi@efficios.com>
1678
1679 * tui-win.h (tui_set_var_cmd): Remove.
1680 * tui-win.c (tui_set_var_cmd): Make static.
1681
adce99fe
SM
16822019-11-26 Simon Marchi <simon.marchi@efficios.com>
1683
1684 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1685 rbreak_command_wrapper): Remove.
1686 * symtab.c (rbreak_command_wrapper): Remove.
1687
fe3adccf
SM
16882019-11-26 Simon Marchi <simon.marchi@efficios.com>
1689
1690 * inferior.h (info_terminal_command): Remove declaration.
1691 * inflow.c (info_terminal_command): Make static.
1692
b926335f
SM
16932019-11-26 Simon Marchi <simon.marchi@efficios.com>
1694
1695 * inferior.c (exit_inferior_silent): Remove.
1696
b62f6f54
SM
16972019-11-26 Simon Marchi <simon.marchi@efficios.com>
1698
1699 * dictionary.c (dict_empty, mdict_empty): Remove.
1700 * dictionary.c (mdict_empty): Remove.
1701
cb8c24b6
SM
17022019-11-26 Simon Marchi <simon.marchi@efficios.com>
1703
1704 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1705 (arc_insn_get_memory_offset): Likewise.
1706 (arc_insn_dump): Likewise.
1707 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1708 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1709 * dictionary.c (dict_iterator_next): Likewise.
1710 (dict_iter_match_first): Likewise.
1711 (dict_iter_match_next): Likewise.
1712 * f-lang.c (evaluate_subexp_f): Likewise.
1713 * hppa-tdep.c (hppa_read_pc): Likewise.
1714 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1715 * parse.c (write_exp_elt_msym): Likewise.
1716 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1717 * remote.c (remote_packet_size): Likewise.
1718 (remote_notif_stop_parse): Likewise.
1719 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1720 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1721 * source.c (prepare_path_for_appending): Likewise.
1722 * sparc64-linux-tdep.c
1723 (sparc64_linux_handle_segmentation_fault); Likewise.
1724 * stack.c (frame_selection_by_function_completer): Likewise.
1725
781597ff
SM
17262019-11-26 Simon Marchi <simon.marchi@efficios.com>
1727
1728 * completer.c (set_gdb_completion_word_break_characters):
1729 Remove.
1730
23baa4cc
SM
17312019-11-26 Simon Marchi <simon.marchi@efficios.com>
1732
1733 * dwarf-index-write.c: Include dwarf-index-write.h.
1734 * mi/mi-interp.c: Include mi/mi-interp.h.
1735
23767560
SM
17362019-11-26 Simon Marchi <simon.marchi@efficios.com>
1737
1738 * aarch32-tdep.c: Include aarch32-tdep.h.
1739 * aarch32-tdep.h: Forward-declare struct target_desc.
1740
6d91ce9a
CB
17412019-11-26 Christian Biesinger <cbiesinger@google.com>
1742
1743 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1744 strerror.
1745 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1746 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1747
3cf2f237
TV
17482019-11-25 Tom de Vries <tdevries@suse.de>
1749
1750 * contrib/words.sh: Add -c option.
1751
5b89c67a
CB
17522019-11-25 Christian Biesinger <cbiesinger@google.com>
1753
1754 * solib.c (solib_find_1): Change int to bool.
1755 (exec_file_find): Change int to bool.
1756 (solib_find): Change int to bool.
1757 (solib_read_symbols): Change int to bool.
1758 (solib_used): Change int to bool.
1759 (solib_add): Change int to bool.
1760 (info_sharedlibrary_command): Change int to bool.
1761 (solib_contains_address_p): Change int to bool.
1762 (solib_keep_data_in_core): Change int to bool.
1763 (in_solib_dynsym_resolve_code): Change int to bool.
1764 (reload_shared_libraries_1): Change int to bool.
1765 (gdb_sysroot_changed): Change int to bool.
1766 * solib.h (solib_read_symbols): Change int to bool.
1767 (solib_contains_address_p): Change int to bool.
1768 (solib_keep_data_in_core): Change int to bool.
1769 (in_solib_dynsym_resolve_code): Change int to bool.
1770 (libpthread_name_p): Change int to bool.
1771
6cc8564b
LM
17722019-11-25 Luis Machado <luis.machado@linaro.org>
1773
1774 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1775 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1776 (remote_packet_max_chars): New static global.
1777 (show_remote_packet_max_chars): New function.
1778 (remote_target::putpkt_binary): Adjust to use new
1779 remote_packet_max_chars option.
1780 (remote_target::getpkt_or_notif_sane_1): Likewise.
1781 (_initialize_remote): Register new remote-packet-max-chars option.
1782
a7cdaa91
SM
17832019-11-24 Simon Marchi <simon.marchi@efficios.com>
1784
1785 * m68k-linux-nat.c: Include gdbarch.h.
1786
26abc753
TT
17872019-11-24 Tom Tromey <tom@tromey.com>
1788
1789 * symfile.c (read_symbols): Update.
1790 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1791 bool.
1792 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1793 (psym_lookup_symbol, psym_find_last_source_symtab)
1794 (psym_forget_cached_source_info, psym_print_stats)
1795 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1796 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1797 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1798 (psym_find_compunit_symtab_by_address)
1799 (maintenance_print_psymbols, maintenance_info_psymtabs)
1800 (maintenance_check_psymtabs): Update.
1801 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1802 bool.
1803
012fc909
TT
18042019-11-22 Tom Tromey <tom@tromey.com>
1805
1806 * observable.h: Update comments.
1807
c83d8d32
TT
18082019-11-22 Tom Tromey <tromey@adacore.com>
1809
1810 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1811 (print_ada_task_info): Don't try to fetch thread id if task is not
1812 alive.
1813
987012b8
CB
18142019-11-22 Christian Biesinger <cbiesinger@google.com>
1815
1816 * ada-exp.y: Update.
1817 * ada-lang.c (sort_choices): Update.
1818 (ada_print_symbol_signature): Update.
1819 (resolve_subexp): Update.
1820 (ada_parse_renaming): Update.
1821 (ada_read_renaming_var_value): Update.
1822 (lesseq_defined_than): Update.
1823 (remove_extra_symbols): Update.
1824 (remove_irrelevant_renamings): Update.
1825 (ada_add_block_symbols): Update.
1826 (ada_collect_symbol_completion_matches): Update.
1827 (ada_is_renaming_symbol): Update.
1828 (aggregate_assign_from_choices): Update.
1829 (ada_evaluate_subexp): Update.
1830 (ada_has_this_exception_support): Update.
1831 (ada_is_non_standard_exception_sym): Update.
1832 (ada_add_exceptions_from_frame): Update.
1833 (ada_add_global_exceptions): Update.
1834 (ada_print_subexp): Update.
1835 * ax-gdb.c (gen_var_ref): Update.
1836 (gen_maybe_namespace_elt): Update.
1837 (gen_expr_for_cast): Update.
1838 (gen_expr): Update.
1839 * block.h: Update.
1840 * blockframe.c (find_pc_partial_function): Update.
1841 * breakpoint.c (print_breakpoint_location): Update.
1842 (update_static_tracepoint): Update.
1843 * btrace.c (ftrace_print_function_name): Update.
1844 (ftrace_function_switched): Update.
1845 * buildsym.c (find_symbol_in_list): Update.
1846 * c-exp.y: Update.
1847 * c-typeprint.c (c_print_typedef): Update.
1848 (c_type_print_template_args): Update.
1849 * cli/cli-cmds.c (edit_command): Update.
1850 (list_command): Update.
1851 (print_sal_location): Update.
1852 * coffread.c (patch_opaque_types): Update.
1853 (process_coff_symbol): Update.
1854 (coff_read_enum_type): Update.
1855 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1856 (convert_one_symbol): Update.
1857 (hash_symname): Update.
1858 (eq_symname): Update.
1859 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1860 * compile/compile-cplus-types.c (debug_print_scope): Update.
1861 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1862 * compile/compile-object-load.c (get_out_value_type): Update.
1863 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1864 (search_symbol_list): Update.
1865 (cp_lookup_symbol_imports_or_template): Update.
1866 * cp-support.c (overload_list_add_symbol): Update.
1867 * ctfread.c (psymtab_to_symtab): Update.
1868 * dbxread.c (cp_set_block_scope): Update.
1869 * dictionary.c (iter_match_first_hashed): Update.
1870 (iter_match_next_hashed): Update.
1871 (insert_symbol_hashed): Update.
1872 (iter_match_next_linear): Update.
1873 * dictionary.h: Update.
1874 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1875 (locexpr_describe_location_piece): Update.
1876 (locexpr_describe_location_1): Update.
1877 (locexpr_generate_c_location): Update.
1878 (loclist_describe_location): Update.
1879 (loclist_generate_c_location): Update.
1880 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1881 (read_func_scope): Update.
1882 (process_enumeration_scope): Update.
1883 (new_symbol): Update.
1884 (dwarf2_const_value): Update.
1885 (dwarf2_symbol_mark_computed): Update.
1886 * eval.c (evaluate_funcall): Update.
1887 (evaluate_subexp_standard): Update.
1888 * expprint.c (print_subexp_standard): Update.
1889 (dump_subexp_body_standard): Update.
1890 * f-valprint.c (info_common_command_for_block): Update.
1891 * findvar.c (get_hosting_frame): Update.
1892 (default_read_var_value): Update.
1893 * go-lang.c (go_symbol_package_name): Update.
1894 * guile/scm-block.c (bkscm_print_block_smob): Update.
1895 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1896 (gdbscm_symbol_name): Update.
1897 (gdbscm_symbol_linkage_name): Update.
1898 (gdbscm_symbol_print_name): Update.
1899 * infcall.c (get_function_name): Update.
1900 * infcmd.c (jump_command): Update.
1901 (finish_command): Update.
1902 * infrun.c (insert_exception_resume_breakpoint): Update.
1903 * linespec.c (canonicalize_linespec): Update.
1904 (create_sals_line_offset): Update.
1905 (convert_linespec_to_sals): Update.
1906 (complete_label): Update.
1907 (find_label_symbols_in_block): Update.
1908 * m2-typeprint.c (m2_print_typedef): Update.
1909 * mdebugread.c (mdebug_reg_to_regnum): Update.
1910 (parse_symbol): Update.
1911 (mylookup_symbol): Update.
1912 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1913 (list_args_or_locals): Update.
1914 * objc-lang.c (compare_selectors): Update.
1915 (info_selectors_command): Update.
1916 (compare_classes): Update.
1917 (info_classes_command): Update.
1918 (find_imps): Update.
1919 * p-typeprint.c (pascal_print_typedef): Update.
1920 * printcmd.c (build_address_symbolic): Update.
1921 (info_address_command): Update.
1922 (print_variable_and_value): Update.
1923 * python/py-framefilter.c (extract_sym): Update.
1924 (py_print_single_arg): Update.
1925 * python/py-symbol.c (sympy_str): Update.
1926 (sympy_get_name): Update.
1927 (sympy_get_linkage_name): Update.
1928 * python/python.c (gdbpy_rbreak): Update.
1929 * record-btrace.c (btrace_get_bfun_name): Update.
1930 (btrace_call_history): Update.
1931 * rust-lang.c (rust_print_typedef): Update.
1932 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1933 * stabsread.c (stab_reg_to_regnum): Update.
1934 (define_symbol): Update.
1935 (read_enum_type): Update.
1936 (common_block_end): Update.
1937 (cleanup_undefined_types_1): Update.
1938 (scan_file_globals): Update.
1939 * stack.c (print_frame_arg): Update.
1940 (print_frame_args): Update.
1941 (find_frame_funname): Update.
1942 (info_frame_command_core): Update.
1943 (iterate_over_block_locals): Update.
1944 (print_block_frame_labels): Update.
1945 (do_print_variable_and_value): Update.
1946 (iterate_over_block_arg_vars): Update.
1947 (return_command): Update.
1948 * symmisc.c (dump_symtab_1): Update.
1949 (print_symbol): Update.
1950 * symtab.c (eq_symbol_entry): Update.
1951 (symbol_cache_dump): Update.
1952 (lookup_language_this): Update.
1953 (find_pc_sect_line): Update.
1954 (skip_prologue_sal): Update.
1955 (symbol_search::compare_search_syms): Update.
1956 (treg_matches_sym_type_name): Update.
1957 (search_symbols): Update.
1958 (print_symbol_info): Update.
1959 (rbreak_command): Update.
1960 (completion_list_add_symbol): Update.
1961 (find_gnu_ifunc): Update.
1962 (get_symbol_address): Update.
1963 (search_module_symbols): Update.
1964 (info_module_subcommand): Update.
1965 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1966 (SYMBOL_LINKAGE_NAME): Remove.
1967 (SYMBOL_DEMANGLED_NAME): Remove.
1968 (SYMBOL_PRINT_NAME): Remove.
1969 (SYMBOL_SEARCH_NAME): Remove.
1970 * tracepoint.c (set_traceframe_context): Update.
1971 (validate_actionline): Update.
1972 (collection_list::collect_symbol): Update.
1973 (encode_actions_1): Update.
1974 (info_scope_command): Update.
1975 (print_one_static_tracepoint_marker): Update.
1976 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1977 * valops.c (address_of_variable): Update.
1978 (find_overload_match): Update.
1979 (find_oload_champ): Update.
1980
c9d95fa3
CB
19812019-11-22 Christian Biesinger <cbiesinger@google.com>
1982
1983 * ada-lang.c (ada_lookup_simple_minsym): Update.
1984 (ada_collect_symbol_completion_matches): Update.
1985 * ada-tasks.c (read_atcb): Update.
1986 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1987 (amd64_windows_skip_trampoline_code): Update.
1988 * arm-tdep.c (skip_prologue_function): Update.
1989 (arm_skip_stack_protector): Update.
1990 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1991 (arm_wince_skip_main_prologue): Update.
1992 * ax-gdb.c (gen_expr): Update.
1993 * block.c (call_site_for_pc): Update.
1994 * blockframe.c (find_pc_partial_function): Update.
1995 * breakpoint.c (set_breakpoint_location_function): Update.
1996 * btrace.c (ftrace_print_function_name): Update.
1997 (ftrace_function_switched): Update.
1998 * c-valprint.c (print_unpacked_pointer): Update.
1999 * coffread.c (coff_symfile_read): Update.
2000 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
2001 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
2002 * dwarf-index-write.c (write_psymbols): Update.
2003 * dwarf2loc.c (call_site_to_target_addr): Update.
2004 (func_verify_no_selftailcall): Update.
2005 (tailcall_dump): Update.
2006 (call_site_find_chain_1): Update.
2007 (dwarf_expr_reg_to_entry_parameter): Update.
2008 * elfread.c (elf_gnu_ifunc_record_cache): Update.
2009 * eval.c (evaluate_funcall): Update.
2010 (evaluate_subexp_standard): Update.
2011 (evaluate_subexp_for_sizeof): Update.
2012 * expprint.c (print_subexp_standard): Update.
2013 (dump_subexp_body_standard): Update.
2014 * frame.c (get_prev_frame_always_1): Update.
2015 * frv-tdep.c (frv_skip_main_prologue): Update.
2016 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2017 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2018 (gnuv3_get_typename_from_type_info): Update.
2019 (gnuv3_skip_trampoline): Update.
2020 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2021 * i386-tdep.c (i386_skip_main_prologue): Update.
2022 (i386_pe_skip_trampoline_code): Update.
2023 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2024 * infcall.c (get_function_name): Update.
2025 * linespec.c (minsym_found): Update.
2026 * linux-fork.c (info_checkpoints_command): Update.
2027 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2028 (m32c_m16c_pointer_to_address): Update.
2029 * maint.c (maintenance_translate_address): Update.
2030 * minsyms.c (add_minsym_to_hash_table): Update.
2031 (add_minsym_to_demangled_hash_table): Update.
2032 (lookup_minimal_symbol_mangled): Update.
2033 (lookup_minimal_symbol_demangled): Update.
2034 (lookup_minimal_symbol_linkage): Update.
2035 (lookup_minimal_symbol_text): Update.
2036 (lookup_minimal_symbol_by_pc_name): Update.
2037 (minimal_symbol_is_less_than): Update.
2038 (compact_minimal_symbols): Update.
2039 (build_minimal_symbol_hash_tables): Update.
2040 (find_solib_trampoline_target): Update.
2041 * mips-tdep.c (mips_stub_frame_sniffer): Update.
2042 (mips_skip_pic_trampoline_code): Update.
2043 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2044 * objc-lang.c (info_selectors_command): Update.
2045 (info_classes_command): Update.
2046 (find_methods): Update.
2047 (find_imps): Update.
2048 * p-valprint.c (pascal_val_print): Update.
2049 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2050 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2051 * printcmd.c (build_address_symbolic): Update.
2052 (info_symbol_command): Update.
2053 * psymtab.c (psymbol_name_matches): Update.
2054 (match_partial_symbol): Update.
2055 (lookup_partial_symbol): Update.
2056 (print_partial_symbols): Update.
2057 (sort_pst_symbols): Update.
2058 (maintenance_check_psymtabs): Update.
2059 * python/py-framefilter.c (py_print_frame): Update.
2060 * python/python.c (gdbpy_rbreak): Update.
2061 * record-btrace.c (btrace_get_bfun_name): Update.
2062 (btrace_call_history): Update.
2063 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2064 (rs6000_skip_trampoline_code): Update.
2065 * sol-thread.c (info_cb): Update.
2066 * stabsread.c (scan_file_globals): Update.
2067 * stack.c (find_frame_funname): Update.
2068 (info_frame_command_core): Update.
2069 * symmisc.c (dump_msymbols): Update.
2070 * symtab.c (symbol_natural_name): Rename to..,
2071 (general_symbol_info::natural_name): ...this.
2072 (symbol_demangled_name): Rename to...
2073 (general_symbol_info::demangled_name): ...this.
2074 (symbol_search_name): Rename to...
2075 (general_symbol_info::search_name): ...this.
2076 (symbol_matches_search_name): Update.
2077 (find_pc_sect_line): Update.
2078 (skip_prologue_sal): Update.
2079 (search_symbols): Update.
2080 (print_msymbol_info): Update.
2081 (rbreak_command): Update.
2082 (completion_list_add_msymbol): Update.
2083 (completion_list_objc_symbol): Update.
2084 (get_msymbol_address): Update.
2085 * symtab.h (struct general_symbol_info): Add member functions
2086 natural_name (), linkage_name (), print_name (), demangled_name (),
2087 and search_name ().
2088 (SYMBOL_NATURAL_NAME): Update.
2089 (symbol_natural_name): Move to a member function on general_symbol_info.
2090 (SYMBOL_DEMANGLED_NAME): Update.
2091 (symbol_demangled_name): Move to a member function on
2092 general_symbol_info.
2093 (SYMBOL_SEARCH_NAME): Update.
2094 (symbol_search_name): Move to a member function on general_symbol_info.
2095 (MSYMBOL_NATURAL_NAME): Remove.
2096 (MSYMBOL_LINKAGE_NAME): Remove.
2097 (MSYMBOL_PRINT_NAME): Remove.
2098 (MSYMBOL_DEMANGLED_NAME): Remove.
2099 (MSYMBOL_SEARCH_NAME): Remove.
2100 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2101
f8bab2d6
CB
21022019-11-22 Christian Biesinger <cbiesinger@google.com>
2103
2104 * symtab.c (create_demangled_names_hash): Use per_bfd->
2105 minimal_symbol_count for computing the initial size, if greater
2106 than our default size.
2107
85e7588d
TV
21082019-11-22 Tom de Vries <tdevries@suse.de>
2109
2110 * contrib/words.sh: Improve words extraction.
2111
f6180073
TV
21122019-11-22 Tom de Vries <tdevries@suse.de>
2113
2114 * contrib/words.sh: Combine sed invocations.
2115
f10ffa41
CB
21162019-11-21 Christian Biesinger <cbiesinger@google.com>
2117
2118 * Makefile.in: Update.
2119 * demangle.c: Rename to...
2120 * gdb-demangle.c: ..this.
2121 (is_cplus_marker): Change return type to bool.
2122 (_initialize_demangler): Rename to...
2123 (_initialize_gdb_demangle): ...this.
2124 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2125 * symtab.h (demangle): Remove declaration; instead include
2126 gdb-demangle.h.
2127
6ba18521
TT
21282019-11-21 Tom Tromey <tromey@adacore.com>
2129
2130 * gdbsupport/format.c (format_pieces): Parse %I64d.
2131 * unittests/format_pieces-selftests.c (test_windows_formats): New
2132 function.
2133 (run_tests): Call it.
2134
34877895
PJ
21352019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2136
2137 Byte reverse display of variables with DW_END_big, DW_END_little
2138 (DW_AT_endianity) dwarf attributes if different than the native
2139 byte order.
2140 * ada-lang.c (ada_value_binop):
2141 Use type_byte_order instead of gdbarch_byte_order.
2142 * ada-valprint.c (printstr):
2143 (ada_val_print_string):
2144 * ada-lang.c (value_pointer):
2145 (ada_value_binop):
2146 Use type_byte_order instead of gdbarch_byte_order.
2147 * c-lang.c (c_get_string):
2148 Use type_byte_order instead of gdbarch_byte_order.
2149 * c-valprint.c (c_val_print_array):
2150 Use type_byte_order instead of gdbarch_byte_order.
2151 * cp-valprint.c (cp_print_class_member):
2152 Use type_byte_order instead of gdbarch_byte_order.
2153 * dwarf2loc.c (rw_pieced_value):
2154 Use type_byte_order instead of gdbarch_byte_order.
2155 * dwarf2read.c (read_base_type): Handle DW_END_big,
2156 DW_END_little
2157 * f-lang.c (f_get_encoding):
2158 Use type_byte_order instead of gdbarch_byte_order.
2159 * findvar.c (default_read_var_value):
2160 Use type_byte_order instead of gdbarch_byte_order.
2161 * gdbtypes.c (check_types_equal):
2162 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2163 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2164 and TYPE_ENDIANITY_LITTLE if set.
2165 (type_byte_order): new function.
2166 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2167 (struct main_type) <flag_endianity_not_default>:
2168 New field.
2169 (type_byte_order): New function.
2170 * infcmd.c (default_print_one_register_info):
2171 Use type_byte_order instead of gdbarch_byte_order.
2172 * p-lang.c (pascal_printstr):
2173 Use type_byte_order instead of gdbarch_byte_order.
2174 * p-valprint.c (pascal_val_print):
2175 Use type_byte_order instead of gdbarch_byte_order.
2176 * printcmd.c (print_scalar_formatted):
2177 Use type_byte_order instead of gdbarch_byte_order.
2178 * solib-darwin.c (darwin_current_sos):
2179 Use type_byte_order instead of gdbarch_byte_order.
2180 * solib-svr4.c (solib_svr4_r_ldsomap):
2181 Use type_byte_order instead of gdbarch_byte_order.
2182 * stap-probe.c (stap_modify_semaphore):
2183 Use type_byte_order instead of gdbarch_byte_order.
2184 * target-float.c (target_float_same_format_p):
2185 Use type_byte_order instead of gdbarch_byte_order.
2186 * valarith.c (scalar_binop):
2187 (value_bit_index):
2188 Use type_byte_order instead of gdbarch_byte_order.
2189 * valops.c (value_cast):
2190 Use type_byte_order instead of gdbarch_byte_order.
2191 * valprint.c (generic_emit_char):
2192 (generic_printstr):
2193 (val_print_string):
2194 Use type_byte_order instead of gdbarch_byte_order.
2195 * value.c (unpack_long):
2196 (unpack_bits_as_long):
2197 (unpack_value_bitfield):
2198 (modify_field):
2199 (pack_long):
2200 (pack_unsigned_long):
2201 Use type_byte_order instead of gdbarch_byte_order.
2202 * findvar.c (unsigned_pointer_to_address):
2203 (signed_pointer_to_address):
2204 (unsigned_address_to_pointer):
2205 (address_to_signed_pointer):
2206 (default_read_var_value):
2207 (default_value_from_register):
2208 Use type_byte_order instead of gdbarch_byte_order.
2209 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2210 Use type_byte_order instead of gdbarch_byte_order.
2211 * riscv-tdep.c (riscv_print_one_register_info):
2212 Use type_byte_order instead of gdbarch_byte_order.
2213
87fb00ea
SM
22142019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2215
2216 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2217 (current_ui_gdb_stdin_ptr): Likewise.
2218 (current_ui_gdb_stderr_ptr): Likewise.
2219 (current_ui_gdb_stdlog_ptr): Likewise.
2220 (current_ui_current_uiout_ptr): Likewise.
2221 (gen_ret_current_ui_field_ptr): Remove.
2222
65d1cd5f
TV
22232019-11-21 Tom de Vries <tdevries@suse.de>
2224
2225 PR gdb/24956
2226 * cli/cli-script.c (execute_control_command): Only switch to
2227 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2228
9f6ad286
TT
22292019-11-19 Tom Tromey <tom@tromey.com>
2230
2231 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2232 Now static. Change type of "name".
2233 (tui_set_win_height_command): Don't copy "arg".
2234 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2235 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2236
435d3d88
AT
22372019-11-19 Ali Tamur <tamur@google.com>
2238
2239 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2240 "if (attr != nullptr)".
2241 (dwarf2_find_base_address): Likewise.
2242 (dwarf2_build_include_psymtabs): Likewise.
2243 (read_cutu_die_from_dwo): Likewise.
2244 (read_func_scope): Likewise.
2245 (read_call_site_scope): Likewise.
2246 (dwarf2_get_pc_bounds): Likewise.
2247 (dwarf2_record_block_ranges): Likewise.
2248 (dwarf2_add_field): Likewise.
2249 (dwarf2_add_member_fn): Likewise.
2250 (read_structure_type): Likewise.
2251 (read_enumeration_type): Likewise.
2252 (read_array_type): Likewise.
2253 (read_array_order): Likewise.
2254 (read_set_type): Likewise.
2255 (read_common_block): Likewise.
2256 (read_tag_reference_type): Likewise.
2257 (read_tag_string_type): Likewise.
2258 (read_subroutine_type): Likewise.
2259 (read_base_type): Likewise.
2260 (read_subrange_type): Likewise.
2261 (new_symbol): Likewise.
2262 (prepare_one_comp_unit): Likewise.
2263
c9739b6a
TT
22642019-11-19 Tom Tromey <tromey@adacore.com>
2265
2266 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2267 result in error when DebugActiveProcess fails.
2268
494409bb
SDJ
22692019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2270 Pedro Alves <palves@redhat.com>
2271
2272 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2273 * target.c (target_stack::push): Call 'unpush' if there's a
2274 target on top of the stack.
2275
2e953aca
PW
22762019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2277
2278 * python/py-block.c (blpy_dealloc): Call tp_free.
2279 (blpy_block_syms_dealloc): Likewise.
2280 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2281 * python/py-inferior.c (infpy_dealloc): Likewise.
2282 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2283 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2284 * python/py-symbol.c (sympy_dealloc): Likewise.
2285 * python/py-symtab.c (stpy_dealloc): Likewise.
2286 * python/py-type.c (typy_iterator_dealloc): Likewise.
2287
6edc43ec
CB
22882019-11-18 Christian Biesinger <cbiesinger@google.com>
2289
2290 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2291 constructor instead of using a class initializer.
2292
cd850b40
CB
22932019-11-15 Christian Biesinger <cbiesinger@google.com>
2294
2295 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2296 * configure: Regenerate.
2297 * configure.ac: Don't source common.host.
2298 * gdbsupport/common.host: Remove.
2299 * gdbsupport/mingw-strerror.c: Remove.
2300 * gdbsupport/posix-strerror.c: Rename to...
2301 * gdbsupport/safe-strerror.c: ...this.
2302
53fea9c7
CB
23032019-11-15 Christian Biesinger <cbiesinger@google.com>
2304
2305 * maint.c (scoped_command_stats::print_time): Use localtime_r
2306 instead of localtime (provided through gnulib if necessary).
2307 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2308 of ctime.
2309
f8e27d88
CB
23102019-11-15 Christian Biesinger <cbiesinger@google.com>
2311
2312 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2313 avoid compile errors.
2314
5abebf3c
CB
23152019-11-15 Christian Biesinger <cbiesinger@google.com>
2316
2317 * config.in: Regenerate.
2318 * configure: Regenerate.
2319 * gdbsupport/common.m4: No longer check for strerror_r.
2320 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2321 POSIX version of strerror_r, now that gnulib provides it if
2322 necessary.
2323
9a351667
CB
23242019-11-14 Christian Biesinger <cbiesinger@google.com>
2325
2326 * README (`configure' options): Update.
2327
55708e99
TT
23282019-11-14 Tom Tromey <tromey@adacore.com>
2329
2330 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2331 expected type for the RHS if the LHS is a convenience variable.
2332
4b09bb2e
SM
23332019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2334
2335 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2336 Provide explicit default and copy constructor.
2337
bd454f8b
PW
23382019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2339
2340 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2341 only call Py_INCREF (newbp) in the bppy_pending_object case.
2342
d1aa3cf0
TT
23432019-11-13 Tom Tromey <tromey@adacore.com>
2344
2345 PR build/25182:
2346 * psympriv.h (partial_symbol): Remove static assert.
2347 * symtab.h (general_symbol_info, symbol): Remove static assert.
2348
e06f3d6e
AB
23492019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2350
2351 * gdbsupport/format.c (format_pieces::format_pieces): Support
2352 printf 'z' size modifier.
2353 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2354 * printcmd.c (ui_printf): Handle size_t_arg.
2355 * ui-out.c (ui_out::vmessage): Likewise.
2356 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2357 function.
2358 (run_tests): Call test_format_int_sizes.
2359
468c0cbb
CB
23602019-11-12 Christian Biesinger <cbiesinger@google.com>
2361
2362 * ada-exp.y (write_ambiguous_var): Update.
2363 * buildsym.c (add_symbol_to_list): Update.
2364 * dwarf2read.c (read_variable): Update.
2365 (new_symbol): Update.
2366 * jit.c (finalize_symtab): Update.
2367 * language.c (language_alloc_type_symbol): Update.
2368 * symtab.c (fixup_symbol_section): Update.
2369 (initialize_objfile_symbol_1): Move code to...
2370 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2371 (allocate_symbol): Update.
2372 (allocate_template_symbol): Update.
2373 (get_symbol_address): Update.
2374 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2375 of having as a field, and add a constructor.
2376 (SYMBOL_VALUE): Update.
2377 (SYMBOL_VALUE_ADDRESS): Update.
2378 (SET_SYMBOL_VALUE_ADDRESS): Update.
2379 (SYMBOL_VALUE_BYTES): Update.
2380 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2381 (SYMBOL_BLOCK_VALUE): Update.
2382 (SYMBOL_VALUE_CHAIN): Update.
2383 (SYMBOL_LANGUAGE): Update.
2384 (SYMBOL_SECTION): Update.
2385 (SYMBOL_OBJ_SECTION): Update.
2386 (SYMBOL_SET_LANGUAGE): Update.
2387 (SYMBOL_SET_LINKAGE_NAME): Update.
2388 (SYMBOL_SET_NAMES): Update.
2389 (SYMBOL_NATURAL_NAME): Update.
2390 (SYMBOL_LINKAGE_NAME): Update.
2391 (SYMBOL_DEMANGLED_NAME): Update.
2392 (SYMBOL_SEARCH_NAME): Update.
2393 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2394 (struct symbol): Update.
2395 (struct template_symbol): Update.
2396 (struct rust_vtable_symbol): Update.
2397 * xcoffread.c (SYMBOL_DUP): Update.
2398
ed2c82c3
TT
23992019-11-12 Tom Tromey <tom@tromey.com>
2400
2401 * tui/tui-layout.c (show_layout): Set current_layout.
2402 (show_source_disasm_command, show_data)
2403 (show_source_or_disasm_and_command): Don't set current_layout.
2404
d9fcefd5
TT
24052019-11-12 Tom Tromey <tom@tromey.com>
2406
2407 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2408
45e42163
TT
24092019-11-12 Tom Tromey <tom@tromey.com>
2410
2411 * tui/tui-win.c (resize_message): New global.
2412 (show_tui_resize_message): New function.
2413 (tui_async_resize_screen): Print message if requested.
2414 (_initialize_tui_win): Add tui-resize-message setting.
2415 * NEWS: Add entry for new commands.
2416
c86d74cc
TT
24172019-11-11 Tom Tromey <tom@tromey.com>
2418
2419 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2420 functions.
2421
7b7b9424
CB
24222019-11-11 Christian Biesinger <cbiesinger@google.com>
2423
2424 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2425
086baaf1
AB
24262019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2427
2428 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2429 function.
2430 * python/python-internal.h (gdbpy_lookup_static_symbols):
2431 Declare new function.
2432 * python/python.c (python_GdbMethods): Add
2433 gdb.lookup_static_symbols method.
2434 * NEWS: Mention gdb.lookup_static_symbols.
2435
09ff83af
AB
24362019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2437
2438 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2439 static block of current object file first. Also fix typo in
2440 header comment.
2441
eb2dd8df
AB
24422019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2443
2444 * stack.c (set_last_displayed_sal): Delete.
2445 (last_displayed_sal_valid): Delete.
2446 (last_displayed_pspace): Delete.
2447 (last_displayed_addr): Delete.
2448 (last_displayed_symtab): Delete.
2449 (last_displayed_line): Delete.
2450 (class last_displayed_symtab_info_type): New.
2451 (last_displayed_symtab_info): New static global variable.
2452 (print_frame_info): Call methods on last_displayed_symtab_info.
2453 (clear_last_displayed_sal): Update header comment, and make use of
2454 last_displayed_symtab_info.
2455 (last_displayed_sal_is_valid): Likewise.
2456 (get_last_displayed_pspace): Likewise.
2457 (get_last_displayed_addr): Likewise.
2458 (get_last_displayed_symtab): Likewise.
2459 (get_last_displayed_line): Likewise.
2460 (get_last_displayed_sal): Likewise.
2461 * stack.h (clear_last_displayed_sal): Update header comment.
2462 (last_displayed_sal_is_valid): Likewise.
2463 (get_last_displayed_pspace): Likewise.
2464 (get_last_displayed_addr): Likewise.
2465 (get_last_displayed_symtab): Likewise.
2466 (get_last_displayed_line): Likewise.
2467 (get_last_displayed_sal): Likewise.
2468
62137775
AB
24692019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2470
2471 * stack.c (frame_show_address): Convert return type to bool.
2472 * stack.h (frame_show_address): Likewise, and update header
2473 comment.
2474
cf57ad6d
AB
24752019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2476
2477 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2478 * unittests/vec-utils-selftests.c: New file.
2479 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2480
0b026263
TT
24812019-11-10 Tom Tromey <tom@tromey.com>
2482
2483 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2484 (tui_highlight_win): Likewise.
2485 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2486 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2487 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2488 Don't set can_highlight.
2489
b049ce2d
TT
24902019-11-10 Tom Tromey <tom@tromey.com>
2491
2492 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2493 Remove unused declaration.
2494
992a7040
TT
24952019-11-08 Tom Tromey <tromey@adacore.com>
2496
2497 * top.c (read_command_file): Update.
2498 (command_line_input): Make return type const.
2499 * python/py-gdb-readline.c: Update.
2500 * linespec.c (decode_line_2): Update.
2501 * defs.h (command_line_input): Make return type const.
2502 * cli/cli-script.c (read_next_line): Make return type const.
2503 * ada-lang.c (get_selections): Update.
2504
ca3a04f6
CB
25052019-11-06 Christian Biesinger <cbiesinger@google.com>
2506
2507 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2508 * mi/mi-main.c (output_cores): Likewise.
2509 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2510 (linux_xfer_osdata_modules): Likewise.
2511 * remote.c (register_remote_support_xml): Likewise.
2512 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2513 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2514
e0eac551
TT
25152019-11-06 Tom Tromey <tom@tromey.com>
2516
2517 * tui/tui-interp.c: Don't include readline.h.
2518 * tui/tui-hooks.c: Don't include readline.h.
2519 * symmisc.c: Include tilde.h, not readline.h.
2520 * symfile.c: Include tilde.h, not readline.h.
2521 * source.c: Include tilde.h, not readline.h.
2522 * solib.c: Include tilde.h, not readline.h.
2523 * psymtab.c: Include tilde.h, not readline.h.
2524 * exec.c: Include tilde.h, not readline.h.
2525 * corelow.c: Include tilde.h, not readline.h.
2526 * cli/cli-dump.c: Include tilde.h, not readline.h.
2527 * cli/cli-cmds.c: Don't include readline.h.
2528
825165c5
TT
25292019-11-05 Tom Tromey <tom@tromey.com>
2530
2531 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2532 (tui_disassemble): Set addr_size.
2533 (tui_disasm_window::set_contents): Use addr_size.
2534
91ae903f
TT
25352019-11-05 Tom Tromey <tom@tromey.com>
2536
2537 * rust-lang.c (rust_language_defn): Update.
2538 * python/py-value.c (valpy_string): Call c_get_string.
2539 * p-lang.c (pascal_language_defn): Update.
2540 * opencl-lang.c (opencl_language_defn): Update.
2541 * objc-lang.c (objc_language_defn): Update.
2542 * m2-lang.c (m2_language_defn): Update.
2543 * language.c (unknown_language_defn, auto_language_defn): Update.
2544 (default_get_string): Remove.
2545 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2546 * go-lang.c (go_language_defn): Update.
2547 * f-lang.c (f_language_defn): Update.
2548 * d-lang.c (d_language_defn): Update.
2549 * c-lang.c (c_language_defn, cplus_language_defn)
2550 (asm_language_defn, minimal_language_defn): Update.
2551 * ada-lang.c (ada_language_defn): Update.
2552 * language.h (struct language_defn) <la_get_string>: Remove.
2553 (LA_GET_STRING): Remove.
2554 (default_get_string): Don't declare.
2555
1df2f9ef
TT
25562019-11-05 Tom Tromey <tom@tromey.com>
2557
2558 * tui/tui-source.h (struct tui_source_window): Inline
2559 constructor. Remove destructor.
2560 <style_changed, m_observable>: Move to superclass.
2561 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2562 (struct tui_source_window_base): Move private members to end.
2563 <style_changed, m_observable>: Move from tui_source_window.
2564 * tui/tui-winsource.c (tui_copy_source_line): Move from
2565 tui-source.c. Rename from copy_source_line. Add special handling
2566 for negative line number.
2567 (tui_source_window_base::style_changed): Move from
2568 tui_source_window.
2569 (tui_source_window_base): Register observer.
2570 (~tui_source_window_base): New.
2571 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2572 rename.
2573 (tui_source_window::set_contents): Use tui_copy_source_line.
2574 (tui_source_window::tui_source_window): Move to tui-source.h.
2575 (tui_source_window::~tui_source_window): Remove.
2576 (tui_source_window::style_changed): Move to superclass.
2577 * tui/tui-disasm.c (tui_disassemble): Create string file with
2578 styling, when possible. Add "addr_size" parameter.
2579 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2580 Don't compute maximum size.
2581 (len_without_escapes): New function
2582
5d051055
TT
25832019-11-05 Tom Tromey <tom@tromey.com>
2584
2585 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2586 std::string.
2587 * tui/tui-winsource.c (tui_show_source_line): Update.
2588 * tui/tui-source.c (tui_source_window::set_contents): Update.
2589 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2590
ade7beea
CB
25912019-11-05 Christian Biesinger <cbiesinger@google.com>
2592
2593 * symtab.h (gdb_static_assert): Put && operator at the beginning
2594 of the line instead of the end.
2595
3573abe1
CB
25962019-11-04 Christian Biesinger <cbiesinger@google.com>
2597
2598 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2599 and sizeof (symbol).
2600 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2601
dae8b3eb
RO
26022019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2603
2604 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2605 * configure.host: Mark *-*-solaris2.10* obsolete.
2606 * configure.tgt: Mark Solaris < 11 obsolete.
2607 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2608 Update target triplet.
2609
5df96a4e
TT
26102019-11-01 Tom Tromey <tromey@adacore.com>
2611
2612 * utils.c (print_sys_errmsg): Simplify.
2613
b7481649
TT
26142019-11-01 Tom Tromey <tromey@adacore.com>
2615
2616 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2617
e48f6033
CB
26182019-11-01 Christian Biesinger <cbiesinger@google.com>
2619
2620 * configure: Regenerate.
2621 * configure.ac: Remove check for strerror_r.
2622 * gdbsupport/common.m4: Check for strerror_r.
2623
bd5766ec
LM
26242019-11-01 Luis Machado <luis.machado@linaro.org>
2625
2626 PR gdb/25124
2627
2628 * arm-tdep.c (arm_per_objfile): Rename to ...
2629 (arm_per_bfd): ... this.
2630 (arm_objfile_data_key): Rename to ...
2631 (arm_bfd_data_key): ... this.
2632 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2633 data.
2634 (arm_record_special_symbol): Likewise.
2635
e1709896
AB
26362019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2637
2638 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2639 end.
2640 * c-typeprint.c (c_print_typedef): Likewise.
2641 * f-typeprint.c (f_print_typedef): Likewise.
2642 * m2-typeprint.c (m2_print_typedef): Likewise.
2643 * p-typeprint.c (pascal_print_typedef): Likewise.
2644 * rust-lang.c (rust_print_typedef): Likewise.
2645 * symtab.c (print_symbol_info): Print a newline after calling
2646 typedef_print.
2647
165f8965
AB
26482019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2649
2650 * symtab.c (info_module_cmdlist): New variable.
2651 (info_module_command): New function.
2652 (search_module_symbols): New function.
2653 (info_module_subcommand): New function.
2654 (struct info_modules_var_func_options): New struct.
2655 (info_modules_var_func_options_defs): New variable.
2656 (make_info_modules_var_func_options_def_group): New function.
2657 (info_module_functions_command): New function.
2658 (info_module_variables_command): New function.
2659 (info_module_var_func_command_completer): New function.
2660 (_initialize_symtab): Register new 'info module functions' and
2661 'info module variables' commands.
2662 * symtab.h (typedef symbol_search_in_module): New typedef.
2663 (search_module_symbols): Declare new function.
2664 * NEWS: Mention new commands.
2665
59c35742
AB
26662019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2667
2668 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2669 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2670 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2671 MODULES_DOMAIN.
2672 (scan_partial_symbols): Only create partial module symbols for non
2673 declarations.
2674 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2675 and MODULES_DOMAIN.
2676 * symtab.c (search_domain_name): Likewise.
2677 (search_symbols): Likewise.
2678 (print_symbol_info): Likewise.
2679 (symtab_symbol_info): Likewise.
2680 (info_modules_command): New function.
2681 (_initialize_symtab): Register 'info modules' command.
2682 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2683 * NEWS: Mention new 'info modules' command.
2684
aed61d02
PW
26852019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2686
2687 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2688 and $_gdb_maint_setting_str.
2689
9ad9b77d
PW
26902019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2691
2692 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2693 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2694 (str_value_from_setting, gdb_setting_str_internal_fn)
2695 (gdb_maint_setting_str_internal_fn): New functions.
2696 (_initialize_cli_cmds): Define the new convenience functions.
2697 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2698 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2699
8d6efaa2
CB
27002019-10-31 Christian Biesinger <cbiesinger@google.com>
2701
2702 * agent.c (set_can_use_agent): When the setting is turned on,
2703 look up agent symbols if we don't have them yet.
2704 (agent_new_objfile): Don't look up agent symbols when the agent
2705 setting is off.
2706
33cb1647
CB
27072019-10-31 Christian Biesinger <cbiesinger@google.com>
2708
2709 * config.in: Regenerate.
2710
b231e86a
CB
27112019-10-31 Christian Biesinger <cbiesinger@google.com>
2712
2713 * configure: Regenerate.
2714 * configure.ac: Check for strerror_r.
2715 * gdbsupport/common-utils.h (safe_strerror): Change return value
2716 to const char * and document that this function is now threadsafe.
2717 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2718 thread_local and call strerror_r, if available.
2719 * utils.c (perror_string): Update.
2720 (print_sys_errmsg): Update.
2721
a2726d4f
LM
27222019-10-31 Luis Machado <luis.machado@linaro.org>
2723
2724 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2725 objfile_key.
2726 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2727 objfile to fetch per-bfd data.
2728 (arm_find_exidx_entry): Likewise.
2729
75cafaa6
CB
27302019-10-31 Christian Biesinger <cbiesinger@google.com>
2731
2732 * gdbsupport/agent.c (debug_agent): Change type to bool.
2733 (use_agent): Likewise.
2734 (all_agent_symbols_look_up): Likewise.
2735 (agent_loaded_p): Change return value to bool.
2736 (agent_look_up_symbols): Update.
2737 (agent_capability_check): Change return value to bool.
2738 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2739 (debug_agent): Change type to bool.
2740 (use_agent): Likewise.
2741 (agent_capability_check): Change return value to bool.
2742
808590ec
CB
27432019-10-30 Christian Biesinger <cbiesinger@google.com>
2744
2745 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2746 (build_minimal_symbol_hash_tables): Code to clear the table moved
2747 to clear_minimal_symbol_hash_tables.
2748 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2749 when needed.
2750
f18ad8a1
SM
27512019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2752
2753 * infcmd.c: Remove includes.
2754 * infrun.c: Remove includes.
2755
de93309a
SM
27562019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2757
2758 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2759 (grow_vect): Remove declaration.
2760 (ada_type_of_array): Remove declaration.
2761 (ada_update_initial_language): Remove declaration.
2762 (ada_fold_name): Remove declaration.
2763 (ada_fill_in_ada_prototype): Remove declaration.
2764 (user_select_syms): Remove declaration.
2765 (get_selections): Remove declaration.
2766 (ada_tag_type): Remove declaration.
2767 (ada_value_tag): Remove declaration.
2768 (ada_is_others_clause): Remove declaration.
2769 (ada_in_variant): Remove declaration.
2770 (ada_value_struct_elt): Remove declaration.
2771 (ada_attribute_name): Remove declaration.
2772 (ada_system_address_type): Remove declaration.
2773 * ada-lang.c (ada_watch_location_expression): Make static.
2774 (GROW_VECT): Move here from ada-lang.h.
2775 (grow_vect): Make static.
2776 (ada_update_initial_language): Make static.
2777 (ada_fold_name): Make static.
2778 (ada_type_of_array): Make static.
2779 (encoded_ordered_before): Move up.
2780 (sort_choices): Move up.
2781 (print_signatures): Move up.
2782 (ada_print_symbol_signature): Move up.
2783 (get_selections): Move up and make static.
2784 (user_select_syms): Move up and make static.
2785 (ada_value_struct_elt): Move up and make static.
2786 (ada_tag_type): Make static.
2787 (ada_value_tag): Make static.
2788 (ada_is_others_clause): Make static.
2789 (ada_in_variant): Make static.
2790 (ada_attribute_name): Make static.
2791
cdc46a9f
SM
27922019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2793
2794 * ada-lang.c: Remove includes.
2795 * ada-typeprint.c: Remove includes.
2796 * ada-valprint.c: Remove includes.
2797
90421c56
SM
27982019-10-29 Simon Marchi <simon.marchi@efficios.com>
2799
2800 * addrmap.c: Add static assertions of type size, moved from
2801 _initialize_addrmap.
2802 (_initialize_addrmap): Remove.
2803
31edb802
CB
28042019-10-29 Christian Biesinger <cbiesinger@google.com>
2805
2806 * coffread.c (record_minimal_symbol): Update.
2807 (process_coff_symbol): Update.
2808 * dbxread.c (read_dbx_symtab): Update.
2809 * dwarf2read.c (add_partial_symbol): Update.
2810 (fixup_go_packaging): Update.
2811 (load_partial_dies): Update.
2812 (new_symbol): Update.
2813 * elfread.c (record_minimal_symbol): Change signature to use
2814 gdb::string_view instead of name+len.
2815 (elf_symtab_read): Update.
2816 (elf_rel_plt_read): Update.
2817 * mdebugread.c (parse_partial_symbols): Update.
2818 (handle_psymbol_enumerators): Update.
2819 (new_symbol): Update.
2820 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2821 to use gdb::string_view instead of name+len.
2822 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2823 * psympriv.h (add_psymbol_to_list): Likewise.
2824 * psymtab.c (add_psymbol_to_bcache): Likewise.
2825 (add_psymbol_to_list): Likewise.
2826 * stabsread.c (define_symbol): Update.
2827 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2828 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2829 (symbol_set_names): Likewise.
2830 * xcoffread.c (scan_xcoff_symtab): Update.
2831
0c921b21
CB
28322019-10-29 Christian Biesinger <cbiesinger@google.com>
2833
2834 * symtab.h (symbol_set_names): Document that copy_name must be
2835 set to true for non-nullterminated strings.
2836 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2837 linkage_name if the entry was not found and we need to demangle.
2838
35e65c49
CB
28392019-10-29 Christian Biesinger <cbiesinger@google.com>
2840
2841 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2842 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2843 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2844 * gdbsupport/gdb_binary_search.h: New file.
2845
ed2a2229
CB
28462019-10-29 Christian Biesinger <cbiesinger@google.com>
2847
2848 * NEWS: Mention new --with-system-gdbinit-dir option.
2849 * config.in: Regenerate.
2850 * configure: Regenerate.
2851 * configure.ac: Add new option --with-system-gdbinit-dir.
2852 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2853 for a ".gdb" suffix.
2854 * main.c (get_init_files): Change system_gdbinit argument to
2855 a vector and return the files in SYSTEM_GDBINIT_DIR in
2856 addition to SYSTEM_GDBINIT.
2857 (captured_main_1): Update.
2858 (print_gdb_help): Update.
2859 * top.c (print_gdb_configuration): Also print the value of
2860 SYSTEM_GDBINIT_DIR.
2861
87f34879
CB
28622019-10-28 Christian Biesinger <cbiesinger@google.com>
2863
2864 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2865 that takes gdb::string_view arguments.
2866
30baf67b
TV
28672019-10-26 Tom de Vries <tdevries@suse.de>
2868
2869 * aarch64-linux-tdep.c: Fix typos in comments.
2870 * aarch64-tdep.c: Same.
2871 * ada-lang.c: Same.
2872 * amd64-nat.c: Same.
2873 * arc-tdep.c: Same.
2874 * arch/aarch64-insn.c: Same.
2875 * block.c: Same.
2876 * breakpoint.h: Same.
2877 * btrace.h: Same.
2878 * c-varobj.c: Same.
2879 * cli/cli-decode.c: Same.
2880 * cli/cli-script.c: Same.
2881 * cli/cli-utils.h: Same.
2882 * coff-pe-read.c: Same.
2883 * coffread.c: Same.
2884 * compile/compile-cplus-symbols.c: Same.
2885 * compile/compile-object-run.c: Same.
2886 * completer.c: Same.
2887 * corelow.c: Same.
2888 * cp-support.c: Same.
2889 * demangle.c: Same.
2890 * dwarf-index-write.c: Same.
2891 * dwarf2-frame.c: Same.
2892 * dwarf2-frame.h: Same.
2893 * eval.c: Same.
2894 * frame-base.h: Same.
2895 * frame.h: Same.
2896 * gdbcmd.h: Same.
2897 * gdbtypes.h: Same.
2898 * gnu-nat.c: Same.
2899 * guile/scm-objfile.c: Same.
2900 * i386-tdep.c: Same.
2901 * i386-tdep.h: Same.
2902 * infcall.c: Same.
2903 * infcall.h: Same.
2904 * linux-nat.c: Same.
2905 * m68k-tdep.c: Same.
2906 * macroexp.c: Same.
2907 * memattr.c: Same.
2908 * mi/mi-cmd-disas.c: Same.
2909 * mi/mi-getopt.h: Same.
2910 * mi/mi-main.c: Same.
2911 * minsyms.c: Same.
2912 * nat/aarch64-sve-linux-sigcontext.h: Same.
2913 * objfiles.h: Same.
2914 * ppc-linux-nat.c: Same.
2915 * ppc-linux-tdep.c: Same.
2916 * ppc-tdep.h: Same.
2917 * progspace.h: Same.
2918 * prologue-value.h: Same.
2919 * python/py-evtregistry.c: Same.
2920 * python/py-instruction.h: Same.
2921 * record-btrace.c: Same.
2922 * record-full.c: Same.
2923 * remote.c: Same.
2924 * rs6000-tdep.c: Same.
2925 * ser-tcp.c: Same.
2926 * sol-thread.c: Same.
2927 * sparc-sol2-tdep.c: Same.
2928 * sparc64-tdep.c: Same.
2929 * stabsread.c: Same.
2930 * symfile.c: Same.
2931 * symtab.h: Same.
2932 * target.c: Same.
2933 * tracepoint.c: Same.
2934 * tui/tui-data.h: Same.
2935 * tui/tui-io.c: Same.
2936 * tui/tui-win.c: Same.
2937 * tui/tui.c: Same.
2938 * unittests/rsp-low-selftests.c: Same.
2939 * user-regs.h: Same.
2940 * utils.c: Same.
2941 * utils.h: Same.
2942 * valarith.c: Same.
2943 * valops.c: Same.
2944 * valprint.c: Same.
2945 * valprint.h: Same.
2946 * value.c: Same.
2947 * value.h: Same.
2948 * varobj.c: Same.
2949 * x86-nat.h: Same.
2950 * xtensa-tdep.c: Same.
2951
1834d45f
AT
29522019-10-25 Ali Tamur <tamur@google.com>
2953
2954 * charset.c (find_charset_names): Reflect API change.
2955
5396ae17
CB
29562019-10-25 Christian Biesinger <cbiesinger@google.com>
2957
2958 * symtab.c (struct demangled_name_entry): Change demangled name
2959 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2960 part of the struct anymore.
2961 (symbol_set_names): No longer obstack allocate + copy the demangled
2962 name, just store the allocated name from bfd.
2963
93878f47
TT
29642019-10-25 Tom Tromey <tromey@adacore.com>
2965
2966 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2967 (bsearch_cie_cmp, add_cie): Remove.
2968 (find_cie): Reimplement.
2969 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2970 (dwarf2_build_frame_info): Update.
2971
7b71fc97
L
29722019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2973
2974 PR gdb/25126
2975 * symfile.c (reread_symbols): Call forget_cached_source_info to
2976 clear the stale source cache.
2977
cbb5a2ea
CB
29782019-10-24 Christian Biesinger <cbiesinger@google.com>
2979
2980 * configure: Regenerate.
2981 * configure.ac: Remove code that sets python_has_threads.
2982
71737c43
CB
29832019-10-24 Christian Biesinger <cbiesinger@google.com>
2984
2985 * config.in: Regenerate.
2986 * configure: Regenerate.
2987 * configure.ac: Remove the code that uses sed to get the python
2988 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2989
33d569b7
AB
29902019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2991
2992 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2993 error paths.
2994
f16f7b7c
TT
29952019-10-23 Tom Tromey <tom@tromey.com>
2996
2997 * arc-tdep.c: Remove ".." from include.
2998 * frv-tdep.c: Remove ".." from include.
2999 * lm32-tdep.c: Remove ".." from include.
3000 * microblaze-tdep.c: Remove ".." from include.
3001 * or1k-tdep.h: Remove ".." from include.
3002 * s12z-tdep.c: Remove ".." from include.
3003 * Makefile.in (OPCODES_CFLAGS): Add comment.
3004 (TOP_CFLAGS): New variable.
3005 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
3006
6999161a
TT
30072019-10-23 Tom Tromey <tom@tromey.com>
3008
3009 * Makefile.in (READLINE_DIR): Update.
3010
12e7c35e
TBA
30112019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3012
3013 * infcall.c (call_function_by_hand_dummy): Fix the function
3014 comment. And extract out a code section into...
3015 (reserve_stack_space): ...this new function.
3016
37055cad
TBA
30172019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3018
3019 * infcall.c (value_arg_coerce): Remove an unused parameter.
3020 (call_function_by_hand_dummy): Update the call to
3021 'value_arg_coerce'.
3022
39bcc47c
TBA
30232019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3024
3025 * infcall.c (call_function_by_hand_dummy): Refactor.
3026
bd888c0f
TBA
30272019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3028
3029 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3030
c12d372d
TT
30312019-10-23 Tom Tromey <tom@tromey.com>
3032
3033 * configure: Rebuild.
3034 * configure.ac: Don't check for sigprocmask.
3035 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3036
4d0b984b
TT
30372019-10-23 Tom Tromey <tom@tromey.com>
3038
3039 * configure: Rebuild.
3040 * acinclude.m4: Use m4_include, not sinclude.
3041
7e785608
TV
30422019-10-23 Tom de Vries <tdevries@suse.de>
3043
3044 PR breakpoints/24687
3045 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3046
403772ef
CB
30472019-10-22 Christian Biesinger <cbiesinger@google.com>
3048
3049 * symtab.c (struct demangled_name_entry) <language>: Change from
3050 bitfield to regular variable.
3051
3a494279
CB
30522019-10-22 Christian Biesinger <cbiesinger@google.com>
3053
3054 * symtab.c (struct demangled_name_entry): Add a constructor.
3055 (free_demangled_name_entry): New function to call the destructor
3056 for demangled_name_entry.
3057 (create_demangled_names_hash): Pass free_demangled_name_entry to
3058 htab_create_alloc.
3059 (symbol_set_names): Call placement new for demangled_name_entry.
3060 * utils.c: No longer include xxhash.h here, now that fast_hash
3061 is inlined in the header.
3062 * utils.h: Instead, include it here.
3063
ccb1ba62
CB
30642019-10-22 Christian Biesinger <cbiesinger@google.com>
3065
3066 * Makefile.in: Link with libxxhash.
3067 * config.in: Regenerate.
3068 * configure: Regenerate.
3069 * configure.ac: Search for libxxhash.
3070 * utils.c (fast_hash): Use xxhash if present.
3071
1a6ff1a9
CB
30722019-10-22 Christian Biesinger <cbiesinger@google.com>
3073
3074 * utils.h (fast_hash): New function.
3075 * symtab.c (hash_demangled_name_entry): Call new function
3076 fast_hash.
3077
7bb43059
CB
30782019-10-22 Christian Biesinger <cbiesinger@google.com>
3079
3080 * symtab.c (struct demangled_name_entry): Change type of mangled
3081 to gdb::string_view. Also adds a constructor that takes the
3082 mangled name.
3083 (hash_demangled_name_entry): Update.
3084 (eq_demangled_name_entry): Update.
3085 (free_demangled_name_entry): New function to call the destructor
3086 now that this is not a POD anymore.
3087 (create_demangled_names_hash): Pass free_demangled_name_entry to
3088 htab_create_alloc.
3089 (symbol_set_names): Update.
3090
7ba99d21
AT
30912019-10-21 Ali Tamur <tamu@google.com>
3092
3093 * dwarf2read.c (dir_index): Change type.
3094 (file_name_index): Likewise.
3095 (line_header::include_dir_at): Change comment and implementation on
3096 whether it is DWARF 5.
3097 (line_header::is_valid_file_index): New function.
3098 (line_header::file_name_at): Change comment and implementation on
3099 whether it is DWARF 5.
3100 (line_header::file_names): Change to private field renamed as
3101 m_file_names and introduce a new accessor method.
3102 (line_header::file_names_size): New method.
3103 (line_header::include_dirs): Change to private field and rename as
3104 m_include_dirs.
3105 (dw2_get_file_names_reader): Define local var at a smaller scope and
3106 reflect API change.
3107 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3108 (process_structure_scope): Likewise.
3109 (line_header::add_include_dir): Change message and reflect renaming.
3110 (line_header::add_file_name): Likewise.
3111 (read_formatted_entries): Handle DW_FORM_data16.
3112 (dwarf_decode_line_header): Fix line header length calculation.
3113 (psymtab_include_file_name): Change comment and API.
3114 (lnp_state_machine::m_file): Update comment and reflect type change.
3115 (lnp_state_machine::record_line): Reflect type change.
3116 (dwarf_decode_lines): Reflect API change.
3117 (file_file_name): Likewise.
3118 (file_full_name): Likewise.
3119
45f47c3a
AB
31202019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
3121
3122 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3123
e5f3c0e3
TT
31242019-10-21 Tom Tromey <tom@tromey.com>
3125
3126 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3127
a0a461e5
TT
31282019-10-21 Tom Tromey <tom@tromey.com>
3129
3130 * configure.ac (nm.h): Conditionally create nm.h link. Subst
3131 NM_H. Use AC_CONFIG_LINKS.
3132 * configure: Rebuild.
3133 * Makefile.in (NM_H): New variable.
3134 (generated_files): Add NM_H. Remove gcore.
3135 (nm.h, stamp-nmh): New targets.
3136
54d83b8d
TT
31372019-10-20 Tom Tromey <tom@tromey.com>
3138
3139 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3140 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3141 obsolete comment.
3142 (put_objfile_before): Now static.
3143
23771117
SM
31442019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3145
3146 * gdbsupport/common-utils.h (startswith): Change return type to
3147 bool.
3148
39ef2f62
CB
31492019-10-19 Christian Biesinger <cbiesinger@google.com>
3150
3151 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3152 * breakpoint.c (bp_locations_compare): Rename to...
3153 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3154 (update_global_location_list): Use std::sort instead of qsort.
3155 * buildsym.c (compare_line_numbers): Rename to...
3156 (lte_is_less_than): ...this, and change to std::sort semantics.
3157 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3158 instead of qsort.
3159 * disasm.c (compare_lines): Rename to...
3160 (line_is_less_than): ...this, and change to std::sort semantics.
3161 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3162 of qsort.
3163 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3164 (fde_is_less_than): ...this, and change to std::sort semantics.
3165 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3166 * mdebugread.c (compare_blocks):
3167 (block_is_less_than): ...this, and change to std::sort semantics.
3168 (sort_blocks): Call std::sort instead of qsort.
3169 * objfiles.c (qsort_cmp): Rename to...
3170 (sort_cmp): ...this, and change to std::sort semantics.
3171 (update_section_map): Call std::sort instead of qsort.
3172 * remote.c (compare_pnums): Remove.
3173 (map_regcache_remote_table): Call std::sort instead of qsort.
3174 * utils.c (compare_positive_ints): Remove.
3175 * utils.h (compare_positive_ints): Remove.
3176 * xcoffread.c (compare_lte): Remove.
3177 (arrange_linetable): Call std::sort instead of qsort.
3178
f71433ee
SDJ
31792019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3180
3181 * symfile.c (init_entry_point_info): Fix typo.
3182 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3183
85102364
TV
31842019-10-18 Tom de Vries <tdevries@suse.de>
3185
3186 * aarch64-tdep.c: Fix typos in comments.
3187 * ada-lang.c: Same.
3188 * ada-tasks.c: Same.
3189 * alpha-tdep.c: Same.
3190 * alpha-tdep.h: Same.
3191 * amd64-nat.c: Same.
3192 * amd64-windows-tdep.c: Same.
3193 * arc-tdep.c: Same.
3194 * arc-tdep.h: Same.
3195 * arch-utils.c: Same.
3196 * arm-nbsd-tdep.c: Same.
3197 * arm-tdep.c: Same.
3198 * ax-gdb.c: Same.
3199 * blockframe.c: Same.
3200 * btrace.c: Same.
3201 * c-varobj.c: Same.
3202 * coff-pe-read.c: Same.
3203 * coffread.c: Same.
3204 * cris-tdep.c: Same.
3205 * darwin-nat.c: Same.
3206 * dbxread.c: Same.
3207 * dcache.c: Same.
3208 * disasm.c: Same.
3209 * dtrace-probe.c: Same.
3210 * dwarf-index-write.c: Same.
3211 * dwarf2-frame-tailcall.c: Same.
3212 * dwarf2-frame.c: Same.
3213 * dwarf2read.c: Same.
3214 * eval.c: Same.
3215 * exceptions.c: Same.
3216 * fbsd-tdep.c: Same.
3217 * findvar.c: Same.
3218 * frame.c: Same.
3219 * frv-tdep.c: Same.
3220 * gnu-v3-abi.c: Same.
3221 * go32-nat.c: Same.
3222 * h8300-tdep.c: Same.
3223 * hppa-tdep.c: Same.
3224 * i386-linux-tdep.c: Same.
3225 * i386-tdep.c: Same.
3226 * ia64-libunwind-tdep.c: Same.
3227 * ia64-tdep.c: Same.
3228 * infcmd.c: Same.
3229 * infrun.c: Same.
3230 * linespec.c: Same.
3231 * linux-nat.c: Same.
3232 * linux-thread-db.c: Same.
3233 * machoread.c: Same.
3234 * mdebugread.c: Same.
3235 * mep-tdep.c: Same.
3236 * mn10300-tdep.c: Same.
3237 * namespace.c: Same.
3238 * objfiles.c: Same.
3239 * opencl-lang.c: Same.
3240 * or1k-tdep.c: Same.
3241 * osabi.c: Same.
3242 * ppc-linux-nat.c: Same.
3243 * ppc-linux-tdep.c: Same.
3244 * ppc-sysv-tdep.c: Same.
3245 * printcmd.c: Same.
3246 * procfs.c: Same.
3247 * record-btrace.c: Same.
3248 * record-full.c: Same.
3249 * remote-fileio.c: Same.
3250 * remote.c: Same.
3251 * rs6000-tdep.c: Same.
3252 * s12z-tdep.c: Same.
3253 * score-tdep.c: Same.
3254 * ser-base.c: Same.
3255 * ser-go32.c: Same.
3256 * skip.c: Same.
3257 * sol-thread.c: Same.
3258 * solib-svr4.c: Same.
3259 * solib.c: Same.
3260 * source.c: Same.
3261 * sparc-nat.c: Same.
3262 * sparc-sol2-tdep.c: Same.
3263 * sparc-tdep.c: Same.
3264 * sparc64-tdep.c: Same.
3265 * stabsread.c: Same.
3266 * stack.c: Same.
3267 * symfile.c: Same.
3268 * symtab.c: Same.
3269 * target-descriptions.c: Same.
3270 * target-float.c: Same.
3271 * thread.c: Same.
3272 * utils.c: Same.
3273 * valops.c: Same.
3274 * valprint.c: Same.
3275 * value.c: Same.
3276 * varobj.c: Same.
3277 * windows-nat.c: Same.
3278 * xcoffread.c: Same.
3279 * xstormy16-tdep.c: Same.
3280 * xtensa-tdep.c: Same.
3281
c5adaa19
TT
32822019-10-17 Tom Tromey <tromey@adacore.com>
3283
3284 * configure: Rebuild.
3285 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3286 in AC_CONFIG_FILES invocation.
3287 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3288 new-style config.status invocation.
3289
405feb71
TV
32902019-10-17 Tom de Vries <tdevries@suse.de>
3291
3292 * arm-nbsd-nat.c: Fix typos in comments.
3293 * arm-tdep.c: Same.
3294 * darwin-nat-info.c: Same.
3295 * dwarf2read.c: Same.
3296 * elfread.c: Same.
3297 * event-top.c: Same.
3298 * findvar.c: Same.
3299 * gdbtypes.c: Same.
3300 * hppa-tdep.c: Same.
3301 * i386-tdep.c: Same.
3302 * jit.c: Same.
3303 * main.c: Same.
3304 * mdebugread.c: Same.
3305 * moxie-tdep.c: Same.
3306 * nto-procfs.c: Same.
3307 * osabi.c: Same.
3308 * ppc-linux-tdep.c: Same.
3309 * remote.c: Same.
3310 * riscv-tdep.c: Same.
3311 * s390-tdep.c: Same.
3312 * sh-tdep.c: Same.
3313 * sparc-linux-tdep.c: Same.
3314 * sparc-nat.c: Same.
3315 * stack.c: Same.
3316 * target-descriptions.c: Same.
3317 * top.c: Same.
3318 * varobj.c: Same.
3319
befcd486
TT
33202019-10-16 Tom Tromey <tom@tromey.com>
3321
3322 * objfiles.h (struct objfile) <original_name>: Now const.
3323
17bfe554
CB
33242019-10-16 Christian Biesinger <cbiesinger@google.com>
3325
3326 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3327 pass on to sigsetjmp's second argument.
3328 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3329
950b7495
KS
33302019-10-16 Keith Seitz <keiths@redhat.com>
3331
3332 PR gdb/23567
3333 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3334 sections whose size is greater than the file size.
3335
ff371ec9
JW
33362019-10-16 Jim Wilson <jimw@sifive.com>
3337
3338 * riscv-tdep.c (riscv_gcc_target_options): New.
3339 (riscv_gnu_triplet_regexp): New.
3340 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3341 set_gdbarch_gnu_triplet_regexp.
3342
fec4e896
CB
33432019-10-16 Christian Biesinger <cbiesinger@google.com>
3344
3345 * Makefile.in: Add xml-builtin.h.
3346 * features/feature_to_c.sh: Add an include for xml-builtin.h
3347 to ensure that the compiler checks that the types match.
3348 * xml-builtin.h: New file.
3349 * xml-support.c (fetch_xml_builtin): Add missing const.
3350 * xml-support.h: Remove declaration of xml_builtins.
3351
d10eccaa
TV
33522019-10-16 Tom de Vries <tdevries@suse.de>
3353
3354 PR tdep/25096
3355 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3356 (amd64_classify_aggregate): ... here.
3357 (amd64_classify_aggregate_field): Handled fiels of nested structs
3358 recursively.
3359
745ff14e
TV
33602019-10-16 Tom de Vries <tdevries@suse.de>
3361
3362 PR tdep/24104
3363 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3364 that handles 'theclass'.
3365
791b7405
AB
33662019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3367
3368 * linespec.c (decode_digits_ordinary): Update comment.
3369 * make-target-delegates: No longer need to handle VEC case.
3370 * memrange.c (normalize_mem_ranges): Update comment.
3371 * namespace.c (add_using_directive): Update comment.
3372 * objc-lang.c (uniquify_strings): Update comment.
3373 * ppc-linux-nat.c (struct thread_points): Update comment.
3374 * probe.h (find_probes_in_objfile): Update comment.
3375 * target.h (enum flash_preserve_mode): Update comment.
3376 * varobj.c (varobj_restrict_range): Update comment.
3377 * varobj.h (varobj_list_children): Update comment.
3378
0dc32745
AB
33792019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3380
3381 * Makefile.in: Remove references to vec.h and vec.c.
3382 * aarch64-tdep.c: No longer include vec.h.
3383 * ada-lang.c: Likewise.
3384 * ada-lang.h: Likewise.
3385 * arm-tdep.c: Likewise.
3386 * ax.h: Likewise.
3387 * breakpoint.h: Likewise.
3388 * charset.c: Likewise.
3389 * cp-support.h: Likewise.
3390 * dtrace-probe.c: Likewise.
3391 * dwarf2read.c: Likewise.
3392 * extension.h: Likewise.
3393 * gdb_bfd.c: Likewise.
3394 * gdbsupport/gdb_vecs.h: Likewise.
3395 * gdbsupport/vec.c: Remove.
3396 * gdbsupport/vec.h: Remove.
3397 * gdbthread.h: Likewise.
3398 * guile/scm-type.c: Likewise.
3399 * inline-frame.c: Likewise.
3400 * machoread.c: Likewise.
3401 * memattr.c: Likewise.
3402 * memrange.h: Likewise.
3403 * namespace.h: Likewise.
3404 * nat/linux-btrace.h: Likewise.
3405 * osdata.c: Likewise.
3406 * parser-defs.h: Likewise.
3407 * progspace.h: Likewise.
3408 * python/py-type.c: Likewise.
3409 * record-btrace.c: Likewise.
3410 * rust-exp.y: Likewise.
3411 * solib-target.c: Likewise.
3412 * stap-probe.c: Likewise.
3413 * target-descriptions.c: Likewise.
3414 * target-memory.c: Likewise.
3415 * target.h: Likewise.
3416 * varobj.c: Likewise.
3417 * varobj.h: Likewise.
3418 * xml-support.h: Likewise.
3419
ae640021
AB
34202019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3421
3422 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3423 Update for new std::vector based implementation.
3424 (process_psymtab_comp_unit_reader): Likewise.
3425 (scan_partial_symbols): Likewise.
3426 (recursively_compute_inclusions): Likewise.
3427 (compute_compunit_symtab_includes): Likewise.
3428 (process_imported_unit_die): Likewise.
3429 (queue_and_load_dwo_tu): Likewise.
3430 (follow_die_sig_1): Likewise.
3431 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3432 (typedef dwarf2_per_cu_ptr): Remove.
3433 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3434 function.
3435 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3436 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3437 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3438 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3439 std::vector.
3440
55dfc88f
TT
34412019-10-15 Tom Tromey <tromey@adacore.com>
3442
3443 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3444 TID.
3445
96b49c5e
TT
34462019-10-15 Tom Tromey <tromey@adacore.com>
3447
3448 * windows-nat.c (windows_nat_target::fetch_registers)
3449 (windows_nat_target::store_registers): Rename "pid" to "tid".
3450
953cff56
TT
34512019-10-15 Tom Tromey <tromey@adacore.com>
3452
3453 * gdbarch.h, gdbarch.c: Rebuild.
3454 * gdbarch.sh (gcc_target_options): Change return type to
3455 std::string.
3456 * compile/compile.c (get_args): Update.
3457 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3458 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3459 std::string.
3460 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3461 std::string.
3462 * arch-utils.c (default_gcc_target_options): Return std::string.
3463 * arch-utils.h (default_gcc_target_options): Return std::string.
3464 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3465
81e6b8eb
CB
34662019-10-15 Christian Biesinger <cbiesinger@google.com>
3467
3468 * breakpoint.c (breakpoint_chain): Make static.
3469 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3470 of accessing breakpoint_chain.
3471
95da600f
CB
34722019-10-15 Christian Biesinger <cbiesinger@google.com>
3473
3474 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3475 to a gdb::function_view and return value to bool.
3476 * breakpoint.h (iterate_over_breakpoints): Likewise.
3477 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3478 (pop_dummy_frame): Update.
3479 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3480 (gdbscm_breakpoints): Update.
3481 * python/py-breakpoint.c (build_bp_list): Update.
3482 (gdbpy_breakpoints): Update.
3483 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3484 Update.
3485 (bpfinishpy_handle_stop): Update.
3486 (bpfinishpy_handle_exit): Update.
3487 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3488 (svr4_update_solib_event_breakpoints): Update.
3489
ba18312d
AA
34902019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3491
3492 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3493 when unwrapping single-field structs.
3494
6acc1a0b
SM
34952019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3496
3497 * dwarf2read.c: Remove includes.
3498
284782de
SM
34992019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3500
3501 * ui-out.c (ui_out::call_do_message): Silence
3502 -Wformat-nonliteral warning.
3503
073bbbb0
SM
35042019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3505
3506 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3507 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3508 include: readline/tilde.h.
3509
7b9a15e1
CB
35102019-10-12 Christian Biesinger <cbiesinger@google.com>
3511
3512 * remote.c (remote_target::get_trace_status): Remove declaration of
3513 trace_regblock_size.
3514
cc8dee1f
CB
35152019-10-12 Christian Biesinger <cbiesinger@google.com>
3516
3517 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3518 (show_user): Remove declaration of cmdlist.
3519 * cli/cli-cmds.h (max_user_call_depth): Declare.
3520 * cli/cli-script.c (execute_user_command): Remove declaration
3521 of max_user_call_depth.
3522
a83d4ef6
JW
35232019-10-11 Jim Wilson <jimw@sifive.com>
3524
5f93c5a6
JW
3525 * gdbsupport/print-utils.h (pulongest): Fix comment.
3526 (plongest): Likewise.
3527 (phex): Add missing comment, mention leading zeros.
3528 (phex_nz): Add mention of no leading zeros to comment.
3529
a83d4ef6
JW
3530 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3531 plongest instead of unsigned long long cast.
3532
26344e0c
CB
35332019-10-10 Christian Biesinger <cbiesinger@google.com>
3534
3535 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3536 for external_editor_command and gdbtk_test.
3537
c2c440a9
CB
35382019-10-10 Christian Biesinger <cbiesinger@google.com>
3539
3540 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3541 * varobj.c (varobjdebug): Move comment to...
3542 * varobj.h (varobjdebug): ...here, and declare.
3543
a31bff9d
TT
35442019-10-09 Tom Tromey <tom@tromey.com>
3545
3546 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3547 erase_data_content.
3548
7523da63
TT
35492019-10-09 Tom Tromey <tom@tromey.com>
3550
3551 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3552 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3553 * tui/tui-command.c (tui_cmd_window::resize)
3554 (tui_refresh_cmd_win): Update.
3555 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3556 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3557 * tui/tui-data.c (~tui_gen_win_info): Remove.
3558 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3559 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3560 (tui_redisplay_readline, tui_mld_flush)
3561 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3562 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3563 (tui_data_window::erase_data_content)
3564 (tui_data_item_window::rerender)
3565 (tui_data_item_window::refresh_window): Update.
3566 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3567 (box_win, tui_gen_win_info::make_window)
3568 (tui_gen_win_info::make_visible): Update.
3569 (tui_delete_win): Remove.
3570 * tui/tui-winsource.c
3571 (tui_source_window_base::do_erase_source_content): Update.
3572 (tui_show_source_line, tui_source_window_base::update_tab_width)
3573 (tui_source_window_base::update_exec_info): Update.
3574 * tui/tui-data.h (struct curses_deleter): New.
3575 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3576 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3577
a7798e7f
TT
35782019-10-09 Tom Tromey <tom@tromey.com>
3579
3580 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3581
5c45899e
TT
35822019-10-09 Tom Tromey <tom@tromey.com>
3583
3584 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3585 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3586
6d7fd9aa
TT
35872019-10-09 Tom Tromey <tom@tromey.com>
3588
3589 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3590 window height directly.
3591 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3592 declare.
3593 * tui/tui-layout.c (tui_default_win_height): Remove.
3594 (tui_default_win_viewport_height): Remove.
3595
d2dd1084
TT
35962019-10-09 Tom Tromey <tom@tromey.com>
3597
3598 * tui/tui.h: Remove comments.
3599
cff32449
TV
36002019-10-09 Tom de Vries <tdevries@suse.de>
3601
3602 * python/lib/gdb/printer/bound_registers.py: Use
3603 '^builtin_type_bound128' as regexp argument for
3604 add_builtin_pretty_printer.
3605
6a25e8a2
CB
36062019-10-09 Christian Biesinger <cbiesinger@google.com>
3607
3608 * guile/guile.c (guile_extension_script_ops): Remove forward
3609 declaration and mark as static.
3610 (guile_script_ops): Likewise.
3611 (extension_language_guile): Move further down in the file so
3612 it can reference the definitions for guile_{extension_,}script_ops.
3613
6d9d6da4
AA
36142019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3615
3616 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3617 except SORTL, DFLTCC, and KDSA.
3618
3abea05d
TT
36192019-10-08 Tom Tromey <tromey@adacore.com>
3620
3621 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3622 (struct safe_symbol_file_add_args): Remove.
3623
dde996e2
TT
36242019-10-08 Tom Tromey <tromey@adacore.com>
3625
3626 * windows-nat.c: Don't include buildsym-legacy.h.
3627
cd6fdaa1
TT
36282019-10-08 Tom Tromey <tromey@adacore.com>
3629
3630 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3631
79bb1944
CB
36322019-10-08 Christian Biesinger <cbiesinger@google.com>
3633
3634 * gdbtypes.c (overload_debug): Move comment to header.
3635 * gdbtypes.h (overload_debug): Declare.
3636 * valops.c: Remove declaration of overload_debug, instead
3637 include gdbtypes.h.
3638
34916edc
CB
36392019-10-08 Christian Biesinger <cbiesinger@google.com>
3640
3641 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3642 through _().
3643 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3644 move comment...
3645 * language.h (lang_frame_mismatch_warn): ... here. Also add
3646 declaration.
3647 * top.c (lang_frame_mismatch_warn): Remove declaration.
3648 (check_frame_language_change): Pass lang_frame_mismatch_warn
3649 through _().
3650
bad5c026
CB
36512019-10-07 Christian Biesinger <cbiesinger@google.com>
3652
3653 * c-lang.h (vtbl_ptr_name): Declare.
3654 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3655 it from the header.
3656 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3657
51f1fdc3
CB
36582019-10-07 Christian Biesinger <cbiesinger@google.com>
3659
3660 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3661 gdb_static_assert.
3662
30d1f018
WP
36632019-10-07 Weimin Pan <weimin.pan@oracle.com>
3664
606813d5
WP
3665 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3666 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3667 * ctfread.c: New file.
3668 * ctfread.h: New file.
3669 * elfread.c: Include ctfread.h.
3670 (struct elfinfo text_p): New member ctfsect.
3671 (elf_locate_sections): Mark CTF section.
3672 (elf_symfile_read): Call elfctf_build_psymtabs.
3673 * Makefile.in (LIBCTF): Add.
3674 (CLIBS): Use it.
3675 (CDEPS): Likewise.
3676 (DIST): Add ctfread.c.
606813d5
WP
3677
36782019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3679
3680 * ctfread.c (struct nextfield): Renamed to ...
3681 (struct ctf_nextfield): ... this.
3682 (struct field_info): Renamed to ...
3683 (strut ctf_field_info): ... this.
3684 (attach_fields_to_type): Update for renamed structures.
3685 (ctf_add_member_cb): Likewise.
3686 (ctf_add_enum_member_cb): Likewise.
3687 (process_struct_members): Likewise.
3688 (process_enum_type): Likewise.
30d1f018 3689
518fe38c
WP
36902019-10-07 Weimin Pan <weimin.pan@oracle.com>
3691
3692 * tracectf.h: Rename, was ctf.h.
3693 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3694 * tracefile.c: Likewise.
3695 * tracepoint.c: Remove unused include ctf.h.
3696 * mi/mi-main.c: Likewise.
3697 * Makefile.in Replace ctf.c with tracectf.c.
3698
225f296a
JB
36992019-10-06 Joel Brobecker <brobecker@adacore.com>
3700
3701 * version.in: Change version number to "9.0.50.DATE-git".
3702
77c2dba3
TT
37032019-10-03 Tom Tromey <tom@tromey.com>
3704
3705 PR rust/24976:
3706 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3707
179aed7f
AB
37082019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3709
3710 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3711 cp_search_name_hash.
3712 * NEWS: Add entry about nested function support.
3713
0a4b0913
AB
37142019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3715 Andrew Burgess <andrew.burgess@embecosm.com>
3716
3717 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3718 for nested static variables when searchin VAR_DOMAIN.
3719 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3720 global scope, update comment.
3721 (add_partial_subprogram): Call add_partial_subprogram recursively
3722 for nested subroutines when processinng Fortran.
3723 (load_partial_dies): Process the child entities of a subprogram
3724 when processing Fortran.
3725 (partial_die_parent_scope): Handle building scope
3726 for Fortran nested functions.
3727 (process_die): Record that nested functions have a scope.
3728 (new_symbol): Always record Fortran subprograms on the global
3729 symbol list.
3730 (determine_prefix): How to build the prefix for Fortran
3731 subprograms.
3732
d8c06f22
AB
37332019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3734
3735 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3736 have just sent the thread a SIGSTOP and are waiting for it to
3737 arrive.
3738
a8b3b8e9
AB
37392019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3740
3741 * btrace.c (btrace_add_pc): Remove whitespace before the template
3742 parameter in 'std::vector <...>'.
3743 (parse_xml_btrace_block): Likewise.
3744 (btrace_maint_decode_pt): Likewise.
3745 (btrace_maint_update_packets): Likewise.
3746 (btrace_maint_print_packets): Likewise.
3747 * btrace.h (struct btrace_maint_info): Likewise.
3748 * dwarf2read.c (struct type_unit_group): Likewise.
3749 (build_type_psymtabs_reader): Likewise.
3750 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3751 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3752 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3753
4d825eab
TV
37542019-10-03 Tom de Vries <tdevries@suse.de>
3755
3756 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3757 the first line of the help text for set/show style metadata.
3758
80fd2826
TT
37592019-10-02 Tom Tromey <tromey@adacore.com>
3760
3761 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3762 * gdbsupport/common-inferior.c: New file.
3763 * infcmd.c (startup_with_shell): Don't define.
3764 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3765 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3766 * inferior.h (startup_with_shell): Don't declare.
3767
70054538
CB
37682019-10-02 Christian Biesinger <cbiesinger@google.com>
3769
3770 * gdbsupport/gdb_assert.h: Include errors.h.
3771 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3772
37f6a7f4
TT
37732019-10-02 Tom Tromey <tromey@adacore.com>
3774
3775 * NEWS: Add $_ada_exception entry.
3776 * ada-lang.c (struct ada_catchpoint): Add constructor.
3777 <m_kind>: New member.
3778 (allocate_location_exception, re_set_exception): Remove
3779 "ex" parameter.
3780 (should_stop_exception): Compute $_ada_exception.
3781 (check_status_exception, print_it_exception)
3782 (print_one_exception, print_mention_exception): Remove
3783 "ex" parameter.
3784 (allocate_location_catch_exception, re_set_catch_exception)
3785 (check_status_exception, print_it_catch_exception)
3786 (print_one_catch_exception, print_mention_catch_exception)
3787 (print_recreate_catch_exception)
3788 (allocate_location_catch_exception_unhandled)
3789 (re_set_catch_exception_unhandled)
3790 (check_status_exception, print_it_catch_exception_unhandled)
3791 (print_one_catch_exception_unhandled)
3792 (print_mention_catch_exception_unhandled)
3793 (print_recreate_catch_exception_unhandled)
3794 (allocate_location_catch_assert, re_set_catch_assert)
3795 (check_status_assert, print_it_catch_assert)
3796 (print_one_catch_assert, print_mention_catch_assert)
3797 (print_recreate_catch_assert)
3798 (allocate_location_catch_handlers, re_set_catch_handlers)
3799 (check_status_handlers, print_it_catch_handlers)
3800 (print_one_catch_handlers, print_mention_catch_handlers)
3801 (print_recreate_catch_handlers): Remove.
3802 (create_ada_exception_catchpoint): Update.
3803 (initialize_ada_catchpoint_ops): Update.
3804
fccf9de1
TT
38052019-10-02 Tom Tromey <tromey@adacore.com>
3806
3807 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3808 (create_excep_cond_exprs): Simplify exception string computation.
3809 (ada_exception_catchpoint_cond_string): Likewise.
3810
4b610737
TT
38112019-10-02 Tom Tromey <tromey@adacore.com>
3812
3813 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3814 * ada-lang.c (lesseq_defined_than): Handle
3815 LOC_STATIC.
3816 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3817 parameter.
3818 (dwarf2_has_info): Likewise.
3819 (new_symbol): Set maybe_copied on symbol when
3820 appropriate.
3821 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3822 parameter.
3823 <can_copy>: New member.
3824 * elfread.c (record_minimal_symbol): Set maybe_copied
3825 on symbol when appropriate.
3826 (elf_symfile_read): Update call to dwarf2_has_info.
3827 * minsyms.c (lookup_minimal_symbol_linkage): New
3828 function.
3829 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3830 * symtab.c (get_symbol_address, get_msymbol_address):
3831 New functions.
3832 * symtab.h (get_symbol_address, get_msymbol_address):
3833 Declare.
3834 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3835 maybe_copied.
3836 (struct symbol, struct minimal_symbol) <maybe_copied>:
3837 New member.
3838
1dd58850
TT
38392019-10-02 Tom Tromey <tromey@adacore.com>
3840
3841 * source.c (struct current_source_location): New.
3842 (current_source_key): New global.
3843 (current_source_symtab, current_source_line)
3844 (current_source_pspace): Remove.
3845 (get_source_location): New function.
3846 (get_current_source_symtab_and_line)
3847 (set_default_source_symtab_and_line)
3848 (set_current_source_symtab_and_line)
3849 (clear_current_source_symtab_and_line, select_source_symtab)
3850 (info_source_command, print_source_lines_base)
3851 (info_line_command, search_command_helper, _initialize_source):
3852 Update.
3853
5c281dbb
TT
38542019-10-02 Tom Tromey <tromey@adacore.com>
3855
3856 * source.c (select_source_symtab): Don't call
3857 decode_line_with_current_source.
3858
d3d32391
AB
38592019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3860
3861 * symtab.c (lookup_global_symbol): Search global block.
3862
38583298
TT
38632019-10-02 Tom Tromey <tromey@adacore.com>
3864
3865 * coffread.c (process_coff_symbol): Update.
3866 * dwarf2read.c (var_decode_location, new_symbol): Update.
3867 * mdebugread.c (parse_symbol): Update.
3868 * objfiles.c (relocate_one_symbol): Update.
3869 * stabsread.c (define_symbol, fix_common_block)
3870 (scan_file_globals): Update.
3871 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3872 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3873 * xcoffread.c (process_xcoff_symbol): Update.
3874
9344c18f
AA
38752019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3876
3877 * MAINTAINERS: Update my email address.
3878
df07e2c7
AB
38792019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3880
3881 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3882 std::vector.
3883 (build_type_psymtabs_reader): Update for std::vector.
3884 (build_type_psymtab_dependencies): Likewise.
3885 * dwarf2read.h: Remove use of DEF_VEC_P.
3886 (typedef sig_type_ptr): Delete.
3887
554ac434
AB
38882019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3889
3890 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3891 to std::vector.
3892 (btrace_maint_decode_pt): Likewise, and move allocation of the
3893 vector outside of the loop.
3894 (btrace_maint_update_packets): Update to handle change from VEC to
3895 std::vector.
3896 (btrace_maint_print_packets): Likewise.
3897 (maint_info_btrace_cmd): Likewise.
3898 * btrace.h: Remove use of DEF_VEC_O.
3899 (typedef btrace_pt_packet_s): Delete.
3900 (struct btrace_maint_info) <packets>: Change fromm VEC to
3901 std::vector.
3902 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3903
46f29a9a
AB
39042019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3905
3906 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3907 make accesses into the vector constant references.
3908 (btrace_add_pc): Update for std::vector.
3909 (btrace_stitch_bts): Likewise.
3910 (parse_xml_btrace_block): Likewise.
3911 (btrace_maint_update_packets): Likewise.
3912 (btrace_maint_print_packets): Likewise.
3913 (maint_info_btrace_cmd): Likewise.
3914 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3915 std::vector.
3916 (btrace_data::empty): Likewise.
3917 (btrace_data_append): Likewise.
3918 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3919 (typedef btrace_block_s): Delete.
3920 (struct btrace_block): Add constructor.
3921 (struct btrace_data_bts) <blocks>: Change to std::vector.
3922 * nat/linux-btrace.c (perf_event_read_bts): Update for
3923 std::vector.
3924 (linux_read_bts): Likewise.
3925
d770d56f
TT
39262019-10-01 Tom Tromey <tom@tromey.com>
3927
3928 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3929
9d636d67
TT
39302019-10-01 Tom Tromey <tom@tromey.com>
3931
3932 * stack.c (print_frame, info_frame_command_core): Use
3933 styled_string.
3934 * linux-thread-db.c (try_thread_db_load_1)
3935 (try_thread_db_load_from_pdir_1): Use styled_string.
3936 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3937 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3938 (maybe_print_unsupported_script_warning)
3939 (maybe_print_script_not_found_warning): Use styled_string.
3940 * ada-lang.c (user_select_syms): Use styled_string.
3941
7f6aba03
TT
39422019-10-01 Tom Tromey <tom@tromey.com>
3943
3944 * p-lang.c (pascal_printstr): Use metadata style.
3945 * value.c (show_convenience): Use metadata style.
3946 * valprint.c (valprint_check_validity, val_print_optimized_out)
3947 (val_print_not_saved, val_print_unavailable)
3948 (val_print_invalid_address, generic_val_print, val_print)
3949 (value_check_printable, val_print_array_elements): Use metadata
3950 style.
3951 * ui-out.h (class ui_out) <field_fmt>: New overload.
3952 <do_field_fmt>: Add style parameter.
3953 * ui-out.c (ui_out::field_fmt): New overload.
3954 * typeprint.c (type_print_unknown_return_type)
3955 (val_print_not_allocated, val_print_not_associated): Use metadata
3956 style.
3957 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3958 parameter.
3959 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3960 * tracepoint.c (tvariables_info_1): Use metadata style.
3961 * stack.c (print_frame_arg, print_frame_info, print_frame)
3962 (info_frame_command_core): Use metadata style.
3963 * skip.c (info_skip_command): Use metadata style.
3964 * rust-lang.c (rust_print_enum): Use metadata style.
3965 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3966 metadata style.
3967 * python/py-framefilter.c (py_print_single_arg): Use metadata
3968 style.
3969 * printcmd.c (do_one_display, print_variable_and_value): Use
3970 metadata style.
3971 * p-valprint.c (pascal_val_print)
3972 (pascal_object_print_value_fields): Use metadata style.
3973 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3974 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3975 parameter.
3976 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3977 * m2-valprint.c (m2_print_long_set): Use metadata style.
3978 * m2-typeprint.c (m2_print_type): Use metadata style.
3979 * infcmd.c (print_return_value_1): Use metadata style.
3980 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3981 * f-valprint.c (info_common_command_for_block): Use metadata
3982 style.
3983 * f-typeprint.c (f_type_print_base): Use metadata style.
3984 * expprint.c (print_subexp_standard): Use metadata style.
3985 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3986 * cli/cli-style.h (class cli_style_option): Add constructor.
3987 (metadata_style): Declare.
3988 * cli/cli-style.c (metadata_style): New global.
3989 (_initialize_cli_style): Register metadata style.
3990 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3991 parameter.
3992 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3993 * c-typeprint.c (c_type_print_base_struct_union)
3994 (c_type_print_base_1): Use metadata style.
3995 * breakpoint.c (watchpoint_value_print)
3996 (print_one_breakpoint_location): Use metadata style.
3997 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3998 style.
3999 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
4000 style.
4001 * ada-valprint.c (val_print_packed_array_elements, printstr)
4002 (print_field_values, ada_val_print_ref, ada_val_print): Use
4003 metadata style.
4004 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
4005 style.
4006 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
4007 style.
4008 * ada-lang.c (user_select_syms): Use metadata style.
4009
14309bb6
TT
40102019-10-01 Tom Tromey <tom@tromey.com>
4011
4012 * cli/cli-cmds.c (pwd_command): Style output.
4013
6a831f06
PA
40142019-10-01 Pedro Alves <palves@redhat.com>
4015 Tom Tromey <tom@tromey.com>
4016
4017 * symtab.c (print_symbol_info): Use %ps.
4018 (print_msymbol_info): Use %ps.
4019 * symfile.c (symbol_file_add_with_addrs): Use %ps.
4020 * printcmd.c (print_variable_and_value): Use %ps.
4021 * macrocmd.c (show_pp_source_pos): Use %ps.
4022 * infrun.c (print_exited_reason): Use ui_out::message.
4023 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4024 (describe_other_breakpoints): Use ui_out::message and new
4025 formats.
4026 (say_where): Use new formats.
4027 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4028 and new formats.
4029
2a3c1174
PA
40302019-10-01 Pedro Alves <palves@redhat.com>
4031 Tom Tromey <tom@tromey.com>
4032
4033 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4034 (test_gdb_formats): New function.
4035 (run_tests): Call it.
4036 (test_format_specifier): Update.
4037 * utils.h (fputs_filtered): Update comment.
4038 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4039 (fputs_styled_unfiltered): Declare.
4040 * utils.c (fputs_styled_unfiltered): New function.
4041 (vfprintf_maybe_filtered): Add gdbfmt parameter.
4042 (vfprintf_filtered): Update.
4043 (vfprintf_unfiltered, vprintf_filtered): Update.
4044 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4045 * ui-out.h (enum ui_out_flag) <unfiltered_output,
4046 disallow_ui_out_field>: New constants.
4047 (enum class field_kind): New.
4048 (struct base_field_s, struct signed_field_s): New.
4049 (signed_field): New function.
4050 (struct string_field_s): New.
4051 (string_field): New function.
4052 (struct styled_string_s): New.
4053 (styled_string): New function.
4054 (class ui_out) <message>: Add comment.
4055 <vmessage, call_do_message>: New methods.
4056 <do_message>: Add style parameter.
4057 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4058 methods.
4059 (ui_out::message): Rewrite.
4060 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4061 parameter.
4062 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4063 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4064 gdb_extensions parameter.
4065 (class format_piece): Add parameter to constructor.
4066 (n_int_args): New field.
4067 * gdbsupport/format.c (format_pieces::format_pieces): Add
4068 gdb_extensions parameter. Handle '*'.
4069 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4070 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
4071 vfprintf_styled_no_gdbfmt.
4072 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4073 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4074 unfiltered output.
4075 * ui-style.h (struct ui_file_style) <ptr>: New method.
4076
0dfe5bfb
TT
40772019-10-01 Tom Tromey <tom@tromey.com>
4078
4079 * unittests/format_pieces-selftests.c: Update. Add final format.
4080 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4081 empty literal pieces.
4082
e43b10e1
TT
40832019-10-01 Tom Tromey <tom@tromey.com>
4084
4085 * ui-out.h (enum class ui_out_style_kind): Remove.
4086 (class ui_out) <field_string, field_stsream, do_field_string>:
4087 Change type of "style".
4088 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4089 (ui_out::field_string): Update.
4090 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4091 of "style".
4092 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4093 * tracepoint.c (print_one_static_tracepoint_marker): Update.
4094 * stack.c (print_frame_arg, print_frame_info, print_frame):
4095 Update.
4096 * source.c (print_source_lines_base): Update.
4097 * solib.c (info_sharedlibrary_command): Update.
4098 * skip.c (info_skip_command): Update.
4099 * record-btrace.c (btrace_call_history_src_line)
4100 (btrace_call_history): Update.
4101 * python/py-framefilter.c (py_print_frame): Update.
4102 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4103 "style".
4104 * mi/mi-out.c (mi_ui_out::do_table_header)
4105 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4106 (mi_ui_out::do_field_string): Update.
4107 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4108 Update.
4109 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4110 "style".
4111 * cli-out.c (cli_ui_out::do_table_header)
4112 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4113 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4114 (cli_ui_out::do_field_fmt): Update.
4115 * breakpoint.c (print_breakpoint_location): Update.
4116 (update_static_tracepoint): Update.
4117
cd7c32c3
PW
41182019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4119
4120 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4121 conversion of gdb_datadir.
4122 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4123 remove not needed c_str ().
4124
8fe0f950
AT
41252019-09-30 Ali Tamur <tamur@google.com>
4126
4127 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4128 (dwarf2_string_attr): Likewise.
4129
5f48f8f3
AT
41302019-09-30 Ali Tamur <tamur@google.com>
4131
4132 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4133 (process_full_type_unit): Likewise.
4134 (dump_die_shallow): Likewise.
4135 (cu_debug_loc_section): Likewise.
4136
6fb08628
CB
41372019-09-28 Christian Biesinger <cbiesinger@google.com>
4138
4139 * minsyms.c (compare_minimal_symbols): Rename to...
4140 (minimal_symbol_is_less_than): ...this, and adjust to STL
4141 conventions (return bool, take arguments as references)
4142 (minimal_symbol_reader::install): Call std::sort instead
4143 of qsort.
4144
c7ee338a
CB
41452019-09-29 Christian Biesinger <cbiesinger@google.com>
4146
4147 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4148 hash and why.
4149 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4150 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4151
703a86c2
SM
41522019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4153
4154 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4155 * psympriv.h (add_psymbol_to_list): Move comment here and update
4156 it.
4157
0df0352a
TV
41582019-09-29 Tom de Vries <tdevries@suse.de>
4159
4160 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4161 Use $tmpdir/$(basename "$output_file").dwz instead of
4162 "${output_file}.dwz".
4163
ad75efa6
SM
41642019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4165
4166 PR gdb/25045
4167 * hppa-linux-nat.c: Include gdbarch.h.
4168
ececd218
CB
41692019-09-26 Christian Biesinger <cbiesinger@google.com>
4170
4171 * blockframe.c (find_pc_partial_function): Change return type to bool.
4172 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4173 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4174 (stub_gnu_ifunc_resolve_name): Likewise.
4175 * symtab.c (compare_filenames_for_search): Likewise.
4176 (compare_glob_filenames_for_search): Likewise.
4177 (matching_obj_sections): Likewise.
4178 (symbol_matches_domain): Likewise.
4179 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4180 (find_line_pc): Change return type to bool.
4181 (find_line_pc_range): Likewise.
4182 (producer_is_realview): Likewise.
4183 * symtab.h (symbol_matches_domain): Likewise.
4184 (find_pc_partial_function): Likewise.
4185 (find_pc_line_pc_range): Likewise.
4186 (in_gnu_ifunc_stub): Likewise.
4187 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4188 (find_line_pc): Likewise.
4189 (find_line_pc_range): Likewise.
4190 (matching_obj_sections): Likewise.
4191 (find_line_symtab): Change out parameter to bool.
4192 (producer_is_realview): Change return type to bool.
4193 (compare_filenames_for_search): Likewise.
4194 (compare_glob_filenames_for_search): Likewise.
4195
27a900b8
TT
41962019-09-26 Tom Tromey <tom@tromey.com>
4197
4198 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4199 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4200 * gdb_usleep.h: Remove.
4201 * gdb_usleep.c: Remove.
4202 * utils.c: Don't include gdb_usleep.h.
4203
5d63b30a
TT
42042019-09-26 Tom Tromey <tromey@adacore.com>
4205
4206 * python/py-type.c (type_to_type_object): Call check_typedef
4207 for stub types.
4208
12904d37
TT
42092019-09-26 Tom Tromey <tom@tromey.com>
4210
4211 * utils.h (initialize_utils): Don't declare.
4212 * top.c (gdb_init): Don't call initialize_utils.
4213 * utils.c (initialize_utils): Remove. Move contents...
4214 (_initialize_utils): ... here.
4215
858f25f0
TT
42162019-09-25 Tom Tromey <tom@tromey.com>
4217
4218 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4219 * utils.h (make_hex_string): Don't declare.
4220 * utils.c (make_hex_string): Remove.
4221
3d435220
TV
42222019-09-24 Tom de Vries <tdevries@suse.de>
4223
4224 PR gdb/23815
4225 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4226 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4227
ddd44b70
DD
42282019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4229
4230 * NEWS: Mention new simulator port for PRU.
4231
f945dedf
CB
42322019-09-23 Christian Biesinger <cbiesinger@google.com>
4233
4234 * ada-exp.y (write_object_remaining): Update.
4235 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4236 and eliminate the static buffer.
4237 (ada_decode_symbol): Update.
4238 (ada_la_decode): Update.
4239 (ada_sniff_from_mangled_name): Update.
4240 (is_valid_name_for_wild_match): Update.
4241 (ada_lookup_name_info::matches): Update and simplify.
4242 (name_matches_regex): Update.
4243 (ada_add_global_exceptions): Update.
4244 * ada-lang.h (ada_decode): Update signature.
4245 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4246 * dwarf-index-write.c (debug_names::insert): Update.
4247
7ab78ccb
SM
42482019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4249
4250 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4251 formatting.
4252
9252448b
SM
42532019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4254
4255 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4256 Change "nonzero" to "true" in documentation.
4257
626ca2c0
CB
42582019-09-20 Christian Biesinger <cbiesinger@google.com>
4259
4260 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4261 (_initialize_darwin_solib): Don't set
4262 darwin_so_ops.lookup_lib_global_symbol.
4263 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4264 set_gdbarch_iterate_over_objfiles_in_search_order.
4265 (elf_lookup_lib_symbol): Rename to...
4266 (svr4_iterate_over_objfiles_in_search_order): this, and update
4267 to iterate semantics.
4268 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4269 * solib.c (solib_global_lookup): Remove.
4270 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4271 (solib_global_lookup): Remove.
4272 * symtab.c (lookup_global_or_static_symbol): Remove call to
4273 solib_global_lookup.
4274
5a3a0d63
JB
42752019-09-20 Joel Brobecker <brobecker@adacore.com>
4276
4277 * NEWS: Move entries about default MI version now being
4278 version 3, and about the GDB/MI fix for multi-location
4279 breakpoints to the "since GDB 8.3" section.
4280
ffea1427
JB
42812019-09-20 Joel Brobecker <brobecker@adacore.com>
4282
4283 GDB 8.3.1 released.
4284
abf516c6
UW
42852019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4286
4287 * NEWS: Mention that Cell/B.E. debugging support was removed.
4288 * MAINTAINERS: Remove spu target.
4289
4290 * config/djgpp/fnchange.lst: Remove entries for removed files.
4291
4292 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4293 spu-multiarch.o, and spu-tdep.o.
4294 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4295 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4296 spu-multiarch.c, and spu-tdep.c.
4297 * spu-linux-nat.c: Remove file.
4298 * spu-multiarch.c: Remove file.
4299 * spu-tdep.c: Remove file.
4300 * spu-tdep.h: Remove file.
4301 * solib-spu.c: Remove file.
4302 * solib-spu.h: Remove file.
4303
4304 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4305 * configure.nat (spu-linux): Remove.
4306 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4307 solib-multiarch.o from gdb_target_obs.
4308 (spu*-*-*): Remove.
4309
4310 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4311 feature flag.
4312 (ppc_linux_no_features): Update.
4313 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4314 Cell/B.E. support.
4315 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4316 (tdesc_powerpc_cell64l): Likewise.
4317 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4318 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4319 Cell/B.E. support.
4320 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4321 Do not include "features/rs6000/powerpc-cell32l.c" or
4322 "features/rs6000/powerpc-cell64l.c".
4323 (ppc_linux_spu_section): Remove.
4324 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4325 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4326 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4327 (ppc_linux_spe_context_lookup): Remove.
4328 (ppc_linux_spe_context_inferior_created): Remove.
4329 (ppc_linux_spe_context_solib_loaded): Remove.
4330 (ppc_linux_spe_context_solib_unloaded): Remove.
4331 (ppc_linux_spe_context): Remove.
4332 (struct ppu2spu_cache): Remove.
4333 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4334 (struct ppu2spu_data): Remove.
4335 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4336 ppu2spu_unwind): Remove.
4337 (ppc_linux_init_abi): Remove Cell/B.E. support.
4338 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4339
4340 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4341 (rs6000/powerpc-cell64l-expedite): Likewise
4342 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4343 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4344 rs6000/powerpc-cell64l.xml.
4345 * features/rs6000/powerpc-cell32l.xml: Remove.
4346 * features/rs6000/powerpc-cell64l.xml: Likewise.
4347 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4348 * features/rs6000/powerpc-cell64l.c: Likewise.
4349 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4350 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4351 * regformats/reg-spu.dat: Remove.
4352
4353 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4354 * corelow.c (struct spuid_list): Remove.
4355 (add_to_spuid_list): Remove.
4356 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4357 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4358 (remote_protocol_features): Remove associated entries.
4359 (_initialize_remote): No longer initialize them.
4360 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4361 * linux-nat.c (SPUFS_MAGIC): Remove.
4362 (linux_proc_xfer_spu): Remove.
4363 (spu_enumerate_spu_ids): Remove.
4364 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4365 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4366 (linux_make_corefile_notes): No longer call it.
4367
4368 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4369 (cooked_write_test): Likewise.
4370
78e8cb91
TT
43712019-09-20 Tom Tromey <tom@tromey.com>
4372
4373 * NEWS: Mention case-sensitivity of TUI commands.
4374 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4375 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4376 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4377
f074b67e
TT
43782019-09-20 Tom Tromey <tom@tromey.com>
4379
4380 * tui/tui-source.c (tui_source_window::set_contents): Use
4381 make_unique_xstrdup.
4382 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4383 make_unique_xstrdup.
4384
63c4bf19
TT
43852019-09-20 Tom Tromey <tom@tromey.com>
4386
4387 * tui/tui-data.c: Remove separator comments.
4388 * tui/tui-layout.c: Remove separator comments.
4389 * tui/tui-win.c: Remove separator comments.
4390 * tui/tui-wingeneral.c: Remove separator comments.
4391
43df9b2f
TT
43922019-09-20 Tom Tromey <tom@tromey.com>
4393
4394 * tui/tui.h (strcat_to_buf): Don't declare.
4395 * tui/tui.c (strcat_to_buf): Remove.
4396
7226433c
TT
43972019-09-20 Tom Tromey <tom@tromey.com>
4398
4399 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4400 from "fullname".
4401 * tui/tui-source.c (tui_source_window::set_contents)
4402 (tui_source_window::location_matches_p)
4403 (tui_source_window::maybe_update): Update.
4404
80df3337
TT
44052019-09-20 Tom Tromey <tom@tromey.com>
4406
4407 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4408 Update.
4409 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4410 prefix.
4411 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4412 (tui_data_window::line_from_reg_element_no)
4413 (tui_data_window::first_reg_element_no_inline)
4414 (tui_data_window::show_registers)
4415 (tui_data_window::show_register_group)
4416 (tui_data_window::display_registers_from)
4417 (tui_data_window::display_registers_from_line)
4418 (tui_data_window::first_data_item_displayed)
4419 (tui_data_window::delete_data_content_windows)
4420 (tui_data_window::erase_data_content)
4421 (tui_data_window::do_scroll_vertical)
4422 (tui_data_window::refresh_window)
4423 (tui_data_window::check_register_values): Update.
4424
9923f347
TT
44252019-09-20 Tom Tromey <tom@tromey.com>
4426
4427 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4428 (struct tui_locator_window) <full_name, proc_name>: Now
4429 std::string.
4430 * tui/tui-stack.c (tui_locator_window::make_status_line)
4431 (tui_locator_window::set_locator_fullname)
4432 (tui_locator_window::set_locator_info): Update.
4433 * tui/tui-source.c (tui_source_window::set_contents)
4434 (tui_source_window::showing_source_p): Update.
4435
b76251ab
TT
44362019-09-20 Tom Tromey <tom@tromey.com>
4437
4438 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4439 Don't call tui_locator_win_info_ptr.
4440
0891be08
TT
44412019-09-20 Tom Tromey <tom@tromey.com>
4442
4443 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4444
1b935acf
TT
44452019-09-20 Tom Tromey <tom@tromey.com>
4446
4447 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4448 height for locator.
4449 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4450 * tui/tui-layout.c (show_source_disasm_command, show_data)
4451 (show_source_or_disasm_and_command): Use 1 as height for locator.
4452
9abd8a65
TT
44532019-09-20 Tom Tromey <tom@tromey.com>
4454
4455 * tui/tui.c (tui_enable): Update.
4456 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4457 Update.
4458 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4459 Update.
4460 * tui/tui-data.c (win_resized): Now bool.
4461 (tui_win_resized): Return bool.
4462 (tui_set_win_resized_to): Accept a bool.
4463
b5457826
TT
44642019-09-20 Tom Tromey <tom@tromey.com>
4465
4466 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4467 Change type of "refresh_values_only".
4468 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4469 type of "refresh_values_only".
4470
6b915f7d
TT
44712019-09-20 Tom Tromey <tom@tromey.com>
4472
4473 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4474 std::string.
4475 (tui_disassemble): Add "pos" parameter.
4476 (tui_disasm_window::set_contents): Simplify.
4477
2ad52f6f
TT
44782019-09-20 Tom Tromey <tom@tromey.com>
4479
4480 * tui/tui-winsource.h (struct tui_source_window_base)
4481 <show_source_content>: Now private.
4482 * tui/tui-winsource.c
4483 (tui_source_window_base::show_source_content): Don't handle empty
4484 content case.
4485
b3b1bde6
TT
44862019-09-20 Tom Tromey <tom@tromey.com>
4487
4488 * tui/tui-layout.c (show_source_disasm_command)
4489 (show_source_or_disasm_and_command): Don't call
4490 show_source_content.
4491
71a25ed2
TT
44922019-09-20 Tom Tromey <tom@tromey.com>
4493
4494 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4495 Declare.
4496 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4497 from tui_make_status_line.
4498 (tui_locator_window::rerender): Update.
4499
f8532154
TT
45002019-09-20 Tom Tromey <tom@tromey.com>
4501
4502 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4503 (tui_locator_window::rerender): Update.
4504
2d81b349
TT
45052019-09-20 Tom Tromey <tom@tromey.com>
4506
4507 * tui/tui-winsource.h (struct tui_source_window_base)
4508 <~tui_source_window_base>: Don't declare.
4509 <fullname>: Remove.
4510 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4511 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4512 member.
4513 * tui/tui-source.c (tui_source_window::set_contents): Update.
4514 (tui_source_window::location_matches_p)
4515 (tui_source_window::maybe_update): Update.
4516
f14bec58
TT
45172019-09-20 Tom Tromey <tom@tromey.com>
4518
4519 * tui/tui-winsource.h (~tui_source_element): Remove.
4520 (tui_source_element): Update.
4521 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4522 * tui/tui-winsource.c (tui_show_source_line): Update.
4523 * tui/tui-source.c (tui_source_window::set_contents): Update.
4524 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4525
78d5933a
TT
45262019-09-20 Tom Tromey <tom@tromey.com>
4527
4528 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4529 declare.
4530 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4531 tui_clear_source_windows_detail.
4532 * tui/tui-winsource.h (struct tui_source_window_base)
4533 <clear_detail>: Don't declare.
4534 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4535 Remove.
4536 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4537
d4207696
TT
45382019-09-20 Tom Tromey <tromey@adacore.com>
4539
4540 PR ada/24919:
4541 * block.c (contained_in): Fix final return value.
4542
00f93c44
AM
45432019-09-20 Alan Modra <amodra@gmail.com>
4544
4545 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4546 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4547 (read_indirect_string_from_dwz): Use bfd accessor.
4548 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4549 * machoread.c (macho_symfile_read_all_oso): Likewise.
4550 * solib.c (solib_bfd_open): Likewise.
4551
e4153ae6
CB
45522019-09-19 Christian Biesinger <cbiesinger@google.com>
4553
4554 * eval.c: Move declaration of overload_resolution to...
4555 * value.h: ...here.
4556
c7ae7675
CB
45572019-09-19 Christian Biesinger <cbiesinger@google.com>
4558
4559 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4560 * arm-linux-tdep.c: Likewise.
4561 * arm-nbsd-nat.c: Likewise.
4562 * arm-tdep.h: Declare arm_apcs_32.
4563 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4564
e86f08d2
CB
45652019-09-19 Christian Biesinger <cbiesinger@google.com>
4566
4567 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4568 * dwarf2read.h: Declare dwarf_always_disassemble.
4569
f64e2f40
TV
45702019-09-19 Tom de Vries <tdevries@suse.de>
4571
4572 PR gdb/25009
4573 * source-cache.c (source_cache::ensure): Catch exception thrown during
4574 construction of the highlighter.
4575
fd361982
AM
45762019-09-18 Alan Modra <amodra@gmail.com>
4577
4578 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4579 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4580 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4581 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4582 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4583 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4584 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4585 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4586 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4587 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4588 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4589 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4590 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4591 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4592 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4593 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4594 * mi/mi-interp.c: Update throughout for bfd section macro and
4595 function changes.
4596 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4597 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4598
11061048
TT
45992019-09-18 Tom Tromey <tom@tromey.com>
4600
4601 * NEWS: Add entry.
4602 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4603 call rl_initialize.
4604 (tui_enable): Do not call rl_initialize.
4605
7a27b85f
CG
46062019-09-18 Christian Groessler <chris@groessler.org>
4607
4608 * alpha-linux-nat.c: Include gdbarch.h.
4609
f64eea3a
SM
46102019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4611
4612 * ui-file.c: Include cli/cli-style.h.
4613 (term_cli_styling): Remove cli_styling declaration.
4614
e6f7f6d1
AM
46152019-09-18 Alan Modra <amodra@gmail.com>
4616
4617 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4618 to bfd_asymbol_section.
4619
1d38e9d1
AM
46202019-09-18 Alan Modra <amodra@gmail.com>
4621
4622 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4623 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4624 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4625
90d92a63
AM
46262019-09-18 Alan Modra <amodra@gmail.com>
4627
4628 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4629 * spu-linux-nat.c (spu_bfd_open): Likewise.
4630
a3d181d2
CB
46312019-09-18 Christian Biesinger <cbiesinger@google.com>
4632
4633 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4634 to bool to match definition in dwarf2read.c.
4635
491144b5
CB
46362019-09-17 Christian Biesinger <cbiesinger@google.com>
4637
4638 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4639 (print_signatures): Likewise.
4640 (trust_pad_over_xvs): Likewise.
4641 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4642 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4643 * arm-linux-nat.c (arm_apcs_32): Likewise.
4644 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4645 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4646 * arm-tdep.c (arm_debug): Likewise.
4647 (arm_apcs_32): Likewise.
4648 * auto-load.c (debug_auto_load): Likewise.
4649 (auto_load_gdb_scripts): Likewise.
4650 (global_auto_load): Likewise.
4651 (auto_load_local_gdbinit): Likewise.
4652 (auto_load_local_gdbinit_loaded): Likewise.
4653 * auto-load.h (global_auto_load): Likewise.
4654 (auto_load_local_gdbinit): Likewise.
4655 (auto_load_local_gdbinit_loaded): Likewise.
4656 * breakpoint.c (disconnected_dprintf): Likewise.
4657 (breakpoint_proceeded): Likewise.
4658 (automatic_hardware_breakpoints): Likewise.
4659 (always_inserted_mode): Likewise.
4660 (target_exact_watchpoints): Likewise.
4661 (_initialize_breakpoint): Update.
4662 * breakpoint.h (target_exact_watchpoints): Change to bool.
4663 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4664 * cli/cli-cmds.c (trace_commands): Likewise.
4665 * cli/cli-cmds.h (trace_commands): Likewise.
4666 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4667 to bool*.
4668 * cli/cli-logging.c (logging_overwrite): Change to bool.
4669 (logging_redirect): Likewise.
4670 (debug_redirect): Likewise.
4671 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4672 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4673 to bool.
4674 <boolean_option_def>: Update.
4675 (struct flag_option_def): Change default type of Context to bool
4676 from int.
4677 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4678 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4679 (get_setshow_command_value_string): Likewise.
4680 * cli/cli-style.c (cli_styling): Change to bool.
4681 (source_styling): Likewise.
4682 * cli/cli-style.h (source_styling): Likewise.
4683 (cli_styling): Likewise.
4684 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4685 to bool.
4686 * command.h (var_types): Update comment.
4687 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4688 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4689 bool.
4690 (debug_compile_cplus_scopes): Likewise.
4691 * compile/compile-internal.h (compile_debug): Likewise.
4692 * compile/compile.c (compile_debug): Likewise.
4693 (struct compile_options) <raw>: Likewise.
4694 * cp-support.c (catch_demangler_crashes): Likewise.
4695 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4696 (usr_cmd_cris_dwarf2_cfi): Likewise.
4697 * csky-tdep.c (csky_debug): Likewise.
4698 * darwin-nat.c (enable_mach_exceptions): Likewise.
4699 * dcache.c (dcache_enabled_p): Likewise.
4700 * defs.h (info_verbose): Likewise.
4701 * demangle.c (demangle): Likewise.
4702 (asm_demangle): Likewise.
4703 * dwarf-index-cache.c (debug_index_cache): Likewise.
4704 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4705 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4706 * dwarf2read.c (check_physname): Likewise.
4707 (use_deprecated_index_sections): Likewise.
4708 (dwarf_always_disassemble): Likewise.
4709 * eval.c (overload_resolution): Likewise.
4710 * event-top.c (set_editing_cmd_var): Likewise.
4711 (exec_done_display_p): Likewise.
4712 * event-top.h (set_editing_cmd_var): Likewise.
4713 (exec_done_display_p): Likewise.
4714 * exec.c (write_files): Likewise.
4715 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4716 (debug_fbsd_nat): Likewise.
4717 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4718 Likewise.
4719 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4720 <backtrace_past_entry> Likewise.
4721 * gdb-demangle.h (demangle): Likewise.
4722 (asm_demangle): Likewise.
4723 * gdb_bfd.c (bfd_sharing): Likewise.
4724 * gdbcore.h (write_files): Likewise.
4725 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4726 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4727 * gdbthread.h (print_thread_events): Likewise.
4728 * gdbtypes.c (opaque_type_resolution): Likewise.
4729 (strict_type_checking): Likewise.
4730 * gnu-nat.c (gnu_debug_flag): Likewise.
4731 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4732 * guile/scm-param.c (pascm_variable): Add boolval.
4733 (add_setshow_generic): Update.
4734 (pascm_param_value): Update.
4735 (pascm_set_param_value_x): Update.
4736 * hppa-tdep.c (hppa_debug): Change to bool..
4737 * infcall.c (may_call_functions_p): Likewise.
4738 (coerce_float_to_double_p): Likewise.
4739 (unwind_on_signal_p): Likewise.
4740 (unwind_on_terminating_exception_p): Likewise.
4741 * infcmd.c (startup_with_shell): Likewise.
4742 * inferior.c (print_inferior_events): Likewise.
4743 * inferior.h (startup_with_shell): Likewise.
4744 (print_inferior_events): Likewise.
4745 * infrun.c (step_stop_if_no_debug): Likewise.
4746 (detach_fork): Likewise.
4747 (debug_displaced): Likewise.
4748 (disable_randomization): Likewise.
4749 (non_stop): Likewise.
4750 (non_stop_1): Likewise.
4751 (observer_mode): Likewise.
4752 (observer_mode_1): Likewise.
4753 (set_observer_mode): Update.
4754 (sched_multi): Change to bool.
4755 * infrun.h (debug_displaced): Likewise.
4756 (sched_multi): Likewise.
4757 (step_stop_if_no_debug): Likewise.
4758 (non_stop): Likewise.
4759 (disable_randomization): Likewise.
4760 * linux-tdep.c (use_coredump_filter): Likewise.
4761 (dump_excluded_mappings): Likewise.
4762 * linux-thread-db.c (auto_load_thread_db): Likewise.
4763 (check_thread_db_on_load): Likewise.
4764 * main.c (captured_main_1): Update.
4765 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4766 xx2_opt, boolean_opt>: Change to bool.
4767 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4768 * maint.c (maintenance_profile_p): Likewise.
4769 (per_command_time): Likewise.
4770 (per_command_space): Likewise.
4771 (per_command_symtab): Likewise.
4772 * memattr.c (inaccessible_by_default): Likewise.
4773 * mi/mi-main.c (mi_async): Likewise.
4774 (mi_async_1): Likewise.
4775 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4776 * nat/fork-inferior.h (startup_with_shell): Likewise.
4777 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4778 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4779 * nios2-tdep.c (nios2_debug): Likewise.
4780 * or1k-tdep.c (or1k_debug): Likewise.
4781 * parse.c (parser_debug): Likewise.
4782 * parser-defs.h (parser_debug): Likewise.
4783 * printcmd.c (print_symbol_filename): Likewise.
4784 * proc-api.c (procfs_trace): Likewise.
4785 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4786 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4787 (set_parameter_value): Update.
4788 (add_setshow_generic): Update.
4789 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4790 to bool*.
4791 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4792 int*.
4793 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4794 * record-btrace.c (record_btrace_target::store_registers): Update.
4795 * record-full.c (record_full_memory_query): Change to bool.
4796 (record_full_stop_at_limit): Likewise.
4797 * record-full.h (record_full_memory_query): Likewise.
4798 * remote-notif.c (notif_debug): Likewise.
4799 * remote-notif.h (notif_debug): Likewise.
4800 * remote.c (use_range_stepping): Likewise.
4801 (interrupt_on_connect): Likewise.
4802 (remote_break): Likewise.
4803 * ser-tcp.c (tcp_auto_retry): Likewise.
4804 * ser-unix.c (serial_hwflow): Likewise.
4805 * skip.c (debug_skip): Likewise.
4806 * solib-aix.c (solib_aix_debug): Likewise.
4807 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4808 (spu_auto_flush_cache_p): Likewise.
4809 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4810 Likewise.
4811 (struct info_print_options) <quiet>: Likewise.
4812 * symfile-debug.c (debug_symfile): Likewise.
4813 * symfile.c (auto_solib_add): Likewise.
4814 (separate_debug_file_debug): Likewise.
4815 * symfile.h (auto_solib_add): Likewise.
4816 (separate_debug_file_debug): Likewise.
4817 * symtab.c (basenames_may_differ): Likewise.
4818 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4819 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4820 (struct info_types_options) <quiet>: Likewise.
4821 * symtab.h (demangle): Likewise.
4822 (basenames_may_differ): Likewise.
4823 * target-dcache.c (stack_cache_enabled_1): Likewise.
4824 (code_cache_enabled_1): Likewise.
4825 * target.c (trust_readonly): Likewise.
4826 (may_write_registers): Likewise.
4827 (may_write_memory): Likewise.
4828 (may_insert_breakpoints): Likewise.
4829 (may_insert_tracepoints): Likewise.
4830 (may_insert_fast_tracepoints): Likewise.
4831 (may_stop): Likewise.
4832 (auto_connect_native_target): Likewise.
4833 (target_stop_and_wait): Update.
4834 (target_async_permitted): Change to bool.
4835 (target_async_permitted_1): Likewise.
4836 (may_write_registers_1): Likewise.
4837 (may_write_memory_1): Likewise.
4838 (may_insert_breakpoints_1): Likewise.
4839 (may_insert_tracepoints_1): Likewise.
4840 (may_insert_fast_tracepoints_1): Likewise.
4841 (may_stop_1): Likewise.
4842 * target.h (target_async_permitted): Likewise.
4843 (may_write_registers): Likewise.
4844 (may_write_memory): Likewise.
4845 (may_insert_breakpoints): Likewise.
4846 (may_insert_tracepoints): Likewise.
4847 (may_insert_fast_tracepoints): Likewise.
4848 (may_stop): Likewise.
4849 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4850 (make_thread_apply_all_options_def_group): Change argument from int*
4851 to bool*.
4852 (thread_apply_all_command): Update.
4853 (print_thread_events): Change to bool.
4854 * top.c (confirm): Likewise.
4855 (command_editing_p): Likewise.
4856 (history_expansion_p): Likewise.
4857 (write_history_p): Likewise.
4858 (info_verbose): Likewise.
4859 * top.h (confirm): Likewise.
4860 (history_expansion_p): Likewise.
4861 * tracepoint.c (disconnected_tracing): Likewise.
4862 (circular_trace_buffer): Likewise.
4863 * typeprint.c (print_methods): Likewise.
4864 (print_typedefs): Likewise.
4865 * utils.c (debug_timestamp): Likewise.
4866 (sevenbit_strings): Likewise.
4867 (pagination_enabled): Likewise.
4868 * utils.h (sevenbit_strings): Likewise.
4869 (pagination_enabled): Likewise.
4870 * valops.c (overload_resolution): Likewise.
4871 * valprint.h (struct value_print_options) <prettyformat_arrays,
4872 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4873 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4874 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4875 Likewise.
4876 * windows-nat.c (new_console): Likewise.
4877 (cygwin_exceptions): Likewise.
4878 (new_group): Likewise.
4879 (debug_exec): Likewise.
4880 (debug_events): Likewise.
4881 (debug_memory): Likewise.
4882 (debug_exceptions): Likewise.
4883 (useshell): Likewise.
4884 * windows-tdep.c (maint_display_all_tib): Likewise.
4885 * xml-support.c (debug_xml): Likewise.
4886
f1b620e9
MG
48872019-09-17 Mike Gulick <mgulick@mathworks.com>
4888
4889 * source.c (prepare_path_for_appending): New function.
4890 (openp): Make use of new function.
4891 (find_and_open_source): Search for the compilation directory and
4892 source file as a relative path beneath the directory search path.
4893
67f3ed6a
AB
48942019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4895
4896 * source-cache.c (source_cache::get_line_charpos): Catch
4897 exceptions and return false, this matches the behaviour documented
4898 in the header file.
4899
74332189
JB
49002019-09-17 Joel Brobecker <brobecker@adacore.com>
4901
4902 * ada-tasks.c (info_task): Remove quoting of the task's name.
4903
f2f24aa9
CB
49042019-09-16 Christian Biesinger <cbiesinger@google.com>
4905
4906 * symfile.c (auto_solib_add): Replace comment with a reference
4907 to the header file.
4908
6a062a93
CB
49092019-09-14 Christian Biesinger <cbiesinger@google.com>
4910
4911 * NEWS: Mention that gdb can now be compiled with Python 3
4912 on Windows.
4913
ec6c8338
AB
49142019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4915
4916 * maint.c (maint_print_section_data::maint_print_section_data):
4917 Force use of 'float log10 (float)' by casting the argument to
4918 float.
4919
aa17805f
AB
49202019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4921
4922 * maint.c: Add 'cmath' include.
4923 (struct maint_print_section_data): New structure.
4924 (print_section_index): New function.
4925 (print_bfd_section_info): Add header comment, small whitespace
4926 cleanup, and update to call new print_section_index function.
4927 (print_objfile_section_info): Likewise.
4928 (maint_obj_section_from_bfd_section): New function.
4929 (print_bfd_section_info_maybe_relocated): New function.
4930 (maintenance_info_sections): Add header comment, always use
4931 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4932
3dd9bb46
AB
49332019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4934
4935 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4936 inner scope, add check that the objfile has psymtabs before
4937 checking psymtabs_addrmap.
4938 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4939
4993045d
PW
49402019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4941
4942 * NEWS: Announce that Ada task names are now shown at more places,
4943 and between quotes (except in info task output).
4944 * gdb/ada-tasks.c (task_to_str): New function.
4945 (display_current_task_id): Call task_to_str.
4946 (task_command_1): Likewise.
4947 (print_ada_task_info): In non-mi mode, Properly align headers and data
4948 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4949
7a289707
RO
49502019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4951
4952 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4953 prstatus.pr_lwp.pr_info instead of making it up.
4954
f2aec7f6
CB
49552019-09-11 Christian Biesinger <cbiesinger@google.com>
4956
4957 * auto-load.c (auto_load_expand_dir_vars): Update.
4958 * defs.h (gdb_datadir): Change to std::string.
4959 (python_libdir): Likewise.
4960 (relocate_gdb_directory): Change return type to std::string.
4961 * guile/guile.c (gdbscm_data_directory): Update.
4962 (initialize_scheme_side): Update.
4963 * jit.c (jit_reader_dir): Change to std::string.
4964 (jit_reader_load_command): Update.
4965 * main.c (gdb_datadir): Change to std::string.
4966 (python_libdir): Likewise.
4967 (set_gdb_data_directory): Update.
4968 (relocate_path): Change to return std::string.
4969 (relocate_gdb_directory): Change to return std::string.
4970 (relocate_gdbinit_path_maybe_in_datadir): Update.
4971 (captured_main_1): Update.
4972 * python/python.c (do_start_initialization): Update.
4973 * top.c (show_gdb_datadir): Update.
4974 * xml-syscall.c (xml_init_syscalls_info): Update.
4975 (init_syscalls_info): Update.
4976
9224a013
CB
49772019-09-11 Christian Biesinger <cbiesinger@google.com>
4978
4979 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4980 out of get_init_files.
4981 (get_init_files): Update.
4982
f48cd836
CB
49832019-09-11 Christian Biesinger <cbiesinger@google.com>
4984
4985 * main.c (get_init_files): Change to use std::string.
4986 (captured_main_1): Update.
4987 (print_gdb_help): Update.
4988
9cab7ecd
AT
49892019-09-11 Ali Tamur <tamur@google.com>
4990
4991 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4992 implementation.
4993
67547d89
CB
49942019-09-11 Christian Biesinger <cbiesinger@google.com>
4995
4996 * dbxread.c (read_dbx_symtab): Update.
4997 * dwarf2read.c (load_partial_dies): Update.
4998 * mdebugread.c (parse_partial_symbols): Update.
4999 (handle_psymbol_enumerators): Update.
5000 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
5001 * psymtab.c (add_psymbol_to_bcache): Likewise.
5002 (add_psymbol_to_list): Likewise.
5003 * symtab.c (symbol_set_names): Likewise.
5004 * symtab.h (symbol_set_names): Likewise.
5005 * xcoffread.c (scan_xcoff_symtab): Update.
5006
64b2d4a0
TT
50072019-09-11 Tom Tromey <tom@tromey.com>
5008
5009 * symfile-mem.c (symbol_file_add_from_memory): Use
5010 bfd_set_filename.
5011 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5012 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5013
3b00ef10
TT
50142019-09-10 Tom Tromey <tromey@adacore.com>
5015
5016 * dwarf-index-write.c (write_psymbols): Extend error message.
5017 (debug_names::insert): Add Ada code.
5018 (debug_names::write_psymbols): Remove Ada check.
5019 (debug_names) <m_string_obstack>: New member.
5020 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5021 (gdb_index_symbol_name_matcher::matches): Remove.
5022 (mapped_index_base::find_name_components_bounds): Add "lang"
5023 parameter.
5024 (mapped_index_base::build_name_components): Also split names
5025 according to Ada syntax.
5026 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
5027 type of "match_callback".
5028 (check_match, check_find_bounds_finds)
5029 (dw2_expand_symtabs_matching): Update.
5030 (dw2_debug_names_iterator): Add new constructor.
5031 (dw2_debug_names_map_matching_symbols): New function.
5032 (dw2_debug_names_expand_symtabs_matching): Update.
5033 (dwarf2_debug_names_functions): Use
5034 dw2_debug_names_map_matching_symbols.
5035
aa391654
TT
50362019-09-10 Tom Tromey <tromey@adacore.com>
5037
5038 * dwarf2read.c (dw2_get_file_names_reader): Add the
5039 CU's file name to the results.
5040
b054970d
TT
50412019-09-10 Tom Tromey <tromey@adacore.com>
5042
5043 * ada-lang.c (add_nonlocal_symbols): Combine calls to
5044 map_matching_symbols. Update.
5045 * dwarf2read.c (dw2_map_matching_symbols): Update.
5046 * psymtab.c (match_partial_symbol): Change type; update.
5047 (psym_map_matching_symbols): Likewise.
5048 * symfile-debug.c (debug_qf_map_matching_symbols): Change
5049 type; update.
5050 * symfile.h (struct quick_symbol_functions)
5051 <map_matching_symbols>: Change "name" to be a lookup_name_info.
5052 Remove "match".
5053
6a3dbf1b
TT
50542019-09-10 Tom Tromey <tromey@adacore.com>
5055
5056 * psymtab.c (map_block): Remove.
5057 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5058 * symtab.c (iterate_over_symbols_terminated): New function.
5059 * symtab.c (iterate_over_symbols_terminated): Declare.
5060
6969f124
TT
50612019-09-10 Tom Tromey <tromey@adacore.com>
5062
5063 * ada-lang.c (ada_iterate_over_symbols): Return bool.
5064 * language.h (struct language_defn) <la_iterate_over_symbols>:
5065 Return bool.
5066 * symtab.c (iterate_over_symbols): Return bool.
5067 * symtab.h (iterate_over_symbols): Return bool.
5068
199b4314
TT
50692019-09-10 Tom Tromey <tromey@adacore.com>
5070
5071 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5072 (add_nonlocal_symbols): Update.
5073 * dwarf2read.c (dw2_map_matching_symbols): Change type.
5074 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5075 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5076 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5077 Change type of "callback". Remove "data".
5078
a084a2a6
AT
5079
50802019-09-09 Ali Tamur <tamur@google.com>
5081
5082 * dwarf2read.c (comp_unit_head): Update comment.
5083 (dwarf2_dwo_name): New function declaration.
5084 (dwarf_unit_type_name): New function declaration.
5085 (read_comp_unit_head): Add support for new compilation units,
5086 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5087 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5088 (currently named as "signature") in their header. Also clarify error
5089 messages.
5090 (lookup_dwo_id): New function. Returns the dwo id of the given
5091 compile unit.
5092 (lookup_dwo_unit): Use the new lookup_dwo_id function.
5093 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5094 functions.
5095 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5096 (dwarf2_dwo_name): Get the dwo name if present.
5097 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5098 purposes.
5099
25a2915e
TT
51002019-09-09 Tom Tromey <tom@tromey.com>
5101
5102 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5103
e4df0874
PW
51042019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5105
5106 * python/python.c (do_start_initialization): Make progname_copy static,
5107 to avoid a leak report.
5108
8634b462
TT
51092019-09-08 Tom Tromey <tom@tromey.com>
5110
5111 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5112
c7f839cb
SM
51132019-09-07 Simon Marchi <simon.marchi@efficios.com>
5114
5115 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5116 Change type to gdb::optional<block_enum>.
5117 (dw2_symtab_iter_init): Change block_index parameter type
5118 to gdb::optional<block_enum>.
5119 (dw2_lookup_symbol): Change block_index parameter
5120 type to block_enum.c
5121 (dw2_debug_names_lookup_symbol): Likewise.
5122 * psymtab.c (psym_lookup_symbol): Likewise.
5123 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5124 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5125 Likewise.
5126
ead0e69a
CB
51272019-09-06 Christian Biesinger <cbiesinger@google.com>
5128
5129 * defs.h (relocate_gdb_directory): Change int to bool in
5130 signature and rename flag to relocatable.
5131 * main.c (relocate_path): Likewise.
5132 (relocate_gdb_directory): Likewise.
5133
b16c44de
AM
51342019-09-06 Alan Modra <amodra@gmail.com>
5135
5136 * coffread.c (coff_symfile_read): Constify filename variable.
5137 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5138 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5139 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5140 * solib.c (reload_shared_libraries_1): Likewise.
5141 * symfile.c (reread_symbols): Likewise.
5142 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5143 * solib-darwin.c (darwin_bfd_open): Likewise.
5144 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5145
06ff036e
AB
51462019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5147
5148 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5149 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5150
4e962e74
TT
51512019-09-03 Tom Tromey <tromey@adacore.com>
5152
5153 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5154 types.
5155 (has_negatives): Unbias a range type bound.
5156 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5157 * gdbtypes.c (operator==): Handle new field.
5158 (create_range_type): Add "bias" parameter.
5159 (create_static_range_type, resolve_dynamic_range): Update.
5160 * gdbtypes.h (struct range_bounds) <bias>: New member.
5161 (create_range_type): Add bias parameter.
5162 * printcmd.c (print_scalar_formatted): Unbias range types.
5163 * value.c (unpack_long): Unbias range types.
5164 (pack_long): Bias range types.
5165
d90b8f26
AH
51662019-09-02 Alan Hayward <alan.hayward@arm.com>
5167
5168 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5169 probe arguments.
5170
fe01123e
AH
51712019-09-02 Alan Hayward <alan.hayward@arm.com>
5172
5173 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5174 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5175 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5176 (compile_probe_arg): Likewise.
5177 * probe.h (get_argument_count): Likewise.
5178 * solib-svr4.c (solib_event_probe_action): Likewise.
5179 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5180
e661ef01
AH
51812019-09-02 Alan Hayward <alan.hayward@arm.com>
5182
5183 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5184 code to here...
5185 (svr4_create_solib_event_breakpoints): ...from here.
5186
47a536d9
SDJ
51872019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5188
5189 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5190 suffix from warning message.
5191
d6a00eba
TT
51922019-08-30 Tom Tromey <tom@tromey.com>
5193
5194 * tui/tui-winsource.h (struct tui_source_window_base)
5195 <refresh_all>: Don't declare.
5196 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5197 Remove.
5198 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5199 tui_show_locator_content.
5200 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5201 declare.
5202 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5203 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5204 declare.
5205
55b2657b
TT
52062019-08-30 Tom Tromey <tom@tromey.com>
5207
5208 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5209
12a8555a
TT
52102019-08-30 Tom Tromey <tom@tromey.com>
5211
5212 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5213 Remove unnecessary forward declarations.
5214
900ac242
TT
52152019-08-30 Tom Tromey <tom@tromey.com>
5216
5217 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5218 rerender.
5219 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5220 tui_show_locator_content.
5221
99ab33fb
TT
52222019-08-30 Tom Tromey <tom@tromey.com>
5223
5224 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5225 (tui_locator_window::rerender): Rewrite using body of previous
5226 tui_show_locator_content.
5227
e594a5d1
TT
52282019-08-30 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5231 set_locator_fullname>: New methods.
5232 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5233 Rename from tui_set_locator_fullname.
5234 (tui_locator_window::set_locator_info): Rename from
5235 tui_set_locator_info. Return bool.
5236 (tui_update_locator_fullname, tui_show_frame_info): Update.
5237
715bb467
TT
52382019-08-30 Tom Tromey <tom@tromey.com>
5239
5240 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5241
772f3f03
TT
52422019-08-30 Tom Tromey <tom@tromey.com>
5243
5244 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5245 call touchwin.
5246
108e13ab
TT
52472019-08-30 Tom Tromey <tom@tromey.com>
5248
5249 * tui/tui-wingeneral.c (box_win): Assume win_info and
5250 win_info->handle cannot be NULL.
5251
cdaa6eb4
TT
52522019-08-30 Tom Tromey <tom@tromey.com>
5253
5254 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5255 refresh_window>: Declare.
5256 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5257 resize.
5258 (tui_data_item_window::rerender): Rename from
5259 tui_display_register.
5260 (tui_data_item_window::refresh_window): New method.
5261 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5262 no-op.
5263
89df7f90
TT
52642019-08-30 Tom Tromey <tom@tromey.com>
5265
5266 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5267 regs_column_count, current_group>: Move later. Now private.
5268 <get_current_group>: New method.
5269 * tui/tui-regs.c (tui_reg_command): Update.
5270 * tui/tui-layout.c (tui_set_layout): Update.
5271
1bf2866a
TT
52722019-08-30 Tom Tromey <tom@tromey.com>
5273
5274 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5275 (tui_data_window::rerender): Don't call
5276 check_and_display_highlight_if_needed.
5277 (tui_data_window::refresh_all): Remove call to
5278 erase_data_content.
5279
0670413d
TT
52802019-08-30 Tom Tromey <tom@tromey.com>
5281
5282 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5283 (tui_data_window::display_registers_from)
5284 (tui_data_window::display_reg_element_at_line)
5285 (tui_data_window::display_registers_from_line): Remove checks of
5286 "empty".
5287
18bb55c7
TT
52882019-08-30 Tom Tromey <tom@tromey.com>
5289
5290 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5291 Don't declare.
5292 * tui/tui-regs.c (tui_data_window::show_registers): Call
5293 rerender.
5294 (tui_data_window::rerender): Rename from display_all_data.
5295 (tui_data_window::rerender): Remove old implementation.
5296
1f6d2f10
TT
52972019-08-30 Tom Tromey <tom@tromey.com>
5298
5299 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5300 text.
5301 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5302
16d01f9c
BW
53032019-08-29 Bernhard Wodok <barto@gmx.net>
5304 Sergio Durigan Junior <sergiodj@redhat.com>
5305
5306 PR win32/24284
5307 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5308
d8f27c60
AB
53092019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5310
5311 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5312 when searching for types.
5313
1f20c35e
AB
53142019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5315
5316 * f-lang.c (f_language_defn): Use f_print_typedef.
5317 * f-lang.h (f_print_typedef): Declare.
5318 * f-typeprint.c (f_print_typedef): Define.
5319
550105b7
CB
53202019-08-27 Christian Biesinger <cbiesinger@google.com>
5321
5322 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5323
4acfdd20
AB
53242019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5325
5326 * cli/cli-utils.c (info_print_options_defs): Delete.
5327 (make_info_print_options_def_group): Delete.
5328 (extract_info_print_options): Delete.
5329 (info_print_command_completer): Delete.
5330 (info_print_args_help): Add extra parameter, and optionally
5331 include text about -n flag.
5332 * cli/cli-utils.h (struct info_print_options): Delete.
5333 (extract_info_print_options): Delete declaration.
5334 (info_print_command_completer): Delete declaration.
5335 (info_print_args_help): Add extra parameter, extend header
5336 comment.
5337 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5338 search_symbols.
5339 * stack.c (struct info_print_options): New type.
5340 (info_print_options_defs): New file scoped variable.
5341 (make_info_print_options_def_group): New static function.
5342 (info_print_command_completer): New static function.
5343 (info_locals_command): Update to use new local functions.
5344 (info_args_command): Likewise.
5345 (_initialize_stack): Add extra parameter to calls to
5346 info_print_args_help.
5347 * symtab.c (search_symbols): Add extra parameter, use this to
5348 possibly excluse non-debug symbols.
5349 (symtab_symbol_info): Add extra parameter, which is passed on to
5350 search_symbols.
5351 (struct info_print_options): New type.
5352 (info_print_options_defs): New file scoped variable.
5353 (make_info_print_options_def_group): New static function.
5354 (info_print_command_completer): New static function.
5355 (info_variables_command): Update to use local functions, and pass
5356 extra parameter through to symtab_symbol_info.
5357 (info_functions_command): Likewise.
5358 (info_types_command): Pass additional argument through to
5359 symtab_symbol_info.
5360 (rbreak_command): Pass extra argument to search_symbols.
5361 (_initialize_symtab): Add extra arguments for calls to
5362 info_print_args_help, and update help text for 'info variables',
5363 'whereis', and 'info functions' commands.
5364 * symtab.h (search_symbols): Add extra argument to declaration.
5365 * NEWS: Mention new flags.
5366
9aa55206
CB
53672019-08-26 Christian Biesinger <cbiesinger@google.com>
5368
5369 * symtab.c (lookup_static_symbol): Call the new function (and move
5370 it down to be next to lookup_global_symbol).
5371 (struct global_sym_lookup_data): Add block_enum member and rename to...
5372 (struct global_or_static_sym_lookup_data): ...this.
5373 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5374 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5375 (lookup_symbol_global_or_static_iterator_cb): ...this.
5376 (lookup_global_or_static_symbol): New function.
5377 (lookup_global_symbol): Call new function.
5378
5c31b358
TV
53792019-08-26 Tom de Vries <tdevries@suse.de>
5380
5381 PR c++/24852
5382 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5383 when pc_probe.prob == NULL.
5384
23c13d42
SM
53852019-08-25 Simon Marchi <simon.marchi@efficios.com>
5386
5387 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5388 variable symbol_linkage to symbol_linkage_.
5389
beadd3e8
SM
53902019-08-25 Simon Marchi <simon.marchi@efficios.com>
5391
5392 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5393 represent whether the symbol is static, dynamic, or we don't
5394 know.
5395
e3ec872f
YS
53962019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5397
5398 * gdb/rx-tdep.c (rx_register_names): New.
5399 (rx_register_name): Delete.
5400 (rx_psw_type): Delete.
5401 (rx_fpsw_type): Delete.
5402 (rx_register_type): Delete.
5403 (rx_gdbarch_init): Convert target-descriptions.
5404 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5405 * gdb/features/Makefile: Add rx.xml.
5406 * gdb/features/rx.xml: New.
5407 * gdb/features/rx.c: Generated.
5408 * gdb/NEWS: Mention target description support.
5409
d0509ba4
CB
54102019-08-22 Christian Biesinger <cbiesinger@google.com>
5411
5412 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5413 *slot_ptr.
5414
2d41fa11
SDJ
54152019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5416
5417 * configure.ac: Don't check for 'dlfcn.h' (moved to
5418 gdbsupport/common.m4).
5419 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5420 'gdbsupport/'.
5421 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5422 * compile/compile-c-support.c: Include
5423 'gdbsupport/gdb-dlfcn.h'.
5424 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5425 * gdb-dlfcn.c: Move to...
5426 * gdbsupport/gdb-dlfcn.c: ... here.
5427 * gdb-dlfcn.h: Move to...
5428 * gdbsupport/gdb-dlfcn.h: ... here.
5429
de8af808
SL
54302019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5431
5432 * nios2-tdep.c (struct reg_value): Improve comments. Make
5433 the offset field signed.
5434
27204489
CB
54352019-08-22 Christian Biesinger <cbiesinger@google.com>
5436
5437 * python/lib/gdb/__init__.py (_execute_file): New function.
5438 * python/python.c (python_run_simple_file): Call gdb._execute_file
5439 on Windows.
5440
43771869
AB
54412019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5442
5443 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5444 all uses as this was never set to anything but a zero value.
5445
26c957f1
PA
54462019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5447
5448 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5449
c07aae6e
CB
54502019-08-21 Christian Biesinger <cbiesinger@google.com>
5451
5452 * tui/tui-data.h (tui_gen_win_info): Add an =default
5453 move constructor, required by some GCC versions.
5454
3960cb7a
JF
54552019-08-21 Jinke Fan <fanjinke51@yeah.net>
5456
5457 * go32-nat.c (go32_sysinfo): Add hygon_p.
5458
04c72a68
TT
54592019-08-20 Tom Tromey <tom@tromey.com>
5460
5461 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5462 line_from_reg_element_no, first_reg_element_no_inline,
5463 display_all_data, delete_data_content_windows,
5464 erase_data_content>: Now private.
5465
072272ce
TT
54662019-08-20 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5469 (tui_unhighlight_win, tui_highlight_win)
5470 (tui_win_info::make_window): Update.
5471 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5472
973961bd
TT
54732019-08-20 Tom Tromey <tom@tromey.com>
5474
5475 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5476 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5477 (MAX_PID_WIDTH): Move to tui-stack.c.
5478 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5479 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5480 (MAX_PID_WIDTH): Move from tui-data.h.
5481
ab0e1f1a
TT
54822019-08-20 Tom Tromey <tom@tromey.com>
5483
5484 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5485 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5486 (box_win): Update.
5487 (tui_gen_win_info::make_window): Rename from tui_make_window.
5488 (tui_win_info::make_window): New method.
5489 (tui_gen_win_info::make_visible): Update.
5490 * tui/tui-source.c (tui_source_window::set_contents): Update.
5491 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5492 (tui_data_window::display_registers_from): Update.
5493 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5494 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5495 Declare.
5496 <can_box>: Remove.
5497 <title>: Remove.
5498 (struct tui_win_info) <make_window>: Declare.
5499 <can_box>: Now virtual.
5500 <title>: New member.
5501 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5502 * tui/tui-command.c (tui_cmd_window::resize): Update.
5503
100c2bf3
TT
55042019-08-20 Tom Tromey <tom@tromey.com>
5505
5506 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5507 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5508 (tui_data_window::check_register_values): Update.
5509
fa4dc567
TT
55102019-08-20 Tom Tromey <tom@tromey.com>
5511
5512 * tui/tui-regs.h (struct tui_data_window): Use
5513 DISABLE_COPY_AND_ASSIGN.
5514 <regs_content>: Change type, removing unique_ptr.
5515 <tui_data_window>: Add move constructor.
5516 * tui/tui-regs.c (tui_data_window::show_registers)
5517 (tui_data_window::show_register_group)
5518 (tui_data_window::display_registers_from)
5519 (tui_data_window::display_registers_from)
5520 (tui_data_window::first_data_item_displayed)
5521 (tui_data_window::delete_data_content_windows)
5522 (tui_data_window::rerender, tui_data_window::refresh_window)
5523 (tui_data_window::check_register_values): Update.
5524
ca02d7c8
TT
55252019-08-20 Tom Tromey <tom@tromey.com>
5526
5527 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5528 show_register_group>: Declare.
5529 (tui_show_register_group): Don't declare.
5530 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5531 tui_show_registers.
5532 (tui_data_window::show_register_group): Rename from
5533 tui_show_register_group.
5534 (tui_data_window::check_register_values, tui_reg_command):
5535 Update.
5536 * tui/tui-layout.c (tui_set_layout): Update.
5537
63356bfd
TT
55382019-08-20 Tom Tromey <tom@tromey.com>
5539
5540 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5541 Declare.
5542 (tui_check_register_values): Don't declare.
5543 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5544 from tui_check_register_values.
5545 * tui/tui-hooks.c (tui_register_changed): Update.
5546
42cc14a7
TT
55472019-08-20 Tom Tromey <tom@tromey.com>
5548
5549 * tui/tui-regs.c (tui_reg_layout): Move later.
5550 (tui_show_registers): Don't enable TUI mode or change layout.
5551
b9ad3686
TT
55522019-08-20 Tom Tromey <tom@tromey.com>
5553
5554 * tui/tui-regs.h (struct tui_data_item_window)
5555 <~tui_data_item_window>: Remove.
5556 <content>: Now a unique_xmalloc_ptr.
5557 * tui/tui-regs.c (tui_register_format): Return a
5558 unique_xmalloc_ptr.
5559 (tui_get_register): Update.
5560 (~tui_data_item_window): Remove.
5561 (tui_data_window::display_registers_from, tui_display_register):
5562 Update.
5563 * tui/tui-io.h (tui_expand_tabs): Update.
5564 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5565 Remove "col" parameter.
5566
8e114aab
TT
55672019-08-20 Tom Tromey <tom@tromey.com>
5568
5569 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5570 field.
5571 * tui/tui-regs.c (~tui_data_item_window): Update.
5572
1a4f81dd
TT
55732019-08-20 Tom Tromey <tom@tromey.com>
5574
5575 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5576 earlier.
5577
0f8d8876
TT
55782019-08-20 Tom Tromey <tom@tromey.com>
5579
5580 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5581
605dc2c2
TT
55822019-08-20 Tom Tromey <tom@tromey.com>
5583
5584 * tui/tui-source.h (struct tui_source_window): Update.
5585 * tui/tui-regs.c (tui_show_registers): Update.
5586 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5587 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5588 (NO_REGS_STRING): Remove defines.
5589
aedbe3bb
CM
55902019-08-20 Conrad Meyer <cem@FreeBSD.org>
5591
5592 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5593 unnecessary thread walk if remote doesn't support the packet.
5594
7ce8f214
TT
55952019-08-19 Tom Tromey <tromey@adacore.com>
5596
5597 * python/py-value.c (value_has_field): Fix indentation.
5598
f21c2bd7
TT
55992019-08-19 Tom Tromey <tromey@adacore.com>
5600
5601 * printcmd.c (do_one_display, info_display_command): Update.
5602 * block.h (contained_in): Return bool. Add allow_nested
5603 parameter.
5604 * block.c (contained_in): Return bool. Add allow_nested
5605 parameter.
5606
d806ea2d
TT
56072019-08-19 Tom Tromey <tom@tromey.com>
5608
5609 * configure: Rebuild.
5610 * configure.ac: Disallow the combination of -static-libstdc++ and
5611 source highlight.
5612 * source-cache.c (get_language_name): Handle rust.
5613 (source_cache::get_source_lines): Ignore highlighting exceptions.
5614
398fdd60
TT
56152019-08-16 Tom Tromey <tom@tromey.com>
5616
5617 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5618 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5619 (struct tui_source_window_base) <make_visible, refresh_window,
5620 resize>: Remove methods.
5621 <execution_info>: Remove field.
5622 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5623 (tui_show_source_line, tui_source_window_base)
5624 (~tui_source_window_base): Update.
5625 (tui_source_window_base::resize)
5626 (tui_source_window_base::make_visible)
5627 (tui_source_window_base::refresh_window): Remove.
5628 (tui_source_window_base::update_exec_info): Update.
5629 * tui/tui-source.c (tui_source_window::set_contents): Update.
5630 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5631
e699d331
TT
56322019-08-16 Tom Tromey <tom@tromey.com>
5633
5634 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5635 deprecated_query_hook.
5636
bb01dbfc
TT
56372019-08-16 Tom Tromey <tom@tromey.com>
5638
5639 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5640 (tui_update_source_windows_with_line): Update.
5641 * tui/tui-source.h (struct tui_source_window)
5642 <show_symtab_source>: Declare.
5643 (tui_show_symtab_source): Don't declare.
5644 * tui/tui-source.c (tui_show_symtab_source): Rename from
5645 tui_show_symtab_source.
5646
81c82c4b
TT
56472019-08-16 Tom Tromey <tom@tromey.com>
5648
5649 * tui/tui-winsource.h (struct tui_source_window_base)
5650 <set_contents>: Declare.
5651 * tui/tui-winsource.c
5652 (tui_source_window_base::update_source_window_as_is): Update.
5653 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5654 Declare.
5655 (tui_set_source_content): Don't declare.
5656 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5657 tui_set_source_content.
5658 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5659 Declare.
5660 (tui_set_disassem_content): Don't declare.
5661 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5662 tui_set_disassem_content.
5663
2ddaf614
TT
56642019-08-16 Tom Tromey <tom@tromey.com>
5665
5666 * tui/tui-winsource.h (struct tui_source_window_base)
5667 <update_breakpoint_info>: Declare.
5668 (tui_update_breakpoint_info): Don't declare.
5669 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5670 (tui_update_all_breakpoint_info): Update.
5671 (tui_source_window_base::update_breakpoint_info): Rename from
5672 tui_update_breakpoint_info.
5673 (tui_source_window_base::update_exec_info): Update.
5674
017f9828
TT
56752019-08-16 Tom Tromey <tom@tromey.com>
5676
5677 * tui/tui-winsource.h (struct tui_source_window_base)
5678 <update_source_window>: Declare.
5679 (tui_update_source_window): Don't declare.
5680 * tui/tui-winsource.c
5681 (tui_source_window_base::update_source_window): Rename from
5682 tui_update_source_window.
5683 (tui_source_window_base::rerender): Update.
5684 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5685 * tui/tui-disasm.c (tui_show_disassem)
5686 (tui_show_disassem_and_update_source)
5687 (tui_disasm_window::maybe_update): Update.
5688
ed8358e9
TT
56892019-08-16 Tom Tromey <tom@tromey.com>
5690
5691 * tui/tui-winsource.h (struct tui_source_window_base)
5692 <update_source_window_as_is>: Declare.
5693 (tui_update_source_window_as_is): Don't declare.
5694 * tui/tui-winsource.c (tui_update_source_window): Update
5695 (tui_source_window_base::update_source_window_as_is): Rename from
5696 tui_update_source_window_as_is.
5697 (tui_source_window_base::refill): Update.
5698 * tui/tui-source.c (tui_show_symtab_source): Update.
5699 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5700 Update.
5701
20149b6b
TT
57022019-08-16 Tom Tromey <tom@tromey.com>
5703
5704 * tui/tui-winsource.h (tui_update_source_window)
5705 (tui_update_source_window_as_is): Remove "noerror" parameter.
5706 * tui/tui-winsource.c (tui_update_source_window)
5707 (tui_update_source_window_as_is): Remove "noerror" parameter.
5708 (tui_update_source_windows_with_addr)
5709 (tui_update_source_windows_with_line)
5710 (tui_source_window_base::rerender)
5711 (tui_source_window_base::refill): Update.
5712 * tui/tui-source.h (tui_set_source_content)
5713 (tui_show_symtab_source): Remove "noerror" parameter.
5714 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5715 parameter.
5716 (tui_show_symtab_source): Likewise.
5717 (tui_source_window::maybe_update): Update.
5718 * tui/tui-disasm.c (tui_show_disassem)
5719 (tui_show_disassem_and_update_source)
5720 (tui_disasm_window::do_scroll_vertical)
5721 (tui_disasm_window::maybe_update): Update.
5722
2d83e710
TT
57232019-08-16 Tom Tromey <tom@tromey.com>
5724
5725 * tui/tui.c (tui_is_window_visible): Update.
5726 * tui/tui-wingeneral.c (tui_make_window)
5727 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5728 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5729 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5730 (tui_set_win_height_command, parse_scrolling_args): Update.
5731 * tui/tui-source.c (tui_source_window::style_changed): Update.
5732 * tui/tui-regs.c (tui_show_registers)
5733 (tui_data_window::first_data_item_displayed)
5734 (tui_data_window::delete_data_content_windows)
5735 (tui_check_register_values, tui_reg_command): Update.
5736 * tui/tui-disasm.c (tui_show_disassem): Update.
5737 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5738 method.
5739 <is_visible>: Remove field.
5740 * tui/tui-data.c (tui_next_win, tui_prev_win)
5741 (tui_delete_invisible_windows): Update.
5742
d4ab829a
TT
57432019-08-16 Tom Tromey <tom@tromey.com>
5744
5745 * tui/tui-winsource.h (struct tui_source_window_base)
5746 <m_has_locator>: Remove.
5747 * tui/tui-layout.c (show_source_disasm_command, show_data)
5748 (show_source_or_disasm_and_command): Update.
5749
aa7ca1bb
AH
57502019-08-16 Alan Hayward <alan.hayward@arm.com>
5751
5752 * NEWS (Other MI changes): New subsection.
5753 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5754 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5755 * arch-utils.c (default_get_pc_address_flags): New function.
5756 * arch-utils.h (default_get_pc_address_flags): New declaration.
5757 * gdbarch.sh: Add get_pc_address_flags.
5758 * gdbarch.c: Regenerate.
5759 * gdbarch.h: Likewise.
5760 * stack.c (print_pc): New function.
5761 (print_frame_info) (print_frame): Call print_pc.
5762
6eac171f
TV
57632019-08-16 Tom de Vries <tdevries@suse.de>
5764
5765 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5766 print_objfile_section_info.
5767
3df505f6
TT
57682019-08-15 Tom Tromey <tom@tromey.com>
5769
5770 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5771 calling update_cmdwin_start_line.
5772 * tui/tui-winsource.h (struct tui_source_window_base)
5773 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5774 <rerender>: Declare.
5775 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5776 Call rerender.
5777 (tui_source_window_base::set_new_height): Remove.
5778 (tui_source_window_base::rerender): Rename from
5779 do_make_visible_with_new_height.
5780 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5781 resize method.
5782 (tui_win_info::make_invisible_and_set_new_height)
5783 (tui_win_info::make_visible_with_new_height): Remove.
5784 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5785 Declare.
5786 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5787 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5788 do_make_visible_with_new_height>: Don't declare.
5789 <rerender>: Declare.
5790 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5791 set_new_height.
5792 (tui_data_window::do_make_visible_with_new_height): Remove.
5793 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5794 call tui_show_locator_content.
5795 (tui_gen_win_info::resize): Call rerender.
5796 (show_source_or_disasm_and_command): Don't call
5797 tui_show_locator_content.
5798 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5799 method.
5800 (struct tui_win_info) <rerender>: Declare.
5801 <set_new_height, make_invisible_and_set_new_height,
5802 make_visible_with_new_height>: Don't declare.
5803 * tui/tui-data.c (tui_win_list::rerender): New method.
5804 * tui/tui-command.h (struct tui_cmd_window)
5805 <do_make_visible_with_new_height>: Don't declare.
5806 * tui/tui-command.c
5807 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5808
272560b5
TT
58092019-08-15 Tom Tromey <tromey@adacore.com>
5810
5811 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5812 * ada-lang.c (ada_enum_name): Likewise.
5813
08235187
CB
58142019-08-15 Christian Biesinger <cbiesinger@google.com>
5815
5816 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5817 leading underscore.
5818 (GdbOutputErrorFile): Likewise.
5819 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5820 accordingly.
5821 (execute_unwinders): Rename to have a leading underscore.
5822 (auto_load_packages): Likewise.
5823 (global scope): Adjust call to auto_load_packages accordingly.
5824 (GdbSetPythonDirectory): Likewise.
5825 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5826 instead of execute_unwinders.
5827
db502012
TT
58282019-08-15 Tom Tromey <tom@tromey.com>
5829
5830 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5831 (show_data): Don't change window visibility.
5832 (tui_gen_win_info::resize): Remove special case for command
5833 window. Use wresize, when available.
5834 (show_source_or_disasm_and_command): Don't change window
5835 visibility.
5836 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5837 <make_visible>: New method.
5838 * tui/tui-command.c (tui_cmd_window::resize): New method.
5839
3891b65e
TT
58402019-08-15 Tom Tromey <tom@tromey.com>
5841
5842 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5843 (struct tui_source_windows): New.
5844 * tui/tui-winsource.c (tui_display_main): Update.
5845 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5846 (new_height_ok, parse_scrolling_args): Update.
5847 * tui/tui-layout.c (show_layout, show_data): Update.
5848 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5849 (tui_add_to_source_windows): Don't declare.
5850 * tui/tui-data.c (source_windows, tui_source_windows)
5851 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5852
ee556432
TT
58532019-08-15 Tom Tromey <tom@tromey.com>
5854
5855 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5856 Rename from reset.
5857 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5858 * tui/tui-layout.c (show_source_disasm_command, show_data):
5859 Update.
5860 (tui_gen_win_info::resize): Rename.
5861 (show_source_or_disasm_and_command): Update.
5862 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5863 reset.
5864
46f438e3
TT
58652019-08-15 Tom Tromey <tom@tromey.com>
5866
5867 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5868 * tui/tui-interp.c (tui_interp::init): Don't call
5869 tui_initialize_static_data.
5870 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5871
f4ce562c
TT
58722019-08-15 Tom Tromey <tom@tromey.com>
5873
5874 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5875 examine tui_win_list.
5876
c398c3d0
TT
58772019-08-15 Tom Tromey <tom@tromey.com>
5878
5879 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5880 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5881 tui_clear_source_content.
5882 (tui_clear_source_content): Remove.
5883 (tui_source_window_base::do_erase_source_content): Hoist call to
5884 content.clear().
5885 * tui/tui-stack.c (tui_show_frame_info): Don't call
5886 tui_clear_source_content.
5887
e25d2004
TT
58882019-08-15 Tom Tromey <tom@tromey.com>
5889
5890 * tui/tui-winsource.h (struct tui_source_window_base)
5891 <do_erase_source_content>: New method.
5892 <erase_source_content>: New method.
5893 (tui_erase_source_content): Don't declare.
5894 * tui/tui-winsource.c (tui_clear_source_content): Update.
5895 (tui_source_window_base::do_erase_source_content): Rename from
5896 tui_erase_source_content.
5897 (tui_source_window_base::show_source_content): Update.
5898 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5899 * tui/tui-source.h (struct tui_source_window)
5900 <erase_source_content>: New method.
5901 * tui/tui-disasm.h (struct tui_disasm_window)
5902 <erase_source_content>: New method.
5903
002f15c2
TT
59042019-08-15 Tom Tromey <tom@tromey.com>
5905
5906 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5907 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5908 constructor.
5909 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5910 * tui/tui-source.c (tui_set_source_content): Update.
5911 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5912
c9033fe8
TT
59132019-08-15 Tom Tromey <tom@tromey.com>
5914
5915 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5916 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5917 tui-source.c.
5918 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5919 Declare.
5920 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5921 method.
5922 (tui_source_window::maybe_update): Update.
5923
088f37dd
TT
59242019-08-15 Tom Tromey <tom@tromey.com>
5925
5926 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5927 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5928 tui-disasm.c.
5929 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5930 Declare.
5931 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5932 method.
5933 (tui_disasm_window::maybe_update): Update.
5934
a54700c6
TT
59352019-08-15 Tom Tromey <tom@tromey.com>
5936
5937 * tui/tui-winsource.h (struct tui_source_window_base)
5938 <maybe_update>: Declare.
5939 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5940 method.
5941 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5942 Declare.
5943 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5944 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5945 Declare.
5946 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5947
e2a678a5
TT
59482019-08-15 Tom Tromey <tom@tromey.com>
5949
5950 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5951
f2dda477
TT
59522019-08-15 Tom Tromey <tom@tromey.com>
5953
5954 * tui/tui-wingeneral.c: Include tui-stack.h.
5955 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5956 (struct tui_locator_window): Move from tui-data.h.
5957 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5958 (tui_initialize_static_data): Move from tui-data.c.
5959 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5960 (struct tui_locator_window): Move to tui-stack.c.
5961 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5962 (tui_initialize_static_data): Move to tui-stack.c.
5963
ed4a1084
TT
59642019-08-15 Tom Tromey <tom@tromey.com>
5965
5966 * tui/tui-layout.c (show_source_disasm_command)
5967 (show_source_or_disasm_and_command): Use make_visible method, not
5968 tui_make_window.
5969 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5970 Remove.
5971
65962b20
TT
59722019-08-15 Tom Tromey <tom@tromey.com>
5973
5974 * tui/tui-wingeneral.h (tui_make_window): Update.
5975 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5976 parameter.
5977 (tui_gen_win_info::make_visible): Update.
5978 * tui/tui-regs.c (tui_data_window::display_registers_from):
5979 Update.
5980 * tui/tui-layout.c (show_source_disasm_command)
5981 (show_source_or_disasm_and_command): Update.
5982 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5983 (enum tui_box): Remove.
5984 (struct tui_win_info) <can_box>: New method.
5985 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5986 method.
5987
2208ee91
TV
59882019-08-15 Tom de Vries <tdevries@suse.de>
5989
5990 * linux-nat-trad.c: Include gdbarch.h.
5991
75faf5c4
AH
59922019-08-14 Alan Hayward <alan.hayward@arm.com>
5993
5994 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5995 register sizes.
5996
b1c896b3
TT
59972019-08-14 Tom Tromey <tromey@adacore.com>
5998
5999 * darwin-nat.c: Include gdbarch.h.
6000 * darwin-nat-info.c: Include gdbarch.h.
6001
6405cd73
TT
60022019-08-13 Tom Tromey <tom@tromey.com>
6003
6004 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
6005 Remove.
6006 * tui/tui-data.c (tui_initialize_static_data): Update.
6007
5216580d
TT
60082019-08-13 Tom Tromey <tom@tromey.com>
6009
6010 * tui/tui-winsource.h (struct tui_exec_info_window)
6011 <~tui_exec_info_window, maybe_allocate_content, get_content,
6012 m_content>: Remove.
6013 (struct tui_source_window_base) <set_exec_info_content,
6014 show_exec_info_content>: Don't declare.
6015 * tui/tui-winsource.c
6016 (tui_exec_info_window::maybe_allocate_content): Remove.
6017 (tui_source_window_base::update_exec_info): Rename from
6018 set_exec_info_content.
6019 (tui_source_window_base::show_exec_info_content)
6020 (tui_source_window_base::update_exec_info): Remove.
6021
93858ad3
TT
60222019-08-13 Tom Tromey <tom@tromey.com>
6023
6024 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6025 declare.
6026 * tui/tui-winsource.c (tui_update_source_window_as_is)
6027 (tui_update_source_windows_with_addr, tui_erase_source_content):
6028 Update.
6029 (tui_clear_exec_info_content): Remove.
6030
e321e7ce
TT
60312019-08-13 Tom Tromey <tom@tromey.com>
6032
6033 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6034 declare.
6035 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6036 call tui_erase_exec_info_content.
6037 (tui_clear_exec_info_content): Rename from
6038 tui_erase_exec_info_content.
6039 (tui_clear_exec_info_content): Delete.
6040
8270ac62
TT
60412019-08-13 Tom Tromey <tom@tromey.com>
6042
6043 * tui/tui-winsource.h (struct tui_source_window_base)
6044 <show_exec_info_content>: Declare.
6045 (tui_show_exec_info_content): Don't declare.
6046 * tui/tui-winsource.c
6047 (tui_source_window_base::show_exec_info_content): Rename from
6048 tui_show_exec_info_content.
6049 (tui_source_window_base::update_exec_info): Update.
6050
7b56485d
TT
60512019-08-13 Tom Tromey <tom@tromey.com>
6052
6053 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6054 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6055 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6056 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6057 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6058 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6059 ... here.
6060
7ba913dc
TT
60612019-08-13 Tom Tromey <tom@tromey.com>
6062
6063 * tui/tui-winsource.h (struct tui_source_window_base)
6064 <update_exec_info>: Declare.
6065 (tui_update_exec_info): Don't declare.
6066 * tui/tui-winsource.c (tui_update_source_window_as_is)
6067 (tui_source_window_base::refresh_all)
6068 (tui_update_all_breakpoint_info): Update.
6069 (tui_source_window_base::update_exec_info): Rename from
6070 tui_update_exec_info.
6071 * tui/tui-stack.c (tui_show_frame_info): Update.
6072
37a4a131
TT
60732019-08-13 Tom Tromey <tom@tromey.com>
6074
6075 * tui/tui-winsource.h (struct tui_source_window_base)
6076 <set_exec_info_content>: Declare.
6077 (tui_set_exec_info_content): Don't declare.
6078 * tui/tui-winsource.c
6079 (tui_source_window_base::set_exec_info_content): Rename from
6080 tui_set_exec_info_content.
6081 (tui_update_exec_info): Update.
6082
0bd27e07
TT
60832019-08-13 Tom Tromey <tom@tromey.com>
6084
6085 * tui/tui-winsource.h (struct tui_source_window_base)
6086 <show_source_content>: Declare.
6087 (tui_show_source_content): Don't declare.
6088 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6089 (tui_source_window_base::show_source_content): Rename from
6090 tui_show_source_content.
6091 (tui_source_window_base::refresh_all): Update.
6092 * tui/tui-layout.c (show_source_disasm_command)
6093 (show_source_or_disasm_and_command): Update.
6094
b4ef5aeb
TT
60952019-08-13 Tom Tromey <tom@tromey.com>
6096
6097 * tui/tui-winsource.c (tui_erase_source_content)
6098 (tui_show_source_content, tui_source_window_base::refresh_all):
6099 Update.
6100 * tui/tui-wingeneral.h
6101 (tui_check_and_display_highlight_if_needed): Don't declare.
6102 * tui/tui-wingeneral.c
6103 (tui_win_info::check_and_display_highlight_if_needed): Rename from
6104 check_and_display_highlight_if_needed.
6105 * tui/tui-win.c (tui_rehighlight_all)
6106 (tui_win_info::make_visible_with_new_height): Update.
6107 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6108 (tui_data_window::erase_data_content)
6109 (tui_data_window::display_all_data): Update.
6110 * tui/tui-data.h (struct tui_win_info)
6111 <check_and_display_highlight_if_needed>: Declare.
6112
fede5273
TT
61132019-08-13 Tom Tromey <tom@tromey.com>
6114
6115 * tui/tui-win.c (tui_resize_all): Call
6116 tui_delete_invisible_windows.
6117 * tui/tui-layout.c (show_layout): Call
6118 tui_delete_invisible_windows.
6119 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6120 * tui/tui-data.c (tui_delete_invisible_windows): New function.
6121
22c3f490
TT
61222019-08-13 Tom Tromey <tom@tromey.com>
6123
6124 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
6125 tui_add_win_to_layout.
6126
16cb7910
TT
61272019-08-13 Tom Tromey <tom@tromey.com>
6128
6129 * tui/tui-layout.h (tui_default_win_height): Don't declare.
6130 * tui/tui-layout.c (tui_default_win_height): Now static.
6131
cc0c3ffb
TT
61322019-08-13 Tom Tromey <tom@tromey.com>
6133
6134 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6135 single switch.
6136 (show_source_disasm_command, show_source_or_disasm_and_command):
6137 Don't check current layout.
6138
3f3ffe54
TT
61392019-08-13 Tom Tromey <tom@tromey.com>
6140
6141 * tui/tui-wingeneral.c (make_all_visible): Remove.
6142 (tui_make_all_invisible): Simplify.
6143 * tui/tui-layout.c (tui_make_all_invisible): Move from
6144 tui-wingeneral.c; simplify.
6145 (show_layout): Hoist call to tui_make_all_invisible.
6146 (show_data): Don't call tui_make_all_invisible.
6147
69258091
TT
61482019-08-13 Tom Tromey <tom@tromey.com>
6149
6150 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6151 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6152
62cf57fe
TT
61532019-08-13 Tom Tromey <tom@tromey.com>
6154
6155 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6156 tui-data.c.
6157 (show_source_disasm_command, show_data)
6158 (show_source_or_disasm_and_command): Don't use
6159 tui_set_current_layout_to.
6160 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6161 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6162 tui-layout.c.
6163 (tui_set_current_layout_to): Remove.
6164
2afade5d
TT
61652019-08-13 Tom Tromey <tom@tromey.com>
6166
6167 * tui/tui-layout.c (tui_set_layout): Update.
6168 * tui/tui-data.h (struct tui_layout_def): Remove.
6169 (tui_layout_def): Don't declare.
6170 * tui/tui-data.c (layout_def): Remove.
6171 (tui_layout_def): Remove.
6172
a3504e96
TT
61732019-08-13 Tom Tromey <tom@tromey.com>
6174
6175 * tui/tui-winsource.h (struct tui_source_window_base)
6176 <clear_detail>: No longer "override".
6177 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6178 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6179 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6180 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6181 Remove.
6182 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6183
29c92911
TT
61842019-08-13 Tom Tromey <tromey@adacore.com>
6185
6186 * tracepoint.c: Don't include readline.h or history.h.
6187
86c6b807
TT
61882019-08-12 Tom Tromey <tom@tromey.com>
6189
6190 * configure: Rebuild.
6191 * configure.ac: Check for readline 7.
6192 * NEWS: Mention readline 7 requirement.
6193 * README: Update.
6194
5db2718c
TT
61952019-08-12 Tom Tromey <tom@tromey.com>
6196
6197 * mingw-hdep.c (gdb_select): Remove readline hack.
6198
dac36daf
PFC
61992019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6200
6201 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6202 when the function fails.
6203
1022c627
AA
62042019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6205
6206 * s390-tdep.c (s390_type_align): New function.
6207 (s390_gdbarch_init): Set it as type_align gdbarch method.
6208
eba4caf2
TV
62092019-08-09 Tom de Vries <tdevries@suse.de>
6210
6211 PR gdb/24591
6212 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6213 pc_low with relocation offset.
6214
123cd851
TT
62152019-08-07 Tom Tromey <tromey@adacore.com>
6216
6217 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6218 (print_frame_args): Update.
6219 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6220 Update.
6221 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6222 * frame.h (struct frame_arg): Add initializers.
6223 <error>: Now a unique_xmalloc_ptr.
6224
3d31bc39
AH
62252019-08-07 Alan Hayward <alan.hayward@arm.com>
6226
6227 * NEWS: Expand the Pointer Authentication entry.
6228 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6229 (aarch64_frame_unmask_lr): ... to this.
6230 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6231 Call aarch64_frame_unmask_lr.
6232 * frame.c (struct frame_info): Add "masked" variable.
6233 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6234 (fprint_frame): Check for masked pc.
6235 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6236 declarations.
6237 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6238 * stack.c (print_frame): Check for masked pc.
6239
0cf9feb9
TT
62402019-08-06 Tom Tromey <tom@tromey.com>
6241
6242 * stabsread.c (patch_block_stabs, read_one_struct_field)
6243 (read_enum_type): Use obstack_strndup.
6244 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6245 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6246 * dwarf2read.c (guess_full_die_structure_name)
6247 (anonymous_struct_prefix): Use obstack_strndup.
6248 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6249 * c-exp.y (yylex): Use obstack_strndup.
6250 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6251 (write_var_or_type): Use obstack_strndup.
6252
efba19b0
TT
62532019-08-06 Tom Tromey <tom@tromey.com>
6254
6255 * symfile.c (reread_symbols): Use obstack_strdup.
6256 * stabsread.c (read_type): Use obstack_strdup.
6257 * gdb_obstack.h (obstack_strdup): New overload.
6258 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6259 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6260 (dwarf2_canonicalize_name): Use obstack_strdup.
6261 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6262 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6263 Use obstack_strdup.
6264
f25102f7
TT
62652019-08-06 Tom Tromey <tom@tromey.com>
6266
6267 * gdb_obstack.h (obstack_strdup): Define.
6268 * gdb_obstack.c (obstack_strdup): Don't define.
6269
021887d8
TT
62702019-08-06 Tom Tromey <tom@tromey.com>
6271
6272 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6273 obstack_strdup.
6274 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6275 obstack_strdup.
6276 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6277 * stabsread.c (common_block_start): Use obstack_strdup.
6278 * objfiles.c (set_objfile_main_name, objfile): Use
6279 obstack_strdup.
6280 * namespace.c (add_using_directive): Use obstack_strdup.
6281 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6282 * jit.c (finalize_symtab): Use obstack_strdup.
6283 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6284 (guess_partial_die_structure_name, partial_die_info::fixup)
6285 (dwarf2_name): Use obstack_strdup.
6286 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6287 obstack_strdup.
6288 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6289 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6290 obstack_strdup.
6291 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6292
d2834edc
PW
62932019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6294
6295 * unittests/help-doc-selftests.c: New file.
6296 * Makefile.in: Add the new file.
6297
590042fc
PW
62982019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6299
6300 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6301 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6302 the full first line, except when FOR_VALUE_PREFIX. In this case,
6303 the trailing '.' is not output, and the first character is uppercased.
6304 (print_help_for_command): Update call to print_doc_line.
6305 (print_doc_of_command): Likewise.
6306 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6307 * cli/cli-option.c (append_indented_doc): Do not append newline.
6308 (build_help_option): Append newline after first appended_indented_doc
6309 only if a second call is done.
6310 (build_help): Append 2 new lines before each option, except the first
6311 one.
6312 * compile/compile.c (_initialize_compile): Add new lines after
6313 %OPTIONS%, when not at the end of the help.
6314 Change help doc or code
6315 producing the help doc to respect the invariants.
6316 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6317 Also removed the new line after 'Options:', as all other commands
6318 do not put an empty line between 'Options:' and the first option.
6319 * printcmd.c (_initialize_printcmd): Likewise.
6320 * stack.c (_initialize_stack): Likewise.
6321 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6322 incorrectly telling COMMAND is optional.
6323 * ada-lang.c (_initialize_ada_language): Change help doc or code
6324 producing the help doc to respect the invariants.
6325 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6326 * breakpoint.c (_initialize_breakpoint): Likewise.
6327 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6328 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6329 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6330 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6331 _initialize_cli_style): Likewise.
6332 * corelow.c (core_target_info): Likewise.
6333 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6334 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6335 * filesystem.c (_initialize_filesystem): Likewise.
6336 * frame.c (_initialize_frame): Likewise.
6337 * gnu-nat.c (add_task_commands): Likewise.
6338 * infcall.c (_initialize_infcall): Likewise.
6339 * infcmd.c (_initialize_infcmd): Likewise.
6340 * interps.c (_initialize_interpreter): Likewise.
6341 * language.c (_initialize_language): Likewise.
6342 * linux-fork.c (_initialize_linux_fork): Likewise.
6343 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6344 * maint.c (_initialize_maint_cmds): Likewise.
6345 * memattr.c (_initialize_mem): Likewise.
6346 * printcmd.c (_initialize_printcmd): Likewise.
6347 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6348 _RegEx): Likewise.
6349 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6350 * record-btrace.c (_initialize_record_btrace): Likewise.
6351 * record-full.c (_initialize_record_full): Likewise.
6352 * record.c (_initialize_record): Likewise.
6353 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6354 * regcache.c (_initialize_regcache): Likewise.
6355 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6356 _initialize_remote): Likewise.
6357 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6358 * serial.c (_initialize_serial): Likewise.
6359 * skip.c (_initialize_step_skip): Likewise.
6360 * source.c (_initialize_source): Likewise.
6361 * stack.c (_initialize_stack): Likewise.
6362 * symfile.c (_initialize_symfile): Likewise.
6363 * symtab.c (_initialize_symtab): Likewise.
6364 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6365 * top.c (init_main): Likewise.
6366 * tracefile-tfile.c (tfile_target_info): Likewise.
6367 * tracepoint.c (_initialize_tracepoint): Likewise.
6368 * tui/tui-win.c (_initialize_tui_win): Likewise.
6369 * utils.c (add_internal_problem_command): Likewise.
6370 * valprint.c (value_print_option_defs): Likewise.
6371
404f2902
FCE
63722019-08-06 Frank Ch. Eigler <fche@redhat.com>
6373
6374 PR build/24886
6375 * configure.ac: Drop enable-libmcheck support.
6376 * configure, config.in: Rebuild.
6377 * libmcheck.m4: Remove.
6378 * acinclude.m4: Don't include it.
6379 * Makefile.in: Don't distribute it.
6380 * top.c (print_gdb_configuration): Don't mention it.
6381
046bebe1
TT
63822019-08-06 Tom Tromey <tom@tromey.com>
6383
6384 * utils.c (set_output_style): Sometimes pass stream to
6385 emit_style_escape.
6386 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6387 * record-btrace.c (btrace_insn_history): Update.
6388 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6389 method.
6390 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6391 Update initializers.
6392 <m_uiout>: New field.
6393 <m_di>: Move lower.
6394 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6395 Remove "uiout" parameter.
6396 (dump_insns): Update.
6397 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6398 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6399
ddbcedf5
CB
64002019-08-06 Christian Biesinger <cbiesinger@google.com>
6401
6402 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6403 (error_in_psymtab_expansion): Likewise.
6404 (lookup_symbol_via_quick_fns): Likewise.
6405 (basic_lookup_transparent_type_quick): Likewise.
6406 (basic_lookup_transparent_type_1): Likewise.
6407
b08b16c8
TT
64082019-08-06 Tom Tromey <tromey@adacore.com>
6409
6410 * source.c (last_source_error): Now bool.
6411 (print_source_lines_base): Make "noprint" bool. Only open
6412 source file when last_source_visited changes.
6413
cb44333d
TT
64142019-08-06 Tom Tromey <tromey@adacore.com>
6415
6416 * annotate.c (annotate_source_line): Use g_source_cache.
6417 * source-cache.c (source_cache::get_plain_source_lines): Change
6418 parameters. Populate m_offset_cache.
6419 (source_cache::ensure): New method.
6420 (source_cache::get_line_charpos): New method.
6421 (extract_lines): Move lower. Change parameters.
6422 (source_cache::get_source_lines): Move lower.
6423 * source-cache.h (class source_cache): Update comment.
6424 <get_line_charpos>: New method.
6425 <get_source_lines>: Update comment.
6426 <clear>: Clear m_offset_cache.
6427 <get_plain_source_lines>: Change parameters.
6428 <ensure>: New method
6429 <m_offset_cache>: New member.
6430 * source.c (forget_cached_source_info_for_objfile): Update.
6431 (info_source_command): Use g_source_cache.
6432 (find_source_lines, open_source_file_with_line_charpos): Remove.
6433 (print_source_lines_base, search_command_helper): Use g_source_cache.
6434 * source.h (open_source_file_with_line_charpos): Don't declare.
6435 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6436 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6437 Use g_source_cache.
6438
872dceaa
TT
64392019-08-06 Tom Tromey <tromey@adacore.com>
6440
6441 * source-cache.c (source_cache::get_plain_source_lines):
6442 Remove "first_line" and "last_line" parameters.
6443 (source_cache::get_source_lines): Cache plain text.
6444 * source-cache.h (class source_cache)
6445 <get_plain_source_lines>: Update.
6446
269249d9
TT
64472019-08-06 Tom Tromey <tromey@adacore.com>
6448
6449 * source-cache.c (extract_lines): No longer a method.
6450 Changed type of parameter. Include final newline.
6451 (selftests::extract_lines_test): New function.
6452 (_initialize_source_cache): Likewise.
6453 * source-cache.h (class source_cache)
6454 <extract_lines>: Don't declare.
6455
c0e8dcd8
TT
64562019-08-06 Tom Tromey <tromey@adacore.com>
6457
6458 * breakpoint.c (init_breakpoint_sal): Update.
6459 (breakpoint): Update.
6460 * breakpoint.h (struct breakpoint) <filter>: Now a
6461 unique_xmalloc_ptr.
6462
0b27c27d
CB
64632019-08-05 Christian Biesinger <cbiesinger@google.com>
6464
6465 * NEWS: Mention dictionary access on blocks.
6466 * python/py-block.c (blpy_getitem): New function.
6467 (block_object_as_mapping): New struct.
6468 (block_object_type): Use new struct for tp_as_mapping field.
6469
4ee94178
CB
64702019-08-05 Christian Biesinger <cbiesinger@google.com>
6471
6472 * objfiles.h (objfile): Add a comment describing partial symbols.
6473
8abfcabc
TT
64742019-08-05 Tom Tromey <tromey@adacore.com>
6475
6476 * compile/compile.c (_initialize_compile): Use _(), not N_().
6477 * thread.c (_initialize_thread): Use _(), not N_().
6478 * stack.c (_initialize_stack): Use _(), not N_().
6479 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6480
2b79f376
SM
64812019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6482
6483 * dwarf2read.c (struct dw2_symtab_iterator):
6484 <want_specific_block>: Remove.
6485 <block_index>: Change type to gdb::optional.
6486 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6487 change type of BLOCK_INDEX parameter to gdb::optional.
6488 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6489 (dw2_lookup_symbol): Don't pass argument for
6490 WANT_SPECIFIC_BLOCK.
6491 (dw2_expand_symtabs_for_function): Don't pass argument for
6492 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6493 (class dw2_debug_names_iterator)
6494 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6495 parameter, change BLOCK_INDEX type to gdb::optional.
6496 <m_want_specific_block>: Remove.
6497 <m_block_index>: Change type to gdb::optional.
6498 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6499 gdb::optional. Re-write in function of gdb::optional.
6500 (dw2_debug_names_lookup_symbol): Don't pass argument for
6501 WANT_SPECIFIC_BLOCK.
6502 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6503 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6504 BLOCK_INDEX.
6505
ae60f04e
PW
65062019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6507
6508 * NEWS: Mention changes to "info sources" command.
6509
28cd9371
PW
65102019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6511
6512 * symtab.c (filename_partial_match_opts): New struct type.
6513 (struct output_source_filename_data): New members
6514 regexp, c_regexp, partial_match.
6515 (output_source_filename): Use new members to decide to print file.
6516 (info_sources_option_defs): New variable.
6517 (make_info_sources_options_def_group, print_info_sources_header,
6518 info_sources_command_completer):
6519 New functions.
6520 (info_sources_command): Read new optional arguments.
6521 (_initialize_symtab): Update info sources help.
6522
ca683e3a
AO
65232019-08-02 Alexandre Oliva <oliva@adacore.com>
6524
6525 * ada-lang.c (exception_support_info_v0): Renamed from...
6526 (default_exception_support_info): ... this. Create new
6527 definition for v1.
6528 (ada_has_this_exception_support): Look up catch_handlers_sym.
6529 (ada_exception_support_info_sniffer): Try v0 after default.
6530
f1264162
TT
65312019-08-01 Tom Tromey <tromey@adacore.com>
6532
6533 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6534 gdbarch.h.
6535
0a7b2485
CB
65362019-08-01 Christian Biesinger <cbiesinger@google.com>
6537
6538 * s12z-tdep.c: Fix include path for s12z-opc.h.
6539
c6bdbeb7
AH
65402019-08-01 Alan Hayward <alan.hayward@arm.com>
6541
6542 * NEWS: Require GNU make 3.82.
6543
a2bd7b82
TT
65442019-07-16 Tom Tromey <tom@tromey.com>
6545
6546 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6547 declare.
6548
aa3b6533
TT
65492019-07-30 Tom Tromey <tromey@adacore.com>
6550
6551 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6552
a1530dc7
KB
65532019-07-30 Kevin Buettner <kevinb@redhat.com>
6554
6555 * printcmd.c (print_address_symbolic): Print negative offsets.
6556 (build_address_symbolic): Force signed arithmetic when computing
6557 offset.
6558
2906593f
CB
65592019-07-30 Christian Biesinger <cbiesinger@google.com>
6560
6561 PR/24474: Add a function to lookup static variables.
6562 * NEWS: Mention this new function.
6563 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6564 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6565 * python/python.c (python_GdbMethods): Add new function.
6566
c620ed88
CB
65672019-07-29 Christian Biesinger <cbiesinger@google.com>
6568
6569 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6570 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6571 (objfpy_lookup_static_symbol): New function.
6572 (objfile_object_methods): Add new functions.
6573
bc4268a5
PW
65742019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6575
6576 * NEWS: Mention 'set|show print frame-info'. Mention new
6577 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6578 backtrace argument. Mention that python frame filtering code
6579 is now consistent with what 'backtrace' command prints.
6580
4b5e8d19
PW
65812019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6582
6583 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6584 comments.
6585 (print_frame_info_auto, print_frame_info_source_line,
6586 print_frame_info_location, print_frame_info_source_and_location,
6587 print_frame_info_location_and_address, print_frame_info_short_location):
6588 New declarations.
6589 (struct frame_print_options): New member print_frame_info.
6590 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6591 * stack.h (get_user_print_what_frame_info): New declaration.
6592 (frame_show_address): New declaration.
6593 * stack.c (print_frame_arguments_choices): New value 'presence'.
6594 (print_frame_info_auto, print_frame_info_source_line,
6595 print_frame_info_location, print_frame_info_source_and_location,
6596 print_frame_info_location_and_address, print_frame_info_short_location,
6597 print_frame_info_choices, print_frame_info_print_what): New definitions.
6598 (print_frame_args): Only print dots for args if print frame-arguments
6599 is 'presence'.
6600 (frame_print_option_defs): New element for "frame-info".
6601 (get_user_print_what_frame_info): New function.
6602 (frame_show_address): Make non static. Move comment to stack.h.
6603 (print_frame_info_to_print_what): New function.
6604 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6605 to decide what to print.
6606 (backtrace_command_1): Handle the new print_frame_arguments_presence
6607 value.
6608 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6609 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6610 (py_print_frame): In non-mi mode, use LOCATION as default for
6611 print_what, similarly to frame information printed directly by
6612 backtrace command. Handle frame-info user option in non MI mode.
6613
6bdfee81
KB
66142019-07-27 Kevin Buettner <kevinb@redhat.com>
6615
6616 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6617 Add case for debugging 32-bit target on 64-bit host. Revise
6618 comment.
6619
98a617f8
KB
66202019-07-27 Kevin Buettner <kevinb@redhat.com>
6621
6622 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6623 instead of find_function_entry_range_from_pc.
6624
567238c9
KB
66252019-07-27 Kevin Buettner <kevinb@redhat.com>
6626
6627 * stack.c (find_frame_funname): Remove code which preferred
6628 minsym over symtab sym in "certain pathological cases".
6629
2dc80cf8
KB
6630 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6631 parameter. Change type of "do_demangle" to bool.
6632 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6633 Pass suitable "prefer_sym_over_minsym" flag to
6634 build_address_symbolic(). Don't output "+" for negative offsets.
6635 * printcmd.c (print_address_symbolic): Update invocation of
6636 build_address_symbolic to include a "prefer_sym_over_minsym"
6637 flag.
6638 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6639 Restrict cases in which use of minimal symbol is preferred to that
6640 of a found symbol. Update comments.
6641
1aff7173
KB
6642 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6643 for entry pc when entry pc is out of range for that FDE.
6644
89b085ac
BC
66452019-07-26 Brian Callahan <bcallah@openbsd.org>
6646
6647 PR gdb/24839:
6648 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6649 type.
6650
f32feb4a
CB
66512019-07-25 Christian Biesinger <cbiesinger@google.com>
6652
6653 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6654 this function's Python signature.
6655
6656
66572019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6658
6659 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6660 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6661 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6662 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6663 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6664
6665
c54e4253
YS
66662019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6667
6668 * h8300-tdep.c (h8300_register_name_common): New.
6669 h8300_register_name): Use h8300_register_name_common.
6670 (h8300s_register_name): Likewise.
6671 (h8300sx_register_name): Likewise.
6672 (h8300h_register_nam): New.
6673 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6674
6675
40eadf04
SP
66762019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6677
6678 * arm-tdep.c (arm_skip_cmse_entry): New function.
6679 (arm_is_sgstubs_section): New function.
6680 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6681
bfa2a36d
TT
66822019-07-22 Tom Tromey <tom@tromey.com>
6683
6684 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6685 Don't self-assign.
6686
a8e9d247
AB
66872019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6688
6689 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6690 type_print.
6691
eb86c5e2
AB
66922019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6693
6694 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6695 so that GDB doesn't match any msymbols when searching in the
6696 TYPES_DOMAIN.
6697 (print_symbol_info): Print using typedef_print or type_print based
6698 on the type of the symbol. Add updated FIXME comment moved from...
6699 (_initialize_symtab): ... move and update FIXME comment to above.
6700
a8eab7c6
AB
67012019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6702
6703 * NEWS: Mention adding -q option to "info types".
6704 * symtab.c (struct info_types_options): New struct.
6705 (info_types_options_defs): New variable.
6706 (make_info_types_options_def_group): New function.
6707 (info_types_command): Use gdb::option framework to parse options.
6708 (info_types_command_completer): New function.
6709 (_initialize_symtab): Extend the help text on "info types" and
6710 register command completer.
6711
b4603c34
CB
67122019-07-21 Christian Biesinger <cbiesinger@google.com>
6713
6714 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6715 (lookup_symbol_in_objfile): Change int to block_enum and add a
6716 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6717
c8cdc1e0
CB
67182019-07-20 Christian Biesinger <cbiesinger@google.com>
6719
6720 * MAINTAINERS (Write After Approval): Add self.
6721
01e175fe
AB
67222019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6723
6724 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6725 instruction to the dummy code region.
6726
56f79b63
TT
67272019-07-19 Tom Tromey <tromey@adacore.com>
6728
6729 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6730 (ARGSUSED, PARAMS, __func__): Remove rules.
6731
4c5aa8e0
AH
67322019-07-19 Alan Hayward <alan.hayward@arm.com>
6733
6734 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6735 * features/arm/arm-with-iwmmxt.c: Remove.
6736 * features/arm/arm-with-iwmmxt.xml: Remove.
6737 * features/arm/arm-with-m-fpa-layout.c: Remove.
6738 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6739 * features/arm/arm-with-m-vfp-d16.c: Remove.
6740 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6741 * features/arm/arm-with-m.c: Remove.
6742 * features/arm/arm-with-m.xml: Remove.
6743 * features/arm/arm-with-neon.c: Remove.
6744 * features/arm/arm-with-neon.xml: Remove.
6745 * features/arm/arm-with-vfpv2.c: Remove.
6746 * features/arm/arm-with-vfpv2.xml: Remove.
6747 * features/arm/arm-with-vfpv3.c: Remove.
6748 * features/arm/arm-with-vfpv3.xml: Remove.
6749
f42b2617
AH
67502019-07-19 Alan Hayward <alan.hayward@arm.com>
6751
6752 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6753
f29ec966
AH
67542019-07-19 Alan Hayward <alan.hayward@arm.com>
6755
6756 * arch/aarch32.c (aarch32_create_target_description): Create
6757 target descriptions using features.
6758 * arch/arm.c (arm_create_target_description)
6759 (arm_create_mprofile_target_description): Likewise.
6760 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6761
d105cce5
AH
67622019-07-19 Alan Hayward <alan.hayward@arm.com>
6763
6764 * Makefile.in: Add new files.
6765 * aarch32-tdep.c: New file.
6766 * aarch32-tdep.h: New file.
6767 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6768 Call aarch32_read_description.
6769 * arch/aarch32.c: New file.
6770 * arch/aarch32.h: New file.
6771 * arch/arm.c (arm_create_target_description)
6772 (arm_create_mprofile_target_description): New function.
6773 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6774 (arm_create_target_description)
6775 (arm_create_mprofile_target_description): New declaration.
6776 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6777 read_description functions.
6778 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6779 Likewise.
6780 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6781 * arm-tdep.c (tdesc_arm_list): New variable.
6782 (arm_register_g_packet_guesses): Call create description functions.
6783 (arm_read_description) (arm_read_mprofile_description): New
6784 function.
6785 * arm-tdep.h (arm_read_description)
6786 (arm_read_mprofile_description): Add declaration.
6787 * configure.tgt: Add new files.
6788
afe09f0b
GL
67892019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6790
6791 * top.c (new_ui_command): Open specified terminal just once.
6792
cd215b2e
TT
67932019-07-18 Tom Tromey <tromey@adacore.com>
6794
6795 * symtab.c (main_name): Constify return type.
6796 * symfile.c (set_initial_language): Update.
6797 * symtab.h (main_name): Constify return type.
6798
d8f68fcb
TT
67992019-07-17 Tom Tromey <tom@tromey.com>
6800
6801 * tui/tui-winsource.c (tui_update_source_window)
6802 (tui_update_source_window_as_is)
6803 (tui_update_source_windows_with_line): Remove return.
6804 * tui/tui-disasm.c (tui_show_disassem)
6805 (tui_show_disassem_and_update_source): Remove return.
6806 * tui/tui.c (tui_reset): Remove return.
6807 * tui/tui-wingeneral.c
6808 (tui_check_and_display_highlight_if_needed): Remove return.
6809
ca5af91e
TT
68102019-07-17 Tom Tromey <tom@tromey.com>
6811
6812 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6813
5104fe36
TT
68142019-07-17 Tom Tromey <tom@tromey.com>
6815
6816 * tui/tui-winsource.h (struct tui_exec_info_window)
6817 (struct tui_source_window_base): Move from tui-data.h.
6818 * tui/tui-winsource.c: Move many method definitions from
6819 elsewhere. Remove "structuring" comments.
6820 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6821 (tui_source_window_base::refresh_window): Move to
6822 tui-winsource.c.
6823 * tui/tui-win.c (tui_source_window_base::refresh_all)
6824 (tui_source_window_base::update_tab_width)
6825 (tui_source_window_base::set_new_height)
6826 (tui_source_window_base::do_make_visible_with_new_height): Move to
6827 tui-winsource.c.
6828 * tui/tui-source.h: Update.
6829 * tui/tui-source.c (tui_source_window_base::reset): Move to
6830 tui-winsource.c.
6831 * tui/tui-disasm.h: Update.
6832 * tui/tui-data.h (struct tui_exec_info_window): Move to
6833 tui-winsource.h.
6834 (struct tui_source_window_base): Likewise.
6835 * tui/tui-data.c (tui_source_window_base::clear_detail)
6836 (tui_source_window_base, ~tui_source_window_base): Move to
6837 tui-winsource.c.
6838
daa15dde
TT
68392019-07-17 Tom Tromey <tom@tromey.com>
6840
6841 * tui/tui-win.c (tui_resize_all)
6842 (tui_source_window_base::update_tab_width)
6843 (tui_adjust_win_heights): Update.
6844 (tui_win_info::make_invisible_and_set_new_height): Rename from
6845 make_invisible_and_set_new_height.
6846 * tui/tui-data.h (struct tui_win_info)
6847 <make_invisible_and_set_new_height>: New method.
6848
bfad4537
TT
68492019-07-17 Tom Tromey <tom@tromey.com>
6850
6851 * tui/tui.c: Update.
6852 * tui/tui-source.h (struct tui_source_window): Move from
6853 tui-data.h.
6854 * tui/tui-layout.c: Update.
6855 * tui/tui-disasm.c: Update.
6856 * tui/tui-data.h (struct tui_source_window): Move to
6857 tui-source.h.
6858
88f7e873
TT
68592019-07-17 Tom Tromey <tom@tromey.com>
6860
6861 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6862 tui-data.h.
6863 * tui/tui-data.h (struct tui_disasm_window): Move to
6864 tui-disasm.h.
6865
96bd6233
TT
68662019-07-17 Tom Tromey <tom@tromey.com>
6867
6868 * tui/tui-regs.h (struct tui_data_item_window): Move from
6869 tui-data.h.
6870 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6871 * tui/tui-data.h (struct tui_data_item_window): Move to
6872 tui-regs.h.
6873 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6874
ce38393b
TT
68752019-07-17 Tom Tromey <tom@tromey.com>
6876
6877 * tui/tui.c: Update.
6878 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6879 (tui_cmd_window::max_height): Move to tui-command.c.
6880 * tui/tui-layout.c: Update.
6881 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6882 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6883 tui-command.c.
6884 * tui/tui-command.h (struct tui_cmd_window): Move from
6885 tui-data.h.
6886 * tui/tui-command.c: Remove "structuring" comments.
6887 (tui_cmd_window::clear_detail)
6888 (tui_cmd_window::do_make_visible_with_new_height)
6889 (tui_cmd_window::max_height): Move from elsewhere.
6890
2d8b51cb
TT
68912019-07-17 Tom Tromey <tom@tromey.com>
6892
6893 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6894 Now static.
6895 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6896 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6897
18ab23af
TT
68982019-07-17 Tom Tromey <tom@tromey.com>
6899
6900 * tui/tui.c: Update.
6901 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6902 tui-regs.c.
6903 * tui/tui-windata.h: Remove file.
6904 * tui/tui-windata.c: Remove file.
6905 * tui/tui-win.c (tui_data_window::set_new_height)
6906 (tui_data_window::do_make_visible_with_new_height): Move to
6907 tui-regs.c.
6908 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6909 * tui/tui-regs.c: Remove "structuring" comments.
6910 (tui_data_window::first_data_item_displayed)
6911 (tui_data_window::delete_data_content_windows)
6912 (tui_data_window::erase_data_content)
6913 (tui_data_window::display_all_data)
6914 (tui_data_window::refresh_all)
6915 (tui_data_window::do_scroll_vertical)
6916 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6917 (tui_data_window::do_make_visible_with_new_height)
6918 (tui_data_window::refresh_window): Move from elsewhere.
6919 (_initialize_tui_regs): Move to end of file.
6920 * tui/tui-layout.c: Update.
6921 * tui/tui-hooks.c: Update.
6922 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6923 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6924 tui-regs.c.
6925 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6926
88b7e7cc
TT
69272019-07-17 Tom Tromey <tom@tromey.com>
6928
6929 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6930 seen.
6931
0fcd3711
TT
69322019-07-17 Tom Tromey <tom@tromey.com>
6933
6934 * tui/tui-win.c (tui_source_window_base::set_new_height)
6935 (tui_source_window_base::do_make_visible_with_new_height): Use
6936 m_has_locator field directly.
6937 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6938 method.
6939 (struct tui_source_window_base) <has_locator>: Likewise.
6940
4a38112d
TT
69412019-07-17 Tom Tromey <tom@tromey.com>
6942
6943 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6944 Don't declare.
6945 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6946 Remove.
6947 * tui/tui-win.c (tui_source_window_base::set_new_height)
6948 (tui_source_window_base::set_new_height)
6949 (make_invisible_and_set_new_height)
6950 (tui_source_window_base::do_make_visible_with_new_height)
6951 (tui_source_window_base::do_make_visible_with_new_height):
6952 Update.
6953 * tui/tui-layout.c (show_source_disasm_command, show_data)
6954 (show_source_or_disasm_and_command): Update.
6955 * tui/tui-layout.c (show_layout): Update.
6956
09129226
TT
69572019-07-17 Tom Tromey <tom@tromey.com>
6958
6959 * tui/tui-layout.c (make_data_window): Remove.
6960 (show_data): Unify creation and re-initialization cases.
6961
4a8a5e84
TT
69622019-07-17 Tom Tromey <tom@tromey.com>
6963
6964 * tui/tui-layout.c (make_source_window, make_disasm_window):
6965 Remove.
6966 (show_data): Unify creation and re-initialization cases.
6967
76d2be8e
TT
69682019-07-17 Tom Tromey <tom@tromey.com>
6969
6970 * tui/tui-layout.c (make_command_window): Remove.
6971 (show_source_disasm_command, show_source_or_disasm_and_command):
6972 Unify creation and re-initialization cases.
6973
890b8bde
TT
69742019-07-17 Tom Tromey <tom@tromey.com>
6975
6976 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6977 creation and re-initialization cases.
6978
2cdfa113
TT
69792019-07-17 Tom Tromey <tom@tromey.com>
6980
6981 * tui/tui-regs.c (tui_get_register): Return void.
6982
8e3cfd09
TT
69832019-07-17 Tom Tromey <tom@tromey.com>
6984
6985 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6986 Simplify.
6987
f4e04977
TT
69882019-07-17 Tom Tromey <tom@tromey.com>
6989
6990 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6991 resetting.
6992
0379b883
TT
69932019-07-17 Tom Tromey <tom@tromey.com>
6994
6995 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6996 * tui/tui-regs.c (tui_reg_layout): New function.
6997 (tui_show_registers, tui_reg_command): Use it.
6998 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6999 (tui_layout_command): Rename from tui_set_layout_by_name. Change
7000 parameters.
7001 (tui_layout_command): Remove.
7002
b7fbad91
TT
70032019-07-17 Tom Tromey <tom@tromey.com>
7004
7005 * tui/tui-layout.h (tui/tui-layout): Return void.
7006 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
7007
4e1e56b9
TT
70082019-07-17 Tom Tromey <tom@tromey.com>
7009
7010 * tui/tui-layout.c (show_source_disasm_command, show_data):
7011 Update.
7012 (reset_locator): Remove.
7013 (show_source_or_disasm_and_command): Update.
7014
1e0c09ba
TT
70152019-07-17 Tom Tromey <tom@tromey.com>
7016
7017 * tui/tui-source.c (tui_source_window_base::reset): Remove
7018 win_type parameter.
7019 * tui/tui-layout.c (make_command_window, make_source_window)
7020 (make_disasm_window, make_data_window)
7021 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7022 (reset_locator, show_source_or_disasm_and_command): Update.
7023 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7024 win_type parameter.
7025 (struct tui_source_window_base) <reset>: Likewise.
7026
1bf605de
TT
70272019-07-17 Tom Tromey <tom@tromey.com>
7028
7029 * tui/tui-layout.c (show_source_disasm_command): Use
7030 reset_locator.
7031 (reset_locator): New function.
7032 (init_and_make_win): Remove.
7033 (show_source_or_disasm_and_command): Use reset_locator.
7034
098f9ed4
TT
70352019-07-17 Tom Tromey <tom@tromey.com>
7036
7037 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7038 condition.
7039 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7040 Remove condition.
7041 * tui/tui-source.c (tui_source_window_base::reset): New method.
7042 * tui/tui-layout.c (make_command_window): Don't call
7043 init_and_make_win.
7044 (make_source_window, make_disasm_window): Don't call
7045 make_source_or_disasm_window.
7046 (make_data_window): Don't call init_and_make_win. Change calling
7047 convention.
7048 (show_source_disasm_command, show_data): Simplify.
7049 (make_source_or_disasm_window): Remove.
7050 (show_source_or_disasm_and_command): Simplify.
7051 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7052 (struct tui_source_window_base) <reset>: Likewise.
7053 <execution_info>: Remove initializer.
7054 * tui/tui-data.c (tui_source_window_base): Initialize
7055 execution_info.
7056
80110957
TT
70572019-07-17 Tom Tromey <tom@tromey.com>
7058
7059 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7060 variable.
7061
cf82af05
TT
70622019-07-17 Tom Tromey <tom@tromey.com>
7063
7064 * tui/tui.c (tui_rl_other_window): Update.
7065 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7066 superclass method first. Always iterate over regs_content.
7067 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7068 method.
7069 * tui/tui-win.c (tui_set_focus_command): Update.
7070
01aeb396
TT
70712019-07-17 Tom Tromey <tom@tromey.com>
7072
7073 * tui/tui-win.c (tui_set_focus_command): Rename from
7074 tui_set_focus. Call tui_enable.
7075 (tui_set_focus_command): Remove.
7076
fd6c75ee
TT
70772019-07-17 Tom Tromey <tom@tromey.com>
7078
7079 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7080 refresh_window.
7081 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7082 touchwin.
7083 (tui_data_window::refresh_window): Call refresh_window on data
7084 items. Always call superclass refresh_window.
7085 (tui_win_info::refresh): Remove.
7086 (tui_source_window_base::refresh_window): Update.
7087 (tui_refresh_all): Update.
7088 * tui/tui-layout.c (show_source_disasm_command): Remove call to
7089 refresh_window.
7090 (show_source_or_disasm_and_command): Likewise.
7091 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7092 (struct tui_source_window_base) <refresh>: Likewise.
7093
f6cc34a9
TT
70942019-07-17 Tom Tromey <tom@tromey.com>
7095
7096 * tui/tui-winsource.c (tui_clear_source_content)
7097 (tui_show_source_content): Update.
7098 * tui/tui-source.c (tui_source_window::showing_source_p): Check
7099 whether content is empty.
7100 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7101 Remove.
7102
f31ec9af
TT
71032019-07-17 Tom Tromey <tom@tromey.com>
7104
7105 * tui/tui-winsource.c (tui_erase_source_content): Clear the
7106 window's contents.
7107 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7108 * tui/tui-source.c (tui_set_source_content_nil): Remove.
7109
d1b6f1e5
TT
71102019-07-17 Tom Tromey <tom@tromey.com>
7111
7112 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7113 (struct tui_data_item_window): Update.
7114
d9743a13
TT
71152019-07-17 Tom Tromey <tom@tromey.com>
7116
7117 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7118 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7119 defines.
7120
caf0bc4e
TT
71212019-07-17 Tom Tromey <tom@tromey.com>
7122
7123 * tui/tui-winsource.h (tui_erase_source_content)
7124 (tui_clear_source_content): Remove "display_prompt" parameter.
7125 * tui/tui-winsource.c (tui_update_source_window_as_is)
7126 (tui_update_source_windows_with_addr): Update.
7127 (tui_clear_source_content): Remove "display_prompt" parameter.
7128 (tui_erase_source_content): Likewise. Simplify.
7129 (tui_show_source_content): Update.
7130 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7131 * tui/tui-stack.c (tui_show_frame_info): Update.
7132 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7133 Remove defines.
7134
9d391078
TT
71352019-07-17 Tom Tromey <tom@tromey.com>
7136
7137 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7138 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7139 parameter.
7140 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7141 parameter.
7142
a38da35d
TT
71432019-07-17 Tom Tromey <tom@tromey.com>
7144
7145 * tui/tui-winsource.c (tui_clear_source_content)
7146 (tui_show_source_content, tui_show_exec_info_content)
7147 (tui_clear_exec_info_content): Update.
7148 * tui/tui-stack.c (tui_show_locator_content): Update.
7149 (tui_show_frame_info): Update.
7150 * tui/tui-source.h (tui_source_window): Don't declare.
7151 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7152 from tui_source_is_displayed.
7153 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7154 Remove field.
7155 (struct tui_source_window_base) <content_in_use>: New field. Now
7156 bool.
7157 (struct tui_source_window) <showing_source_p>: New method.
7158 (TUI_SRC_WIN): Change cast.
7159 * tui/tui-data.c (tui_initialize_static_data): Update.
7160
c2cd8994
TT
71612019-07-17 Tom Tromey <tom@tromey.com>
7162
7163 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7164 location_matches_p.
7165 * tui/tui-source.c (tui_source_window::location_matches_p): New
7166 method.
7167 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7168 method.
7169 * tui/tui-data.h (struct tui_source_window_base)
7170 <location_matches_p>: New method.
7171 (struct tui_source_window, struct tui_disasm_window)
7172 <location_matches_p>: Likewise.
7173
4dde7b34
TT
71742019-07-17 Tom Tromey <tom@tromey.com>
7175
7176 * tui/tui-win.c (tui_set_win_height_command): Rename from
7177 tui_set_win_height.
7178 (tui_set_win_height_command): Remove.
7179
b73dd877
TT
71802019-07-17 Tom Tromey <tom@tromey.com>
7181
7182 * tui/tui-source.c (tui_source_window): New constructor. Add
7183 observer.
7184 (~tui_source_window): New destructor.
7185 (tui_source_window::style_changed): New method.
7186 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7187 (tui_attach_detach_observers): Update.
7188 * tui/tui-data.h (struct tui_source_window): Make constructor not
7189 inline. Add destructor.
7190 (struct tui_source_window) <style_changed>: New method.
7191 <m_observable>: New member.
7192
ae2b5380
TT
71932019-07-17 Tom Tromey <tom@tromey.com>
7194
7195 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7196 * tui/tui-win.c (tui_resize_all): Fix typo.
7197
1ce3e844
TT
71982019-07-17 Tom Tromey <tom@tromey.com>
7199
7200 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7201 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7202 (tui_refresh_all): Remove "list" parameter. Use foreach.
7203 * tui/tui-win.c (window_name_completer): Use foreach.
7204 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7205 (update_tab_width): Likewise.
7206 * tui/tui-layout.c (show_layout): Update.
7207 * tui/tui-data.h (class tui_window_iterator): New.
7208 (struct all_tui_windows): New.
7209 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7210
fe3eaf1c
TT
72112019-07-17 Tom Tromey <tom@tromey.com>
7212
7213 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7214 parameter. Don't reference globals.
7215 (tui_reg_command): Update.
7216
368c1354
TT
72172019-07-17 Tom Tromey <tom@tromey.com>
7218
7219 * tui/tui-regs.c (tui_show_registers): Simplify.
7220
e80cd204
TT
72212019-07-17 Tom Tromey <tom@tromey.com>
7222
7223 * tui/tui-regs.c (tui_show_registers): Update.
7224 (tui_show_register_group): Add win_info parameter.
7225
aca2dd16
TT
72262019-07-17 Tom Tromey <tom@tromey.com>
7227
7228 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7229 Rename from tui_display_reg_element_at_line.
7230 (tui_data_window::display_registers_from_line): Update.
7231 * tui/tui-data.h (struct tui_data_window)
7232 <display_reg_element_at_line>: New method.
7233
517e9505
TT
72342019-07-17 Tom Tromey <tom@tromey.com>
7235
7236 * tui/tui-regs.h (tui_display_registers_from)
7237 (tui_display_registers_from_line): Don't declare.
7238 * tui/tui-windata.c (tui_data_window::display_all_data)
7239 (tui_data_window::refresh_all)
7240 (tui_data_window::do_scroll_vertical): Update.
7241 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7242 from tui_display_registers_from.
7243 (tui_display_reg_element_at_line): Update.
7244 (tui_data_window::display_registers_from_line): Rename from
7245 tui_display_registers_from_line.
7246 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7247 display_registers_from_line>: New methods.
7248
f76d8b19
TT
72492019-07-17 Tom Tromey <tom@tromey.com>
7250
7251 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7252 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7253 from tui_erase_data_content.
7254 (tui_data_window::display_all_data)
7255 (tui_data_window::refresh_all)
7256 (tui_data_window::do_scroll_vertical): Update.
7257 * tui/tui-regs.c (tui_show_registers): Update.
7258 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7259 New method.
7260
b4094625
TT
72612019-07-17 Tom Tromey <tom@tromey.com>
7262
7263 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7264 declare.
7265 * tui/tui-windata.c
7266 (tui_data_window::delete_data_content_windows): Rename from
7267 tui_delete_data_content_windows.
7268 (tui_data_window::display_all_data)
7269 (tui_data_window::do_scroll_vertical): Update.
7270 * tui/tui-data.h (struct tui_data_window)
7271 <delete_data_content_windows>: New method.
7272
c223a729
TT
72732019-07-17 Tom Tromey <tom@tromey.com>
7274
7275 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7276 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7277
50daf268
TT
72782019-07-17 Tom Tromey <tom@tromey.com>
7279
7280 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7281 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7282 from tui_display_all_data.
7283 * tui/tui-win.c
7284 (tui_data_window::do_make_visible_with_new_height): Update.
7285 * tui/tui-regs.c (tui_show_registers): Update.
7286 * tui/tui-layout.c (tui_set_layout): Update.
7287 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7288 method.
7289
df5f8cab
TT
72902019-07-17 Tom Tromey <tom@tromey.com>
7291
7292 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7293 * tui/tui-windata.c (tui_display_data_from): Remove.
7294 (tui_data_window::refresh_all): Update.
7295
80cb6c27
TT
72962019-07-17 Tom Tromey <tom@tromey.com>
7297
7298 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7299 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7300 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7301 tui_display_registers_from_line.
7302 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7303 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7304 "force_display" parameter.
7305
baff0c28
TT
73062019-07-17 Tom Tromey <tom@tromey.com>
7307
7308 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7309 declare.
7310 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7311 Rename from tui_first_reg_element_no_inline.
7312 (tui_display_reg_element_at_line)
7313 (tui_display_registers_from_line): Update.
7314 * tui/tui-data.h (struct tui_data_window)
7315 <first_reg_element_no_inline>: New method.
7316
3b23c5f2
TT
73172019-07-17 Tom Tromey <tom@tromey.com>
7318
7319 * tui/tui-windata.c (tui_display_data_from)
7320 (tui_data_window::do_scroll_vertical): Update.
7321 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7322 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7323 Rename from tui_line_from_reg_element_no.
7324 (tui_display_registers_from_line): Update.
7325 * tui/tui-data.h (struct tui_data_window)
7326 <line_from_reg_element_no>: New method.
7327
0b5ec218
TT
73282019-07-17 Tom Tromey <tom@tromey.com>
7329
7330 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7331 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7332 tui_last_regs_line_no.
7333 (tui_display_reg_element_at_line)
7334 (tui_display_registers_from_line): Update.
7335 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7336 method.
7337
0807ab7b
TT
73382019-07-17 Tom Tromey <tom@tromey.com>
7339
7340 PR tui/24722:
7341 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7342 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7343 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7344 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7345 (tui_update_breakpoint_info): Likewise.
7346 * tui/tui-hooks.c (tui_event_create_breakpoint)
7347 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7348 Update.
7349
9ad7fdef
TT
73502019-07-17 Tom Tromey <tom@tromey.com>
7351
7352 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7353
5813316f
TT
73542019-07-17 Tom Tromey <tom@tromey.com>
7355
7356 * tui/tui-winsource.c (tui_update_source_window_as_is)
7357 (tui_update_source_windows_with_addr): Update.
7358 * tui/tui-source.h (tui_set_source_content)
7359 (tui_show_symtab_source): Add "win_info" parameter.
7360 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7361 parameter.
7362 (tui_show_symtab_source): Likewise.
7363
00e264e7
TT
73642019-07-17 Tom Tromey <tom@tromey.com>
7365
7366 * tui/tui-wingeneral.c
7367 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7368
06210ce4
TT
73692019-07-17 Tom Tromey <tom@tromey.com>
7370
7371 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7372 (struct tui_cmd_window) <can_scroll>: New method.
7373 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7374 method.
7375
381befee
TT
73762019-07-17 Tom Tromey <tromey@adacore.com>
7377
7378 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7379 do_field_signed>: Rename. Change type of "value".
7380 * ui-out.c (ui_out::field_signed): Rename from field_int.
7381 Change type of "value".
7382 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7383 type of "value".
7384 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7385 do_field_int. Change type of "value".
7386 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7387 do_field_int. Change type of "value".
7388 * tracepoint.c (trace_status_mi, tfind_1)
7389 (print_one_static_tracepoint_marker): Update.
7390 * thread.c (print_thread_info_1, print_selected_thread_frame):
7391 Update.
7392 * stack.c (print_frame, print_frame_info): Update.
7393 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7394 Update.
7395 * source.c (print_source_lines_base): Update.
7396 * skip.c (info_skip_command): Update.
7397 * record-btrace.c (btrace_ui_out_decode_error)
7398 (btrace_call_history_src_line): Update.
7399 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7400 Update.
7401 * progspace.c (print_program_space): Update.
7402 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7403 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7404 do_field_int. Change type of "value".
7405 * mi/mi-out.c (mi_ui_out::do_table_begin)
7406 (mi_ui_out::do_table_header): Update.
7407 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7408 type of "value".
7409 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7410 (mi_cmd_data_list_changed_registers, output_register)
7411 (mi_cmd_data_read_memory, mi_load_progress)
7412 (mi_cmd_trace_frame_collected): Update.
7413 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7414 Update.
7415 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7416 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7417 (mi_cmd_var_list_children, varobj_update_one): Update.
7418 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7419 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7420 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7421 * inferior.c (print_inferior): Update.
7422 * gdb_bfd.c (print_one_bfd): Update.
7423 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7424 Update.
7425 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7426 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7427 do_field_int. Change type of "value".
7428 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7429 do_field_int. Change type of "value".
7430 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7431 (print_one_breakpoint_location, print_it_catch_fork)
7432 (print_one_catch_fork, print_it_catch_vfork)
7433 (print_one_catch_vfork, print_it_catch_solib)
7434 (print_it_catch_exec, print_it_ranged_breakpoint)
7435 (print_mention_watchpoint, print_mention_masked_watchpoint)
7436 (bkpt_print_it, update_static_tracepoint): Update.
7437 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7438 * break-catch-syscall.c (print_it_catch_syscall): Update.
7439 * ada-tasks.c (print_ada_task_info): Update.
7440 * ada-lang.c (print_it_exception, print_mention_exception):
7441 Update.
7442
6b78c3f8
AB
74432019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7444
7445 PR breakpoints/24541
7446 * gdbarch.c: Regenerate.
7447 * gdbarch.h: Regenerate.
7448 * gdbarch.sh: Adjust return type and parameter types for
7449 'stap_adjust_register'.
7450 (i386_stap_adjust_register): Adjust signature and return new
7451 register name.
7452 * stap-probe.c (stap_parse_register_operand): Adjust use of
7453 'gdbarch_stap_adjust_register'.
7454
d72a9b85
TT
74552019-07-17 Tom Tromey <tromey@adacore.com>
7456
7457 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7458 declare VEC.
7459 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7460 std::vector.
7461 (struct s390_process_info): Add initializers.
7462 (s390_add_process): Use new.
7463 (s390_linux_nat_target::low_forget_process): Use delete.
7464 (s390_linux_nat_target::low_new_fork)
7465 (s390_linux_nat_target::stopped_by_watchpoint)
7466 (s390_linux_nat_target::low_prepare_to_resume)
7467 (s390_linux_nat_target::insert_watchpoint)
7468 (s390_linux_nat_target::insert_hw_breakpoint)
7469 (s390_linux_nat_target::remove_watchpoint)
7470 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7471
206e6c58
JB
74722019-07-16 John Baldwin <jhb@FreeBSD.org>
7473
7474 * aarch64-fbsd-nat.c: Include regcache.h.
7475 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7476 argument.
7477 (aarch64_fbsd_nat_target::fetch_registers)
7478 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7479 variable.
7480 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7481
cbde90f2
JB
74822019-07-16 John Baldwin <jhb@FreeBSD.org>
7483
7484 * fbsd-nat.c: Include gdbarch.h.
7485
07128006
TT
74862019-07-15 Tom Tromey <tromey@adacore.com>
7487
7488 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7489
1f77b012
TT
74902019-07-15 Tom Tromey <tromey@adacore.com>
7491
7492 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7493 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7494 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7495 * cli-out.c (cli_ui_out::do_field_int): New method.
7496 * ui-out.c (ui_out::field_unsigned): New method.
7497 * symfile.c (generic_load): Use field_unsigned.
7498 (print_transfer_performance): Likewise.
7499 * record-btrace.c (ui_out_field_uint): Remove.
7500 (btrace_call_history_insn_range, btrace_call_history): Use
7501 field_unsigned.
7502 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7503 field_unsigned.
7504 * ui-out.h (class ui_out) <field_unsigned>: New method.
7505 <do_field_unsigned>: Likewise.
7506
33eca680
TT
75072019-07-15 Tom Tromey <tromey@adacore.com>
7508
7509 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7510 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7511 * target.c (flash_erase_command): Use field_string.
7512 * infrun.c (print_signal_received_reason): Use field_string.
7513 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7514 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7515 field_string.
7516 * ada-tasks.c (print_ada_task_info): Use field_string.
7517
ca8d69be
TT
75182019-07-15 Tom Tromey <tromey@adacore.com>
7519
7520 * target.c (flash_erase_command): Use field_core_addr.
7521 * symfile.c (generic_load): Use field_core_addr.
7522 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7523 Use field_core_addr.
7524 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7525 field_core_addr.
7526
0d4e84ed
AB
75272019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7528
7529 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7530 value if its desired type is smaller than a CORE_ADDR and signed.
7531
9a49df9d
AB
75322019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7533
7534 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7535 of changes to field names, and use new is_reference field to
7536 decide if a property is a reference or not.
7537 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7538 field.
7539 (struct dwarf2_property_baton): Update header comment, rename
7540 'referenced_type' to 'property_type' and update comments.
7541 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7542 default property type, store in property baton, update to take
7543 accound of renamed field.
7544 (read_func_scope): Update call to attr_to_dynamic_prop.
7545 (read_array_type): Likewise.
7546 (dwarf2_per_cu_addr_sized_int_type): New function.
7547 (read_subrange_index_type): Move type finding code to
7548 dwarf2_per_cu_addr_sized_int_type.
7549 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7550 (dwarf2_per_cu_addr_type): New function.
7551 (set_die_type): Update calls to attr_to_dynamic_prop.
7552
b86352cf
AB
75532019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7554
7555 * dwarf2read.c (read_subrange_index_type): New function.
7556 (read_subrange_type): Move code into new function and call it.
7557 * gdbtypes.c (create_range_type): Add some asserts.
7558
603490bf
AB
75592019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7560
7561 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7562 update return statements.
7563 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7564 declaration, and update comment to match.
7565 * gdbtypes.c (resolve_dynamic_array): Update call to
7566 dwarf2_evaluate_property to match new return type.
7567
592f9d27
AB
75682019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7569
7570 * valarith.c (value_subscripted_rvalue): Change lowerbound
7571 parameter type from int to LONGEST.
7572 * value.h (value_subscripted_rvalue): Likewise in declaration.
7573
60cfcb20
AB
75742019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7575
7576 * cli/cli-utils.c (info_print_command_completer): New function.
7577 * cli/cli-utils.h: Add 'completer.h' include, and forward
7578 declaration for 'struct cmd_list_element'.
7579 (info_print_command_completer): Declare.
7580 * stack.c (_initialize_stack): Add completer for 'info locals' and
7581 'info args'.
7582 * symtab.c (_initialize_symtab): Add completer for 'info
7583 variables' and 'info functions'.
7584 * NEWS: Mention completion for additional info commands.
7585
b16507e0
AB
75862019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7587
7588 * cli/cli-utils.c (extract_info_print_args): Delete.
7589 (extract_arg_maybe_quoted): Delete.
7590 (info_print_options_defs): New variable.
7591 (make_info_print_options_def_group): New function.
7592 (extract_info_print_options): Define new function.
7593 * cli/cli-utils.h (extract_info_print_args): Delete.
7594 (struct info_print_options): New structure.
7595 (extract_info_print_options): Declare new function.
7596 * stack.c (info_locals_command): Update to use new
7597 extract_info_print_options, also add a header comment.
7598 (info_args_command): Likewise.
7599 * symtab.c (info_variables_command): Likewise.
7600 (info_functions_command): Likewise.
7601
021d8588
AB
76022019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7603
7604 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7605 to extract string arguments.
7606 * common/common-utils.c (extract_string_maybe_quoted): New function.
7607 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7608
b777eb6d
TT
76092019-07-11 Tom Tromey <tromey@adacore.com>
7610
7611 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7612 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7613 * top.h (gdbinit): Don't declare.
7614 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7615 into...
7616 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7617 * top.c (gdb_init): Don't call init_cli_cmds.
7618 (gdbinit): Remove.
7619 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7620
72ee03ff
TT
76212019-07-11 Tom Tromey <tromey@adacore.com>
7622
7623 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7624 after it has been moved.
7625
00db9531
SM
76262019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7627
7628 * valops.c (value_must_coerce_to_target): Change return type to
7629 bool.
7630 * value.h (value_must_coerce_to_target): Likewise.
7631
f2478a7e
SM
76322019-07-10 Simon Marchi <simon.marchi@efficios.com>
7633
7634 * breakpoint.c (is_hardware_watchpoint): Remove
7635 forward-declaration.
7636 (is_masked_watchpoint): Change return type to bool.
7637 (is_tracepoint): Likewise.
7638 (is_breakpoint): Likewise.
7639 (is_hardware_watchpoint): Likewise.
7640 (is_watchpoint): Likewise.
7641 (is_no_memory_software_watchpoint): Likewise.
7642 (is_catchpoint): Likewise.
7643 (breakpoint_1): Make FILTER parameter's return type bool.
7644 is_masked_watchpoint): Change return type to bool.
7645 (save_breakpoints): Make FILTER parameter's return type bool.
7646 * breakpoint.h (is_breakpoint): Change return type to bool.
7647 (is_watchpoint): Likewise.
7648 (is_catchpoint): Likewise.
7649 (is_tracepoint): Likewise.
7650
0d12e84c
TT
76512019-07-10 Tom Tromey <tom@tromey.com>
7652
7653 * defs.h: Don't include gdbarch.h.
7654 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7655 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7656 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7657 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7658 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7659 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7660 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7661 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7662 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7663 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7664 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7665 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7666 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7667 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7668 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7669 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7670 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7671 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7672 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7673 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7674 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7675 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7676 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7677 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7678 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7679 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7680 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7681
f06f1252
TT
76822019-07-10 Tom Tromey <tromey@adacore.com>
7683
7684 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7685 * breakpoint.c (init_ada_exception_breakpoint): Register as
7686 bp_catchpoint.
7687 (print_one_breakpoint_location, print_one_breakpoint): Use
7688 is_ada_exception_catchpoint.
7689 * ada-lang.c (class ada_catchpoint_location): Pass
7690 bp_loc_software_breakpoint to bp_location constructor.
7691 (is_ada_exception_catchpoint): New function.
7692
7a5d944b
TT
76932019-07-10 Tom Tromey <tromey@adacore.com>
7694
7695 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7696 VEC.
7697 (struct arm_exidx_entry): New method operator<.
7698 (struct arm_exidx_data) <section_maps>: Change type.
7699 (arm_exidx_data_free): Remove.
7700 (arm_exidx_data_key): Change type. Move lower.
7701 (arm_exidx_new_objfile): Update.
7702 (arm_compare_exidx_entries): Remove.
7703 (arm_find_exidx_entry, _initialize_arm_tdep)
7704
48c66e1d
TT
77052019-07-10 Tom Tromey <tromey@adacore.com>
7706
7707 * solib-spu.c (ocl_program_data_key): Change type.
7708 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7709 Update.
7710
a269fbf1
TT
77112019-07-10 Tom Tromey <tromey@adacore.com>
7712
7713 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7714 (struct solib_aix_inferior_data) <library_list>: Change type.
7715 (solib_aix_inferior_data_handle): Change type.
7716 (get_solib_aix_inferior_data): Update.
7717 (solib_aix_free_library_list): Remove.
7718 (library_list_start_library): Update.
7719 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7720 return type.
7721 (solib_aix_get_library_list)
7722 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7723 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7724
c294730c
TT
77252019-07-10 Tom Tromey <tromey@adacore.com>
7726
7727 * solib-dsbt.c (struct dsbt_info): Add initializers.
7728 (solib_dsbt_pspace_data): Change type.
7729 (dsbt_pspace_data_cleanup): Remove.
7730 (get_dsbt_info, _initialize_dsbt_solib): Update.
7731
9d52077d
TT
77322019-07-10 Tom Tromey <tromey@adacore.com>
7733
7734 * spu-tdep.c (spu_overlay_data): Change type.
7735 (spu_get_overlay_table, spu_overlay_new_objfile)
7736 (_initialize_spu_tdep): Update.
7737
22a20dca
TT
77382019-07-10 Tom Tromey <tromey@adacore.com>
7739
7740 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7741 destructor.
7742 (dbx_objfile_data_key): Change type and declare later.
7743 (DBX_SYMFILE_INFO): Rewrite.
7744 * dbxread.c (dbx_objfile_data_key): Change type.
7745 (dbx_symfile_init): Update.
7746 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7747 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7748 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7749
cb60f420
TT
77502019-07-10 Tom Tromey <tromey@adacore.com>
7751
7752 * jit.c (jit_program_space_key): Change type. Move lower.
7753 (get_jit_program_space_data): Update.
7754 (jit_program_space_data_cleanup): Remove.
7755 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7756 Update.
7757 (struct jit_program_space_data): Add initializers.
7758
51df2ae3
TT
77592019-07-10 Tom Tromey <tromey@adacore.com>
7760
7761 * solib-darwin.c (struct darwin_info): Add initializers.
7762 (solib_darwin_pspace_data): Change type.
7763 (darwin_pspace_data_cleanup): Remove.
7764 (get_darwin_info, _initialize_darwin_solib): Update.
7765
18101a35
TT
77662019-07-10 Tom Tromey <tromey@adacore.com>
7767
7768 * remote-sim.c (struct sim_inferior_data): Add initializers,
7769 constructor, and destructor.
7770 (sim_inferior_data_key): Change type. Move lower.
7771 (check_for_duplicate_sim_descriptor): Update.
7772 (get_sim_inferior_data): Use new. Update.
7773 (~sim_inferior_data_cleanup): Rename from
7774 sim_inferior_data_cleanup. Simplify.
7775 (gdbsim_close_inferior, simulator_command)
7776 (sim_command_completer, _initialize_remote_sim): Update.
7777 (next_pid, INITIAL_PID): Move earlier.
7778
05b08ac1
TT
77792019-07-10 Tom Tromey <tromey@adacore.com>
7780
7781 * python/python-internal.h (create_thread_object): Return
7782 gdbpy_ref.
7783 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7784 * python/py-inferior.c (struct threadlist_entry): Add
7785 constructor.
7786 <thread_obj>: Now a gdbpy_ref.
7787 (thread_to_thread_object): Update.
7788 (add_thread_object): Use new.
7789 (delete_thread_object): Use delete.
7790 (infpy_threads): Update.
7791 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7792 GIL.
7793
32372d80
TT
77942019-07-10 Tom Tromey <tromey@adacore.com>
7795
7796 * valops.c (value_cast): Specialize error message for Ada.
7797
5c458ae8
SM
77982019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7799
7800 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7801
4c462cb0
SM
78022019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7803
7804 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7805 bpstat_should_step): Return bool, adjust comments.
7806 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7807 bpstat_should_step): Likewise.
7808
89abbcc2
AH
78092019-07-10 Alan Hayward <alan.hayward@arm.com>
7810
7811 * features/Makefile: Use feature target descriptions for Arm.
7812 * features/arm/arm-core.c: Generate new file.
7813 * features/arm/arm-fpa.c: Likewise.
7814 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7815 * features/arm/arm-m-profile.c: Likewise.
7816 * features/arm/arm-vfpv2.c: Likewise.
7817 * features/arm/arm-vfpv3.c: Likewise.
7818 * features/arm/xscale-iwmmxt.c: Likewise.
7819 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7820
166a82be
AH
78212019-07-10 Alan Hayward <alan.hayward@arm.com>
7822
7823 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7824 ptrace earlier.
7825
9fb4c7e9
AH
78262019-07-10 Alan Hayward <alan.hayward@arm.com>
7827
7828 * features/aarch64-pauth.c: Regenerate.
7829
e2d0f980
SM
78302019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7831
7832 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7833 bool.
7834 (bpstat_what): Use false instead of 0.
7835
a38118e5
PA
78362019-07-09 Pedro Alves <palves@redhat.com>
7837
7838 * break-catch-throw.c (is_exception_catchpoint): New.
7839 * breakpoint.c (print_one_breakpoint_location): New parameter
7840 'raw_loc'. Handle it. Use
7841 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7842 looking at the breakpoint's type.
7843 (print_one_breakpoint): If handling "maint info breakpoints", also
7844 print locations of exception catchpoints.
7845 * breakpoint.h (is_exception_catchpoint): Declare.
7846
cb1e4e32
PA
78472019-07-09 Pedro Alves <palves@redhat.com>
7848
7849 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7850 "addr" field.
7851 (allocate_location_exception_catchpoint): New.
7852 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7853 (initialize_throw_catchpoint_ops): Install
7854 allocate_location_exception_catchpoint as allocate_location
7855 method.
7856 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7857 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7858 bp_loc_other.
7859 (breakpoint_address_is_meaningful): Delete.
7860 (bl_address_is_meaningful): New.
7861 (breakpoint_locations_match): Adjust comment.
7862 (bp_location_from_bp_type): New, factored out of...
7863 (bp_location::bp_location(breakpoint *)): ... this.
7864 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7865 factored out of...
7866 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7867 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7868 breakpoint_address_is_meaningful.
7869 (bp_locations_compare): Adjust comment.
7870 (update_global_location_list): Use bl_address_is_meaningful
7871 instead of breakpoint_address_is_meaningful.
7872 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7873 explicit.
7874 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7875 * python/py-breakpoint.c (bppy_get_location): No longer check
7876 whether location is null.
7877
b58a68fe
PA
78782019-07-09 Pedro Alves <palves@redhat.com>
7879
7880 PR c++/15468
7881 * breakpoint.c (print_one_breakpoint_location): Remove
7882 single-location assert.
7883
268a13a5
TT
78842019-07-09 Tom Tromey <tom@tromey.com>
7885
7886 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7887 * configure: Rebuild.
7888 * configure.ac: Change common to gdbsupport.
7889 * gdbsupport: Rename from common.
7890 * acinclude.m4: Change common to gdbsupport.
7891 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7892 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7893 gdbsupport.
7894 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7895 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7896 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7897 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7898 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7899 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7900 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7901 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7902 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7903 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7904 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7905 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7906 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7907 coff-pe-read.c, command.h, compile/compile-c-support.c,
7908 compile/compile-c.h, compile/compile-cplus-symbols.c,
7909 compile/compile-cplus-types.c, compile/compile-cplus.h,
7910 compile/compile-loc2c.c, compile/compile.c, completer.c,
7911 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7912 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7913 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7914 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7915 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7916 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7917 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7918 features/aarch64-core.c, features/aarch64-fpu.c,
7919 features/aarch64-pauth.c, features/aarch64-sve.c,
7920 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7921 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7922 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7923 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7924 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7925 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7926 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7927 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7928 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7929 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7930 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7931 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7932 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7933 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7934 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7935 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7936 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7937 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7938 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7939 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7940 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7941 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7942 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7943 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7944 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7945 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7946 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7947 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7948 minsyms.c, mips-linux-tdep.c, namespace.h,
7949 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7950 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7951 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7952 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7953 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7954 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7955 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7956 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7957 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7958 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7959 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7960 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7961 procfs.c, producer.c, progspace.h, psymtab.h,
7962 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7963 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7964 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7965 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7966 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7967 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7968 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7969 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7970 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7971 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7972 target-memory.c, target.c, target.h, target/waitstatus.c,
7973 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7974 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7975 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7976 unittests/array-view-selftests.c,
7977 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7978 unittests/common-utils-selftests.c,
7979 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7980 unittests/format_pieces-selftests.c,
7981 unittests/function-view-selftests.c,
7982 unittests/lookup_name_info-selftests.c,
7983 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7984 unittests/mkdir-recursive-selftests.c,
7985 unittests/observable-selftests.c,
7986 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7987 unittests/parse-connection-spec-selftests.c,
7988 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7989 unittests/scoped_fd-selftests.c,
7990 unittests/scoped_mmap-selftests.c,
7991 unittests/scoped_restore-selftests.c,
7992 unittests/string_view-selftests.c, unittests/style-selftests.c,
7993 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7994 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7995 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7996 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7997 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7998 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7999
5b0e2db4
AB
80002019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8001
8002 * linespec.c (decode_digits_list_mode): Set explicit_line to a
8003 bool value.
8004 (decode_digits_ordinary): Set explicit_line field in sal.
8005 * symtab.c (skip_prologue_sal): Don't skip prologue for a
8006 symtab_and_line that was set on an explicit line number in
8007 assembler code. Do always update the recorded symtab and line if
8008 we do skip the prologue.
8009
0ba852ab
AB
80102019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8011
8012 * breakpoint.c (set_breakpoint_location_function): Remove
8013 explicit_loc parameter.
8014 (momentary_breakpoint_from_master): Update call to
8015 set_breakpoint_location_function.
8016 (add_location_to_breakpoint): Likewise.
8017
b3a7d171
AB
80182019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8019
8020 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8021 required features based on default bfd type when no specific bfd
8022 is present.
8023
1f6f6e21
PW
80242019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8025
8026 * NEWS: Mention that GDB printf and eval commands can now print
8027 C-style and Ada-style convenience var strings without
8028 calling the inferior.
8029 * printcmd.c (printf_c_string): Locally print GDB internal var
8030 instead of transiting via the inferior.
8031 (printf_wide_c_string): Likewise.
8032
80332019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 8034
5862c886 8035 PR breakpoints/25011
ea142fbf
AH
8036 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8037
0598af48
TT
80382019-07-04 Tom Tromey <tom@tromey.com>
8039
8040 PR tui/24724:
8041 * tui/tui-winsource.c (tui_clear_source_content): Update.
8042 (tui_source_window_base::set_is_exec_point_at): Fix comment.
8043 (tui_update_breakpoint_info): Update.
8044 (tui_set_exec_info_content): Update.
8045 * tui/tui-source.c (tui_set_source_content_nil): Update.
8046 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8047 has_break.
8048 * tui/tui-data.h (enum tui_bp_flag): New.
8049 (tui_bp_flags): New enum flags type.
8050 (struct tui_source_element) <break_mode>: Change type. Rename
8051 from has_break.
8052 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8053 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
8054 constants.
8055 * tui/tui-winsource.h: Fix comment.
8056
350fab54
AH
80572019-07-04 Alan Hayward <alan.hayward@arm.com>
8058
8059 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8060 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8061 (store_fpregs_to_thread)
8062 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8063 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8064 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8065 (IWMMXT_REGS_SIZE): Add define.
8066 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8067 (fetch_vfp_regs, store_vfp_regs)
8068 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8069 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8070
f0452268
AH
80712019-07-04 Alan Hayward <alan.hayward@arm.com>
8072
8073 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8074 defines.
8075 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8076 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8077 (ARM_INT_REGISTER_SIZE): ...to this.
8078 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8079 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8080 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8081 (arm_linux_collect_gregset, supply_nwfpe_register)
8082 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8083 defines.
8084 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8085 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8086 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8087 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8088 (arm_return_in_memory, arm_store_return_value)
8089 (arm_get_longjmp_target, arm_register_g_packet_guesses)
8090 (arm_record_ld_st_multiple): Likewise.
8091 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8092 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8093
e935475c
AH
80942019-07-04 Alan Hayward <alan.hayward@arm.com>
8095
8096 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8097 AARCH64_DISPLACED_MODIFIED_INSNS.
8098 * aarch64-tdep.c (struct aarch64_displaced_step_data)
8099 (aarch64_displaced_step_copy_insn): Likewise.
8100 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8101 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8102 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8103 ARM_DISPLACED_MODIFIED_INSNS.
8104 * arm-tdep.c (arm_gdbarch_init): Likewise.
8105 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8106 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8107 (struct arm_displaced_step_closure): Use
8108 ARM_DISPLACED_MODIFIED_INSNS.
8109
df0bb381
AH
81102019-07-04 Alan Hayward <alan.hayward@arm.com>
8111
8112 * features/Makefile: Remove unused xml files.
8113 * features/aarch64.xml: Remove.
8114 * features/i386/amd64-avx-avx512-linux.xml: Remove.
8115 * features/i386/amd64-avx-avx512.xml: Remove.
8116 * features/i386/amd64-avx-linux.xml: Remove.
8117 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8118 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8119 * features/i386/amd64-avx-mpx-linux.xml: Remove.
8120 * features/i386/amd64-avx-mpx.xml: Remove.
8121 * features/i386/amd64-avx.xml: Remove.
8122 * features/i386/amd64-linux.xml: Remove.
8123 * features/i386/amd64-mpx-linux.xml: Remove.
8124 * features/i386/amd64-mpx.xml: Remove.
8125 * features/i386/amd64.xml: Remove.
8126 * features/i386/i386-avx-avx512-linux.xml: Remove.
8127 * features/i386/i386-avx-avx512.xml: Remove.
8128 * features/i386/i386-avx-linux.xml: Remove.
8129 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8130 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8131 * features/i386/i386-avx-mpx-linux.xml: Remove.
8132 * features/i386/i386-avx-mpx.xml: Remove.
8133 * features/i386/i386-avx.xml: Remove.
8134 * features/i386/i386-linux.xml: Remove.
8135 * features/i386/i386-mmx-linux.xml: Remove.
8136 * features/i386/i386-mmx.xml: Remove.
8137 * features/i386/i386-mpx-linux.xml: Remove.
8138 * features/i386/i386-mpx.xml: Remove.
8139 * features/i386/i386.xml: Remove.
8140 * features/i386/x32-avx-avx512-linux.xml: Remove.
8141 * features/i386/x32-avx-linux.xml: Remove.
8142 * features/i386/x32-linux.xml: Remove.
8143
edd6266a
AH
81442019-07-04 Alan Hayward <alan.hayward@arm.com>
8145
8146 * regformats/aarch64.dat: Remove.
8147 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8148 * regformats/i386/amd64-avx-linux.dat: Remove.
8149 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8150 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8151 * regformats/i386/amd64-linux.dat: Remove.
8152 * regformats/i386/amd64-mpx-linux.dat: Remove.
8153 * regformats/i386/amd64.dat: Remove.
8154 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8155 * regformats/i386/i386-avx-linux.dat: Remove.
8156 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8157 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8158 * regformats/i386/i386-linux.dat: Remove.
8159 * regformats/i386/i386-mmx-linux.dat: Remove.
8160 * regformats/i386/i386-mpx-linux.dat: Remove.
8161 * regformats/i386/i386.dat: Remove.
8162 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8163 * regformats/i386/x32-avx-linux.dat: Remove.
8164 * regformats/i386/x32-linux.dat: Remove.
8165
2b40fda7
AH
81662019-07-04 Alan Hayward <alan.hayward@arm.com>
8167
8168 * aarch64-tdep.c: Remove xml self tests.
8169 * amd64-linux-tdep.c: Likewise.
8170 * amd64-tdep.c: Likewise.
8171 * i386-linux-tdep.c: Likewise.
8172 * i386-tdep.c: Likewise.
8173
5f4ba3e7
PA
81742019-07-03 Pedro Alves <palves@redhat.com>
8175
8176 PR cli/24732
8177 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8178 (pipe_cmd_option_defs): New.
8179 (make_pipe_cmd_options_def_group): New.
8180 (pipe_command): Use gdb::option::process_options.
8181 (pipe_command_completer): New function.
8182 (_initialize_cli_cmds): Install completer for "pipe" command.
8183
3d9be6f5
PA
81842019-07-03 Pedro Alves <palves@redhat.com>
8185
8186 * cli/cli-option.c (union option_value) <string>: New field.
8187 (struct option_def_and_value): Add ctor, move ctor, dtor and
8188 use DISABLE_COPY_AND_ASSIGN.
8189 (option_def_and_value::clear_value): New.
8190 (parse_option, save_option_value_in_ctx, get_val_type_str)
8191 (add_setshow_cmds_for_options): Handle var_string.
8192 * cli-option.h (union option_def::var_address) <string>: New
8193 field.
8194 (struct string_option_def): New.
8195 * maint-test-options.c (struct test_options_opts): Add default
8196 ctor and use DISABLE_COPY_AND_ASSIGN.
8197 <string_opt>: New field.
8198 (test_options_opts::~test_options_opts): New.
8199 (test_options_opts::dump): Also dump "-string".
8200 (test_options_option_defs): Install "string.
8201
41fc454c
PA
82022019-07-03 Pedro Alves <palves@redhat.com>
8203
8204 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8205 option_value with a null enumeration.
8206 (complete_options): Save the option values in the context.
8207 (save_option_value_in_ctx): New, factored out from ...
8208 (process_options): ... here.
8209 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8210 of the function.
8211 * maint-test-options.c (test_options_opts::dump): New, factored
8212 out from ...
8213 (maintenance_test_options_command_mode): ... here.
8214 (maintenance_test_options_command_completion_result): Delete.
8215 (maintenance_test_options_command_completion_text): Update
8216 comment.
8217 (maintenance_show_test_options_completion_result): Change
8218 prototype. Just print
8219 maintenance_test_options_command_completion_text.
8220 (save_completion_result): New.
8221 (maintenance_test_options_completer_mode): Pass options context to
8222 complete_options, and then save a dump.
8223 (_initialize_maint_test_options): Use add_cmd to install "maint
8224 show test-options-completion-result".
8225
fdbc9870
PA
82262019-07-03 Pedro Alves <palves@redhat.com>
8227
8228 * NEWS (New commands): Mention "with" and "maint with".
8229 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8230 (with_command, with_command_completer): New.
8231 (pipe_command): Adjust to new repeat_previous
8232 interface.
8233 (_initialize_cli_cmds): Install the "with" command and its "w"
8234 alias.
8235 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8236 declarations.
8237 * cli/cli-setshow.c (parse_cli_var_uinteger)
8238 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8239 argument strings for all var_types.
8240 (get_setshow_command_value_string): New, factored out from ...
8241 (do_show_command): ... this.
8242 * cli/cli-setshow.h: Include <string>.
8243 (get_setshow_command_value_string): Declare.
8244 * command.h (repeat_previous): Now returns const char *. Adjust
8245 comment.
8246 * maint.c: Include "cli/cli-cmds.h".
8247 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8248 (_initialize_maint_cmds): Register the "maintenance with" command.
8249 * top.c (repeat_previous): Move bits from pipe_command here:
8250 Return the saved command line, if any; error out if there's no
8251 command to relaunch.
8252
c6ac8931
PA
82532019-07-03 Pedro Alves <palves@redhat.com>
8254
8255 * NEWS (New commands): Mention "maint set/show test-settings"
8256 instead of "maint test-settings".
8257 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8258 (maintenance_test_settings_set_list): Rename to ...
8259 (maintenance_set_test_settings_list): ... this.
8260 (maintenance_test_settings_show_list): Rename to ...
8261 (maintenance_show_test_settings_list): ... this.
8262 (maintenance_test_settings_cmd): Delete.
8263 (maintenance_test_settings_set_cmd): ...
8264 (maintenance_set_test_settings_cmd): ... this.
8265 (maintenance_test_settings_show_cmd): ...
8266 (maintenance_show_test_settings_cmd): ... this.
8267 (maintenance_test_settings_show_value_cmd):
8268 (maintenance_show_test_settings_value_cmd): ... this.
8269 (_initialize_maint_test_settings): No longer install the "maint
8270 test-settings" prefix command. Rename "maint test-settings set"
8271 to "maint set test-settings", and "maint test-settings show" to
8272 "maint show test-settings". Adjust all subcommands.
8273
d1fcf2fd
PA
82742019-07-03 Pedro Alves <palves@redhat.com>
8275
8276 * maint-test-settings.c: Fix file's intro comment. Replace all
8277 references to "test-options" with references to "test-settings",
8278 in comments.
8279
970f9d09
PA
82802019-07-03 Pedro Alves <palves@redhat.com>
8281
8282 * maint-test-settings.c (maintenance_test_settings_xxx)
8283 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8284 New.
8285 (maintenance_test_settings_enums): Use them.
8286 (maintenance_test_settings_enum): Default to
8287 maintenance_test_settings_xxx.
8288 (_initialize_maint_test_settings): Initialize
8289 MAINTENANCE_TEST_SETTINGS_FILENAME.
8290
f3869b1a
SM
82912019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8292
8293 * breakpoint.h (remove_breakpoints_inf): Change return type to
8294 void, move function documentation here.
8295 * breakpoint.c (remove_breakpoints_inf): Change return type to
8296 void, move function documentation to header.
8297
54d66006
PA
82982019-07-02 Pedro Alves <palves@redhat.com>
8299
8300 * NEWS (Completion improvements): Mention "info threads".
8301 * thread.c (struct info_threads_opts, info_threads_option_defs)
8302 (make_info_threads_options_def_group): New.
8303 (info_threads_command): Use gdb::option::process_options.
8304 (info_threads_command_completer): New.
8305 (_initialize_thread): Use gdb::option::build_help to build the
8306 help text for "info threads".
8307
854f6088
SM
83082019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8309
8310 * defs.h (generic_load): Move from here...
8311 * symfile.h (generic_load): ... to here. Rename name parameter
8312 to args.
8313 * symfile.c (generic_load): Add comment.
8314
54ee4252
TT
83152019-07-01 Tom Tromey <tromey@adacore.com>
8316
8317 * dwarf2read.c
8318 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8319 declaration of without_params. Fix formatting.
8320
65392b3e
TT
83212019-07-01 Tom Tromey <tromey@adacore.com>
8322
8323 * ada-exp.y (find_primitive_type): Update.
8324 * ada-lang.h (ada_lookup_symbol): Update.
8325 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8326 parameter.
8327 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8328
7d7571f0
SDJ
83292019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8330
8331 PR breakpoints/24541
8332 * gdbarch.c: Regenerate.
8333 * gdbarch.h: Regenerate.
8334 * gdbarch.sh: Add 'stap_adjust_register'.
8335 * i386-tdep.c: Include '<unordered_set>'.
8336 (i386_stap_adjust_register): New function.
8337 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8338 * stap-probe.c (stap_parse_register_operand): Call
8339 'gdbarch_stap_adjust_register'.
8340
5af5392a
SDJ
83412019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8342
8343 PR python/24742
8344 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8345 * python/python.c (do_start_initialization): Use 'xmalloc'
8346 instead of 'PyMem_Malloc'.
8347
10d06d82
TT
83482019-06-28 Tom Tromey <tromey@adacore.com>
8349
8350 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8351 for Ada.
8352
1b7f24cd
TT
83532019-06-27 Tom Tromey <tromey@adacore.com>
8354
8355 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8356 objfile_key.
8357 (arm_find_mapping_symbol, arm_record_special_symbol)
8358 (_initialize_arm_tdep): Update.
8359 (arm_objfile_data_free): Remove.
8360
3d507ff2
TT
83612019-06-27 Tom Tromey <tromey@adacore.com>
8362
8363 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8364 to cp_print_static_field.
8365
762c164d
TT
83662019-06-26 Tom Tromey <tromey@adacore.com>
8367
8368 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8369 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8370 declare.
8371
aa2f9bcf
AH
83722019-06-26 Alan Hayward <alan.hayward@arm.com>
8373
8374 * features/aarch64-core.c (create_feature_aarch64_core):
8375 Regenerate.
8376 * features/aarch64-core.xml: Add cpsr flags.
8377
3426ae57
AH
83782019-06-26 Alan Hayward <alan.hayward@arm.com>
8379
8380 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8381 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8382
4838e44c
SM
83832019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8384
8385 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8386 field.
8387 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8388 use.
8389 (arm_record_special_symbol): Don't insert new symbol in sorted
8390 position, push it at the end.
8391
54cc7474
SM
83922019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8393
8394 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8395 (arm_mapping_symbol_s): Remove.
8396 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8397 (arm_mapping_symbol_vec): New typedef.
8398 (struct arm_per_objfile): Add constructor.
8399 <section_maps>: Change type to
8400 std::unique_ptr<arm_mapping_symbol_vec[]>.
8401 (arm_compare_mapping_symbols): Remove.
8402 (arm_find_mapping_symbol): Adjust to section_maps type change.
8403 (arm_objfile_data_free): Call delete on arm_per_objfile.
8404 (arm_record_special_symbol): Adjust to section_maps type change.
8405 Allocate arm_per_objfile with new.
8406
b65b566c
PW
84072019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8408
8409 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8410 with the command prefix.
8411
c2fc64f5
TT
84122019-06-25 Tom Tromey <tom@tromey.com>
8413
8414 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8415 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8416
fb54fa76
TT
84172019-06-25 Tom Tromey <tom@tromey.com>
8418
8419 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8420 type.
8421 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8422 protected.
8423
f7952c57
TT
84242019-06-25 Tom Tromey <tom@tromey.com>
8425
8426 * tui/tui-winsource.c
8427 (tui_source_window_base::set_is_exec_point_at): Add check against
8428 LOA_ADDRESS.
8429
17568d78
TT
84302019-06-25 Tom Tromey <tom@tromey.com>
8431
8432 * tui/tui-source.c (tui_set_source_content): Don't check before
8433 xfree.
8434 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8435
53e7cdba
TT
84362019-06-25 Tom Tromey <tom@tromey.com>
8437
8438 * tui/tui-winsource.h (tui_update_source_window_as_is)
8439 (tui_alloc_source_buffer, tui_line_is_displayed)
8440 (tui_addr_is_displayed): Change type of win_info.
8441 * tui/tui-winsource.c (tui_update_source_window_as_is)
8442 (tui_clear_source_content, tui_show_source_line)
8443 (tui_show_source_content, tui_source_window_base::refill)
8444 (tui_source_window_base::set_is_exec_point_at)
8445 (tui_source_window_base::set_is_exec_point_at)
8446 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8447 (tui_alloc_source_buffer, tui_line_is_displayed)
8448 (tui_addr_is_displayed): Change type of win_info. Update.
8449 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8450 (tui_source_window_base::do_make_visible_with_new_height):
8451 Update.
8452 * tui/tui-source.c (tui_set_source_content)
8453 (tui_set_source_content_nil)
8454 (tui_source_window::do_scroll_vertical): Update.
8455 * tui/tui-layout.c (show_layout): Update.
8456 * tui/tui-disasm.c (tui_set_disassem_content)
8457 (tui_disasm_window::do_scroll_vertical): Update.
8458 * tui/tui-data.h (tui_win_content): Remove.
8459 (struct tui_gen_win_info) <content, content_size>: Remove.
8460 (struct tui_source_element): Add initializers and destructor.
8461 (union tui_which_element, struct tui_win_element): Remove.
8462 (struct tui_source_window_base) <content>: New field.
8463 (struct tui_data_window): Remove destructor.
8464 (tui_alloc_content, tui_free_win_content)
8465 (tui_free_all_source_wins_content): Don't declare.
8466 * tui/tui-data.c (tui_initialize_static_data): Update.
8467 (init_content_element, tui_alloc_content): Remove.
8468 (~tui_gen_win_info): Update.
8469 (~tui_data_window, tui_free_all_source_wins_content)
8470 (tui_free_win_content, free_content, free_content_elements):
8471 Remove.
8472
7908abbf
TT
84732019-06-25 Tom Tromey <tom@tromey.com>
8474
8475 * tui/tui-winsource.h (tui_clear_source_content)
8476 (tui_erase_source_content, tui_show_source_content): Change type
8477 of win_info.
8478 * tui/tui-winsource.c (tui_clear_source_content)
8479 (tui_erase_source_content, tui_show_source_content): Change type
8480 of win_info.
8481 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8482 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8483 win_info.
8484 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8485 win_info.
8486 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8487
02c28df0
TT
84882019-06-25 Tom Tromey <tom@tromey.com>
8489
8490 * tui/tui-winsource.c (tui_clear_source_content)
8491 (tui_source_window_base::set_is_exec_point_at): Update.
8492 * tui/tui-source.c (tui_set_source_content_nil): Update.
8493 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8494 a bool.
8495 * tui/tui-data.c (init_content_element): Update.
8496
6658b1bf
TT
84972019-06-25 Tom Tromey <tom@tromey.com>
8498
8499 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8500 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8501 * tui/tui-layout.c (init_and_make_win): Update.
8502 * tui/tui.h (enum tui_win_type): Update.
8503 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8504 tui_win_is_auxillary.
8505 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8506 tui_win_is_auxillary.
8507
21e1c91e
TT
85082019-06-25 Tom Tromey <tom@tromey.com>
8509
8510 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8511 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8512 (tui_delete_data_content_windows, tui_display_all_data)
8513 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8514 Update.
8515 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8516 * tui/tui-regs.c (tui_last_regs_line_no)
8517 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8518 (tui_show_registers): Update.
8519 (tui_show_register_group): Return void. Update.
8520 (tui_display_registers_from, tui_display_reg_element_at_line)
8521 (tui_display_registers_from_line, tui_check_register_values):
8522 Update.
8523 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8524 member.
8525 (struct tui_data_window) <regs_content>: Now a std::vector.
8526 <regs_content_count>: Remove.
8527 (tui_add_content_elements, tui_free_data_content): Don't declare.
8528 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8529 (init_content_element): Remove DATA_WIN case. Add assert.
8530 (tui_add_content_elements): Remove.
8531 (tui_data_window): Update.
8532 (tui_free_data_content): Remove.
8533 (free_content_elements): Remove DATA_WIN case.
8534
115ac53b
TT
85352019-06-25 Tom Tromey <tom@tromey.com>
8536
8537 * tui/tui-data.c (tui_data_item_window): Update.
8538 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8539 * tui/tui-windata.c (tui_display_all_data)
8540 (tui_display_data_from_line): Update.
8541 (tui_check_data_values): Remove.
8542 * tui/tui-regs.c (tui_show_register_group)
8543 (tui_display_reg_element_at_line): Update.
8544 * tui/tui-hooks.c (tui_register_changed)
8545 (tui_refresh_frame_and_register_information): Call
8546 tui_check_register_values.
8547 * tui/tui-data.h (struct tui_data_window) <data_content,
8548 data_content_count, data_type>: Remove.
8549 (enum tui_data_type): Remove.
8550
8551 * tui/tui-data.c (tui_data_window::clear_detail)
8552 (~tui_data_window): Update.
8553
eaf9738b
TT
85542019-06-25 Tom Tromey <tom@tromey.com>
8555
8556 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8557 declare.
8558 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8559 Rename from tui_first_data_item_displayed. Update.
8560 (tui_data_window::refresh_all)
8561 (tui_data_window::do_scroll_vertical): Update.
8562 * tui/tui-data.h (struct tui_data_window)
8563 <first_data_item_displayed>: Declare new method.
8564
31ca4723
TT
85652019-06-25 Tom Tromey <tom@tromey.com>
8566
8567 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8568 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8569 contents...
8570 (tui_initialize_static_data): ...here.
8571
41bcff7f
TT
85722019-06-25 Tom Tromey <tom@tromey.com>
8573
8574 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8575 (tui_display_registers_from, tui_check_register_values): Update.
8576 (tui_display_register): Remove win_info parameter; update.
8577 (tui_get_register): Change type of parameters.
8578 * tui/tui-data.h (struct tui_data_element): Remove.
8579 (union tui_which_element) <data>: Remove.
8580 <data_window>: Change type.
8581 (struct tui_data_item_window): New.
8582 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8583 case. Add assert.
8584 (~tui_data_item_window): New destructor.
8585 (free_content_elements): Remove DATA_ITEM_WIN case.
8586
d2802c33
TT
85872019-06-25 Tom Tromey <tom@tromey.com>
8588
8589 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8590 Remove.
8591
dd835f8b
TT
85922019-06-25 Tom Tromey <tom@tromey.com>
8593
8594 * tui/tui-data.h (struct tui_command_element): Remove.
8595 (union tui_which_element) <command>: Remove.
8596 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8597 assert.
8598 (free_content_elements): Remove CMD_WIN case.
8599
bd7db367
TT
86002019-06-25 Tom Tromey <tom@tromey.com>
8601
8602 * tui/tui-layout.c (tui_set_layout): Update.
8603 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8604 * tui/tui-data.c (layout_def): Update.
8605
3add462f
TT
86062019-06-25 Tom Tromey <tom@tromey.com>
8607
8608 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8609 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8610 (tui_source_window_base::set_new_height): Update.
8611 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8612 Update.
8613 (tui_set_locator_fullname, tui_set_locator_info)
8614 (tui_show_frame_info): Update.
8615 * tui/tui-source.c (tui_set_source_content)
8616 (tui_source_is_displayed): Update.
8617 * tui/tui-layout.c (show_source_disasm_command, show_data)
8618 (show_source_or_disasm_and_command): Update.
8619 * tui/tui-disasm.c (tui_set_disassem_content)
8620 (tui_get_begin_asm_address): Update.
8621 * tui/tui-data.h (struct tui_locator_element): Remove.
8622 (union tui_which_element) <locator>: Remove.
8623 (struct tui_locator_window): New.
8624 (tui_locator_win_info_ptr): Change return type.
8625 * tui/tui-data.c (_locator): Change type.
8626 (tui_locator_win_info_ptr): Change return type.
8627 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8628 (tui_alloc_content): Add assert.
8629
489e9d8b
TT
86302019-06-25 Tom Tromey <tom@tromey.com>
8631
8632 * tui/tui-winsource.c
8633 (tui_exec_info_window::maybe_allocate_content): New method.
8634 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8635 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8636 (make_source_or_disasm_window): Add cast.
8637 * tui/tui-data.h (union tui_which_element) <simple_string>:
8638 Remove.
8639 (struct tui_source_info): New.
8640 (struct tui_source_window_base) <execution_info>: Change type.
8641 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8642 case, and add assert.
8643 (tui_alloc_content): Add assert.
8644
c3fabb7d
TT
86452019-06-25 Tom Tromey <tom@tromey.com>
8646
8647 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8648 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8649 * tui/tui-data.c (tui_alloc_win_info): Remove.
8650
bbc228ee
TT
86512019-06-25 Tom Tromey <tom@tromey.com>
8652
8653 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8654 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8655 can_highlight.
8656
5fcee43a
TT
86572019-06-25 Tom Tromey <tom@tromey.com>
8658
8659 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8660 make_visible_with_new_height method.
8661 (tui_win_info::make_visible_with_new_height): New method.
8662 (tui_source_window_base::do_make_visible_with_new_height)
8663 (tui_data_window::do_make_visible_with_new_height)
8664 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8665 (make_visible_with_new_height): Remove.
8666 (tui_resize_all, tui_adjust_win_heights): Use
8667 make_visible_with_new_height method.
8668 * tui/tui-data.h (struct tui_win_info)
8669 <do_make_visible_with_new_height, make_visible_with_new_height>:
8670 New methods.
8671 (struct tui_source_window_base, struct tui_data_window)
8672 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8673 methods.
8674
d83f1fe6
TT
86752019-06-25 Tom Tromey <tom@tromey.com>
8676
8677 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8678 method.
8679 (update_tab_width): Call update_tab_width method.
8680 * tui/tui-data.h (struct tui_win_info)
8681 (struct tui_source_window_base) <update_tab_width>: New methods.
8682
17374de4
TT
86832019-06-25 Tom Tromey <tom@tromey.com>
8684
8685 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8686 parameter.
8687 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8688 parameter.
8689 (tui_gen_win_info::make_visible): Update.
8690 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8691 parameter.
8692 * tui/tui-data.h (enum tui_box): New enum.
8693 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8694
f936bca2
TT
86952019-06-25 Tom Tromey <tom@tromey.com>
8696
8697 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8698 init_and_make_win for EXEC_INFO_WIN.
8699 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8700 longer inline.
8701 (struct tui_win_info) <~tui_win_info>: Inline.
8702 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8703 Don't declare.
8704 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8705 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8706 Remove.
8707 (tui_initialize_static_data): Update.
8708 (~tui_gen_win_info): Handle more cleanup here.
8709 (~tui_source_window_base): Delete "execution_info".
8710 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8711
d6ba6a11
TT
87122019-06-25 Tom Tromey <tom@tromey.com>
8713
8714 * tui/tui-layout.c (make_command_window): Don't set
8715 can_highlight.
8716 (show_source_disasm_command): Call the reset method.
8717 (show_data): Don't set can_highlight. Call the reset method.
8718 (tui_gen_win_info::reset): Rename from init_gen_win_info
8719 (init_and_make_win): Simplify. Return tui_gen_win_info.
8720 (show_source_or_disasm_and_command): Call the reset method.
8721 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8722 (struct tui_cmd_window): Set can_highlight.
8723
48a3bd16
TT
87242019-06-25 Tom Tromey <tom@tromey.com>
8725
8726 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8727 from make_visible.
8728 (tui_make_visible, tui_make_invisible): Rewrite.
8729 (tui_win_info::make_visible): Remove.
8730 (tui_source_window_base::make_visible): Update.
8731 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8732 method. Moved from...
8733 (struct tui_win_info) <make_visible>: ...here.
8734
c3bd716f
TT
87352019-06-25 Tom Tromey <tom@tromey.com>
8736
8737 * tui/tui-winsource.c
8738 (tui_source_window_base::do_scroll_horizontal): Remove direction
8739 parameter.
8740 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8741 direction parameter.
8742 * tui/tui-win.c (tui_win_info::forward_scroll)
8743 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8744 (tui_win_info::right_scroll): Update.
8745 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8746 direction parameter.
8747 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8748 direction parameter.
8749 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8750 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8751 Remove direction parameter.
8752 (struct tui_source_window_base, struct tui_source_window)
8753 (struct tui_disasm_window, struct tui_data_window)
8754 (struct tui_cmd_window): Update.
8755
21c32dca
TT
87562019-06-25 Tom Tromey <tom@tromey.com>
8757
8758 * tui/tui-winsource.h (tui_set_exec_info_content)
8759 (tui_show_exec_info_content, tui_erase_exec_info_content)
8760 (tui_clear_exec_info_content, tui_update_exec_info): Change
8761 argument to tui_source_window_base.
8762 * tui/tui-winsource.c (tui_set_exec_info_content)
8763 (tui_show_exec_info_content, tui_erase_exec_info_content)
8764 (tui_clear_exec_info_content, tui_update_exec_info): Change
8765 argument to tui_source_window_base.
8766
73fbdc65
TT
87672019-06-25 Tom Tromey <tom@tromey.com>
8768
8769 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8770 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8771
33325343
TT
87722019-06-25 Tom Tromey <tom@tromey.com>
8773
8774 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8775 check.
8776
29d2c474
TT
87772019-06-25 Tom Tromey <tom@tromey.com>
8778
8779 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8780 type to void.
8781 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8782 type to void.
8783 * tui/tui-source.c (tui_set_source_content): Update.
8784 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8785
152f3f4b
TT
87862019-06-25 Tom Tromey <tom@tromey.com>
8787
8788 * tui/tui-win.c (window_name_completer, tui_set_focus)
8789 (tui_all_windows_info): Use name method.
8790 * tui/tui-data.h (struct tui_gen_win_info)
8791 (struct tui_source_window, struct tui_disasm_window)
8792 (struct tui_data_window, struct tui_cmd_window) <name>: New
8793 method.
8794 (tui_win_name): Don't declare.
8795 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8796 (tui_win_name): Remove.
8797
be4da588
TT
87982019-06-25 Tom Tromey <tom@tromey.com>
8799
8800 * tui/tui-winsource.h (tui_update_source_window)
8801 (tui_update_source_window_as_is): Change parameter type.
8802 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8803 to be a tui_source_window_base.
8804 (tui_update_source_window_as_is): Likewise.
8805 * tui/tui-win.c (make_visible_with_new_height): Update.
8806
5b81daba
TT
88072019-06-25 Tom Tromey <tom@tromey.com>
8808
8809 * tui/tui-winsource.c (tui_erase_source_content)
8810 (tui_show_source_content, tui_show_exec_info_content)
8811 (tui_erase_exec_info_content): Use refresh_window method.
8812 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8813 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8814 from tui_refresh_win.
8815 (tui_data_window::refresh_window): New method.
8816 (tui_win_info::refresh, tui_source_window_base::refresh)
8817 (tui_refresh_all): Use refresh_window method.
8818 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8819 method.
8820 * tui/tui-regs.c (tui_display_register): Call refresh_window
8821 method.
8822 * tui/tui-layout.c (show_source_disasm_command)
8823 (show_source_or_disasm_and_command): Call refresh_window method.
8824 * tui/tui-data.h (struct tui_gen_win_info)
8825 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8826 New method.
8827
cb2ce893
TT
88282019-06-25 Tom Tromey <tom@tromey.com>
8829
8830 * tui/tui.c (tui_rl_other_window, tui_enable)
8831 (tui_is_window_visible, tui_get_command_dimension): Update.
8832 * tui/tui-winsource.c (tui_update_source_window_as_is)
8833 (tui_clear_source_content, tui_erase_source_content)
8834 (tui_show_source_line, tui_source_window_base::refill)
8835 (tui_source_window_base::do_scroll_horizontal)
8836 (tui_source_window_base::set_is_exec_point_at)
8837 (tui_update_breakpoint_info, tui_set_exec_info_content)
8838 (tui_alloc_source_buffer, tui_line_is_displayed)
8839 (tui_addr_is_displayed): Update.
8840 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8841 (tui_check_and_display_highlight_if_needed)
8842 (tui_win_info::make_visible, tui_win_info::refresh)
8843 (tui_refresh_all): Update.
8844 * tui/tui-windata.c (tui_first_data_item_displayed)
8845 (tui_delete_data_content_windows, tui_erase_data_content)
8846 (tui_display_all_data, tui_data_window::refresh_all)
8847 (tui_check_data_values): Update.
8848 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8849 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8850 (tui_win_info::backward_scroll, tui_refresh_all_win)
8851 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8852 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8853 (tui_source_window_base::set_new_height)
8854 (tui_data_window::set_new_height)
8855 (make_invisible_and_set_new_height)
8856 (make_visible_with_new_height, new_height_ok)
8857 (parse_scrolling_args): Update.
8858 * tui/tui-stack.c (tui_show_frame_info): Update.
8859 * tui/tui-source.c (tui_set_source_content)
8860 (tui_set_source_content_nil, tui_source_is_displayed)
8861 (tui_source_window::do_scroll_vertical): Update.
8862 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8863 (tui_display_registers_from, tui_display_reg_element_at_line)
8864 (tui_check_register_values, tui_reg_command): Update.
8865 * tui/tui-layout.c (tui_default_win_height)
8866 (show_source_disasm_command, show_data, init_and_make_win)
8867 (show_source_or_disasm_and_command): Update.
8868 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8869 (tui_redisplay_readline, tui_mld_flush)
8870 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8871 (tui_getc): Update.
8872 * tui/tui-disasm.c (tui_set_disassem_content)
8873 (tui_disasm_window::do_scroll_vertical): Update.
8874 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8875 Now virtual.
8876 (struct tui_win_info): Derive from tui_gen_win_info.
8877 <~tui_win_info>: Mark as override.
8878 <generic>: Remove member.
8879 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8880 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8881 (~tui_data_window, ~tui_win_info)
8882 (tui_free_all_source_wins_content): Update.
8883 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8884
ab313b35
TT
88852019-06-25 Tom Tromey <tom@tromey.com>
8886
8887 * tui/tui-layout.c (init_and_make_win): Use new.
8888 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8889 destructor, initializers.
8890 (tui_alloc_generic_win_info): Don't declare.
8891 * tui/tui-data.c (_locator): Add argument to constructor.
8892 (source_win, disasm_win): New globals.
8893 (exec_info): Remove.
8894 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8895 Update.
8896 (tui_alloc_generic_win_info): Remove.
8897 (init_content_element): Use new.
8898 (tui_win_info::tui_win_info): Update.
8899 (free_content_elements) <case DATA_WIN>: Use delete.
8900
dc2c33e4
TT
89012019-06-25 Tom Tromey <tom@tromey.com>
8902
8903 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8904 * tui/tui-windata.c (tui_first_data_item_displayed)
8905 (tui_delete_data_content_windows): Update.
8906 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8907 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8908 (tui_display_registers_from, tui_check_register_values): Update.
8909 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8910 pointer.
8911 * tui/tui-data.c (init_content_element): Update. Allocate the new
8912 window.
8913 (tui_free_data_content): Update.
8914 (free_content_elements) <case DATA_WIN>: Free the window.
8915
214a5cbe
TT
89162019-06-25 Tom Tromey <tom@tromey.com>
8917
8918 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8919 Update.
8920 * tui/tui-layout.c (make_command_window)
8921 (show_source_disasm_command, show_data, init_and_make_win)
8922 (show_source_or_disasm_and_command): Update.
8923 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8924 method.
8925 <can_highight, is_highlighted>: Now bool.
8926 (tui_set_win_highlight): Don't declare.
8927 * tui/tui-data.c (tui_set_win_highlight): Remove.
8928
8e2daf15
TT
89292019-06-25 Tom Tromey <tom@tromey.com>
8930
8931 * tui/tui-wingeneral.c (make_visible): Remove check of window
8932 type.
8933
8903bd8a
TT
89342019-06-25 Tom Tromey <tom@tromey.com>
8935
8936 * tui/tui-win.c (tui_win_info::max_height)
8937 (tui_cmd_window::max_height): New methods.
8938 (new_height_ok): Call max_height.
8939 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8940 <max_height>: New method.
8941
3f02ce1e
TT
89422019-06-25 Tom Tromey <tom@tromey.com>
8943
8944 * tui/tui-win.c (tui_source_window_base::set_new_height)
8945 (tui_data_window::set_new_height): New methods.
8946 (make_invisible_and_set_new_height): Call set_new_height method.
8947 * tui/tui-data.h (struct tui_win_info)
8948 (struct tui_source_window_base, struct tui_data_window)
8949 <set_new_height>: New method.
8950
1825f487
TT
89512019-06-25 Tom Tromey <tom@tromey.com>
8952
8953 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8954 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8955 tui_refresh_data_win.
8956 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8957 method.
8958 (tui_refresh_all_win): Call the refresh_all method.
8959 (tui_set_focus): Likewise.
8960 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8961 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8962 Likewise.
8963
ad54d15b
TT
89642019-06-25 Tom Tromey <tom@tromey.com>
8965
8966 * tui/tui-winsource.h (tui_refill_source_window)
8967 (tui_set_is_exec_point_at): Don't declare.
8968 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8969 (tui_source_window_base::refill): Rename from
8970 tui_refill_source_window.
8971 (tui_source_window_base::do_scroll_horizontal): Update.
8972 (tui_source_window_base::set_is_exec_point_at): Rename from
8973 tui_set_is_exec_point_at.
8974 (tui_update_all_breakpoint_info): Update.
8975 * tui/tui-stack.c (tui_show_frame_info): Update.
8976 * tui/tui-layout.c (show_data): Add cast.
8977 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8978 * tui/tui-data.h (struct tui_source_window_base) <refill,
8979 set_is_exec_point_at>: New methods.
8980 (tui_source_windows, tui_add_to_source_windows): Update types.
8981 (tui_add_to_source_windows): Remove redundant declaration.
8982 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8983 (tui_source_windows): Change return type.
8984 (tui_clear_source_windows_detail): Update.
8985 (tui_add_to_source_windows): Change type of parameter.
8986 (tui_free_all_source_wins_content): Update.
8987
2042b506
TT
89882019-06-25 Tom Tromey <tom@tromey.com>
8989
8990 * tui/tui-wingeneral.c (tui_win_info::refresh)
8991 (tui_source_window_base::refresh): New methods.
8992 (tui_refresh_all): Call the refresh method.
8993 * tui/tui-data.h (struct tui_win_info)
8994 (struct tui_source_window_base) <refresh>: New method.
8995
56122977
TT
89962019-06-25 Tom Tromey <tom@tromey.com>
8997
8998 * tui/tui.h (tui_is_window_visible): Return bool.
8999 * tui/tui.c (tui_is_window_visible): Return bool.
9000 * tui/tui-wingeneral.c (tui_make_window, make_visible)
9001 (tui_make_visible, tui_make_invisible)
9002 (tui_win_info::make_visible)
9003 (tui_source_window_base::make_visible, make_all_visible)
9004 (tui_make_all_visible, tui_make_all_invisible): Update.
9005 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
9006 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
9007 bool.
9008 (struct tui_win_info, struct tui_source_window_base)
9009 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9010 * tui/tui-data.c (tui_init_generic_part): Update.
9011
cda37efb
TT
90122019-06-25 Tom Tromey <tom@tromey.com>
9013
9014 * tui/tui-wingeneral.c (tui_win_info::make_visible)
9015 (tui_source_window_base::make_visible): New methods.
9016 (make_all_visible): Make method call.
9017 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9018 (struct tui_source_window_base, struct tui_cmd_window): Override
9019 make_visible.
9020 (tui_win_is_source_type): Don't declare.
9021 * tui/tui-data.c (tui_win_is_source_type): Remove.
9022
6a0ee02c
TT
90232019-06-25 Tom Tromey <tom@tromey.com>
9024
9025 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9026 NULL check.
9027
63901aec
TT
90282019-06-25 Tom Tromey <tom@tromey.com>
9029
9030 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9031 Inline constructor. Add initializers for members.
9032 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9033 constructors; now inline in class.
9034
ceb13a13
TT
90352019-06-25 Tom Tromey <tom@tromey.com>
9036
9037 * tui/tui-regs.c (tui_show_registers): Update.
9038 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9039 bool.
9040 * tui/tui-data.c (tui_data_window::clear_detail)
9041 (tui_data_window): Update.
9042
238eb706
TT
90432019-06-25 Tom Tromey <tom@tromey.com>
9044
9045 * tui/tui-windata.c (tui_display_all_data)
9046 (tui_display_data_from_line, tui_display_data_from)
9047 (tui_check_data_values, tui_data_window::do_scroll_vertical):
9048 Update.
9049 * tui/tui-regs.c (tui_last_regs_line_no)
9050 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9051 (tui_show_registers, tui_show_register_group)
9052 (tui_display_registers_from, tui_display_reg_element_at_line)
9053 (tui_display_registers_from_line, tui_check_register_values)
9054 (tui_reg_next, tui_reg_prev): Update.
9055 * tui/tui-layout.c (tui_set_layout, show_data): Update.
9056 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
9057 tui_data_window.
9058 (struct tui_win_info) <detail>: Remove. Add new fields from
9059 tui_data_info.
9060 (TUI_DATA_WIN): Add cast.
9061 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9062 (~tui_data_window): Simplify.
9063
81491aa0
TT
90642019-06-25 Tom Tromey <tom@tromey.com>
9065
9066 * tui/tui-layout.c (show_source_disasm_command)
9067 (show_source_or_disasm_and_command): Update.
9068 * tui/tui-io.c (update_cmdwin_start_line)
9069 (tui_redisplay_readline): Update.
9070 * tui/tui-data.h (struct tui_command_info): Remove.
9071 (struct tui_win_info) <detail>: Remove command_info member.
9072 (struct tui_data_window) <start_line>: New member, from
9073 tui_command_info.
9074 (TUI_CMD_WIN): Add casts.
9075
e6e41501
TT
90762019-06-25 Tom Tromey <tom@tromey.com>
9077
9078 * tui/tui-winsource.c (tui_update_source_window)
9079 (tui_refill_source_window)
9080 (tui_source_window_base::do_scroll_horizontal)
9081 (tui_update_breakpoint_info, tui_set_exec_info_content)
9082 (tui_show_exec_info_content, tui_erase_exec_info_content)
9083 (tui_clear_exec_info_content): Update.
9084 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9085 Update.
9086 * tui/tui-win.c (make_invisible_and_set_new_height)
9087 (make_visible_with_new_height): Update.
9088 * tui/tui-source.c (tui_set_source_content)
9089 (tui_show_symtab_source): Update.
9090 * tui/tui-layout.c (extract_display_start_addr)
9091 (show_source_disasm_command, show_data)
9092 (make_source_or_disasm_window)
9093 (show_source_or_disasm_and_command): Update.
9094 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9095 (tui_disasm_window::do_scroll_vertical): Remove shadowing
9096 "gdbarch".
9097 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
9098 to tui_source_window_base.
9099 (struct tui_win_info) <detail>: Remove source_info member.
9100 (struct tui_source_window_base) <has_locator>: Inline.
9101 Move contents from tui_source_info; rename has_locator member to
9102 m_has_locator.
9103 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9104 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9105 header file.
9106 (tui_source_window_base::clear_detail, ~tui_source_window_base):
9107 Simplify.
9108 (tui_free_all_source_wins_content): Cast to
9109 tui_source_window_base.
9110
44f0e208
TT
91112019-06-25 Tom Tromey <tom@tromey.com>
9112
9113 * tui/tui-win.c (make_invisible_and_set_new_height)
9114 (make_visible_with_new_height): Call has_locator method.
9115 * tui/tui-layout.c (show_source_disasm_command, show_data)
9116 (show_source_or_disasm_and_command): Update for bool change.
9117 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9118 (tui_win_info) <has_locator>: New method.
9119 (struct tui_source_window_base) <has_locator>: New method.
9120 (tui_win_has_locator): Don't declare.
9121 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9122 from tui_win_has_locator.
9123 (tui_source_window_base): Use false, not FALSE.
9124
7778b912
TT
91252019-06-25 Tom Tromey <tom@tromey.com>
9126
9127 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9128 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9129 clear_detail method directly.
9130 (tui_clear_win_detail): Remove.
9131
f83d391c
TT
91322019-06-25 Tom Tromey <tom@tromey.com>
9133
9134 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9135 "this", not TUI_DISASM_WIN.
9136
13446e05
TT
91372019-06-25 Tom Tromey <tom@tromey.com>
9138
9139 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9140 declare.
9141 * tui/tui-winsource.c
9142 (tui_source_window_base::do_scroll_horizontal): Rename from
9143 tui_horizontal_source_scroll.
9144 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9145 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9146 from tui_vertical_data_scroll.
9147 * tui/tui-win.h (tui_scroll): Don't declare.
9148 * tui/tui-win.c (tui_win_info::forward_scroll)
9149 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9150 (tui_win_info::right_scroll): Rename and update.
9151 (tui_scroll_forward_command, tui_scroll_backward_command)
9152 (tui_scroll_left_command, tui_scroll_right_command): Update.
9153 (tui_scroll): Remove.
9154 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9155 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9156 from tui_vertical_source_scroll.
9157 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9158 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9159 from tui_vertical_disassem_scroll.
9160 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9161 do_scroll_horizontal>: New methods.
9162 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9163 Likewise.
9164 (struct tui_source_window_base): Add do_scroll_horizontal.
9165 (struct tui_source_window, struct tui_disasm_window): Add
9166 do_scroll_vertical.
9167 (struct tui_data_window, struct tui_cmd_window): Add
9168 do_scroll_horizontal and do_scroll_vertical.
9169 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9170
5cf82909
TT
91712019-06-25 Tom Tromey <tom@tromey.com>
9172
9173 * tui/tui-data.h (struct tui_source_window_base): New struct.
9174 (struct tui_source_window): Derive from tui_source_window_base.
9175 (struct tui_disasm_window): New struct.
9176 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9177 from tui_source_window::clear_detail.
9178 (tui_source_window_base): Rename from tui_source_window.
9179 (~tui_source_window_base): Rename from ~tui_source_window.
9180 (tui_alloc_win_info): Create a tui_disasm_window.
9181
ee1d42d6
TT
91822019-06-25 Tom Tromey <tom@tromey.com>
9183
9184 * tui/tui-data.h (struct tui_source_window)
9185 (struct tui_data_window): Declare destructors.
9186 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9187 destructors.
9188 (tui_win_info): Simplify.
9189
b4eb2452
TT
91902019-06-25 Tom Tromey <tom@tromey.com>
9191
9192 * tui/tui-winsource.c (tui_display_main)
9193 (tui_update_source_windows_with_addr)
9194 (tui_update_all_breakpoint_info): Update.
9195 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9196 (new_height_ok, parse_scrolling_args): Update.
9197 * tui/tui-stack.c (tui_show_frame_info): Update.
9198 * tui/tui-data.h (struct tui_list): Remove.
9199 (tui_source_windows): Return a reference to a std::vector.
9200 * tui/tui-data.c (source_windows): Now a std::vector.
9201 (tui_source_windows): Change return type.
9202 (tui_clear_source_windows): Rewrite.
9203 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9204 (tui_free_all_source_wins_content): Rewrite.
9205
8761a91b
TT
92062019-06-25 Tom Tromey <tom@tromey.com>
9207
9208 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9209 (struct tui_data_window, struct tui_cmd_window): Declare
9210 clear_detail method.
9211 * tui/tui-data.c (tui_source_window::clear_detail)
9212 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9213 methods.
9214 (tui_clear_win_detail): Simplify.
9215
0ed69eda
TT
92162019-06-25 Tom Tromey <tom@tromey.com>
9217
9218 * tui/tui-layout.c (make_source_window, make_disasm_window)
9219 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9220 Return the new window.
9221 (show_source_disasm_command, show_data)
9222 (show_source_or_disasm_and_command): Update.
9223
82432e10
TT
92242019-06-25 Tom Tromey <tom@tromey.com>
9225
9226 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9227 parameter. Return the new window.
9228 (show_source_disasm_command): Update and remove NULL check.
9229 (show_source_or_disasm_and_command): Update.
9230
ec328aa5
TT
92312019-06-25 Tom Tromey <tom@tromey.com>
9232
9233 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9234
33b906ab
TT
92352019-06-25 Tom Tromey <tom@tromey.com>
9236
9237 * tui/tui-data.h (struct tui_win_info): Make constructor
9238 protected. Make destructor virtual. Add initializers.
9239 (tui_source_window, tui_data_window, tui_cmd_window): New
9240 classes.
9241 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9242 constructor. Add "type" parameter.
9243 (tui_source_window, tui_data_window, tui_cmd_window): New
9244 constructors.
9245 (tui_alloc_win_info): Instantiate the appropriate subclass.
9246
e7e11af4
TT
92472019-06-25 Tom Tromey <tom@tromey.com>
9248
9249 * tui/tui-win.c (tui_resize_all): Use delete.
9250 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9251 destructor.
9252 (tui_free_window): Don't declare.
9253 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9254 Update.
9255
6792b55e
TT
92562019-06-25 Tom Tromey <tom@tromey.com>
9257
9258 * tui/tui-data.h (struct tui_win_info): Add constructor.
9259 * tui/tui-data.c (tui_alloc_win_info): Use new.
9260 (tui_free_window): Use delete.
9261
f95675e1
TT
92622019-06-22 Tom Tromey <tom@tromey.com>
9263
9264 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9265 declare.
9266 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9267
5bff081c
TT
92682019-06-22 Tom Tromey <tom@tromey.com>
9269
9270 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9271 declare.
9272 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9273
47e3f474
TV
92742019-06-22 Tom de Vries <tdevries@suse.de>
9275
9276 * dwarf2read.c (create_addrmap_from_aranges)
9277 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9278 instead of '%zu'.
9279
fd5866f6
SM
92802019-06-21 Simon Marchi <simon.marchi@efficios.com>
9281
9282 * dwarf2read.h (dwarf2_section_info_def): Remove.
9283 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9284 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9285 std::vector<dwarf2_section_info>.
9286 (struct dwo_file) <~dwo_file>: Remove.
9287 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9288 types field.
9289 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9290 (dwarf2_read_debug_names): Likewise.
9291 (create_debug_types_hash_table): Change parameter type to
9292 array_view, adjust code accordingly.
9293 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9294 (partial_die_info::fixup): Likewise.
9295 (determine_prefix): Likewise.
9296 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9297
fb1eb2f9
SM
92982019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9299
9300 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9301 gdb_bfd_ref_ptr.
9302 <~dwo_file>: Remove call to gdb_bfd_unref.
9303 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9304 gdb_bfd_ref_ptr::get.
9305
51ac9db5
SM
93062019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9307
9308 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9309 type to htab_up.
9310 * dwarf2read.c (struct dwo_file): Initialize fields.
9311 <~dwo_file>: New.
9312 (free_dwo_file): Remove, move content to ~dwo_file.
9313 (struct dwo_file_deleter): Remove.
9314 (dwo_file_up>: Remove custom deleter.
9315 (free_dwo_files): Remove.
9316 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9317 dwo_files.
9318 (process_skeletonless_type_units): Call unique_ptr::get.
9319 (allocate_dwo_file_hash_table): Add deleter to created hash
9320 table. Change return type to htab_up.
9321 (lookup_dwo_file_slot): Don't memset dwo_file, call
9322 unique_ptr::get.
9323 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9324 (create_dwo_unit_in_dwp_v2): Likewise.
9325 (open_and_init_dwo_file): Likewise.
9326 (free_dwo_file_from_slot): Remove.
9327
dc4ccb6f
SM
93282019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9329
9330 * dwarf2read.h (struct dwarf2_section_info) <readin,
9331 is_virtual>: Change type to bool.
9332 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9333 true instead of 1.
9334
e6a1c5cb
TT
93352019-06-19 Tom Tromey <tom@tromey.com>
9336
9337 * tui/tui-data.h (tui_init_content_element): Don't declare.
9338
6f6ffbeb
TT
93392019-06-19 Tom Tromey <tom@tromey.com>
9340
9341 * tui/tui-data.h (tui_init_win_info): Don't declare.
9342
f23f598e
TV
93432019-06-19 Tom de Vries <tdevries@suse.de>
9344
9345 * dwarf2read.h (abstract_to_concrete): Change type to
9346 std::unordered_map<sect_offset, std::vector<sect_offset>,
9347 gdb::hash_enum<sect_offset>>.
9348
680e1bee
TT
93492019-06-19 Tom Tromey <tromey@adacore.com>
9350
9351 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9352 EVAL_AVOID_SIDE_EFFECTS specially.
9353
dcf37923
TT
93542019-06-19 Tom Tromey <tromey@adacore.com>
9355
9356 * source-cache.c (highlighter): New global.
9357 (source_cache::get_source_lines): Create a highlighter on demand.
9358
494986d5
AB
93592019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9360
9361 * defs.h (deprecated_interactive_hook): Delete declaration.
9362 * interps.c (clear_interpreter_hooks): Remove use of
9363 deprecated_interactive_hook.
9364 * top.c (deprecated_interactive_hook): Delete definition.
9365 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9366
3360b6e7
TV
93672019-06-18 Tom de Vries <tdevries@suse.de>
9368
9369 PR gdb/24515
9370 * dwarf2read.h (abstract_to_concrete): Change type from
9371 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9372 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9373 * dwarf2read.c (read_variable): Update.
9374 (dwarf2_fetch_die_loc_sect_off): Update.
9375
310b3441
TV
93762019-06-17 Tom de Vries <tdevries@suse.de>
9377
9378 PR gdb/24617
9379 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9380 accessing parent[parent_len - 1].
9381
ba9777be
PP
93822019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9383
9384 PR gdb/24364
9385 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9386 call dtrace_process_dof with NULL dof.
9387
2b9f6e89
TV
93882019-06-16 Tom de Vries <tdevries@suse.de>
9389
9390 PR gdb/24445
9391 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9392
431b3ead
TT
93932019-06-16 Tom Tromey <tom@tromey.com>
9394
9395 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9396 (make_all_visible): Use address of member.
9397
d04b44a1
TT
93982019-06-16 Tom Tromey <tom@tromey.com>
9399
9400 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9401 (tui_free_window, free_content, free_content_elements): Remove
9402 unnecessary cast.
9403 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9404 cast.
9405 * tui/tui-regs.c (tui_show_register_group)
9406 (tui_display_registers_from, tui_display_reg_element_at_line):
9407 Remove unnecessary cast.
9408
bf5142e7
AB
94092019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9410
9411 * linux-nat.c (normal_mask): Delete.
9412 (_initialize_linux_nat): Don't initialise normal_mask.
9413
c4973306
SM
94142019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9415
9416 PR gdb/24445
9417 * dwarf-index-write.h (write_psymtabs_to_index): Add
9418 dwz_basename parameter.
9419 * dwarf-index-write.c (write_gdbindex): Move file writing to
9420 write_gdbindex_1. Change return type void.
9421 (assert_file_size): Move up, remove filename parameter.
9422 (write_gdbindex_1): New function.
9423 (write_debug_names): Change return type to void, call
9424 assert_file_size.
9425 (struct index_wip_file): New struct.
9426 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9427 file logic to index_wip_file. Write index for dwz file if
9428 needed.
9429 (save_gdb_index_command): Pass basename of dwz file, if present.
9430 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9431 build-id of dwz file, if present.
9432 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9433 (dwarf2_get_dwz_file): Likewise.
9434 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9435 (dwarf2_get_dwz_file): Likewise.
9436
395f9c91
TT
94372019-06-16 Tom Tromey <tom@tromey.com>
9438
9439 * coffread.c (process_coff_symbol): Use xstrdup.
9440 * value.c (create_internalvar): Use xstrdup.
9441
cafb3438
TT
94422019-06-16 Tom Tromey <tom@tromey.com>
9443
9444 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9445 * breakpoint.c (stopin_command, stopat_command)
9446 (until_break_command, decode_location_default): Remove unnecessary
9447 cast.
9448 * utils.c (subset_compare): Remove unnecessary cast.
9449 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9450 cast.
9451 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9452 cast.
9453 * infcmd.c (path_command): Remove unnecessary cast.
9454 * coffread.c (decode_type): Remove unnecessary cast.
9455 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9456 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9457 * tui/tui-stack.c (tui_show_locator_content)
9458 (tui_show_frame_info): Remove unnecessary cast.
9459 * tui/tui-win.c (tui_scroll_forward_command)
9460 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9461 (parse_scrolling_args): Remove unnecessary cast.
9462 * tui/tui-data.c (init_win_info, tui_del_window)
9463 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9464 (free_content_elements): Remove unnecessary cast.
9465 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9466 unnecessary cast.
9467 * tui/tui-source.c (tui_set_source_content)
9468 (tui_vertical_source_scroll): Remove unnecessary cast.
9469 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9470 cast.
9471 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9472 * tui/tui-regs.c (tui_display_registers_from)
9473 (tui_display_register): Remove unnecessary cast.
9474 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9475 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9476 (make_visible): Remove unnecessary cast.
9477 * tui/tui-winsource.c (tui_erase_source_content)
9478 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9479 unnecessary cast.
9480 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9481 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9482 * stabsread.c (read_type, read_array_type, read_range_type):
9483 Remove unnecessary cast.
9484 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9485 (parse_symbol, parse_type, upgrade_type, parse_external)
9486 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9487 unnecessary cast.
9488 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9489
730ead81
TT
94902019-06-16 Tom Tromey <tom@tromey.com>
9491
9492 * tui/tui-data.c (tui_alloc_generic_win_info)
9493 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9494 checks.
9495
584a927c
AB
94962019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9497 Andrew Burgess <andrew.burgess@embecosm.com>
9498
9499 * f-typeprint.c (f_print_type): Don't return early for not
9500 associated or not allocated types.
9501 (f_type_print_varspec_suffix): Add print_rank parameter and print
9502 ranks of array types in case they dangling.
9503 (f_type_print_base): Add print_rank parameter.
9504
30056ea0
AB
95052019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9506
9507 * NEWS: Mention new MI commands.
9508 * break-catch-throw.c (enum exception_event_kind): Move to
9509 breakpoint.h.
9510 (print_mention_exception_catchpoint): Output text as a single
9511 message.
9512 (catch_exception_command_1): Rename to...
9513 (catch_exception_event): ...this, make non-static, update header
9514 command, and change some parameter types.
9515 (catch_catch_command): Update for changes to
9516 catch_exception_command_1.
9517 (catch_throw_command): Likewise.
9518 (catch_rethrow_command): Likewise.
9519 * breakpoint.c (enum exception_event_kind): Delete.
9520 * breakpoint.h (enum exception_event_kind): Moved here from
9521 break-catch-throw.c.
9522 (catch_exception_event): Declare.
9523 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9524 (mi_cmd_catch_throw): New function.
9525 (mi_cmd_catch_rethrow): New function.
9526 (mi_cmd_catch_catch): New function.
9527 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9528 'catch-catch' entries.
9529 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9530 (mi_cmd_catch_rethrow): Declare.
9531 (mi_cmd_catch_catch): Declare.
9532
ec8e2b6d
AB
95332019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9534
9535 * annotate.c (annotate_source_line): Change return type to void,
9536 update implementation to match.
9537 * annotate.h (annotate_source_line): Change return type to void,
9538 update header comment.
9539 * stack.c (print_frame_info): Don't change what frame information
9540 is printed based on whether annotations are on or not.
9541
0d3abd8c
AB
95422019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9543
9544 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9545 (annotate_source): Make static.
9546 (annotate_source_line): Moved from source.c and renamed from
9547 identify_source_line. Update the return type.
9548 * annotate.h (annotate_source): Delete declaration.
9549 (annotate_source_line): Declaration moved from source.h, and
9550 renamed from identify_source_line. Return type updated.
9551 * source.c (identify_source_line): Moved to annotate.c and renamed
9552 to annotate_source_line.
9553 (info_line_command): Remove check of annotation_level.
9554 * source.h (identify_source_line): Move declaration to annotate.h
9555 and rename to annotate_source_line.
9556 * stack.c: Add 'annotate.h' include.
9557 (print_frame_info): Remove check of annotation_level before
9558 calling annotate_source_line.
9559
00df30ae
AB
95602019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9561
9562 * source-cache.c (source_cache::get_plain_source_lines): Use
9563 open_source_file_with_line_charpos instead of just
9564 open_source_file, remove call to find_source_lines.
9565 (source_cache::get_source_lines): Likewise.
9566 * source.c (find_source_lines): Make static.
9567 (get_filename_and_charpos): Renamed into...
9568 (open_source_file_with_line_charpos): ..this along with changes to
9569 return a scoped_fd, and some other minor clean ups.
9570 (identify_source_line): Use open_source_file_with_line_charpos.
9571 (search_command_helper): Use open_source_file_with_line_charpos
9572 instead of just open_source_file, remove call to
9573 find_source_lines.
9574 * source.h (open_source_file_with_line_charpos): Declare new
9575 function.
9576 (find_source_lines): Delete declaration.
9577
afda45a2
AB
95782019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9579
9580 * source.c (get_filename_and_charpos): Remove fullname
9581 parameter.
9582 (identify_source_line): Update call to get_filename_and_charpos.
9583
0735b091
TT
95842019-06-14 Tom Tromey <tromey@adacore.com>
9585
9586 PR gdb/24502:
9587 * ui-style.h (skip_ansi_escape): Update comment.
9588 * ui-file.h (class no_terminal_escape_file): New class.
9589 * ui-file.c (no_terminal_escape_file::write)
9590 (no_terminal_escape_file::puts): New methods.
9591 * cli/cli-logging.c (handle_redirections): Use
9592 no_terminal_escape_file.
9593
52ce35e2
TT
95942019-06-14 Tom Tromey <tromey@adacore.com>
9595
9596 * NEWS: Move convenience variable news above Python news.
9597
73cc7272
TT
95982019-06-14 Tom Tromey <tom@tromey.com>
9599
9600 * gnulib: Move directory to top-level.
9601 * configure.ac: Don't configure gnulib.
9602 * configure: Rebuild.
9603 * common/common-defs.h: Use new path to gnulib.
9604 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9605 (GNULIB_H): Remove.
9606 (INCGNU): Look in new gnulib location.
9607 (HFILES_NO_SRCDIR): Remove gnulib files.
9608 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9609 (generated_files): Remove GNULIB_H.
9610 ($(LIBGNU), all-lib): Remove targets.
9611 (distclean): Don't mention GNULIB_BUILDDIR.
9612 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9613
f5686554
TT
96142019-06-14 Tom Tromey <tromey@adacore.com>
9615
9616 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9617 Warn if symbol file does not provide any symbols.
9618
a0c1ffed
TT
96192019-06-14 Tom Tromey <tromey@adacore.com>
9620
9621 * source.c (find_and_open_source): Respect basenames_may_differ.
9622
7c39e397
AB
96232019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9624
9625 * annotate.c (annotate_breakpoints_invalid): Make use of
9626 scoped_restore_terminal_state.
9627 (annotate_frames_invalid): Likewise.
9628
f411722c
TT
96292019-06-14 Tom Tromey <tromey@adacore.com>
9630
9631 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9632 allow assignment to an internalvar.
9633
4268ec18
TT
96342019-06-14 Tom Tromey <tromey@adacore.com>
9635
9636 * ada-lex.l: Allow "_" in attribute names.
9637
abdb711e
TT
96382019-06-14 Tom Tromey <tromey@adacore.com>
9639
9640 PR gdb/24653:
9641 * regcache.c (registers_changed): Don't call alloca.
9642 * top.c (execute_command): Don't call alloca.
9643
4c048731
PA
96442019-06-13 Pedro Alves <palves@redhat.com>
9645
9646 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9647 'expression'. When parsing an expression, error out if there's
9648 junk after "unlimited".
9649 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9650 (do_set_command): Adjust calls to is_unlimited_literal.
9651
66eb1ed3
PA
96522019-06-13 Pedro Alves <palves@redhat.com>
9653
9654 * compile/compile.c (make_compile_options_def_group): Add braces
9655 around array_view initializer.
9656 * thread.c (make_thread_apply_all_options_def_group)
9657 (make_thread_apply_all_options_def_group): Likewise.
9658
3345721a
PA
96592019-06-13 Pedro Alves <palves@redhat.com>
9660
9661 * NEWS (New commands): Mention "maint test-options
9662 require-delimiter", "maint test-options unknown-is-error", "maint
9663 test-options unknown-is-operand" and "maint show
9664 test-options-completion-result".
9665 (New command options, command completion): New section.
9666 (Completion improvements): New section.
9667 Mention that you can abbreviate "unlimited".
9668
6206060d
PA
96692019-06-13 Pedro Alves <palves@redhat.com>
9670
9671 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9672 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9673 * unittests/cli-utils-selftests.c (test_parse_flags)
9674 (test_parse_flags_qcs): Delete.
9675 (test_cli_utils): Don't call deleted functions.
9676
6665660a
PA
96772019-06-13 Pedro Alves <palves@redhat.com>
9678
9679 * thread.c: Include "cli/cli-option.h".
9680 (tp_array_compar_ascending): Global.
9681 (tp_array_compar): Delete function.
9682 (tp_array_compar_ascending, tp_array_compar_descending): New
9683 functions.
9684 (ascending_option_def, qcs_flag_option_def)
9685 (thr_qcs_flags_option_defs)
9686 (make_thread_apply_all_options_def_group)
9687 (make_thread_apply_options_def_group): New.
9688 (thread_apply_all_command): Use gdb::option::process_options.
9689 (thread_apply_command_completer)
9690 (thread_apply_all_command_completer): New.
9691 (thread_apply_command): Use gdb::option::process_options.
9692 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9693 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9694 to generate help text of "thread apply". Adjust "taas"'s help.
9695 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9696 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9697
f7e13587
PA
96982019-06-13 Pedro Alves <palves@redhat.com>
9699
9700 * thread.c (thread_apply_command): Check for invalid TID with
9701 isdigit instead of !isalpha.
9702
5d707134
PA
97032019-06-13 Pedro Alves <palves@redhat.com>
9704
9705 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9706 (validate_flags_qcs): New.
9707 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9708 (validate_flags_qcs): Declare.
9709 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9710 (make_frame_apply_options_def_group): New.
9711 (frame_apply_command_count): Process options with
9712 gdb::option::process_options.
9713 (frame_apply_completer): New.
9714 (frame_apply_level_completer, frame_apply_all_completer)
9715 (frame_apply_completer): New.
9716 (_initialize_stack): Update help of "frame apply", "frame apply
9717 level", "frame apply all" and "faas" to mention supported options
9718 and install command completers.
9719 * stack.h (frame_apply_all_completer): Declare.
9720 * thread.c: Include "stack.h".
9721 (tfaas_command): Add "--".
9722 (_initialize_thread): Update help "tfaas" to mention supported
9723 options and install command completer.
9724
272d4594
PA
97252019-06-13 Pedro Alves <palves@redhat.com>
9726
9727 * completer.c (complete_nested_command_line): New.
9728 (gdb_completion_word_break_characters_throw): Add assertion.
9729 * completer.h (complete_nested_command_line): Declare.
9730
90a1ef87
PA
97312019-06-13 Pedro Alves <palves@redhat.com>
9732
9733 * stack.c (parse_backtrace_qualifiers): New.
9734 (backtrace_command): Use it.
9735 (backtrace_command_completer): Complete on qualifiers.
9736
d4c16835
PA
97372019-06-13 Pedro Alves <palves@redhat.com>
9738
9739 * frame.c: Include "cli/cli-option.h.
9740 (user_set_backtrace_options): New.
9741 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9742 Delete.
9743 (get_prev_frame): Adjust.
9744 (boolean_option_def, uinteger_option_def)
9745 (set_backtrace_option_defs): New.
9746 (_initialize_frame): Adjust and use
9747 gdb::option::add_setshow_cmds_for_options to install "set
9748 backtrace past-main" and "set backtrace past-entry".
9749 * frame.h: Include "cli/cli-option.h".
9750 (struct frame_print_options): Forward declare.
9751 (print_frame_arguments_all, print_frame_arguments_scalars)
9752 (print_frame_arguments_none): Declare.
9753 (print_entry_values): Delete declaration.
9754 (struct frame_print_options, user_frame_print_options): New.
9755 (struct set_backtrace_options): New.
9756 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9757 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9758 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9759 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9760 (list_args_or_locals): Add frame_print_options parameter.
9761 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9762 * python/py-framefilter.c (enumerate_args): Pass down
9763 USER_FRAME_PRINT_OPTIONS.
9764 * stack.c: Include "cli/cli-option.h".
9765 (print_frame_arguments_all, print_frame_arguments_scalars)
9766 (print_frame_arguments_none): Declare.
9767 (print_raw_frame_arguments, print_entry_values): Delete.
9768 (user_frame_print_options): New.
9769 (boolean_option_def, enum_option_def, frame_print_option_defs):
9770 New.
9771 (struct backtrace_cmd_options): New.
9772 (bt_flag_option_def): New.
9773 (backtrace_command_option_defs): New.
9774 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9775 (print_frame_arg, read_frame_arg, print_frame_args)
9776 (print_frame_info, print_frame): Add frame_print_options parameter
9777 and use it.
9778 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9779 (backtrace_command_1): Add frame_print_options and
9780 backtrace_cmd_options parameters and use them.
9781 (make_backtrace_options_def_group): New.
9782 (backtrace_command): Process command options with
9783 gdb::option::process_options.
9784 (backtrace_command_completer): New.
9785 (_initialize_stack): Extend "backtrace"'s help to mention
9786 supported options. Install completer for "backtrace".
9787 Install some settings commands with add_setshow_cmds_for_options.
9788
2daf894e
PA
97892019-06-13 Pedro Alves <palves@redhat.com>
9790
9791 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9792 and that "set/show print raw frame-arguments" are now deprecated.
9793
9794 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9795 command.
9796 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9797 * stack.c (_initialize_stack): Install "set/show print
9798 raw-frame-arguments", and deprecate "set/show print raw
9799 frame-arguments".
9800 * valprint.c (_initialize_valprint): Deprecate "set/show print
9801 raw".
9802
e6ed716c
PA
98032019-06-13 Pedro Alves <palves@redhat.com>
9804
9805 * compile/compile.c (struct compile_options): New.
9806 (compile_flag_option_def, compile_command_option_defs)
9807 (make_compile_options_def_group): New.
9808 (compile_file_command): Handle options with
9809 gdb::option::process_options.
9810 (compile_file_command_completer): New function.
9811 (compile_code_command): Handle options with
9812 gdb::option::process_options.
9813 (compile_code_command_completer): New function.
9814 (_initialize_compiler): Install completers for "compile code" and
9815 "compile file". Mention available options in "compile code" and
9816 "compile code"'s help.
9817 * completer.c (advance_to_completion_word): New, factored out from
9818 ...
9819 (advance_to_expression_complete_word_point): ... this.
9820 (advance_to_filename_complete_word_point): New.
9821 * completer.h (advance_to_filename_complete_word_point): New
9822 declaration.
9823
7d8062de
PA
98242019-06-13 Pedro Alves <palves@redhat.com>
9825
9826 * compile/compile.c: Include "cli/cli-option.h".
9827 (compile_print_value): Scope data pointer is now a
9828 value_print_options pointer; adjust.
9829 (compile_print_command): Process options. Scope data pointer is
9830 now a value_print_options pointer; adjust.
9831 (_initialize_compile): Update "compile print"'s help to include
9832 supported options. Install a completer for "compile print".
9833 * cp-valprint.c (show_vtblprint, show_objectprint)
9834 (show_static_field_print): Delete.
9835 (_initialize_cp_valprint): Don't install "set print
9836 static-members", "set print vtbl", "set print object" here.
9837 * printcmd.c: Include "cli/cli-option.h" and
9838 "common/gdb_optional.h".
9839 (print_command_parse_format): Rework to fill in a
9840 value_print_options instead of a format_data.
9841 (print_value): Change parameter type from format_data pointer to
9842 value_print_options reference. Adjust.
9843 (print_command_1): Process options. Adjust to pass down a
9844 value_print_options.
9845 (print_command_completer): New.
9846 (_initialize_printcmd): Install print_command_completer as
9847 handle_brkchars completer for the "print" command. Update
9848 "print"'s help to include supported options.
9849 * valprint.c: Include "cli/cli-option.h".
9850 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9851 here from cp-valprint.c.
9852 (boolean_option_def, uinteger_option_def)
9853 (value_print_option_defs, make_value_print_options_def_group):
9854 New. Use gdb::option::add_setshow_cmds_for_options to install
9855 "set print elements", "set print null-stop", "set print repeats",
9856 "set print pretty", "set print union", "set print array", "set
9857 print address", "set print symbol", "set print array-indexes".
9858 * valprint.h: Include <string> and "cli/cli-option.h".
9859 (make_value_print_options_def_group): Declare.
9860 (print_value): Change parameter type from format_data pointer to
9861 value_print_options reference.
9862 (print_command_completer): Declare.
9863
9d0faba9
PA
98642019-06-13 Pedro Alves <palves@redhat.com>
9865
9866 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9867 (COMMON_SFILES): Add maint-test-settings.c.
9868 * cli/cli-decode.c (boolean_enums): New global, factored out from
9869 ...
9870 (add_setshow_boolean_cmd): ... here.
9871 * cli/cli-decode.h (boolean_enums): Declare.
9872 * cli/cli-option.c: New file.
9873 * cli/cli-option.h: New file.
9874 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9875 factored out from ...
9876 (parse_cli_boolean_value(const char *)): ... this.
9877 (is_unlimited_literal): Change parameter type to pointer to
9878 pointer. Adjust and advance ARG pointer.
9879 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9880 (parse_cli_var_enum): New, factored out from ...
9881 (do_set_command): ... this. Adjust.
9882 * cli/cli-setshow.h (parse_cli_boolean_value)
9883 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9884 (parse_cli_var_enum): Declare.
9885 * cli/cli-utils.c: Include "cli/cli-option.h".
9886 (get_ulongest): New.
9887 * cli/cli-utils.h (get_ulongest): Declare.
9888 (check_for_argument): New overloads.
9889 * maint-test-options.c: New file.
9890
2c722807
PA
98912019-06-13 Pedro Alves <palves@redhat.com>
9892
9893 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9894 parse a range if "-" is at the end of the string.
9895
dee7b4c8
PA
98962019-06-13 Pedro Alves <palves@redhat.com>
9897
9898 * cli/cli-setshow.c (parse_auto_binary_operation)
9899 (parse_cli_boolean_value): Don't allow "o".
9900
dca0f6c0
PA
99012019-06-13 Pedro Alves <palves@redhat.com>
9902
9903 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9904 * NEWS: Mention maint test-settings KIND.
9905 * maint-test-settings.c: New file.
9906
597bf39d
PA
99072019-06-13 Pedro Alves <palves@redhat.com>
9908
9909 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9910 completer.
9911 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9912 "set" completers.
9913
48c410fb
PA
99142019-06-13 Pedro Alves <palves@redhat.com>
9915
9916 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9917 after item.
9918
93bcb043
PA
99192019-06-13 Pedro Alves <palves@redhat.com>
9920
9921 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9922
cbba3ecd
PA
99232019-06-13 Pedro Alves <palves@redhat.com>
9924
9925 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9926 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9927 call.
9928 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9929 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9930 calls.
9931 (check_for_argument): Skip spaces after argument.
9932
b9a3f842
PA
99332019-06-13 Pedro Alves <palves@redhat.com>
9934
9935 * thread.c (thread_apply_command): Adjust TID parsing.
9936 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9937 detected before end of string.
9938 (tid_is_in_list): Error out if LIST is invalid.
9939
3844e605
PA
99402019-06-13 Pedro Alves <palves@redhat.com>
9941
9942 * completer.c (complete_line_internal_1): Rewind completion word
9943 point.
9944 (completion_tracker::advance_custom_word_point_by): Change
9945 parameter type to int.
9946 * completer.h (completion_tracker::advance_custom_word_point_by):
9947 Likewise.
9948
00b56dbe
PA
99492019-06-13 Pedro Alves <palves@redhat.com>
9950
9951 * completer.c (advance_to_completion_word): Handle delimiters.
9952
d106773e
PA
99532019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9954
9955 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9956
08f10e02
TT
99572019-06-11 Tom Tromey <tom@tromey.com>
9958
9959 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9960 (xmalloc_failed): Move to alloc.c.
9961 * alloc.c: New file.
9962 * Makefile.in (COMMON_SFILES): Add alloc.c.
9963
1c7fe951
TT
99642019-06-11 Tom Tromey <tom@tromey.com>
9965
9966 * nat/linux-waitpid.c: Don't include server.h.
9967 (linux_debug): Remove.
9968 (my_waitpid): Update.
9969
89549d7f
TT
99702019-06-11 Tom Tromey <tromey@adacore.com>
9971
9972 * infcall.c (_initialize_infcall): Remove trailing newline from
9973 help.
9974 * user-regs.c (_initialize_user_regs): Remove trailing newline
9975 from help.
9976 * typeprint.c (_initialize_typeprint): Remove trailing newline
9977 from help.
9978 * reverse.c (_initialize_reverse): Remove trailing newlines from
9979 help.
9980 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9981 from help.
9982 * language.c (add_set_language_command): Remove trailing newline
9983 from help.
9984 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9985 help.
9986 * disasm.c (_initialize_disasm): Remove trailing newline from
9987 help.
9988 * top.c (init_main): Remove trailing newline from help.
9989 * interps.c (_initialize_interpreter): Remove trailing newline
9990 from help.
9991 * btrace.c (_initialize_btrace): Remove trailing newlines from
9992 help.
9993 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9994 from help.
9995 * python/python.c (_initialize_python): Remove trailing newline
9996 from help.
9997 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9998 help.
9999 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
10000 from help. Reformat some text.
10001 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
10002 from help.
10003 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
10004 newline from help.
10005
86108c13
TT
100062019-06-11 Tom Tromey <tromey@adacore.com>
10007
10008 * darwin-nat.c (darwin_decode_exception_message)
10009 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10010
a7067863
AB
100112019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
10012
10013 * valops.c (value_slice): Check for not allocated or not
10014 associated values.
10015
9ab08412
TV
100162019-06-10 Tom de Vries <tdevries@suse.de>
10017
10018 PR gdb/24618
10019 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10020 sure an empty slot (defined by a 32-bit zero pair) is recognized as
10021 invalid.
10022
f19e22e9
TV
100232019-06-10 Tom de Vries <tdevries@suse.de>
10024
10025 PR gdb/24611
10026 * linespec.c (linespec_lexer_lex_string): Remove incorrect
10027 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
10028
e99f9db0
TV
100292019-06-10 Tom de Vries <tdevries@suse.de>
10030
10031 PR symtab/24545
10032 * symtab.c (struct demangled_name_entry): Add language field.
10033 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
10034 static minimal symbol". Set and use language field.
10035
9bf7038b
TT
100362019-06-10 Tom Tromey <tromey@adacore.com>
10037
10038 * ada-lang.c (_initialize_ada_language): Update help text.
10039
422186a9
TT
100402019-06-10 Tom Tromey <tromey@adacore.com>
10041
10042 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10043 with a newline.
10044 * guile/guile.c (handle_boot_error): Don't end warning with a
10045 newline.
10046 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10047 warning with a newline.
10048 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10049 newline.
10050 (s12z_frame_cache): Likewise.
10051 * dwarf-index-cache.c (index_cache::store): Don't end warning with
10052 a newline.
10053 * solib-svr4.c (disable_probes_interface): Don't end warning with
10054 a newline.
10055 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10056 newline.
10057 * python/python.c (do_finish_initialization): Don't end warning
10058 with a newline.
10059
25ce02ee
TT
100602019-06-10 Tom Tromey <tom@tromey.com>
10061
10062 * python/py-breakpoint.c (gdbpy_breakpoint_created)
10063 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10064 gdbpy_enter.
10065
caa429d8
TT
100662019-06-10 Tom Tromey <tromey@adacore.com>
10067
10068 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10069 data.
10070 (elf_new_init): Don't call stabsread_new_init.
10071 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10072 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
10073 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10074
81873cc8
TV
100752019-06-10 Tom de Vries <tdevries@suse.de>
10076
10077 PR symtab/16264
10078 PR symtab/24517
10079 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10080
4fa0265e
РИ
100812019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
10082
10083 * source.c (find_and_open_source): Also rewrite relative file
10084 names.
10085
1a3da2cd
AB
100862019-04-26 Amos Bird <amosbird@gmail.com>
10087
10088 * annotate.c (annotate_thread_exited): Add "thread-exited"
10089 annotation.
10090
3847a7bf
TT
100912019-06-06 Tom Tromey <tromey@adacore.com>
10092
10093 * maint.h (class scoped_command_stats): Use
10094 DISABLE_COPY_AND_ASSIGN.
10095 <print_time>: New method.
10096 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10097 print_time.
10098 (scoped_command_stats::print_time): New method.
10099
312617a3
AB
101002019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
10101
10102 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10103 instructions of lengths 6 or 8 bytes.
10104
b02f78f9
PA
101052019-06-04 Pedro Alves <palves@redhat.com>
10106
10107 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10108
10109 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10110 * breakpoint.c (condition_completer): Likewise.
10111 * cli/cli-dump.c (scan_expression): Likewise.
10112 * common/filestuff.c (mkdir_recursive): Likewise.
10113 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10114 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10115 (gdb_abspath): Likewise.
10116 * compile/compile-cplus-types.c
10117 (compile_cplus_instance::decl_name): Likewise.
10118 * completer.c (complete_explicit_location):
10119 (signal_completer, reg_or_group_completer_1): Likewise.
10120 * cp-support.c (cp_remove_params_if_any): Likewise.
10121 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10122 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10123 * infcmd.c (strip_bg_char): Likewise.
10124 * linespec.c (copy_token_string): Likewise.
10125 * mi/mi-main.c (output_cores): Likewise.
10126 * psymtab.c (psymtab_search_name):
10127 * symfile.c (test_set_ext_lang_command): Likewise.
10128 * target.c (target_fileio_read_stralloc): Likewise.
10129 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10130 * value.c (complete_internalvar): Likewise.
10131
e1f2e1a2
CB
101322019-06-04 Christian Biesinger <cbiesinger@google.com>
10133
10134 Add objfile property to gdb.Type.
d3238f7d
PA
10135 * NEWS: Mention Python API addition.
10136 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 10137
e664d728
PW
101382019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10139
10140 * NEWS: Mention the new set|show style [title|highlight].
10141 Mention changes to "show style", "help" and "apropos".
10142
66d8c862
PW
101432019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10144
10145 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10146 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10147 instead of print_help_for_command.
10148 (print_doc_of_command): New function.
10149 (help_list): Add 'apropos -v word' suggestion.
10150 (print_help_for_command): Style the command name using title style.
10151 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10152 (_initialize_cli_cmds): Describe -v in apropos_command help.
10153
9303eb2f
PW
101542019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10155
10156 * cli/cli-style.h (cli_style_option): Add name in constructor,
10157 add m_name class member, add constructor with intensity,
10158 add name class function.
10159 (cli_style_option::add_setshow_commands): Remove name argument.
10160 (highlight_style, title_style): New styles.
10161 * cli/cli-style.c (do_show): New function that shows a style
10162 characteristic styling the style name with itself.
10163 (set_style_name): New function.
10164 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10165 Update all callers according to the changes in cli/cli-style.h.
10166 * utils.h (fputs_highlighted): New function.
10167 * utils.c (fputs_highlighted): Likewise.
10168
e2c52041
PW
101692019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10170
10171 * NEWS: Mention new pipe command and new convenience variables.
10172
947d3946
PW
101732019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10174
10175 * cli/cli-cmds.c (pipe_command): New function.
10176 (_initialize_cli_cmds): Call add_com for pipe_command.
10177 Define | as an alias for pipe.
10178 (exit_status_set_internal_vars): New function.
10179 (shell_escape): Call exit_status_set_internal_vars.
10180 cli/cli-decode.c (find_command_name_length): Recognize | as
10181 a single character command.
10182
b8fd0918
PW
101832019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10184
10185 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10186 top.c (execute_command_to_ui_file): New function, mostly a copy
10187 of execute_command_to_string.
10188 (execute_command_to_string): Implement by calling
10189 execute_command_to_ui_file.
10190
68bb5386
PW
101912019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10192
10193 * top.h (saved_command_line): Remove declaration.
10194 * top.c (previous_saved_command_line, previous_repeat_arguments):
10195 New variables.
10196 (saved_command_line): Make static, define together with other
10197 'repeat variables'.
10198 (dont_repeat): Clear repeat_arguments.
10199 (repeat_previous, get_saved_command_line, save_command_line):
10200 New functions.
10201 (gdb_init): Initialize saved_command_line
10202 and previous_saved_command_line.
10203 * main.c (captured_main_1): Remove saved_command_line initialization.
10204 * event-top.c (handle_line_of_input): Update to use
10205 the new 'repeat' related functions instead of direct access to
10206 saved_command_line.
10207 * command.h (repeat_previous, get_saved_command_line,
10208 save_command_line): New declarations.
10209 (dont_repeat): Add comment.
10210
bfcdb852
TT
102112019-05-30 Tom Tromey <tromey@adacore.com>
10212
10213 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10214 Fix comment.
10215 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10216
0ef209f2
JV
102172019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10218
10219 PR cli/24587
10220 * completer.c (complete): Initialize variable word.
10221
955b06fa
SDJ
102222019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10223
10224 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10225 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10226 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10227 'body' is NULL to the outter 'if', protecting the '!is_define'
10228 situation as well.
10229
fa9c3fa0
TT
102302019-05-29 Tom Tromey <tromey@adacore.com>
10231
10232 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10233 (dwarf_unknown): New function.
10234 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10235 (dwarf_type_encoding_name): Use dwarf_unknown.
10236
4330d61d
TT
102372019-05-29 Tom Tromey <tromey@adacore.com>
10238
10239 PR c++/20020:
10240 * cp-valprint.c (cp_print_value_fields): Call
10241 cp_print_static_field inside "try".
10242
33a6bc35
TT
102432019-05-29 Tom Tromey <tromey@adacore.com>
10244
10245 * inflow.c (struct terminal_info): Add default operator=.
10246 * configure: Rebuild.
10247 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10248 -Wdeprecated-copy-dtor, -Wredundant-move.
10249
000439d5
TT
102502019-05-29 Tom Tromey <tromey@adacore.com>
10251
10252 * NEWS: Add entry.
10253 * infcmd.c (print_return_value_1): Handle finish_print
10254 option.
10255 (show_print_finish): New function.
10256 (_initialize_infcmd): Add "set/show print finish" commands.
10257 * valprint.c (user_print_options): Initialize new member.
10258 * valprint.h (struct value_print_options) <finish_print>: New
10259 member.
10260
c0e70c62
TT
102612019-05-28 Tom Tromey <tromey@adacore.com>
10262
10263 * ada-lang.c (ada_remove_Xbn_suffix)
10264 (find_old_style_renaming_symbol)
10265 (parse_old_style_renaming): Remove.
10266 (ada_find_renaming_symbol): Don't call
10267 find_old_style_renaming_symbol.
10268 (ada_is_renaming_symbol): Rename from
10269 ada_find_renaming_symbol. Remove "block" parameter. Return
10270 bool. Now static.
10271 (ada_read_var_value): Update and simplify.
10272 * ada-exp.y (write_var_or_type): Remove old code.
10273
766f8836
AH
102742019-05-28 Alan Hayward <alan.hayward@arm.com>
10275
68255adc 10276 PR gdb/25010
766f8836
AH
10277 * event-top.c: Remove include comment.
10278 * inflow.c (class scoped_ignore_sigttou): Move from here...
10279 * inflow.h (class scoped_ignore_sigttou): ...to here.
10280 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10281 * top.c: Remove include comment.
10282
eb41253a
TT
102832019-05-27 Tom Tromey <tom@tromey.com>
10284
10285 * NEWS: Fix typo.
10286
4ca51187
TT
102872019-05-22 Tom Tromey <tromey@adacore.com>
10288
10289 * target.c (target_follow_exec): Constify parameter.
10290 * target-delegates.c: Rebuild.
10291 * remote.c (remote_target::follow_exec): Constify parameter.
10292 * infrun.c (follow_exec): Constify parameter.
10293 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10294 (target_follow_exec): Likewise.
10295
8fca4da0
AH
102962019-05-22 Alan Hayward <alan.hayward@arm.com>
10297
10298 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10299 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10300
b7060614
AH
103012019-05-22 Alan Hayward <alan.hayward@arm.com>
10302
10303 * NEWS: Add debugredirect and testsuite sections.
10304
0a5954bd
SC
103052019-05-22 Simon Cook <simon.cook@embecosm.com>
10306
10307 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10308 target descriptions using exclusively floating point register name
10309 aliases.
10310
dc42e902
AB
103112019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10312
10313 PR gdb/18644:
10314 * f-lang.c (build_fortran_types): Handle the case where
10315 gdbarch_floatformat_for_type returns a nullptr.
10316
fb7806c7
TV
103172019-05-21 Tom de Vries <tdevries@suse.de>
10318
10319 PR cli/24587
10320 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10321
34d11c68
AB
103222019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10323
10324 PR gdb/18644:
10325 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10326 16-byte floats.
10327 * i386-tdep.c (i386_floatformat_for_type): Use
10328 floatformats_ia64_quad for the 16-byte floating point component
10329 within a fortran 32-byte complex number.
10330
122cf0f2
AB
103312019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10332
10333 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10334 delete default constructor.
10335 (find_partial_die): Update to return const struct.
10336 (partial_die_parent_scope): Move variable declaration into scope
10337 of its use and change its type to auto.
10338 (guess_partial_die_structure_name): Likewise.
10339 (partial_die_info::fixup): Likewise.
10340
33d0e35a
TT
103412019-05-17 Tom Tromey <tromey@adacore.com>
10342
10343 * source.c (find_and_open_source): Remove cast.
10344
a45575b0
TT
103452019-05-17 Tom Tromey <tromey@adacore.com>
10346
10347 * annotate.c (annotate_source): Make "filename" const.
10348 * annotate.h (annotate_source): Use const.
10349
81f47ac2
AH
103502019-05-17 Alan Hayward <alan.hayward@arm.com>
10351
10352 * disasm.c (set_disassembler_options): Send errors to stderr.
10353
ca1285d1
AH
103542019-05-17 Alan Hayward <alan.hayward@arm.com>
10355
10356 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10357 (cli_interp_base::set_logging): Check debug_redirect.
10358 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10359 * cli/cli-logging.c (debug_redirect): Add static variable.
10360 (pop_output_files): Add default param.
10361 (handle_redirections): Print debug setting.
10362 (show_logging_command): Likewise.
10363 (_initialize_cli_logging): Add debugredirect command.
10364 * interps.c (current_interp_set_logging): Add debug_redirect
10365 parameter.
10366 * interps.h (set_logging): Add debug_redirect parameter.
10367 (current_interp_set_logging): Likewise.
10368 * mi/mi-common.h: Likewise.
10369 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10370
103712019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
10372 Tom Tromey <tromey@adacore.com>
10373
10374 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10375 directly.
10376 * cli/cli-interp.h (make_logging_output): Remove declaration.
10377 * cli/cli-logging.c (make_logging_output): Remove function.
10378 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10379 directly.
10380 * ui-file.c (tee_file::tee_file): Remove bools.
10381 (tee_file::~tee_file): Remove deletes.
10382 * ui-file.h (tee_file): Remove bools.
10383
26648588
JV
103842019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10385
10386 * mi/mi-cmds.h (mi_cmd_complete): New function.
10387 * mi/mi-main.c (mi_cmd_complete): Likewise.
10388 * mi/mi-cmds.c: Define new MI command -complete.
10389 * NEWS: Mention new -complete command.
10390
6e035501
JV
103912019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10392
10393 * completer.h (complete): New function.
10394 * completer.c (complete): Likewise.
10395 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10396 function defined in completer.h.
10397
7d0e2ece
JV
103982019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10399
e79be6e5 10400 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 10401
fb816e8b
TV
104022019-05-17 Tom de Vries <tdevries@suse.de>
10403
10404 PR gdb/24094
10405 * dwarf2read.c (struct cu_partial_die_info): New struct.
10406 (find_partial_die): Return cu_partial_die_info.
10407 (partial_die_parent_scope, guess_partial_die_structure_name)
10408 (partial_die_info::fixup): Handle new return type of find_partial_die.
10409
677052f2
SDJ
104102019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10411
a1726c38 10412 PR breakpoints/24541
677052f2
SDJ
10413 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10414 "std::string", simplifying the algorithm.
10415
f3da9116
SDJ
104162019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10417
10418 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10419 (stap_static_probe_ops::get_probes): Likewise.
10420
f1bb75ab
SDJ
104212019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10422
10423 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10424 '-')" and "else if".
10425 (stap_parse_single_operand): Join checks for
10426 "gdbarch_stap_parse_special_token_p" and
10427 "gdbarch_stap_parse_special_token" in the same "if" statement.
10428 Invert check when verifying for operation on register
10429 displacement.
10430
3ca58cde
SDJ
104312019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10432
10433 * stap-probe.c (stap_get_opcode): Update comment.
10434 (stap_get_expected_argument_type): Likewise.
10435 (handle_stap_probe): Likewise.
10436
af2d9bee
SDJ
104372019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10438
10439 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10440 return type to 'bool'. Adjust comment. Use 'bool' when
10441 appropriate.
10442 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10443 * stap-probe.c (stap_parse_argument_1): Likewise.
10444 (stap_is_operator): Likewise.
10445 (stap_is_generic_prefix): Likewise.
10446 (stap_is_register_prefix): Likewise.
10447 (stap_is_register_indirection_prefix): Likewise.
10448 (stap_is_integer_prefix): Likewise.
10449 (stap_generic_check_suffix): Likewise.
10450 (stap_check_integer_suffix): Likewise.
10451 (stap_check_register_suffix): Likewise.
10452 (stap_check_register_indirection_suffix): Likewise.
10453 (stap_parse_register_operand): Likewise.
10454 (stap_parse_single_operand): Likewise.
10455 (stap_parse_argument_1): Likewise.
10456 (stap_probe::get_argument_count): Likewise.
10457 (stap_is_operator): Likewise.
10458
61c9c421
TT
104592019-05-16 Tom Tromey <tromey@adacore.com>
10460
10461 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10462 keyword to foreach.
10463
9ddc1af1
SM
104642019-05-15 Simon Marchi <simon.marchi@efficios.com>
10465
10466 * linux-thread-db.c (try_thread_db_load_1): Change return type
10467 to bool.
10468 (try_thread_db_load): Likewise.
10469 (try_thread_db_load_from_pdir_1): Likewise.
10470 (try_thread_db_load_from_pdir): Likewise.
10471 (try_thread_db_load_from_sdir): Likewise.
10472 (try_thread_db_load_from_dir): Likewise.
10473 (thread_db_load_search): Likewise.
10474 (has_libpthread): Likewise.
10475 (thread_db_load): Likewise.
10476
7bede828
SDJ
104772019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10478
10479 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10480 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10481 NULL, and complain/return if that's the case.
10482
c5358db4
JD
104832019-05-15 John Darrington <john@darrington.wattle.id.au>
10484
10485 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10486 (advance, posn, abstract_read_memory): New functions.
10487 [struct mem_read_abstraction]: New struct.
10488 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10489
c408a94f
TT
104902019-05-14 Tom Tromey <tromey@adacore.com>
10491
10492 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10493 value is not lval_memory.
10494
e7bd7fba
TT
104952019-05-14 Tom Tromey <tromey@adacore.com>
10496
10497 * solib.c (info_sharedlibrary_command): Style the file name.
10498
a6d0f249
AH
104992019-05-14 Alan Hayward <alan.hayward@arm.com>
10500
10501 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10502 (aarch64_vnv_type): Likewise.
10503 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10504 * common/tdesc.c: Likewise.
10505 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10506 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10507 * features/aarch64-fpu.xml: Add ieee half view.
10508 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10509 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10510 * gdbtypes.h (struct builtin_type): Likewise.
10511 (struct objfile_type): Likewise.
10512
66b8bb74
SM
105132019-05-12 Paul Naert <paul.naert@polymtl.ca>
10514
10515 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10516 typo.
10517 * location.h (string_to_event_location): Likewise.
10518
21c219fd
JB
105192019-05-11 Joel Brobecker <brobecker@adacore.com>
10520
10521 GDB 8.3 released.
10522
13674803
SM
105232019-05-10 Simon Marchi <simon.marchi@efficios.com>
10524
10525 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10526 New variable declaration.
10527 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10528 New variable.
10529 (print_one_breakpoint): Use ui_out::test_flags and new global
10530 variable to compute use_fixed_output.
10531 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10532 Remove.
10533 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10534 (mi_multi_location_breakpoint_output_fixed): Remove.
10535 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10536 new variable.
10537 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10538 fix_multi_location_breakpoint_output flag if version >= 3.
10539 * ui-out.h (enum ui_out_flag)
10540 <fix_multi_location_breakpoint_output>: New enumerator.
10541
a9eac7f9
SM
105422019-05-10 Simon Marchi <simon.marchi@efficios.com>
10543
10544 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10545
71bed2db
TT
105462019-05-10 Tom Tromey <tromey@adacore.com>
10547
10548 * ada-lang.c (catch_ada_completer): New function.
10549 (_initialize_ada_language): Use it.
10550
24c54127
TT
105512019-05-10 Tom Tromey <tromey@adacore.com>
10552
10553 * thread.c (print_thread_info): Make "requested_threads" const.
10554 * gdbthread.h (print_thread_info): Make "requested_threads"
10555 const.
10556 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10557 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10558
7a102139
TT
105592019-05-08 Tom Tromey <tom@tromey.com>
10560
10561 * gdbtypes.c (objfile_type_data): Change type.
10562 (objfile_type, _initialize_gdbtypes): Update.
10563
924d79e2
TT
105642019-05-08 Tom Tromey <tom@tromey.com>
10565
10566 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10567 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10568 (_initialize_dwarf2_frame): Update.
10569
4c58e337
TT
105702019-05-08 Tom Tromey <tom@tromey.com>
10571
10572 * objc-lang.c (objc_objfile_data): Change type.
10573 (find_methods): Update.
10574 (_initialize_objc_lang): Remove.
10575
d772d2ab
TT
105762019-05-08 Tom Tromey <tom@tromey.com>
10577
10578 * stabsread.c (rs6000_builtin_type_data): Change type.
10579 (rs6000_builtin_type, _initialize_stabsread): Update.
10580
d11d83f4
TT
105812019-05-08 Tom Tromey <tom@tromey.com>
10582
10583 * mips-tdep.c (mips_pdr_data): Remove.
10584 (_initialize_mips_tdep): Update.
10585
9a73f0ad
TT
105862019-05-08 Tom Tromey <tom@tromey.com>
10587
10588 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10589 (hppa_init_objfile_priv_data, read_unwind_info)
10590 (find_unwind_entry, _initialize_hppa_tdep): Update.
10591
8127a2fa
TT
105922019-05-08 Tom Tromey <tom@tromey.com>
10593
10594 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10595 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10596 on obstack.
10597 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10598
91d3055d
TT
105992019-05-08 Tom Tromey <tom@tromey.com>
10600
10601 * mdebugread.c (basic_type_data): Change type.
10602 (basic_type, _initialize_mdebugread): Update.
10603
31930bd3
TT
106042019-05-08 Tom Tromey <tom@tromey.com>
10605
10606 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10607
bdb3ed9e
TT
106082019-05-08 Tom Tromey <tom@tromey.com>
10609
10610 * nto-tdep.c (nto_inferior_data_reg): Change type.
10611 (nto_inferior_data): Update.
10612 (nto_inferior_data_cleanup, nto_new_inferior_data)
10613 (_initialize_nto_tdep): Remove.
10614 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10615
f37b313d
TT
106162019-05-08 Tom Tromey <tom@tromey.com>
10617
10618 * ada-lang.c (struct ada_inferior_data): Add initializers.
10619 (ada_inferior_data): Change type.
10620 (ada_inferior_data_cleanup): Remove.
10621 (get_ada_inferior_data, ada_inferior_exit)
10622 (struct ada_pspace_data): Add initializers, destructor.
10623 (ada_pspace_data_handle): Change type.
10624 (get_ada_pspace_data): Update.
10625 (ada_pspace_data_cleanup): Remove.
10626
24699405
TT
106272019-05-08 Tom Tromey <tom@tromey.com>
10628
10629 * coffread.c (struct coff_symfile_info): Add initializers.
10630 (coff_objfile_data_key): Move lower. Change type.
10631 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10632 Update.
10633 (coff_free_info): Remove.
10634
d4e05d2f
TT
106352019-05-08 Tom Tromey <tom@tromey.com>
10636
10637 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10638 (fbsd_pspace_data_handle): Move lower. Change type.
10639 (get_fbsd_pspace_data): Update.
10640 (fbsd_pspace_data_cleanup): Remove.
10641 (_initialize_fbsd_tdep): Update.
10642
14ef6690
TT
106432019-05-08 Tom Tromey <tom@tromey.com>
10644
10645 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10646 (get_ada_tasks_pspace_data): Update.
10647 (ada_tasks_pspace_data_cleanup): Remove.
10648 (_initialize_tasks): Update.
10649 (ada_tasks_inferior_data_handle): Change type.
10650 (get_ada_tasks_inferior_data): Update.
10651 (ada_tasks_inferior_data_cleanup): Remove.
10652 (struct ada_tasks_pspace_data): Add initializers.
10653
814cf43a
TT
106542019-05-08 Tom Tromey <tom@tromey.com>
10655
10656 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10657 * symfile-debug.c (debug_sym_get_probes): Change type.
10658 * stap-probe.c (handle_stap_probe):
10659 (stap_static_probe_ops::get_probes): Change type.
10660 * probe.h (class static_probe_ops) <get_probes>: Change type.
10661 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10662 (parse_probes_in_pspace): Update.
10663 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10664 Update.
10665 (any_static_probe_ops::get_probes): Change type.
10666 * elfread.c (elfread_data): New typedef.
10667 (probe_key): Change type.
10668 (elf_get_probes): Likewise. Update.
10669 (probe_key_free): Remove.
10670 (_initialize_elfread): Update.
10671 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10672 Change type.
10673 (dtrace_process_dof_probe, dtrace_process_dof)
10674 (dtrace_static_probe_ops::get_probe): Change type.
10675
02dc647e
TT
106762019-05-08 Tom Tromey <tom@tromey.com>
10677
10678 * xcoffread.c (struct xcoff_symfile_info): Rename from
10679 coff_symfile_info. Add initializers.
10680 (xcoff_objfile_data_key): Move lower. Change type.
10681 (XCOFF_DATA): Rewrite.
10682 (xcoff_free_info): Remove.
10683 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10684 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10685 (xcoff_initial_scan): Update.
10686
09232438
TT
106872019-05-08 Tom Tromey <tom@tromey.com>
10688
10689 * solib-svr4.c (struct svr4_info): Add initializers and
10690 destructor.
10691 <probes_table>: Now an htab_up.
10692 (solib_svr4_pspace_data): Change type.
10693 (free_probes_table): Simplify.
10694 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10695 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10696 (probes_table_remove_objfile_probes, register_solib_event_probe)
10697 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10698 (_initialize_svr4_solib): Update.
10699
7b4a314f
TT
107002019-05-08 Tom Tromey <tom@tromey.com>
10701
10702 * remote.c (remote_pspace_data): Change type.
10703 (remote_pspace_data_cleanup): Remove.
10704 (get_remote_exec_file, set_pspace_remote_exec_file)
10705 (_initialize_remote): Update.
10706
51d3063a
TT
107072019-05-08 Tom Tromey <tom@tromey.com>
10708
10709 * breakpoint.c (breakpoint_objfile_key): Change type.
10710 (get_breakpoint_objfile_data): Update.
10711 (free_breakpoint_objfile_data): Remove.
10712 (_initialize_breakpoint): Update.
10713
89fb8848
TT
107142019-05-08 Tom Tromey <tom@tromey.com>
10715
10716 * linux-tdep.c (struct linux_info): Add initializers.
10717 (linux_inferior_data): Move. Change type.
10718 (invalidate_linux_cache_inf): Update.
10719 (linux_inferior_data_cleanup): Remove.
10720 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10721
e9b89e2d
TT
107222019-05-08 Tom Tromey <tom@tromey.com>
10723
10724 * auxv.c (auxv_inferior_data): Move. Change type.
10725 (auxv_inferior_data_cleanup): Remove.
10726 (invalidate_auxv_cache_inf): Rewrite.
10727 (get_auxv_inferior_data, _initialize_auxv): Update.
10728
8c42777c
TT
107292019-05-08 Tom Tromey <tom@tromey.com>
10730
10731 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10732 (symfile_debug_objfile_data_key): Change type.
10733 (symfile_debug_installed, debug_qf_has_symbols)
10734 (debug_qf_find_last_source_symtab)
10735 (debug_qf_forget_cached_source_info)
10736 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10737 (debug_qf_print_stats, debug_qf_dump)
10738 (debug_qf_expand_symtabs_for_function)
10739 (debug_qf_expand_all_symtabs)
10740 (debug_qf_expand_symtabs_with_fullname)
10741 (debug_qf_map_matching_symbols)
10742 (debug_qf_expand_symtabs_matching)
10743 (debug_qf_find_pc_sect_compunit_symtab)
10744 (debug_qf_map_symbol_filenames)
10745 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10746 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10747 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10748 (debug_sym_read_linetable, debug_sym_relocate): Update.
10749 (symfile_debug_free_objfile): Remove.
10750 (install_symfile_debug_logging, _initialize_symfile_debug):
10751 Update.
10752
5bfd760d
TT
107532019-05-08 Tom Tromey <tom@tromey.com>
10754
10755 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10756 allocate_on_obstack.
10757 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10758 (get_dwarf2_per_objfile): Update.
10759 (set_dwarf2_per_objfile): Remove.
10760 (dwarf2_has_info, dwarf2_get_section_info): Update.
10761 (dwarf2_free_objfile): Remove.
10762 (_initialize_dwarf2_read): Update.
10763
e85e19b4
TT
107642019-05-08 Tom Tromey <tom@tromey.com>
10765
10766 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10767 initializers.
10768 <unsupported_script_warning_printed,
10769 script_not_found_warning_printed>: Now bool.
10770 (auto_load_pspace_data): Change type.
10771 (~auto_load_pspace_info): Rename from
10772 auto_load_pspace_data_cleanup.
10773 (get_auto_load_pspace_data, init_loaded_scripts_info)
10774 (clear_section_scripts, maybe_print_unsupported_script_warning)
10775 (maybe_print_script_not_found_warning, _initialize_auto_load):
10776 Update.
10777
f6aa7436
TT
107782019-05-08 Tom Tromey <tom@tromey.com>
10779
10780 * objfiles.c (objfile_pspace_info): Add destructor and
10781 initializers.
10782 (objfiles_pspace_data): Change type.
10783 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10784 (get_objfile_pspace_data): Update.
10785 (objfiles_bfd_data): Change type.
10786 (get_objfile_bfd_data): Update.
10787 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10788
6ae614f6
TT
107892019-05-08 Tom Tromey <tom@tromey.com>
10790
10791 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10792 Change type.
10793 (get_catch_syscall_inferior_data): Update.
10794 (catch_syscall_inferior_data_cleanup): Remove.
10795 (_initialize_break_catch_syscall): Update.
10796
6509b8eb
TT
107972019-05-08 Tom Tromey <tom@tromey.com>
10798
10799 * inflow.c (struct terminal_info): Add destructor and
10800 initializers.
10801 (inflow_inferior_data): Change type.
10802 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10803 (get_inflow_inferior_data, inflow_inferior_exit)
10804 (swap_terminal_info, _initialize_inflow): Update.
10805
35632941
TT
108062019-05-08 Tom Tromey <tom@tromey.com>
10807
10808 * target-dcache.c (target_dcache_cleanup): Remove.
10809 (target_dcache_aspace_key): Change type.
10810 (target_dcache_init_p, target_dcache_invalidate)
10811 (target_dcache_get, target_dcache_get_or_init)
10812 (_initialize_target_dcache): Update.
10813 * dcache.h (struct dcache_deleter): New.
10814
3017b94d
TT
108152019-05-08 Tom Tromey <tom@tromey.com>
10816
10817 * symtab.c (struct symbol_cache): Add destructor and
10818 initializers.
10819 (symbol_cache_key): Move. Change type.
10820 (make_symbol_cache, free_symbol_cache): Remove.
10821 (get_symbol_cache): Update.
10822 (symbol_cache_cleanup): Remove.
10823 (ALL_PSPACES, symbol_cache_flush)
10824 (maintenance_print_symbol_cache)
10825 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10826 Update.
10827
a32ad8c5
TT
108282019-05-08 Tom Tromey <tom@tromey.com>
10829
10830 * symtab.c (struct main_info): Add destructor and initializers.
10831 (main_progspace_key): Move. Change type.
10832 (get_main_info): Update.
10833 (main_info_cleanup): Remove.
10834 (_initialize_symtab): Update.
10835
5f6e90a0
TT
108362019-05-08 Tom Tromey <tom@tromey.com>
10837
10838 * registry.h (DECLARE_REGISTRY): Define the _key class.
10839
1bd0c6e4
AB
108402019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10841
10842 * NEWS: Merge two 'New commands' sections.
10843
2228ef77
XR
108442019-05-08 Joel Brobecker <brobecker@adacore.com>
10845
10846 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10847 parameter and use Ada language definition instead.
10848 (ada_val_print_ptr): Remove unused language parameter.
10849 (ada_val_print_num): Remove language parameter and use Ada language
10850 definition instead.
10851 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10852 parameter.
10853 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10854 parameter and use Ada language definition instead.
10855 (ada_val_print_1): Update all ada_val_print_xxx calls.
10856 Remove language parameter.
10857 (ada_val_print): Update ada_val_print_1 call.
10858
60fcc1c3
TT
108592019-05-08 Tom Tromey <tromey@adacore.com>
10860
10861 * remote.c (remote_hw_watchpoint_limit)
10862 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10863 Now static.
10864
ed2b7c17
TT
108652019-05-08 Tom Tromey <tromey@adacore.com>
10866
10867 * maint.c (_initialize_maint_cmds): Move initialization code to
10868 remote.c.
10869 (watchdog, show_watchdog): Move to remote.c.
10870 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10871 "watchdog" static.
10872 (_initialize_remote): Move initialization code from maint.c.
10873 * defs.h (watchdog): Don't declare.
10874
b0be6c91
TT
108752019-05-08 Tom Tromey <tromey@adacore.com>
10876
10877 * tui/tui-interp.c: Include main.h.
10878 * interps.c: Include main.h.
10879 * main.h (interpreter_p): Declare.
10880 * defs.h (interpreter_p): Don't declare.
10881
587ee17b
TT
108822019-05-08 Tom Tromey <tromey@adacore.com>
10883
10884 * dwarf2loc.c: Include dwarf2read.h.
10885 * defs.h (read_unsigned_leb128): Don't declare.
10886 * dwarf2read.h (read_unsigned_leb128): Declare.
10887
ca1df239
TT
108882019-05-08 Tom Tromey <tromey@adacore.com>
10889
10890 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10891 method.
10892
99f20f08
TT
108932019-05-08 Tom Tromey <tromey@adacore.com>
10894
10895 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10896 when no wrap column is set.
10897
80e55b13
TT
108982019-05-08 Tom Tromey <tromey@adacore.com>
10899
10900 * c-lang.c (c_get_string): Handle non-C-style arrays.
10901
9d3421af
TT
109022019-05-08 Tom Tromey <tromey@adacore.com>
10903
10904 * typeprint.c (print_offset_data::update): Print the bit offset,
10905 not the number of bits remaining.
10906
844333e2
TT
109072019-05-08 Tom Tromey <tromey@adacore.com>
10908
10909 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10910 padding at end of comment.
10911
988915ee
TT
109122019-05-08 Tom Tromey <tromey@adacore.com>
10913
10914 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10915 Compare main types.
10916
26bfd823
TT
109172019-05-06 Tom Tromey <tom@tromey.com>
10918
10919 * common/scoped_mmap.c: Include common-defs.h.
10920 * common/scoped_mmap.h: Don't include config.h.
10921
89055eaa
TT
109222019-05-04 Tom Tromey <tom@tromey.com>
10923
10924 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10925 (struct aarch64_call_info): Add initializers.
10926 <si>: Now a std::vector.
10927 (pass_on_stack, aarch64_push_dummy_call): Update.
10928
5da01df5
TT
109292019-05-04 Simon Marchi <simon.marchi@efficios.com>
10930 Tom Tromey <tom@tromey.com>
10931
10932 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10933 (ppc_threads): Now a std::vector. Now static.
10934 (hwdebug_find_thread_points_by_tid)
10935 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10936 Update.
10937
fbdf05a1
TT
109382019-05-04 Tom Tromey <tom@tromey.com>
10939
10940 * arc-tdep.c (arc_tdesc_init): Return bool.
10941
06d16ec9
TT
109422019-05-04 Tom Tromey <tom@tromey.com>
10943
10944 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10945 Use gdb_assert_not_reached.
10946
9c056022
TT
109472019-05-04 Tom Tromey <tom@tromey.com>
10948
10949 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10950 "false".
10951
fa9c2a59
TT
109522019-05-04 Tom Tromey <tom@tromey.com>
10953
10954 * arc-tdep.c (arc_tdesc_init): Use bool.
10955
e2eb806a
TT
109562019-05-04 Tom Tromey <tom@tromey.com>
10957
10958 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10959
6fe87677
TT
109602019-05-04 Tom Tromey <tom@tromey.com>
10961
10962 * cli/cli-cmds.c (valid_command_p): Return bool.
10963
7f008c9e
TT
109642019-05-04 Tom Tromey <tom@tromey.com>
10965
10966 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10967 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10968
b6484282
RT
109692019-05-04 Raul Tambre <raul@tambre.ee>
10970
10971 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10972 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10973 operator for comparison.
10974
af97b416
TT
109752019-05-04 Tom Tromey <tom@tromey.com>
10976
10977 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10978 (lookup_partial_symbol, print_partial_symbols)
10979 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10980 (psymbol_compare): Update.
10981 (add_psymbol_to_bcache): Clear the entire psymbol.
10982 (maintenance_check_psymtabs): Update.
10983 * psympriv.h (struct partial_symbol): Don't derive from
10984 general_symbol_info.
10985 <obj_section, unrelocated_address, address,
10986 set_unrelocated_address>: Update.
10987 <ginfo>: New member.
10988 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10989 (debug_names::write_psymbols): Update.
10990
9d6d4be8
TV
109912019-05-04 Tom de Vries <tdevries@suse.de>
10992
10993 * contrib/cc-with-tweaks.sh: Support -n arg.
10994
66452beb
PW
109952019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10996
10997 * corelow.c (core_target::detach): Ensure frame cache and
10998 register caches are cleared.
10999 inferior.c (exit_inferior_1): Likewise.
11000
bde09ab7
TT
110012019-05-03 Sandra Loosemore <sandra@codesourcery.com>
11002 Tom Tromey <tom@tromey.com>
11003
11004 * dictionary.c (collate_pending_symbols_by_language): Remove
11005 "struct" from foreach.
11006 * symtab.c (lookup_global_symbol_from_objfile)
11007 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
11008 foreach.
11009 * ser-tcp.c (net_open): Remove "struct" from foreach.
11010 * objfiles.c (objfile_relocate, objfile_rebase)
11011 (objfile_has_symbols): Remove "struct" from foreach.
11012 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11013 from foreach.
11014 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11015 foreach.
11016 * darwin-nat.c (thread_info_from_private_thread_info): Remove
11017 "struct" from foreach.
11018 * ada-lang.c (create_excep_cond_exprs)
11019 (ada_exception_catchpoint_cond_string): Remove "struct" from
11020 foreach.
11021
222a8d25
TT
110222019-05-03 Tom Tromey <tromey@adacore.com>
11023
11024 * ada-exp.y (convert_char_literal): Check suffix of each
11025 enumerator.
11026
fcd60b84
DP
110272019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
11028
11029 PR ada/21406:
11030 * ada-exp.y (yywrap): Don't define.
11031 * ada-lex.l (%option): Add noyywrap
11032 (yywrap): Remove.
11033
5f2459c2
EZ
110342019-05-03 Eli Zaretskii <eliz@gnu.org>
11035
353ea2d1
EZ
11036 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11037 _WIN32_WINNT to the XP level, unless already defined to a higher
11038 level.
11039
11040 * unittests/parse-connection-spec-selftests.c:
11041 * ser-tcp.c:
11042 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
11043 override.
11044
5f2459c2
EZ
11045 * symfile.c (find_separate_debug_file): Remove colon from the
11046 drive spec of DOS/Windows file names of the target, so that the
11047 file name produced from DEBUGDIR and the target's directory will
11048 be valid on DOS/Windows systems.
11049
80062eb9
AB
110502019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
11051
11052 * rust-lang.c (val_print_struct): Handle printing structures
11053 containing strings.
11054
b8c05e85
TT
110552019-05-02 Tom Tromey <tromey@adacore.com>
11056
11057 * valarith.c (_initialize_valarith): Remove.
11058
4504bbde
TT
110592019-05-01 Tom Tromey <tromey@adacore.com>
11060
11061 * ada-lang.c (ada_value_primitive_field): Treat more fields as
11062 bitfields.
11063
d48e62f4
TT
110642019-05-01 Tom Tromey <tromey@adacore.com>
11065
11066 * ada-lang.c (ada_value_assign): Correctly compute starting offset
11067 for big-endian copies.
11068
15f18d14
AT
110692019-04-30 Ali Tamur <tamur@google.com>
11070 * gdb/dwarf2read.c (read_3_bytes): New declaration.
11071 (read_attribute_value): Added DW_FORM_strx1-4 cases.
11072 (read_3_bytes): New function.
11073
ab4ee614
JB
110742019-04-30 Joel Brobecker <brobecker@adacore.com>
11075
11076 * windows-nat.c (main_thread_id): Delete.
11077 (handle_output_debug_string): Replace main_thread_id by
11078 current_event.dwThreadId.
11079 (fake_create_process): Likewise.
11080 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11081 Do not set main_thread_id.
11082 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11083 current_event.dwThreadId.
11084 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11085
8ed5b76e
JB
110862019-04-30 Joel Brobecker <brobecker@adacore.com>
11087
11088 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11089 Use current_event.dwThreadId instead of main_thread_id.
11090
2ff0a947
TT
110912019-04-30 Tom Tromey <tromey@adacore.com>
11092
11093 * ada-lang.c (ada_lookup_simple_minsyms): New function.
11094 (create_excep_cond_exprs): Iterate over program spaces.
11095 (ada_exception_catchpoint_cond_string): Examine all minimal
11096 symbols for exception types.
11097
a776957c
TT
110982019-04-30 Tom Tromey <tromey@adacore.com>
11099
11100 PR c++/24470:
11101 * dwarf2read.c (process_structure_scope): Handle case where type
11102 has template parameters but no symbol was created.
11103
bc68014d
AB
111042019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11105 Chris January <chris.january@arm.com>
11106
11107 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11108 qualifier.
11109 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11110
f1fdc960
AB
111112019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11112
11113 * f-typeprint.c (f_print_type): Update rules for printing
11114 whitespace.
11115 (f_type_print_varspec_suffix): Likewise.
11116
bf7a4de1
AB
111172019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11118 Chris January <chris.january@arm.com>
11119
11120 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11121 function arguments.
11122
bbe75b9d
AB
111232019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11124
11125 * f-lang.c (build_fortran_types): Change name of void type to
11126 lower case.
11127 * f-typeprint.c (f_type_print_base): Print the name of the void
11128 type, rather than a fixed string.
11129 * f-valprint.c (f_decorations): Use lower case void string.
11130
1db455a7
AB
111312019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11132 Chris January <chris.january@arm.com>
11133
11134 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11135 types for Fortran.
11136
b6d03bb2
AB
111372019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11138 Chris January <chris.january@arm.com>
11139 David Lecomber <david.lecomber@arm.com>
11140
11141 * f-exp.y (BINOP_INTRINSIC): New token.
11142 (exp): New parser rule handling BINOP_INTRINSIC.
11143 (f77_keywords): Add new builtin procedures.
11144 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11145 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11146 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11147 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11148 (print_unop_subexp_f): New function.
11149 (print_binop_subexp_f): New function.
11150 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11151 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11152 (dump_subexp_body_f): Likewise.
11153 (operator_check_f): Likewise.
11154 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11155 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11156
83228e93
AB
111572019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11158
11159 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11160 UNOP_KIND.
11161 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11162 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11163 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11164 (operator_length_f): New fuction.
11165 (print_subexp_f): New function.
11166 (op_name_f): New function.
11167 (dump_subexp_body_f): New function.
11168 (operator_check_f): New function.
11169 (exp_descriptor_f): Replace standard expression handling functions
11170 with new functions.
11171 * gdb/fortran-operator.def: New file.
11172 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11173 * gdb/std-operator.def: Remove UNOP_KIND.
11174
6fdcd7cc
AB
111752019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11176
11177 * std-operator.def: Remove unbalanced, stray double quote
11178 character.
11179
2e62ab40
AB
111802019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11181 Chris January <chris.january@arm.com>
11182 Daniel Everett <daniel.everett@arm.com>
11183 Nick Forrington <nick.forrington@arm.com>
11184 Richard Bunt <richard.bunt@arm.com>
11185
11186 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11187 of depth when printing anonymous structs or unions.
11188 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11189 Don't print either the top-level value, or the children if the
11190 max-depth is exceeded.
11191 (ppscm_print_children): When printing the key of a map, allow one
11192 extra level of depth.
11193 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11194 print either the top-level value, or the children if the max-depth
11195 is exceeded.
11196 (print_children): When printing the key of a map, allow one extra
11197 level of depth.
11198 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11199 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11200 (user_print_options): Initialise max_depth field.
11201 (val_print_scalar_or_string_type_p): New function.
11202 (val_print): Check to see if the max depth has been reached.
11203 (val_print_check_max_depth): Define new function.
11204 (show_print_max_depth): New function.
11205 (_initialize_valprint): Add 'print max-depth' option.
11206 * valprint.h (struct value_print_options) <max_depth>: New field.
11207 (val_print_check_max_depth): Declare new function.
11208 * NEWS: Document new feature.
11209
4be290b2
AB
112102019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11211
11212 * ada-lang.c (ada_language_defn): Initialise new field.
11213 * c-lang.c (c_is_string_type_p): New function.
11214 (c_language_defn): Initialise new field.
11215 (cplus_language_defn): Initialise new field.
11216 (asm_language_defn): Initialise new field.
11217 (minimal_language_defn): Initialise new field.
11218 * c-lang.h (c_is_string_type_p): Declare new function.
11219 * d-lang.c (d_language_defn): Initialise new field.
11220 * f-lang.c (f_is_string_type_p): New function.
11221 (f_language_defn): Initialise new field.
11222 * go-lang.c (go_is_string_type_p): New function.
11223 (go_language_defn): Initialise new field.
11224 * language.c (default_is_string_type_p): New function.
11225 (unknown_language_defn): Initialise new field.
11226 (auto_language_defn): Initialise new field.
11227 * language.h (struct language_defn) <la_is_string_type_p>: New
11228 member variable.
11229 (default_is_string_type_p): Declare new function.
11230 * m2-lang.c (m2_language_defn): Initialise new field.
11231 * objc-lang.c (objc_language_defn): Initialise new field.
11232 * opencl-lang.c (opencl_language_defn): Initialise new field.
11233 * p-lang.c (pascal_is_string_type_p): New function.
11234 (pascal_language_defn): Initialise new field.
11235 * rust-lang.c (rust_is_string_type_p): New function.
11236 (rust_language_defn): Initialise new field.
11237
721b08c6
AB
112382019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11239
11240 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11241 New field.
11242 * ada-lang.c (ada_language_defn): Initialise new field.
11243 * c-lang.c (c_language_defn): Likewise.
11244 (cplus_language_defn): Likewise.
11245 (asm_language_defn): Likewise.
11246 (minimal_language_defn): Likewise.
11247 * d-lang.c (d_language_defn): Likewise.
11248 * f-lang.c (f_language_defn): Likewise.
11249 * go-lang.c (go_language_defn): Likewise.
11250 * language.c (unknown_language_defn): Likewise.
11251 (auto_language_defn): Likewise.
11252 * m2-lang.c (m2_language_defn): Likewise.
11253 * objc-lang.c (objc_language_defn): Likewise.
11254 * opencl-lang.c (opencl_language_defn): Likewise.
11255 * p-lang.c (pascal_language_defn): Likewise.
11256 * rust-lang.c (rust_language_defn): Likewise.
11257
fc913e53
AB
112582019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11259
11260 * ada-lang.c (ada_is_character_type): Change return type to bool.
11261 (ada_is_string_type): Likewise.
11262 * ada-lang.h (ada_is_character_type): Update declaration
11263 (ada_is_string_type): Likewise.
11264
fa731fa0
PW
112652019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11266
11267 Support style in 'frame|thread apply'
11268
11269 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11270 * record.c (record_start, record_stop): Update callers of
11271 execute_command_to_string with false.
11272 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11273 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11274 methods.
11275 (class string_file): New constructor with term_out parameter.
11276 Override methods term_out and can_emit_style_escape. New member
11277 term_out.
11278 (class stdio_file): Override can_emit_style_escape.
11279 (class tee_file): Override term_out and can_emit_style_escape.
11280 * utils.h (can_emit_style_escape): Remove.
11281 * utils.c (can_emit_style_escape): Likewise.
11282 Update all callers of can_emit_style_escape (SOMESTREAM) to
11283 SOMESTREAM->can_emit_style_escape.
11284 * source-cache.c (source_cache::get_source_lines): Likewise.
11285 * stack.c (frame_apply_command_count): Call execute_command_to_string
11286 passing the term_out characteristic of the current gdb_stdout.
11287 * thread.c (thr_try_catch_cmd): Likewise.
11288 * top.c (execute_command_to_string): pass term_out parameter
11289 to construct the string_file for the command output.
11290 * ui-file.c (term_cli_styling): New function (most code moved
11291 from utils.c can_emit_style_escape).
11292 (string_file::string_file, string_file::can_emit_style_escape,
11293 stdio_file::can_emit_style_escape, tee_file::term_out,
11294 tee_file::can_emit_style_escape): New functions.
11295
136afab8
PW
112962019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11297
11298 * NEWS: Mention the new set|show may-call-functions.
11299 * infcall.c (may_call_functions_p): New variable.
11300 (show_may_call_functions_p): New function.
11301 (call_function_by_hand_dummy): Throws an error if not
11302 may-call-functions.
11303 (_initialize_infcall): Call add_setshow_boolean_cmd for
11304 may-call-functions.
11305
725cbb63
KS
113062019-04-25 Keith Seitz <keiths@redhat.com>
11307
11308 PR c++/24367
11309 * cp-support.c (inspect_type): Don't attempt substitutions
11310 of symbol with the same name.
11311
3d1cbb78
TT
113122019-04-25 Tom Tromey <tromey@adacore.com>
11313
11314 PR gdb/24475:
11315 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11316 static.
11317
94aeb44b
TT
113182019-04-25 Tom Tromey <tromey@adacore.com>
11319
11320 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11321 rvalue reference.
11322 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11323 (gdb_xml_parser::parse): Use std::move.
11324 * python/python-internal.h (gdbpy_convert_exception): Take a const
11325 reference.
11326 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11327 std::move.
11328 * python/py-utils.c (gdbpy_convert_exception): Take a const
11329 reference.
11330 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11331 Use std::move.
11332 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11333 Use std::move.
11334 * mi/mi-main.c (mi_print_exception): Take a const reference.
11335 * main.c (handle_command_errors): Take a const reference.
11336 * linespec.c (parse_linespec): Use std::move.
11337 * infcall.c (run_inferior_call): Use std::move.
11338 (call_function_by_hand_dummy): Use std::move.
11339 * exec.c (try_open_exec_file): Use std::move.
11340 * exceptions.h (exception_print, exception_fprintf)
11341 (exception_print_same): Update.
11342 * exceptions.c (print_exception, exception_print)
11343 (exception_fprintf, exception_print_same): Change parameters to
11344 const reference.
11345 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11346 * common/new-op.c: Use std::move.
11347 * common/common-exceptions.h (struct gdb_exception): Add move
11348 constructor.
11349 (struct gdb_exception_error, struct gdb_exception_quit, struct
11350 gdb_quit_bad_alloc): Change constructor to move constructor.
11351 (throw_exception): Change parameter to rvalue reference.
11352 * common/common-exceptions.c (throw_exception): Take rvalue
11353 reference.
11354 * cli/cli-interp.c (safe_execute_command): Use std::move.
11355 * breakpoint.c (insert_bp_location, location_to_sals): Use
11356 std::move.
11357
680d7fd5
TT
113582019-04-25 Tom Tromey <tromey@adacore.com>
11359
11360 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11361 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11362 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11363 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11364 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11365 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11366 guile/scm-value.c: Use unpack.
11367 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11368 gdbscm_gdb_exception.
11369 (gdbscm_throw_gdb_exception): Likewise.
11370 (struct gdbscm_gdb_exception): New.
11371 (unpack): New function.
11372 (gdbscm_wrap): Use unpack.
11373
c6fdd8b2
TT
113742019-04-25 Tom Tromey <tromey@adacore.com>
11375
11376 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11377 (gdb_rl_callback_handler): Use std::move.
11378 * common/common-exceptions.h (struct gdb_exception): Add move
11379 assignment operator.
11380 (throw_exception_sjlj): Change "exception" to const reference.
11381 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11382 (throw_exception_sjlj): Change "exception" to const reference.
11383
cc06b668
TT
113842019-04-25 Tom Tromey <tromey@adacore.com>
11385
11386 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11387 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11388 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11389 Update.
11390 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11391 Update.
11392 * mi/mi-interp.c (mi_interp::exec): Update.
11393 * linespec.c (parse_linespec): Update.
11394 * infcall.c (run_inferior_call): Update.
11395 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11396 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11397 (gdbscm_lookup_global_symbol): Update.
11398 * guile/scm-param.c (gdbscm_parameter_value): Update.
11399 * guile/scm-frame.c (gdbscm_frame_read_register)
11400 (gdbscm_frame_read_var): Update.
11401 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11402 * exec.c (try_open_exec_file): Update.
11403 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11404 (gdb_rl_callback_handler): Update.
11405 * common/common-exceptions.h (exception_none): Don't declare.
11406 * common/common-exceptions.c (exception_none): Don't define.
11407 (struct catcher) <exception>: Update.
11408 * cli/cli-interp.c (safe_execute_command): Update.
11409 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11410
cf532bd1
AT
114112019-04-25 Ali Tamur <tamur@google.com>
11412
11413 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11414 (read_attribute_value): Likewise.
11415 (dwarf2_read_addr_index): Update comment.
11416 (read_str_index): Add DW_FORM_strx.
11417 (dwarf2_string_attr): Likewise.
11418 (dwarf2_const_value_attr): Likewise.
11419 (dump_die_shallow): Likewise.
11420 (dwarf2_fetch_constant_bytes): Likewise.
11421 (skip_form_bytes): Likewise.
11422 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11423
82433e3e
SDJ
114242019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11425
11426 PR corefiles/11608
11427 PR corefiles/18187
11428 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11429 OFFSET. Verify if current mapping contains an ELF header.
11430 (linux_find_memory_regions_full): Adjust call to
11431 dump_mapping_p.
11432
723adb65
SL
114332019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11434 Kang Li <kanglictf@gmail.com>
11435
11436 PR gdb/21600
11437
11438 * dwarf2-frame.c (read_initial_length): Be consistent about using
11439 unsigned representation of length.
11440 (decode_frame_entry_1): Likewise. Check for wraparound of
11441 end pointer as well as buffer overflow.
11442
596179f7
SDJ
114432019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11444
11445 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11446 "vq".
11447
a59240a4
TT
114482019-04-24 Tom Tromey <tromey@adacore.com>
11449
11450 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11451
f872fdbb
AB
114522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11453
11454 * s12z-tdep.c (s12z_unwind_pc): Delete.
11455 (s12z_unwind_sp): Delete.
11456 (s12z_gdbarch_init): Don't register deleted functions with
11457 gdbarch.
11458
b614e6f3
AB
114592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11460
11461 * rl78-tdep.c (rl78_unwind_sp): Delete.
11462 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11463
14faed38
AB
114642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11465
11466 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11467 (xstormy16_unwind_pc): Delete.
11468 (xstormy16_dummy_id): Delete.
11469 (xstormy16_gdbarch_init): Don't register deleted functions with
11470 gdbarch.
11471
541aad8a
AB
114722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11473
11474 * vax-tdep.c (vax_unwind_pc): Delete.
11475 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11476
29222070
AB
114772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11478
11479 * v850-tdep.c (v850_unwind_sp): Delete.
11480 (v850_unwind_pc): Delete.
11481 (v850_dummy_id): Delete.
11482 (v850_gdbarch_init): Don't register deleted functions with
11483 gdbarch.
11484
0f534d76
AB
114852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11486
11487 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11488 (tilegx_unwind_pc): Delete.
11489 (tilegx_unwind_dummy_id): Delete.
11490 (tilegx_gdbarch_init): Don't register deleted functions with
11491 gdbarch.
11492
1ba7b7f9
AB
114932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11494
11495 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11496 (tic6x_dummy_id): Delete.
11497 (tic6x_gdbarch_init): Don't register deleted functions with
11498 gdbarch.
11499
d31f262c
AB
115002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11501
11502 * sparc-tdep.c (sparc_unwind_pc): Delete.
11503 (sparc32_gdbarch_init): Don't register deleted function with
11504 gdbarch.
11505
6d14d64d
AB
115062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11507
11508 * sh-tdep.c (sh_unwind_sp): Delete.
11509 (sh_unwind_pc): Delete.
11510 (sh_dummy_id): Delete.
11511 (sh_gdbarch_init): Don't register deleted functions with
11512 gdbarch.
11513
a40dde9d
AB
115142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11515
11516 * score-tdep.c (score_unwind_sp): Delete.
11517 (score_unwind_pc): Delete.
11518 (score_dummy_id): Delete.
11519 (score_gdbarch_init): Don't register deleted functions with
11520 gdbarch.
11521
47c47d69
AB
115222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11523
11524 * rx-tdep.c (rx_unwind_pc): Delete.
11525 (rx_unwind_sp): Delete.
11526 (rx_dummy_id): Delete.
11527 (rx_gdbarch_init): Don't register deleted functions with
11528 gdbarch. Update comment.
11529
833a4480
AB
115302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11531
11532 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11533 (rs6000_dummy_id): Delete.
11534 (rs6000_gdbarch_init): Don't register deleted functions with
11535 gdbarch.
11536
3f2cef49
AB
115372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11538
11539 * or1k-tdep.c (or1k_dummy_id): Delete.
11540 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11541
96acf884
AB
115422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11543
11544 * nios2-tdep.c (nios2_dummy_id): Delete.
11545 (nios2_unwind_sp): Delete.
11546 (nios2_gdbarch_init): Don't register deleted functions with
11547 gdbarch.
11548
ca0ab0aa
AB
115492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11550
11551 * nds32-tdep.c (nds32_dummy_id): Delete.
11552 (nds32_unwind_pc): Delete.
11553 (nds32_unwind_sp): Delete.
11554 (nds32_gdbarch_init): Don't register deleted functions with
11555 gdbarch.
11556
c8259044
AB
115572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11558
11559 * msp430-tdep.c (msp430_unwind_pc): Delete.
11560 (msp430_unwind_sp): Delete.
11561 (msp430_dummy_id): Delete.
11562 (msp430_gdbarch_init): Don't register deleted functions with
11563 gdbarch.
11564
27f113c8
AB
115652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11566
11567 * moxie-tdep.c (moxie_unwind_sp): Delete.
11568 (moxie_unwind_pc): Delete.
11569 (moxie_dummy_id): Delete.
11570 (moxie_gdbarch_init): Don't register deleted functions with
11571 gdbarch.
11572
aee6c3cd
AB
115732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11574
11575 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11576 (mn10300_unwind_pc): Delete.
11577 (mn10300_unwind_sp): Delete.
11578 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11579 mn10300_unwind_sp.
11580 (mn10300_frame_unwind_init): Don't register deleted functions with
11581 gdbarch.
11582
8e2b5aea
AB
115832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11584
11585 * mep-tdep.c (mep_unwind_pc): Delete.
11586 (mep_unwind_sp): Delete.
11587 (mep_dummy_id): Delete.
11588 (mep_gdbarch_init): Don't register deleted functions with
11589 gdbarch.
11590
43cf3ede
AB
115912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11592
11593 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11594 (m68hc11_unwind_sp): Delete.
11595 (m68hc11_gdbarch_init): Don't register deleted functions with
11596 gdbarch.
11597
5e79b7bb
AB
115982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11599
11600 * m32r-tdep.c (m32r_unwind_sp): Delete.
11601 (m32r_unwind_pc): Delete.
11602 (m32r_dummy_id): Delete.
11603 (m32r_gdbarch_init): Don't register deleted functions with
11604 gdbarch.
11605
89b268d8
AB
116062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11607
11608 * m32c-tdep.c (m32c_unwind_pc): Delete.
11609 (m32c_unwind_sp): Delete.
11610 (m32c_dummy_id): Delete.
11611 (m32c_gdbarch_init): Don't register deleted functions with
11612 gdbarch.
11613
946c28d2
AB
116142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11615
11616 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11617 (lm32_unwind_pc): Delete.
11618 (lm32_dummy_id): Delete.
11619 (lm32_gdbarch_init): Don't register deleted functions with
11620 gdbarch.
11621
bf12844a
AB
116222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11623
11624 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11625 (iq2000_unwind_pc): Delete.
11626 (iq2000_dummy_id): Delete.
11627 (iq2000_gdbarch_init): Don't register deleted functions with
11628 gdbarch.
11629
ecbc06d2
AB
116302019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11631
11632 * nds32-tdep.c (nds32_type_align): Delete.
11633 (nds32_push_dummy_call): Use type_align instead.
11634
030197b4
AB
116352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11636
11637 * arm-tdep.c (arm_type_align): Only handle vector override case.
11638 (arm_push_dummy_call): Use type_align.
11639 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11640
b907456c
AB
116412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11642
11643 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11644 case.
11645 (pass_on_stack): Use type_align.
11646 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11647 function.
11648
9e97ba43
TT
116492019-04-23 Tom Tromey <tromey@adacore.com>
11650
11651 * dwarf2read.c (line_header::file_name_at): Remove unused
11652 overload.
11653
6892f601
TV
116542019-04-23 Tom de Vries <tdevries@suse.de>
11655
11656 PR gdb/24438
11657 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11658 invocation.
11659
336d760d
AT
11660
116612019-03-27 Ali Tamur <tamur@google.com>
11662
11663 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11664 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11665 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11666 (dwarf_expr_context::get_addr_index): Likewise
11667 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11668 (symbol_needs_eval_context::get_addr_index): Likewise
11669 (disassemble_dwarf_expression): Add DW_OP_addrx
11670 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11671 (read_cutu_die_from_dwo): Update comment
11672 (skip_one_die): Add DW_FORM_addrx
11673 (read_attribute_value): Likewise
11674 (var_decode_location): Add DW_OP_addrx
11675 (dwarf2_const_value_attr): Add DW_FORM_addrx
11676 (dump_die_shallow): Likewise
11677 (dwarf2_fetch_constant_bytes): Likewise
11678 (decode_locdesc): Add DW_OP_addrx
11679 (skip_form_bytes): Add DW_FORM_addrx
11680
ad9d13f8
AT
116812019-04-22 Ali Tamur <tamur@google.com>
11682
11683 * MAINTAINERS (Write After Approval): Add self.
11684
d70cc3ba
SM
116852019-04-22 Simon Marchi <simon.marchi@efficios.com>
11686
11687 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11688 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11689 (open_symbol_file_object): Likewise.
11690 (svr4_default_sos): Add info parameter.
11691 (svr4_read_so_list): Likewise.
11692 (svr4_current_sos_direct): Adjust functions calls to pass down
11693 info.
11694 (svr4_current_sos_1): Add info parameter.
11695 (svr4_current_sos): Call get_svr4_info, pass info down to
11696 svr4_current_sos_1.
11697 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11698 get_svr4_info.
11699 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11700 get_svr4_info.
11701 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11702 to get_svr4_info.
11703 (probes_table_remove_objfile_probes): Likewise.
11704 (register_solib_event_probe): Add info parameter.
11705 (solist_update_incremental): Pass info parameter down to
11706 svr4_read_so_list.
11707 (disable_probes_interface): Add info parameter.
11708 (svr4_handle_solib_event): Pass current_program_space to
11709 get_svr4_info. Adjust disable_probes_interface cleanup.
11710 (svr4_create_probe_breakpoints): Add info parameter, pass it
11711 down to register_solib_event_probe.
11712 (svr4_create_solib_event_breakpoints): Add info parameter,
11713 pass it down to svr4_create_probe_breakpoints.
11714 (enable_break): Pass info down to
11715 svr4_create_solib_event_breakpoints.
11716 (svr4_solib_create_inferior_hook): Pass current_program_space to
11717 get_svr4_info.
11718 (svr4_clear_solib): Likewise.
11719
7905fc35
PA
117202019-04-22 Pedro Alves <palves@redhat.com>
11721
11722 * solib-svr4.c (svr4_free_objfile_observer): New.
11723 (probe_and_action::objfile): New field.
11724 (probes_table_htab_remove_objfile_probes)
11725 (probes_table_remove_objfile_probes): New functions.
11726 (register_solib_event_probe): Add 'objfile' parameter. Store it
11727 in the new probe_and_action. Don't store the probe in 'lookup'.
11728 (svr4_create_probe_breakpoints): Pass objfile to
11729 register_solib_event_probe.
11730 (_initialize_svr4_solib): Register a free_objfile observer.
11731
fb881986
TT
117322019-04-19 Tom Tromey <tom@tromey.com>
11733
11734 * common/queue.h: Remove.
11735
8732db6c
TT
117362019-04-19 Tom Tromey <tom@tromey.com>
11737
11738 * event-loop.c: Don't include "common/queue.h".
11739
97dfbadd
TT
117402019-04-19 Tom Tromey <tom@tromey.com>
11741
11742 * remote.c (remote_target): Use delete.
11743 * remote-notif.h: Include <list>, not "common/queue.h".
11744 (notif_client_p): Remove typedef.
11745 (remote_notif_state): Add constructor, destructor, initializer.
11746 <notif_queue>: Now a std::list.
11747 (remote_notif_state_xfree): Don't declare.
11748 * remote-notif.c (remote_notif_process, handle_notification)
11749 (remote_notif_state_allocate): Update.
11750 (~remote_notif_state): Rename from remote_notif_state_xfree.
11751
cf250e36
TT
117522019-04-19 Tom Tromey <tom@tromey.com>
11753
11754 * symfile.c (reread_symbols): Update.
11755 * objfiles.c (objfile_register_static_link)
11756 (objfile_lookup_static_link): Update
11757 (~objfile) Don't delete static_links.
11758 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11759
61f4b350
TT
117602019-04-19 Tom Tromey <tom@tromey.com>
11761
11762 * type-stack.h (struct type_stack) <insert>: Constify string.
11763 * type-stack.c (type_stack::insert): Constify string.
11764 * gdbtypes.h (lookup_template_type): Update.
11765 (address_space_name_to_int): Update.
11766 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11767 const.
11768 (lookup_template_type): Make name const.
11769 * c-exp.y: Update rules.
11770 (lex_one_token, classify_name, classify_inner_name)
11771 (c_print_token): Update.
11772 * p-exp.y: Update rules.
11773 (yylex): Update.
11774 * f-exp.y: Update rules.
11775 (yylex): Update.
11776 * d-exp.y: Update rules.
11777 (lex_one_token, classify_name, classify_inner_name): Update.
11778 * parse.c (write_dollar_variable, copy_name): Return std::string.
11779 * parser-defs.h (copy_name): Change return type.
11780 * m2-exp.y: Update rules.
11781 (yylex): Update.
11782 * go-exp.y (lex_one_token): Update.
11783 Update rules.
11784 (classify_unsafe_function, classify_packaged_name)
11785 (classify_name, yylex): Update.
11786
189b8c2e
ST
117872019-04-19 Sergei Trofimovich <siarheit@google.com>
11788
11789 * configure.ac: add --enable-source-highlight switch.
11790 * configure: Regenerate.
11791 * top.c (print_gdb_version): plumb --enable-source-highlight
11792 status to "show configuration".
11793
8ecb59f8
TT
117942019-04-19 Tom Tromey <tromey@adacore.com>
11795
11796 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11797 Check ADA_TYPE_P.
11798 (empty_record, ada_template_to_fixed_record_type_1)
11799 (template_to_static_fixed_type)
11800 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11801 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11802 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11803 macros.
11804
62160ec9
TT
118052019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11806
11807 PR symtab/24423:
11808 * source.c (print_source_lines_base): Advance "iter" when a
11809 control character is seen.
11810
f2ae8bc8
PW
118112019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11812
11813 * inferior.h (struct infcall_suspend_state_deleter):
11814 Catch exception in destructor to avoid crash.
11815
d563b953
PW
118162019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11817
11818 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11819 close to the add_com "shell".
11820
dc34c897
TT
118212019-04-18 Tom Tromey <tromey@adacore.com>
11822
11823 * process-stratum-target.h (class process_stratum_target)
11824 <stratum>: Add "final".
11825
a12e5744
TT
118262019-04-17 Tom Tromey <tromey@adacore.com>
11827
11828 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11829 against nullptr before use.
11830
a7e559cc
AH
118312019-04-17 Alan Hayward <alan.hayward@arm.com>
11832
11833 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11834
c01660c6
AB
118352019-04-17 Jim Wilson <jimw@sifive.com>
11836 Andrew Burgess <andrew.burgess@embecosm.com>
11837
11838 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11839 code read might fail, assume 4-byte breakpoint in that case.
11840
4aa866af
LS
118412019-04-15 Leszek Swirski <leszeks@google.com>
11842
11843 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11844 rather than a hand-rolled POD check when checking for forced MEMORY
11845 classification.
11846
48574d91
AH
118472019-04-15 Alan Hayward <alan.hayward@arm.com>
11848
11849 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11850 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11851 function.
11852 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11853 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11854 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11855 declaration.
11856
4da037ef
AH
118572019-04-15 Alan Hayward <alan.hayward@arm.com>
11858
11859 * aarch64-linux-nat.c
11860 (aarch64_linux_nat_target::thread_architecture): Add override.
11861 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11862 each VQ.
11863
ccb8d7e8
AH
118642019-04-15 Alan Hayward <alan.hayward@arm.com>
11865
11866 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11867
35add35e
AB
118682019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11869
11870 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11871 target types of size 96-bits, add some additional comments, and
11872 check that the builtin type we found was the correct size.
11873
51196bbc
EZ
118742019-04-12 Eli Zaretskii <eliz@gnu.org>
11875
11876 * utils.c (prompt_for_continue): Don't restore the styling at the
11877 end, as applied_style has the wrong value. This fixes styling in
11878 long lists of file names that are interrupted by the "Continue?"
11879 prompt.
11880
62253a61
AB
118812019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11882
11883 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11884 * c-lang.c (c_language_defn): Likewise.
11885 (cplus_language_defn): Likewise.
11886 (asm_language_defn): Likewise.
11887 (minimal_language_defn): Likewise.
11888 * d-lang.c (d_language_defn): Likewise.
11889 * f-lang.c (f_language_defn): Likewise.
11890 * go-lang.c (go_language_defn): Likewise.
11891 * language.c (unknown_language_defn): Likewise.
11892 (auto_language_defn): Likewise.
11893 * language.h (struct language_defn): Remove la_magic field.
11894 (LANG_MAGIC): Delete.
11895 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11896 * objc-lang.c (objc_language_defn): Likewise.
11897 * opencl-lang.c (opencl_language_defn): Likewise.
11898 * p-lang.c (pascal_language_defn): Likewise.
11899 * rust-lang.c (rust_language_defn): Likewise.
11900
a9158a86
AB
119012019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11902
11903 * riscv-tdep.c (riscv_type_align): New function.
11904 (riscv_type_alignment): Delete.
11905 (riscv_arg_location): Use 'type_align'.
11906 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11907
41077b66
AB
119082019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11909
11910 * gdbtypes.c (type_align): A struct with no non-static fields also
11911 has alignment of 1.
11912
9f0272f8
AB
119132019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11914
11915 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11916 component to 0.
11917 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11918 member.
11919 (riscv_struct_info::analyse): New implementation using new
11920 analyse_inner member function.
11921 (riscv_struct_info::field_offset): New member function.
11922 (riscv_struct_info::m_offsets): New member variable.
11923 (riscv_struct_info::analyse_inner): New private member function,
11924 takes the old implementation of riscv_struct_info::analyse but
11925 extended to track field offsets.
11926 (riscv_call_arg_struct): Update the struct folding special cases
11927 to handle cases where empty C++ structs, which are non-zero
11928 length, are found.
11929 (riscv_arg_location): Initialise the length of each location, a
11930 non-zero length now indicates the location is in use.
11931 (riscv_push_dummy_call): Allow for the first location having a
11932 non-zero offset when setting up arguments.
11933 (riscv_return_value): Likewise, but for return values.
11934
02cf60c7
TT
119352019-04-11 Tom Tromey <tromey@adacore.com>
11936
11937 * utils.c (internal_vproblem): Make "msg" const.
11938
68811f8f
AH
119392019-04-11 Alan Hayward <alan.hayward@arm.com>
11940
11941 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11942 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11943 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11944 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11945
3f52fdbc
KB
119462019-04-10 Kevin Buettner <kevinb@redhat.com>
11947
11948 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11949 function.
11950 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11951 of amd64_collect_native_gregset.
11952 (amd64_linux_nat_target::store_registers): Likewise.
11953
e9ad22ee
TT
119542019-04-10 Tom Tromey <tom@tromey.com>
11955
11956 * symtab.c (lookup_global_symbol_from_objfile)
11957 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11958 * objfiles.h (class separate_debug_iterator): New.
11959 (class separate_debug_range): New.
11960 (struct objfile) <separate_debug_objfiles>: New method.
11961 (objfile_separate_debug_iterate): Don't declare.
11962 * objfiles.c (separate_debug_iterator::operator++): Rename from
11963 objfile_separate_debug_iterate.
11964 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11965 iterator.
11966 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11967 iterator.
11968
ee371134
TT
119692019-04-10 Tom Tromey <tom@tromey.com>
11970
11971 * symfile.c (reread_symbols): Remove old comment.
11972 * objfiles.c (free_all_objfiles): Fix a typo.
11973
bf227d61
TT
119742019-04-10 Tom Tromey <tom@tromey.com>
11975
11976 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11977 * minsyms.c (lookup_minimal_symbol): Use foreach.
11978 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11979 (lookup_minimal_symbol_solib_trampoline): Likewise.
11980 * symfile.c (reread_symbols): Use foreach.
11981
8dc433a0
TT
119822019-04-09 Ivan Begert <ivanbegert@gmail.com>
11983 Tom Tromey <tromey@adacore.com>
11984
11985 PR rust/24414:
11986 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11987 (rust_lex_int_test): Change "value" to be LONGEST.
11988 (rust_lex_tests): Add test for long integer literal.
11989
9ab8741a
TT
119902019-04-09 Tom Tromey <tromey@adacore.com>
11991
11992 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11993 to bool.
11994 (extended_remote_target::attach): Update.
11995 (remote_target::remote_notice_new_inferior): Update.
11996 (remote_target::add_current_inferior_and_thread): Update.
11997 * inferior.c (exit_inferior_1): Use "false".
11998 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11999
e242fd12
SM
120002019-04-09 Simon Marchi <simon.marchi@efficios.com>
12001
9ca1957f 12002 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
12003 the "start" command.
12004
2b0c8b01
KB
120052019-04-08 Kevin Buettner <kevinb@redhat.com>
12006
12007 * python/py-inferior.c (infpy_thread_from_thread_handle):
12008 Adjust comments to reflect renaming of thread_from_thread_handle
12009 to thread_from_handle. Adjust keywords. Fix type error message.
12010 (inferior_object_methods): Add thread_from_handle. Retain
12011 thread_from_thread_handle, but mark it as deprecated.
12012
50a82723
KB
120132019-04-08 Kevin Buettner <kevinb@redhat.com>
12014
12015 * gdbthread.h (find_thread_by_handle): Revise declaration.
12016 * thread.c (find_thread_by_handle): Likewise. Adjust
12017 implementation too.
12018 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12019 support for buffer objects as handles.
12020
cf63b016
KB
120212019-04-08 Kevin Buettner <kevinb@redhat.com>
12022
12023 * python/py-infthread.c (thpy_thread_handle): New function.
12024 (thread_object_methods): Register thpy_thread_handle.
12025
3d6c6204
KB
120262019-04-08 Kevin Buettner <kevinb@redhat.com>
12027
12028 * gdbthread.h (thread_to_thread_handle): Declare.
12029 * thread.c (gdbtypes.h): Include.
12030 (thread_to_thread_handle): New function.
12031
12032 * target.h (struct target_ops): Add thread_info_to_thread_handle.
12033 (target_thread_info_to_thread_handle): Declare.
12034 * target.c (target_thread_info_to_thread_handle): New function.
12035 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12036 * target-delegates.c: Regenerate.
12037
12038 * linux-thread-db.c (class thread_db_target): Add method
12039 thread_info_to_thread_handle.
12040 (thread_db_target::thread_info_to_thread_handle): Define.
12041 * remote.c (class remote_target): Add new method
12042 thread_info_to_thread_handle.
12043 (remote_target::thread_info_to_thread_handle): Define.
12044
56be6ea8
PA
120452019-04-08 Pedro Alves <palves@redhat.com>
12046
12047 * common/common-exceptions.c (throw_exception): Don't create
12048 named object to throw; throw directly.
12049 (throw_it): Likewise. Don't initialize gdb_exception::message
12050 here, with new; pass FMT and AP to the ctor instead.
12051 * common/common-exceptions.h: Include <string>.
12052 (gdb_exception::gdb_exception(enum return_reason, enum errors,
12053 const char *, va_list)): New ctor. Use std::make_shared.
12054 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12055 errors)): Delete.
12056 (gdb_exception_error::gdb_exception_error(enum errors, const char
12057 *, va_list)): New.
12058 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12059 Add assertion.
12060 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12061 errors)): Delete.
12062 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12063 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12064 Add assertion.
12065
eedc3f4f
TT
120662019-04-08 Tom Tromey <tom@tromey.com>
12067
12068 * valops.c (value_rtti_indirect_type): Replace throw_exception
12069 with throw.
12070 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12071 with throw.
12072 * thread.c (thr_try_catch_cmd): Replace throw_exception with
12073 throw.
12074 * target.c (target_translate_tls_address): Replace throw_exception
12075 with throw.
12076 * stack.c (frame_apply_command_count): Replace throw_exception
12077 with throw.
12078 * solib-spu.c (append_ocl_sos): Replace throw_exception with
12079 throw.
12080 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12081 with throw.
12082 * rs6000-tdep.c (rs6000_frame_cache)
12083 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12084 * remote.c: Replace throw_exception with throw.
12085 * record-full.c (record_full_message, record_full_wait_1)
12086 (record_full_restore): Replace throw_exception with throw.
12087 * record-btrace.c:
12088 (get_thread_current_frame_id, record_btrace_start_replaying)
12089 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12090 (cmd_record_btrace_start): Replace throw_exception with throw.
12091 * parse.c (parse_exp_in_context_1): Replace throw_exception with
12092 throw.
12093 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12094 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12095 * linespec.c:
12096 (find_linespec_symbols): Replace throw_exception with throw.
12097 * infrun.c (displaced_step_prepare, resume): Replace
12098 throw_exception with throw.
12099 * infcmd.c (post_create_inferior): Replace throw_exception with
12100 throw.
12101 * inf-loop.c (inferior_event_handler): Replace throw_exception
12102 with throw.
12103 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12104 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12105 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12106 (get_prev_frame_always, get_frame_pc_if_available)
12107 (get_frame_address_in_block_if_available, get_frame_language):
12108 Replace throw_exception with throw.
12109 * frame-unwind.c (frame_unwind_try_unwinder): Replace
12110 throw_exception with throw.
12111 * eval.c (fetch_subexp_value, evaluate_var_value)
12112 (evaluate_funcall, evaluate_subexp_standard): Replace
12113 throw_exception with throw.
12114 * dwarf2loc.c (call_site_find_chain)
12115 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12116 Replace throw_exception with throw.
12117 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12118 with throw.
12119 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12120 throw.
12121 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12122 * completer.c (complete_line_internal): Replace throw_exception
12123 with throw.
12124 * compile/compile-object-run.c (compile_object_run): Replace
12125 throw_exception with throw.
12126 * cli/cli-script.c (process_next_line): Replace throw_exception
12127 with throw.
12128 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12129 (btrace_enable, btrace_maint_update_pt_packets): Replace
12130 throw_exception with throw.
12131 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12132 throw_exception with throw.
12133 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12134 throw_exception with throw.
12135 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12136 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12137 * aarch64-tdep.c (aarch64_make_prologue_cache)
12138 (aarch64_make_stub_cache): Replace throw_exception with throw.
12139
26003a20
TT
121402019-04-08 Tom Tromey <tom@tromey.com>
12141
12142 * common/common-exceptions.c (throw_exception): Rename from
12143 throw_exception_cxx. Remove old copy. Make argument const.
12144 (throw_it): Create and throw exception objects directly.
12145 * common/common-exceptions.h (throw_exception): Make argument
12146 const.
12147 (struct gdb_exception_error): Add constructor.
12148 (struct gdb_exception_quit): Add constructor.
12149
d272eb37
TT
121502019-04-08 Tom Tromey <tom@tromey.com>
12151
12152 * common/common-exceptions.h (exception_rethrow): Don't declare.
12153 (TRY_SJLJ): Update comment.
12154 (TRY, CATCH, END_CATCH): Remove.
12155 * common/common-exceptions.c (exception_rethrow): Remove.
12156
230d2906
TT
121572019-04-08 Tom Tromey <tom@tromey.com>
12158
12159 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12160 Remove.
12161 (gdb_exception_error): Rename from
12162 gdb_exception_RETURN_MASK_ERROR.
12163 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12164 (gdb_quit_bad_alloc): Update.
12165 * aarch64-tdep.c: Update.
12166 * ada-lang.c: Update.
12167 * ada-typeprint.c: Update.
12168 * ada-valprint.c: Update.
12169 * amd64-tdep.c: Update.
12170 * arch-utils.c: Update.
12171 * break-catch-throw.c: Update.
12172 * breakpoint.c: Update.
12173 * btrace.c: Update.
12174 * c-varobj.c: Update.
12175 * cli/cli-cmds.c: Update.
12176 * cli/cli-interp.c: Update.
12177 * cli/cli-script.c: Update.
12178 * common/common-exceptions.c: Update.
12179 * common/new-op.c: Update.
12180 * common/selftest.c: Update.
12181 * compile/compile-c-symbols.c: Update.
12182 * compile/compile-cplus-symbols.c: Update.
12183 * compile/compile-object-load.c: Update.
12184 * compile/compile-object-run.c: Update.
12185 * completer.c: Update.
12186 * corelow.c: Update.
12187 * cp-abi.c: Update.
12188 * cp-support.c: Update.
12189 * cp-valprint.c: Update.
12190 * darwin-nat.c: Update.
12191 * disasm-selftests.c: Update.
12192 * dtrace-probe.c: Update.
12193 * dwarf-index-cache.c: Update.
12194 * dwarf-index-write.c: Update.
12195 * dwarf2-frame-tailcall.c: Update.
12196 * dwarf2-frame.c: Update.
12197 * dwarf2loc.c: Update.
12198 * dwarf2read.c: Update.
12199 * eval.c: Update.
12200 * event-loop.c: Update.
12201 * event-top.c: Update.
12202 * exec.c: Update.
12203 * f-valprint.c: Update.
12204 * fbsd-tdep.c: Update.
12205 * frame-unwind.c: Update.
12206 * frame.c: Update.
12207 * gdbtypes.c: Update.
12208 * gnu-v3-abi.c: Update.
12209 * guile/guile-internal.h: Update.
12210 * guile/scm-block.c: Update.
12211 * guile/scm-breakpoint.c: Update.
12212 * guile/scm-cmd.c: Update.
12213 * guile/scm-disasm.c: Update.
12214 * guile/scm-frame.c: Update.
12215 * guile/scm-lazy-string.c: Update.
12216 * guile/scm-math.c: Update.
12217 * guile/scm-param.c: Update.
12218 * guile/scm-ports.c: Update.
12219 * guile/scm-pretty-print.c: Update.
12220 * guile/scm-symbol.c: Update.
12221 * guile/scm-symtab.c: Update.
12222 * guile/scm-type.c: Update.
12223 * guile/scm-value.c: Update.
12224 * i386-linux-tdep.c: Update.
12225 * i386-tdep.c: Update.
12226 * inf-loop.c: Update.
12227 * infcall.c: Update.
12228 * infcmd.c: Update.
12229 * infrun.c: Update.
12230 * jit.c: Update.
12231 * language.c: Update.
12232 * linespec.c: Update.
12233 * linux-fork.c: Update.
12234 * linux-nat.c: Update.
12235 * linux-tdep.c: Update.
12236 * linux-thread-db.c: Update.
12237 * main.c: Update.
12238 * mi/mi-cmd-break.c: Update.
12239 * mi/mi-cmd-stack.c: Update.
12240 * mi/mi-interp.c: Update.
12241 * mi/mi-main.c: Update.
12242 * objc-lang.c: Update.
12243 * p-valprint.c: Update.
12244 * parse.c: Update.
12245 * ppc-linux-tdep.c: Update.
12246 * printcmd.c: Update.
12247 * python/py-arch.c: Update.
12248 * python/py-breakpoint.c: Update.
12249 * python/py-cmd.c: Update.
12250 * python/py-finishbreakpoint.c: Update.
12251 * python/py-frame.c: Update.
12252 * python/py-framefilter.c: Update.
12253 * python/py-gdb-readline.c: Update.
12254 * python/py-inferior.c: Update.
12255 * python/py-infthread.c: Update.
12256 * python/py-lazy-string.c: Update.
12257 * python/py-linetable.c: Update.
12258 * python/py-objfile.c: Update.
12259 * python/py-param.c: Update.
12260 * python/py-prettyprint.c: Update.
12261 * python/py-progspace.c: Update.
12262 * python/py-record-btrace.c: Update.
12263 * python/py-record.c: Update.
12264 * python/py-symbol.c: Update.
12265 * python/py-type.c: Update.
12266 * python/py-unwind.c: Update.
12267 * python/py-utils.c: Update.
12268 * python/py-value.c: Update.
12269 * python/python.c: Update.
12270 * record-btrace.c: Update.
12271 * record-full.c: Update.
12272 * remote-fileio.c: Update.
12273 * remote.c: Update.
12274 * riscv-tdep.c: Update.
12275 * rs6000-aix-tdep.c: Update.
12276 * rs6000-tdep.c: Update.
12277 * rust-exp.y: Update.
12278 * rust-lang.c: Update.
12279 * s390-tdep.c: Update.
12280 * selftest-arch.c: Update.
12281 * solib-dsbt.c: Update.
12282 * solib-frv.c: Update.
12283 * solib-spu.c: Update.
12284 * solib-svr4.c: Update.
12285 * solib.c: Update.
12286 * sparc64-linux-tdep.c: Update.
12287 * stack.c: Update.
12288 * symfile-mem.c: Update.
12289 * symmisc.c: Update.
12290 * target.c: Update.
12291 * thread.c: Update.
12292 * top.c: Update.
12293 * tracefile-tfile.c: Update.
12294 * tui/tui.c: Update.
12295 * typeprint.c: Update.
12296 * unittests/cli-utils-selftests.c: Update.
12297 * unittests/parse-connection-spec-selftests.c: Update.
12298 * valops.c: Update.
12299 * valprint.c: Update.
12300 * value.c: Update.
12301 * varobj.c: Update.
12302 * windows-nat.c: Update.
12303 * x86-linux-nat.c: Update.
12304 * xml-support.c: Update.
12305
a70b8144
TT
123062019-04-08 Tom Tromey <tom@tromey.com>
12307
12308 * xml-support.c: Use C++ exception handling.
12309 * x86-linux-nat.c: Use C++ exception handling.
12310 * windows-nat.c: Use C++ exception handling.
12311 * varobj.c: Use C++ exception handling.
12312 * value.c: Use C++ exception handling.
12313 * valprint.c: Use C++ exception handling.
12314 * valops.c: Use C++ exception handling.
12315 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12316 handling.
12317 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12318 * typeprint.c: Use C++ exception handling.
12319 * tui/tui.c: Use C++ exception handling.
12320 * tracefile-tfile.c: Use C++ exception handling.
12321 * top.c: Use C++ exception handling.
12322 * thread.c: Use C++ exception handling.
12323 * target.c: Use C++ exception handling.
12324 * symmisc.c: Use C++ exception handling.
12325 * symfile-mem.c: Use C++ exception handling.
12326 * stack.c: Use C++ exception handling.
12327 * sparc64-linux-tdep.c: Use C++ exception handling.
12328 * solib.c: Use C++ exception handling.
12329 * solib-svr4.c: Use C++ exception handling.
12330 * solib-spu.c: Use C++ exception handling.
12331 * solib-frv.c: Use C++ exception handling.
12332 * solib-dsbt.c: Use C++ exception handling.
12333 * selftest-arch.c: Use C++ exception handling.
12334 * s390-tdep.c: Use C++ exception handling.
12335 * rust-lang.c: Use C++ exception handling.
12336 * rust-exp.y: Use C++ exception handling.
12337 * rs6000-tdep.c: Use C++ exception handling.
12338 * rs6000-aix-tdep.c: Use C++ exception handling.
12339 * riscv-tdep.c: Use C++ exception handling.
12340 * remote.c: Use C++ exception handling.
12341 * remote-fileio.c: Use C++ exception handling.
12342 * record-full.c: Use C++ exception handling.
12343 * record-btrace.c: Use C++ exception handling.
12344 * python/python.c: Use C++ exception handling.
12345 * python/py-value.c: Use C++ exception handling.
12346 * python/py-utils.c: Use C++ exception handling.
12347 * python/py-unwind.c: Use C++ exception handling.
12348 * python/py-type.c: Use C++ exception handling.
12349 * python/py-symbol.c: Use C++ exception handling.
12350 * python/py-record.c: Use C++ exception handling.
12351 * python/py-record-btrace.c: Use C++ exception handling.
12352 * python/py-progspace.c: Use C++ exception handling.
12353 * python/py-prettyprint.c: Use C++ exception handling.
12354 * python/py-param.c: Use C++ exception handling.
12355 * python/py-objfile.c: Use C++ exception handling.
12356 * python/py-linetable.c: Use C++ exception handling.
12357 * python/py-lazy-string.c: Use C++ exception handling.
12358 * python/py-infthread.c: Use C++ exception handling.
12359 * python/py-inferior.c: Use C++ exception handling.
12360 * python/py-gdb-readline.c: Use C++ exception handling.
12361 * python/py-framefilter.c: Use C++ exception handling.
12362 * python/py-frame.c: Use C++ exception handling.
12363 * python/py-finishbreakpoint.c: Use C++ exception handling.
12364 * python/py-cmd.c: Use C++ exception handling.
12365 * python/py-breakpoint.c: Use C++ exception handling.
12366 * python/py-arch.c: Use C++ exception handling.
12367 * printcmd.c: Use C++ exception handling.
12368 * ppc-linux-tdep.c: Use C++ exception handling.
12369 * parse.c: Use C++ exception handling.
12370 * p-valprint.c: Use C++ exception handling.
12371 * objc-lang.c: Use C++ exception handling.
12372 * mi/mi-main.c: Use C++ exception handling.
12373 * mi/mi-interp.c: Use C++ exception handling.
12374 * mi/mi-cmd-stack.c: Use C++ exception handling.
12375 * mi/mi-cmd-break.c: Use C++ exception handling.
12376 * main.c: Use C++ exception handling.
12377 * linux-thread-db.c: Use C++ exception handling.
12378 * linux-tdep.c: Use C++ exception handling.
12379 * linux-nat.c: Use C++ exception handling.
12380 * linux-fork.c: Use C++ exception handling.
12381 * linespec.c: Use C++ exception handling.
12382 * language.c: Use C++ exception handling.
12383 * jit.c: Use C++ exception handling.
12384 * infrun.c: Use C++ exception handling.
12385 * infcmd.c: Use C++ exception handling.
12386 * infcall.c: Use C++ exception handling.
12387 * inf-loop.c: Use C++ exception handling.
12388 * i386-tdep.c: Use C++ exception handling.
12389 * i386-linux-tdep.c: Use C++ exception handling.
12390 * guile/scm-value.c: Use C++ exception handling.
12391 * guile/scm-type.c: Use C++ exception handling.
12392 * guile/scm-symtab.c: Use C++ exception handling.
12393 * guile/scm-symbol.c: Use C++ exception handling.
12394 * guile/scm-pretty-print.c: Use C++ exception handling.
12395 * guile/scm-ports.c: Use C++ exception handling.
12396 * guile/scm-param.c: Use C++ exception handling.
12397 * guile/scm-math.c: Use C++ exception handling.
12398 * guile/scm-lazy-string.c: Use C++ exception handling.
12399 * guile/scm-frame.c: Use C++ exception handling.
12400 * guile/scm-disasm.c: Use C++ exception handling.
12401 * guile/scm-cmd.c: Use C++ exception handling.
12402 * guile/scm-breakpoint.c: Use C++ exception handling.
12403 * guile/scm-block.c: Use C++ exception handling.
12404 * guile/guile-internal.h: Use C++ exception handling.
12405 * gnu-v3-abi.c: Use C++ exception handling.
12406 * gdbtypes.c: Use C++ exception handling.
12407 * frame.c: Use C++ exception handling.
12408 * frame-unwind.c: Use C++ exception handling.
12409 * fbsd-tdep.c: Use C++ exception handling.
12410 * f-valprint.c: Use C++ exception handling.
12411 * exec.c: Use C++ exception handling.
12412 * event-top.c: Use C++ exception handling.
12413 * event-loop.c: Use C++ exception handling.
12414 * eval.c: Use C++ exception handling.
12415 * dwarf2read.c: Use C++ exception handling.
12416 * dwarf2loc.c: Use C++ exception handling.
12417 * dwarf2-frame.c: Use C++ exception handling.
12418 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12419 * dwarf-index-write.c: Use C++ exception handling.
12420 * dwarf-index-cache.c: Use C++ exception handling.
12421 * dtrace-probe.c: Use C++ exception handling.
12422 * disasm-selftests.c: Use C++ exception handling.
12423 * darwin-nat.c: Use C++ exception handling.
12424 * cp-valprint.c: Use C++ exception handling.
12425 * cp-support.c: Use C++ exception handling.
12426 * cp-abi.c: Use C++ exception handling.
12427 * corelow.c: Use C++ exception handling.
12428 * completer.c: Use C++ exception handling.
12429 * compile/compile-object-run.c: Use C++ exception handling.
12430 * compile/compile-object-load.c: Use C++ exception handling.
12431 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12432 * compile/compile-c-symbols.c: Use C++ exception handling.
12433 * common/selftest.c: Use C++ exception handling.
12434 * common/new-op.c: Use C++ exception handling.
12435 * cli/cli-script.c: Use C++ exception handling.
12436 * cli/cli-interp.c: Use C++ exception handling.
12437 * cli/cli-cmds.c: Use C++ exception handling.
12438 * c-varobj.c: Use C++ exception handling.
12439 * btrace.c: Use C++ exception handling.
12440 * breakpoint.c: Use C++ exception handling.
12441 * break-catch-throw.c: Use C++ exception handling.
12442 * arch-utils.c: Use C++ exception handling.
12443 * amd64-tdep.c: Use C++ exception handling.
12444 * ada-valprint.c: Use C++ exception handling.
12445 * ada-typeprint.c: Use C++ exception handling.
12446 * ada-lang.c: Use C++ exception handling.
12447 * aarch64-tdep.c: Use C++ exception handling.
12448
3d6e9d23
TT
124492019-04-08 Tom Tromey <tom@tromey.com>
12450
12451 * xml-support.c (gdb_xml_parser::parse): Update.
12452 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12453 * value.c (show_convenience): Update.
12454 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12455 (test_parse_flags_qcs): Update.
12456 * thread.c (thr_try_catch_cmd): Update.
12457 * target.c (target_translate_tls_address): Update.
12458 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12459 (info_frame_command_core, frame_apply_command_count): Update.
12460 * rust-exp.y (rust_lex_exception_test): Update.
12461 * riscv-tdep.c (riscv_print_one_register_info): Update.
12462 * remote.c (remote_target::enable_btrace): Update.
12463 * record-btrace.c (record_btrace_enable_warn): Update.
12464 * python/py-utils.c (gdbpy_convert_exception): Update.
12465 * printcmd.c (do_one_display, print_variable_and_value): Update.
12466 * mi/mi-main.c (mi_print_exception): Update.
12467 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12468 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12469 * linux-nat.c (linux_nat_target::attach): Update.
12470 * linux-fork.c (class scoped_switch_fork_info): Update.
12471 * infrun.c (displaced_step_prepare): Update.
12472 * infcall.c (call_function_by_hand_dummy): Update.
12473 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12474 * gnu-v3-abi.c (print_one_vtable): Update.
12475 * frame.c (get_prev_frame_always): Update.
12476 * f-valprint.c (info_common_command_for_block): Update.
12477 * exec.c (try_open_exec_file): Update.
12478 * exceptions.c (print_exception, exception_print)
12479 (exception_fprintf, exception_print_same): Update.
12480 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12481 * dwarf-index-cache.c (index_cache::store)
12482 (index_cache::lookup_gdb_index): Update.
12483 * darwin-nat.c (maybe_cache_shell): Update.
12484 * cp-valprint.c (cp_print_value_fields): Update.
12485 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12486 (gcc_cplus_symbol_address): Update.
12487 * compile/compile-c-symbols.c (gcc_convert_symbol)
12488 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12489 * common/selftest.c: Update.
12490 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12491 a std::string.
12492 (exception_try_scope_entry, exception_try_scope_exit): Don't
12493 declare.
12494 (struct exception_try_scope): Remove.
12495 (TRY): Don't use exception_try_scope.
12496 (struct gdb_exception): Add constructor, operator=.
12497 <what>: New method.
12498 (struct gdb_exception_RETURN_MASK_ALL)
12499 (struct gdb_exception_RETURN_MASK_ERROR)
12500 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12501 (struct gdb_quit_bad_alloc): Update.
12502 * common/common-exceptions.c (exception_none): Change
12503 initializer.
12504 (struct catcher) <state, exception>: Initialize inline.
12505 <prev>: Remove member.
12506 (current_catcher): Remove.
12507 (catchers): New global.
12508 (exceptions_state_mc_init): Simplify.
12509 (catcher_pop): Remove.
12510 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12511 (try_scope_depth, exception_try_scope_entry)
12512 (exception_try_scope_exit): Remove.
12513 (throw_exception_sjlj): Update.
12514 (exception_messages, exception_messages_size): Remove.
12515 (throw_it): Simplify.
12516 (gdb_exception_sliced_copy): Remove.
12517 (throw_exception_cxx): Update.
12518 * cli/cli-script.c (script_from_file): Update.
12519 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12520 Update.
12521 * ada-valprint.c (ada_val_print): Update.
12522 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12523 (create_excep_cond_exprs): Update.
12524
c5c10118
TT
125252019-04-08 Tom Tromey <tom@tromey.com>
12526
12527 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12528 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12529 (TRY, CATCH, END_CATCH): Remove some definitions.
12530 * common/common-exceptions.c: Don't use GDB_XCPT.
12531 (catcher_list_size): Remove.
12532 (throw_exception, throw_it): Simplify.
12533
4de283e4
TT
125342019-04-05 Tom Tromey <tom@tromey.com>
12535
12536 Revert the header-sorting patch.
12537 * ft32-tdep.c: Revert.
12538 * frv-tdep.c: Revert.
12539 * frv-linux-tdep.c: Revert.
12540 * frame.c: Revert.
12541 * frame-unwind.c: Revert.
12542 * frame-base.c: Revert.
12543 * fork-child.c: Revert.
12544 * findvar.c: Revert.
12545 * findcmd.c: Revert.
12546 * filesystem.c: Revert.
12547 * filename-seen-cache.h: Revert.
12548 * filename-seen-cache.c: Revert.
12549 * fbsd-tdep.c: Revert.
12550 * fbsd-nat.h: Revert.
12551 * fbsd-nat.c: Revert.
12552 * f-valprint.c: Revert.
12553 * f-typeprint.c: Revert.
12554 * f-lang.c: Revert.
12555 * extension.h: Revert.
12556 * extension.c: Revert.
12557 * extension-priv.h: Revert.
12558 * expprint.c: Revert.
12559 * exec.h: Revert.
12560 * exec.c: Revert.
12561 * exceptions.c: Revert.
12562 * event-top.c: Revert.
12563 * event-loop.c: Revert.
12564 * eval.c: Revert.
12565 * elfread.c: Revert.
12566 * dwarf2read.h: Revert.
12567 * dwarf2read.c: Revert.
12568 * dwarf2loc.c: Revert.
12569 * dwarf2expr.h: Revert.
12570 * dwarf2expr.c: Revert.
12571 * dwarf2-frame.c: Revert.
12572 * dwarf2-frame-tailcall.c: Revert.
12573 * dwarf-index-write.h: Revert.
12574 * dwarf-index-write.c: Revert.
12575 * dwarf-index-common.c: Revert.
12576 * dwarf-index-cache.h: Revert.
12577 * dwarf-index-cache.c: Revert.
12578 * dummy-frame.c: Revert.
12579 * dtrace-probe.c: Revert.
12580 * disasm.h: Revert.
12581 * disasm.c: Revert.
12582 * disasm-selftests.c: Revert.
12583 * dictionary.c: Revert.
12584 * dicos-tdep.c: Revert.
12585 * demangle.c: Revert.
12586 * dcache.h: Revert.
12587 * dcache.c: Revert.
12588 * darwin-nat.h: Revert.
12589 * darwin-nat.c: Revert.
12590 * darwin-nat-info.c: Revert.
12591 * d-valprint.c: Revert.
12592 * d-namespace.c: Revert.
12593 * d-lang.c: Revert.
12594 * ctf.c: Revert.
12595 * csky-tdep.c: Revert.
12596 * csky-linux-tdep.c: Revert.
12597 * cris-tdep.c: Revert.
12598 * cris-linux-tdep.c: Revert.
12599 * cp-valprint.c: Revert.
12600 * cp-support.c: Revert.
12601 * cp-namespace.c: Revert.
12602 * cp-abi.c: Revert.
12603 * corelow.c: Revert.
12604 * corefile.c: Revert.
12605 * continuations.c: Revert.
12606 * completer.h: Revert.
12607 * completer.c: Revert.
12608 * complaints.c: Revert.
12609 * coffread.c: Revert.
12610 * coff-pe-read.c: Revert.
12611 * cli-out.h: Revert.
12612 * cli-out.c: Revert.
12613 * charset.c: Revert.
12614 * c-varobj.c: Revert.
12615 * c-valprint.c: Revert.
12616 * c-typeprint.c: Revert.
12617 * c-lang.c: Revert.
12618 * buildsym.c: Revert.
12619 * buildsym-legacy.c: Revert.
12620 * build-id.h: Revert.
12621 * build-id.c: Revert.
12622 * btrace.c: Revert.
12623 * bsd-uthread.c: Revert.
12624 * breakpoint.h: Revert.
12625 * breakpoint.c: Revert.
12626 * break-catch-throw.c: Revert.
12627 * break-catch-syscall.c: Revert.
12628 * break-catch-sig.c: Revert.
12629 * blockframe.c: Revert.
12630 * block.c: Revert.
12631 * bfin-tdep.c: Revert.
12632 * bfin-linux-tdep.c: Revert.
12633 * bfd-target.c: Revert.
12634 * bcache.c: Revert.
12635 * ax-general.c: Revert.
12636 * ax-gdb.h: Revert.
12637 * ax-gdb.c: Revert.
12638 * avr-tdep.c: Revert.
12639 * auxv.c: Revert.
12640 * auto-load.c: Revert.
12641 * arm-wince-tdep.c: Revert.
12642 * arm-tdep.c: Revert.
12643 * arm-symbian-tdep.c: Revert.
12644 * arm-pikeos-tdep.c: Revert.
12645 * arm-obsd-tdep.c: Revert.
12646 * arm-nbsd-tdep.c: Revert.
12647 * arm-nbsd-nat.c: Revert.
12648 * arm-linux-tdep.c: Revert.
12649 * arm-linux-nat.c: Revert.
12650 * arm-fbsd-tdep.c: Revert.
12651 * arm-fbsd-nat.c: Revert.
12652 * arm-bsd-tdep.c: Revert.
12653 * arch-utils.c: Revert.
12654 * arc-tdep.c: Revert.
12655 * arc-newlib-tdep.c: Revert.
12656 * annotate.h: Revert.
12657 * annotate.c: Revert.
12658 * amd64-windows-tdep.c: Revert.
12659 * amd64-windows-nat.c: Revert.
12660 * amd64-tdep.c: Revert.
12661 * amd64-sol2-tdep.c: Revert.
12662 * amd64-obsd-tdep.c: Revert.
12663 * amd64-obsd-nat.c: Revert.
12664 * amd64-nbsd-tdep.c: Revert.
12665 * amd64-nbsd-nat.c: Revert.
12666 * amd64-nat.c: Revert.
12667 * amd64-linux-tdep.c: Revert.
12668 * amd64-linux-nat.c: Revert.
12669 * amd64-fbsd-tdep.c: Revert.
12670 * amd64-fbsd-nat.c: Revert.
12671 * amd64-dicos-tdep.c: Revert.
12672 * amd64-darwin-tdep.c: Revert.
12673 * amd64-bsd-nat.c: Revert.
12674 * alpha-tdep.c: Revert.
12675 * alpha-obsd-tdep.c: Revert.
12676 * alpha-nbsd-tdep.c: Revert.
12677 * alpha-mdebug-tdep.c: Revert.
12678 * alpha-linux-tdep.c: Revert.
12679 * alpha-linux-nat.c: Revert.
12680 * alpha-bsd-tdep.c: Revert.
12681 * alpha-bsd-nat.c: Revert.
12682 * aix-thread.c: Revert.
12683 * agent.c: Revert.
12684 * addrmap.c: Revert.
12685 * ada-varobj.c: Revert.
12686 * ada-valprint.c: Revert.
12687 * ada-typeprint.c: Revert.
12688 * ada-tasks.c: Revert.
12689 * ada-lang.c: Revert.
12690 * aarch64-tdep.c: Revert.
12691 * aarch64-ravenscar-thread.c: Revert.
12692 * aarch64-newlib-tdep.c: Revert.
12693 * aarch64-linux-tdep.c: Revert.
12694 * aarch64-linux-nat.c: Revert.
12695 * aarch64-fbsd-tdep.c: Revert.
12696 * aarch64-fbsd-nat.c: Revert.
12697 * aarch32-linux-nat.c: Revert.
12698
d55e5aa6
TT
126992019-04-05 Tom Tromey <tom@tromey.com>
12700
12701 * ft32-tdep.c: Sort headers.
12702 * frv-tdep.c: Sort headers.
12703 * frv-linux-tdep.c: Sort headers.
12704 * frame.c: Sort headers.
12705 * frame-unwind.c: Sort headers.
12706 * frame-base.c: Sort headers.
12707 * fork-child.c: Sort headers.
12708 * findvar.c: Sort headers.
12709 * findcmd.c: Sort headers.
12710 * filesystem.c: Sort headers.
12711 * filename-seen-cache.h: Sort headers.
12712 * filename-seen-cache.c: Sort headers.
12713 * fbsd-tdep.c: Sort headers.
12714 * fbsd-nat.h: Sort headers.
12715 * fbsd-nat.c: Sort headers.
12716 * f-valprint.c: Sort headers.
12717 * f-typeprint.c: Sort headers.
12718 * f-lang.c: Sort headers.
12719 * extension.h: Sort headers.
12720 * extension.c: Sort headers.
12721 * extension-priv.h: Sort headers.
12722 * expprint.c: Sort headers.
12723 * exec.h: Sort headers.
12724 * exec.c: Sort headers.
12725 * exceptions.c: Sort headers.
12726 * event-top.c: Sort headers.
12727 * event-loop.c: Sort headers.
12728 * eval.c: Sort headers.
12729 * elfread.c: Sort headers.
12730 * dwarf2read.h: Sort headers.
12731 * dwarf2read.c: Sort headers.
12732 * dwarf2loc.c: Sort headers.
12733 * dwarf2expr.h: Sort headers.
12734 * dwarf2expr.c: Sort headers.
12735 * dwarf2-frame.c: Sort headers.
12736 * dwarf2-frame-tailcall.c: Sort headers.
12737 * dwarf-index-write.h: Sort headers.
12738 * dwarf-index-write.c: Sort headers.
12739 * dwarf-index-common.c: Sort headers.
12740 * dwarf-index-cache.h: Sort headers.
12741 * dwarf-index-cache.c: Sort headers.
12742 * dummy-frame.c: Sort headers.
12743 * dtrace-probe.c: Sort headers.
12744 * disasm.h: Sort headers.
12745 * disasm.c: Sort headers.
12746 * disasm-selftests.c: Sort headers.
12747 * dictionary.c: Sort headers.
12748 * dicos-tdep.c: Sort headers.
12749 * demangle.c: Sort headers.
12750 * dcache.h: Sort headers.
12751 * dcache.c: Sort headers.
12752 * darwin-nat.h: Sort headers.
12753 * darwin-nat.c: Sort headers.
12754 * darwin-nat-info.c: Sort headers.
12755 * d-valprint.c: Sort headers.
12756 * d-namespace.c: Sort headers.
12757 * d-lang.c: Sort headers.
12758 * ctf.c: Sort headers.
12759 * csky-tdep.c: Sort headers.
12760 * csky-linux-tdep.c: Sort headers.
12761 * cris-tdep.c: Sort headers.
12762 * cris-linux-tdep.c: Sort headers.
12763 * cp-valprint.c: Sort headers.
12764 * cp-support.c: Sort headers.
12765 * cp-namespace.c: Sort headers.
12766 * cp-abi.c: Sort headers.
12767 * corelow.c: Sort headers.
12768 * corefile.c: Sort headers.
12769 * continuations.c: Sort headers.
12770 * completer.h: Sort headers.
12771 * completer.c: Sort headers.
12772 * complaints.c: Sort headers.
12773 * coffread.c: Sort headers.
12774 * coff-pe-read.c: Sort headers.
12775 * cli-out.h: Sort headers.
12776 * cli-out.c: Sort headers.
12777 * charset.c: Sort headers.
12778 * c-varobj.c: Sort headers.
12779 * c-valprint.c: Sort headers.
12780 * c-typeprint.c: Sort headers.
12781 * c-lang.c: Sort headers.
12782 * buildsym.c: Sort headers.
12783 * buildsym-legacy.c: Sort headers.
12784 * build-id.h: Sort headers.
12785 * build-id.c: Sort headers.
12786 * btrace.c: Sort headers.
12787 * bsd-uthread.c: Sort headers.
12788 * breakpoint.h: Sort headers.
12789 * breakpoint.c: Sort headers.
12790 * break-catch-throw.c: Sort headers.
12791 * break-catch-syscall.c: Sort headers.
12792 * break-catch-sig.c: Sort headers.
12793 * blockframe.c: Sort headers.
12794 * block.c: Sort headers.
12795 * bfin-tdep.c: Sort headers.
12796 * bfin-linux-tdep.c: Sort headers.
12797 * bfd-target.c: Sort headers.
12798 * bcache.c: Sort headers.
12799 * ax-general.c: Sort headers.
12800 * ax-gdb.h: Sort headers.
12801 * ax-gdb.c: Sort headers.
12802 * avr-tdep.c: Sort headers.
12803 * auxv.c: Sort headers.
12804 * auto-load.c: Sort headers.
12805 * arm-wince-tdep.c: Sort headers.
12806 * arm-tdep.c: Sort headers.
12807 * arm-symbian-tdep.c: Sort headers.
12808 * arm-pikeos-tdep.c: Sort headers.
12809 * arm-obsd-tdep.c: Sort headers.
12810 * arm-nbsd-tdep.c: Sort headers.
12811 * arm-nbsd-nat.c: Sort headers.
12812 * arm-linux-tdep.c: Sort headers.
12813 * arm-linux-nat.c: Sort headers.
12814 * arm-fbsd-tdep.c: Sort headers.
12815 * arm-fbsd-nat.c: Sort headers.
12816 * arm-bsd-tdep.c: Sort headers.
12817 * arch-utils.c: Sort headers.
12818 * arc-tdep.c: Sort headers.
12819 * arc-newlib-tdep.c: Sort headers.
12820 * annotate.h: Sort headers.
12821 * annotate.c: Sort headers.
12822 * amd64-windows-tdep.c: Sort headers.
12823 * amd64-windows-nat.c: Sort headers.
12824 * amd64-tdep.c: Sort headers.
12825 * amd64-sol2-tdep.c: Sort headers.
12826 * amd64-obsd-tdep.c: Sort headers.
12827 * amd64-obsd-nat.c: Sort headers.
12828 * amd64-nbsd-tdep.c: Sort headers.
12829 * amd64-nbsd-nat.c: Sort headers.
12830 * amd64-nat.c: Sort headers.
12831 * amd64-linux-tdep.c: Sort headers.
12832 * amd64-linux-nat.c: Sort headers.
12833 * amd64-fbsd-tdep.c: Sort headers.
12834 * amd64-fbsd-nat.c: Sort headers.
12835 * amd64-dicos-tdep.c: Sort headers.
12836 * amd64-darwin-tdep.c: Sort headers.
12837 * amd64-bsd-nat.c: Sort headers.
12838 * alpha-tdep.c: Sort headers.
12839 * alpha-obsd-tdep.c: Sort headers.
12840 * alpha-nbsd-tdep.c: Sort headers.
12841 * alpha-mdebug-tdep.c: Sort headers.
12842 * alpha-linux-tdep.c: Sort headers.
12843 * alpha-linux-nat.c: Sort headers.
12844 * alpha-bsd-tdep.c: Sort headers.
12845 * alpha-bsd-nat.c: Sort headers.
12846 * aix-thread.c: Sort headers.
12847 * agent.c: Sort headers.
12848 * addrmap.c: Sort headers.
12849 * ada-varobj.c: Sort headers.
12850 * ada-valprint.c: Sort headers.
12851 * ada-typeprint.c: Sort headers.
12852 * ada-tasks.c: Sort headers.
12853 * ada-lang.c: Sort headers.
12854 * aarch64-tdep.c: Sort headers.
12855 * aarch64-ravenscar-thread.c: Sort headers.
12856 * aarch64-newlib-tdep.c: Sort headers.
12857 * aarch64-linux-tdep.c: Sort headers.
12858 * aarch64-linux-nat.c: Sort headers.
12859 * aarch64-fbsd-tdep.c: Sort headers.
12860 * aarch64-fbsd-nat.c: Sort headers.
12861 * aarch32-linux-nat.c: Sort headers.
12862
699bd4cf
TT
128632019-04-04 Tom Tromey <tom@tromey.com>
12864
12865 * varobj.c (varobj_create): Update.
12866 * rust-exp.y (struct rust_parser) <update_innermost_block,
12867 lookup_symbol>: New methods.
12868 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12869 Rename.
12870 (rust_parser::rust_lookup_type)
12871 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12872 * printcmd.c (display_command, do_one_display): Update.
12873 * parser-defs.h (struct parser_state) <parser_state>: Add
12874 "tracker" parameter.
12875 (block_tracker): New member.
12876 (class innermost_block_tracker) <innermost_block_tracker>: Add
12877 "types" parameter.
12878 <reset>: Remove method.
12879 (innermost_block): Don't declare.
12880 (null_post_parser): Update.
12881 * parse.c (innermost_block): Remove global.
12882 (write_dollar_variable): Update.
12883 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12884 Remove "tracker_types" parameter.
12885 (parse_expression): Add "tracker" parameter.
12886 (parse_expression_for_completion): Update.
12887 (null_post_parser): Add "tracker" parameter.
12888 * p-exp.y: Update rules.
12889 * m2-exp.y: Update rules.
12890 * language.h (struct language_defn) <la_post_parser>: Add
12891 "tracker" parameter.
12892 * go-exp.y: Update rules.
12893 * f-exp.y: Update rules.
12894 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12895 parameter.
12896 * d-exp.y: Update rules.
12897 * c-exp.y: Update rules.
12898 * breakpoint.c (set_breakpoint_condition): Create an
12899 innermost_block_tracker.
12900 (watch_command_1): Likewise.
12901 * ada-lang.c (resolve): Add "tracker" parameter.
12902 (resolve_subexp): Likewise.
12903 * ada-exp.y (write_var_from_sym): Update.
12904
dac43e32
TT
129052019-04-04 Tom Tromey <tom@tromey.com>
12906
12907 * type-stack.h: New file.
12908 * type-stack.c: New file.
12909 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12910 type-stack.h.
12911 (insert_into_type_stack, insert_type, push_type, push_type_int)
12912 (insert_type_address_space, pop_type, pop_type_int)
12913 (pop_typelist, pop_type_stack, append_type_stack)
12914 (push_type_stack, get_type_stack, push_typelist)
12915 (follow_type_instance_flags, follow_types): Don't declare.
12916 * parse.c (type_stack): Remove global.
12917 (parse_exp_in_context): Update.
12918 (insert_into_type_stack, insert_type, push_type, push_type_int)
12919 (insert_type_address_space, pop_type, pop_type_int)
12920 (pop_typelist, pop_type_stack, append_type_stack)
12921 (push_type_stack, get_type_stack, push_typelist)
12922 (follow_type_instance_flags, follow_types): Remove (moved to
12923 type-stack.c).
12924 * f-exp.y (type_stack): New global.
12925 Update rules.
12926 (push_kind_type, f_parse): Update.
12927 * d-exp.y (type_stack): New global.
12928 Update rules.
12929 (d_parse): Update.
12930 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12931 Update rules.
12932 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12933 (HFILES_NO_SRCDIR): Add type-stack.h.
12934
2a612529
TT
129352019-04-04 Tom Tromey <tom@tromey.com>
12936
12937 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12938 (rust_parser::convert_ast_to_expression, rust_parse)
12939 (rust_lex_test_completion, rust_lex_tests): Update.
12940 * parser-defs.h (struct expr_completion_state): New.
12941 (struct parser_state) <parser_state>: Add completion parameter.
12942 <mark_struct_expression, mark_completion_tag>: New methods.
12943 <parse_completion, m_completion_state>: New members.
12944 (prefixify_expression, null_post_parser): Update.
12945 (mark_struct_expression, mark_completion_tag): Don't declare.
12946 * parse.c (parse_completion, expout_last_struct)
12947 (expout_tag_completion_type, expout_completion_name): Remove
12948 globals.
12949 (parser_state::mark_struct_expression)
12950 (parser_state::mark_completion_tag): Now methods.
12951 (prefixify_expression): Add last_struct parameter.
12952 (prefixify_subexp): Likewise.
12953 (parse_exp_1): Update.
12954 (parse_exp_in_context): Add cstate parameter. Update.
12955 (parse_expression_for_completion): Create an
12956 expr_completion_state.
12957 (null_post_parser): Add "completion" parameter.
12958 * p-exp.y: Update rules.
12959 (yylex): Update.
12960 * language.h (struct language_defn) <la_post_parser>: Add
12961 "completing" parameter.
12962 * go-exp.y: Update rules.
12963 (lex_one_token): Update.
12964 * expression.h (parse_completion): Don't declare.
12965 * d-exp.y: Update rules.
12966 (lex_one_token): Update rules.
12967 * c-exp.y: Update rules.
12968 (lex_one_token): Update.
12969 * ada-lang.c (resolve): Add "parse_completion" parameter.
12970 (resolve_subexp): Likewise.
12971 (ada_resolve_function): Likewise.
12972
43476f0b
TT
129732019-04-04 Tom Tromey <tom@tromey.com>
12974
12975 * parser-defs.h (struct parser_state) <start_arglist,
12976 end_arglist>: New methods.
12977 <arglist_len, m_funcall_chain>: New members.
12978 (arglist_len, start_arglist, end_arglist): Don't declare.
12979 * parse.c (arglist_len, funcall_chain): Remove global.
12980 (start_arglist, end_arglist): Remove functions.
12981 (parse_exp_in_context): Update.
12982 * p-exp.y: Update rules.
12983 * m2-exp.y: Update rules.
12984 * go-exp.y: Update rules.
12985 * f-exp.y: Update rules.
12986 * d-exp.y: Update rules.
12987 * c-exp.y: Update rules.
12988
5776fca3
TT
129892019-04-04 Tom Tromey <tom@tromey.com>
12990
12991 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12992 lex_operator, push_back>: New methods.
12993 Update all rules.
12994 (rust_parser::lex_hex, lex_escape): Rename and update.
12995 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12996 (rust_parser::lex_operator): Rename and update.
12997 (rust_parser::lex_number, rustyylex, rustyyerror)
12998 (rust_lex_test_init, rust_lex_test_sequence)
12999 (rust_lex_test_push_back, rust_lex_tests): Update.
13000 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
13001 parameter.
13002 <lexptr, prev_lexptr>: New members.
13003 (lexptr, prev_lexptr): Don't declare.
13004 * parse.c (lexptr, prev_lexptr): Remove globals.
13005 (parse_exp_in_context): Update.
13006 * p-exp.y (yylex, yyerror): Update.
13007 * m2-exp.y (parse_number, yylex, yyerror): Update.
13008 * go-exp.y (lex_one_token, yyerror): Update.
13009 * f-exp.y (match_string_literal, yylex, yyerror): Update.
13010 * d-exp.y (lex_one_token, yyerror): Update.
13011 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13012 (lex_one_token, yyerror): Update.
13013 * ada-lex.l (YY_INPUT): Update.
13014 (rewind_to_char): Update.
13015 * ada-exp.y (yyerror): Update.
13016
8621b685
TT
130172019-04-04 Tom Tromey <tom@tromey.com>
13018
13019 * rust-exp.y (rustyylex, rust_lex_tests): Update.
13020 * parser-defs.h (struct parser_state) <parser_state>: Add new
13021 parameter.
13022 <comma_terminates>: New member.
13023 (comma_terminates): Don't declare global.
13024 * parse.c (comma_terminates): Remove global.
13025 (parse_exp_in_context): Update.
13026 * p-exp.y (yylex): Update.
13027 * m2-exp.y (yylex): Update.
13028 * go-exp.y (lex_one_token): Update.
13029 * f-exp.y (yylex): Update.
13030 * d-exp.y (lex_one_token): Update.
13031 * c-exp.y (lex_one_token): Update.
13032 * ada-lex.l: Update.
13033
28aaf3fd
TT
130342019-04-04 Tom Tromey <tom@tromey.com>
13035
13036 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13037 (rustyylex, rust_lex_test_init, rust_lex_test_one)
13038 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13039 * parser-defs.h (paren_depth): Don't declare.
13040 * parse.c (paren_depth): Remove global.
13041 (parse_exp_in_context): Update.
13042 * p-exp.y (paren_depth): New global.
13043 (pascal_parse): Initialize it.
13044 * m2-exp.y (paren_depth): New global.
13045 (m2_parse): Initialize it.
13046 * go-exp.y (paren_depth): New global.
13047 (go_parse): Initialize it.
13048 * f-exp.y (paren_depth): New global.
13049 (f_parse): Initialize it.
13050 * d-exp.y (paren_depth): New global.
13051 (d_parse): Initialize it.
13052 * c-exp.y (paren_depth): New global.
13053 (c_parse): Initialize it.
13054 * ada-lex.l (paren_depth): New global.
13055 (lexer_init): Initialize it.
13056
1e58a4a4
TT
130572019-04-04 Tom Tromey <tom@tromey.com>
13058
13059 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13060 (rust_parser::convert_ast_to_type)
13061 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13062 * parser-defs.h (struct parser_state) <parser_state>: Add
13063 parameters. Initialize new members.
13064 <expression_context_block, expression_context_pc>: New members.
13065 * parse.c (expression_context_block, expression_context_pc):
13066 Remove globals.
13067 (parse_exp_in_context): Update.
13068 * p-exp.y: Update all rules.
13069 (yylex): Update.
13070 * m2-exp.y: Update all rules.
13071 (yylex): Update.
13072 * go-exp.y (yylex): Update.
13073 * f-exp.y (yylex): Update.
13074 * d-exp.y: Update all rules.
13075 (yylex): Update.
13076 * c-exp.y: Update all rules.
13077 (lex_one_token, classify_name, yylex, c_parse): Update.
13078 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13079
37eedb39
TT
130802019-04-04 Tom Tromey <tom@tromey.com>
13081
13082 * gdbarch.h, gdbarch.c: Rebuild.
13083 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13084 * stap-probe.h:
13085 (struct stap_parse_info): Replace "parser_state" with
13086 "expr_builder".
13087 * parser-defs.h (struct expr_builder): Rename from "parser_state".
13088 (parser_state): New class.
13089 * parse.c (expr_builder): Rename.
13090 (expr_builder::release): Rename.
13091 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13092 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13093 (write_exp_elt_longcst, write_exp_elt_floatcst)
13094 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13095 (write_exp_string_vector, write_exp_bitstring)
13096 (write_exp_msymbol, mark_struct_expression)
13097 (write_dollar_variable)
13098 (insert_type_address_space, increase_expout_size): Replace
13099 "parser_state" with "expr_builder".
13100 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13101 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13102 "parser_state" with "expr_builder".
13103
73923d7e
TT
131042019-04-04 Tom Tromey <tom@tromey.com>
13105
13106 * rust-exp.y: Replace "parse_language" with method call.
13107 * p-exp.y:
13108 (yylex): Replace "parse_language" with method call.
13109 * m2-exp.y:
13110 (yylex): Replace "parse_language" with method call.
13111 * go-exp.y (classify_name): Replace "parse_language" with method
13112 call.
13113 * f-exp.y (yylex): Replace "parse_language" with method call.
13114 * d-exp.y (lex_one_token): Replace "parse_language" with method
13115 call.
13116 * c-exp.y:
13117 (lex_one_token, classify_name, yylex): Replace "parse_language"
13118 with method call.
13119 * ada-exp.y (find_primitive_type, type_char)
13120 (type_system_address): Replace "parse_language" with method call.
13121
fa9f5be6
TT
131222019-04-04 Tom Tromey <tom@tromey.com>
13123
13124 * rust-exp.y: Replace "parse_gdbarch" with method call.
13125 * parse.c (write_dollar_variable, insert_type_address_space):
13126 Replace "parse_gdbarch" with method call.
13127 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13128 call.
13129 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13130 call.
13131 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13132 "parse_gdbarch" with method call.
13133 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13134 with method call.
13135 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13136 "parse_gdbarch" with method call.
13137 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13138 "parse_gdbarch" with method call.
13139 * c-exp.y (parse_type, parse_number, classify_name): Replace
13140 "parse_gdbarch" with method call.
13141 * ada-lex.l: Replace "parse_gdbarch" with method call.
13142 * ada-exp.y (parse_type, find_primitive_type, type_char)
13143 (type_system_address): Replace "parse_gdbarch" with method call.
13144
1201a264
TT
131452019-04-04 Tom Tromey <tom@tromey.com>
13146
13147 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13148 * stap-probe.c (stap_parse_argument): Update.
13149 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13150 initial_size parameter.
13151 * rust-exp.y (rust_lex_tests): Update.
13152 * parse.c (parser_state): Update.
13153 (parse_exp_in_context): Update.
13154 * parser-defs.h (struct parser_state) <parser_state>: Remove
13155 "initial_size" parameter.
13156
e3980ce2
TT
131572019-04-04 Tom Tromey <tom@tromey.com>
13158
13159 * parser-defs.h (increase_expout_size): Don't declare.
13160 * parse.c (increase_expout_size): Now static.
13161
e9f8e3f1
TS
131622019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13163
13164 * gnu-nat.c (gnu_nat_target::wait): Fix
13165 target_waitstatus_to_string call.
13166
d7df6549
AB
131672019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13168
13169 * eval.c (evaluate_subexp_standard): Handle internal functions
13170 during Fortran function call handling.
13171
8bdc1658
AB
131722019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13173
13174 * NEWS: Mention new internal functions.
13175 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13176 (read_base_type): Use dwarf2_init_complex_target_type.
13177 * value.c (creal_internal_fn): New function.
13178 (cimag_internal_fn): New function.
13179 (_initialize_values): Register new internal functions.
13180
c29705b7
PW
131812019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13182
13183 * infrun.c (stop_all_threads): If debug_infrun, always
13184 trace the wait status after wait_one, using
13185 target_waitstatus_to_string and target_pid_to_str.
13186 (handle_inferior_event): Replace various trace of
13187 wait status kind by a single trace.
13188 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13189 wait status kind image by target_waitstatus_to_string.
13190 * target/waitstatus.c (target_waitstatus_to_string): Fix
13191 obsolete comment.
13192
05caa1d2
TT
131932019-04-01 Tom Tromey <tromey@adacore.com>
13194
13195 PR symtab/23331:
13196 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13197
9d1447e0
SDJ
131982019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13199 Pedro Alves <palves@redhat.com>
13200
13201 * top.c (quit_force): Call 'finalize_values'.
13202 * value.c (finalize_values): New function.
13203 * value.h (finalize_values): Declare.
13204
7734102d
EZ
132052019-03-30 Eli Zaretskii <eliz@gnu.org>
13206
13207 * NEWS: Announce $_gdb_major and $_gdb_minor.
13208
13209 * top.c (init_gdb_version_vars): New function.
13210 (gdb_init): Call init_gdb_version_vars.
13211
188e1fa9
TT
132122019-03-29 Tom Tromey <tromey@adacore.com>
13213
13214 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13215 help text. Remove dead code.
13216
2880242d
KS
132172019-03-29 Keith Seitz <keiths@redhat.com>
13218
13219 From Siddhesh Poyarekar:
13220 * f-lang.h (f77_get_upperbound): Return LONGEST.
13221 (f77_get_lowerbound): Likewise.
13222 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13223 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13224 print them.
13225 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13226 plongest to format print it.
13227 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13228 (f77_get_upperbound): Likewise.
13229 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13230 LOWER_BOUND to LONGEST.
13231 (f77_create_arrayprint_offset_tbl): Likewise.
13232
cc1defb1
KS
132332019-03-29 Keith Seitz <keiths@redhat.com>
13234
13235 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13236 %s/pulongest for TYPE_LENGTH instead of %d in format
13237 strings.
13238 * ada-typerint.c (ada_print_type): Likewise.
13239 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13240 * compile/compile-c-support.c (generate_register_struct): Likewise.
13241 * gdbtypes.c (recursive_dump_type): Likewise.
13242 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13243 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13244 instead of %d in format strings.
13245 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13246 to std::min to ULONGEST.
13247 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13248 instead of %d in format strings.
13249 * tracepoint.c (info_scope_command): Likewise.
13250 * typeprint.c (print_offset_data::update)
13251 (print_offset_data::finish): Likewise.
13252 * xtensa-tdep.c (xtensa_store_return_value)
13253 (xtensa_push_dummy_call): Likewise.
13254
e432ccf1
JT
132552019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13256
13257 * windows-nat.c (display_selector): Fixed format specifications
13258 for 64-bit Cygwin.
13259
65d2b333
PW
132602019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13261
13262 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13263
f489207e
SL
132642019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13265
13266 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13267 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13268 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13269 (nios2_linux_init_abi): Install it.
13270
bffa1015
AH
132712019-03-28 Alan Hayward <alan.hayward@arm.com>
13272
13273 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13274
fc96163a
AH
132752019-03-28 Alan Hayward <alan.hayward@arm.com>
13276
13277 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13278
20dc7e9b
PW
132792019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13280 Tom Tromey <tromey@adacore.com>
13281
13282 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13283
7f5331a8
JB
132842019-03-26 Joel Brobecker <brobecker@adacore.com>
13285
13286 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13287 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13288 method to compute the bounds of range types. Also print "[evaluated]"
13289 if the bounds' values come from a dynamic evaluation.
13290
18c77628
AB
132912019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13292
13293 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13294 whitespace when pretty printing is on.
13295
53c973f2
AH
132962019-03-26 Alan Hayward <alan.hayward@arm.com>
13297
e79be6e5 13298 * ppc-linux-nat.c: Add include.
53c973f2 13299
d851aa71
AH
133002019-03-26 Alan Hayward <alan.hayward@arm.com>
13301
e79be6e5 13302 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 13303
2fe7bab7
AH
133042019-03-26 Alan Hayward <alan.hayward@arm.com>
13305
e79be6e5 13306 * arm-linux-nat.c: Add include.
2fe7bab7 13307
068ef30e
SM
133082019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13309
13310 * source-cache.c (source_cache::get_source_lines): Re-read
13311 fullname after calling open_source_file.
13312
81a24d04
JB
133132019-03-25 John Baldwin <jhb@FreeBSD.org>
13314
13315 * NEWS: Mention TLS support for FreeBSD.
13316
79e7ae11
TT
133172019-03-25 Tom Tromey <tromey@adacore.com>
13318
13319 * minsyms.c (BUNCH_SIZE): Update comment.
13320 (~minimal_symbol_reader): Remove old comment.
13321 (compact_minimal_symbols): Update comment.
13322 (minimal_symbol_reader::install): Remove old comment. Update
13323 other comments.
13324
d45963c2
AH
133252019-03-25 Alan Hayward <alan.hayward@arm.com>
13326
13327 * s390-linux-nat.c: Add include.
13328
0f83012e
AH
133292019-03-25 Alan Hayward <alan.hayward@arm.com>
13330
13331 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13332 Call linux_get_hwcap.
13333 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13334 Likewise.
13335 (aarch64_linux_get_hwcap): Remove function.
13336 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13337 declaration.
13338 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13339 linux_get_hwcap.
13340 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13341 * linux-tdep.c (linux_get_hwcap): Add function.
13342 (linux_get_hwcap2): Likewise.
13343 * linux-tdep.h (linux_get_hwcap): Add declaration.
13344 (linux_get_hwcap2): Likewise.
13345 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13346 (ppc_linux_get_hwcap2): Likewise.
13347 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13348 linux_get_hwcap.
13349 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13350 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13351 (ppc_linux_nat_target::read_description): Likewise.
13352 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13353 * s390-linux-nat.c: Likewise.
13354 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13355
6640a367
TT
133562019-03-24 Tom Tromey <tom@tromey.com>
13357
13358 * ada-lang.c (standard_lookup): Simplify initialization.
13359 (ada_lookup_symbol_nonlocal): Simplify return.
13360 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13361 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13362 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13363 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13364 initialization.
13365 * solib.c (solib_global_lookup): Simplify.
13366 * symtab.c (null_block_symbol): Remove.
13367 (symbol_cache_lookup): Simplify returns.
13368 (lookup_language_this): Simplify returns.
13369 (lookup_symbol_aux): Simplify return.
13370 (lookup_local_symbol): Simplify returns.
13371 (lookup_global_symbol_from_objfile): Simplify return.
13372 (lookup_symbol_in_objfile_symtabs)
13373 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13374 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13375 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13376 * cp-namespace.c (cp_lookup_bare_symbol)
13377 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13378 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13379 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13380 (cp_lookup_symbol_via_imports): Simplify initialization.
13381 (find_symbol_in_baseclass): Likewise.
13382 * symtab.h (null_block_symbol): Remove.
13383 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13384 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13385 (d_lookup_symbol_module): Likewise.
13386 (find_symbol_in_baseclass): Simplify initialization.
13387
a930ebcd
TT
133882019-03-24 Tom Tromey <tom@tromey.com>
13389
13390 * expression.h: Don't include symtab.h.
13391 (struct block): Forward declare.
13392
582942f4
TT
133932019-03-24 Tom Tromey <tom@tromey.com>
13394
13395 * c-exp.y (typebase): Remove casts.
13396 * gdbtypes.c (lookup_unsigned_typename, )
13397 (lookup_signed_typename): Remove cast.
13398 * eval.c (parse_to_comma_and_eval): Remove cast.
13399 * parse.c (write_dollar_variable): Remove cast.
13400 * block.h (struct block) <superblock>: Now const.
13401 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13402 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13403 (map_block): Make "block" const.
13404 * symfile.h (struct quick_symbol_functions)
13405 <map_matching_symbols>: Constify block argument to "callback".
13406 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13407 const.
13408 (find_pc_sect_compunit_symtab): Make "b" const.
13409 (find_symbol_at_address): Likewise.
13410 (search_symbols): Likewise.
13411 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13412 (dw2_debug_names_lookup_symbol): Likewise.
13413 (dw2_map_matching_symbols): Update.
13414 * p-valprint.c (pascal_val_print): Remove "block".
13415 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13416 (aux_add_nonlocal_symbols): Make "block" const.
13417 (resolve_subexp): Remove cast.
13418 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13419 const.
13420 (iterate_over_file_blocks): Likewise.
13421 * f-exp.y (%union) <bval>: Remove.
13422 * coffread.c (patch_opaque_types): Make "b" const.
13423 * spu-tdep.c (spu_catch_start): Make "block" const.
13424 * c-valprint.c (print_unpacked_pointer): Remove "block".
13425 * symmisc.c (dump_symtab_1): Make "b" const.
13426 (block_depth): Make "block" const.
13427 * d-exp.y (%union) <bval>: Remove.
13428 * cp-support.h (cp_lookup_rtti_type): Update.
13429 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13430 * psymtab.c (psym_lookup_symbol): Make "block" const.
13431 (maintenance_check_psymtabs): Make "b" const.
13432 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13433 (enumerate_locals, enumerate_args): Update.
13434 * python/py-symtab.c (stpy_global_block): Make "block" const.
13435 (stpy_static_block): Likewise.
13436 * inline-frame.c (block_starting_point_at): Make "new_block"
13437 const.
13438 * block.c (find_block_in_blockvector): Make return type const.
13439 (blockvector_for_pc_sect): Make "b" const.
13440 (find_block_in_blockvector): Make "b" const.
13441
7ad417dd
TT
134422019-03-23 Tom Tromey <tom@tromey.com>
13443
13444 * varobj.c (varobj_create): Update.
13445 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13446 * printcmd.c (display_command, do_one_display): Don't reset
13447 innermost_block.
13448 * parser-defs.h (enum innermost_block_tracker_type): Move to
13449 expression.h.
13450 (innermost_block): Update comment.
13451 * parse.c (parse_exp_1): Add tracker_types parameter.
13452 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13453 tracker_types parameter. Reset innermost_block.
13454 (parse_exp_in_context): Remove.
13455 (parse_expression_for_completion): Update.
13456 * objfiles.c (~objfile): Don't reset expression_context_block or
13457 innermost_block.
13458 * expression.h (enum innermost_block_tracker_type): Move from
13459 parser-defs.h.
13460 (parse_exp_1): Add tracker_types parameter.
13461 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13462 reset innermost_block.
13463
b366c208
TT
134642019-03-23 Tom Tromey <tom@tromey.com>
13465
13466 * objfiles.h: Include bcache.h.
13467
9bb9b2f9
TT
134682019-03-23 Tom Tromey <tom@tromey.com>
13469
13470 * linespec.c (get_current_search_block): Use
13471 scoped_restore_current_language.
13472 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13473
59c28372
AH
134742019-03-22 Alan Hayward <alan.hayward@arm.com>
13475 Jiong Wang <jiong.wang@arm.com>
13476
13477 * aarch64-linux-tdep.c
13478 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13479 section.
13480 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13481
17e116a7
AH
134822019-03-22 Alan Hayward <alan.hayward@arm.com>
13483 Jiong Wang <jiong.wang@arm.com>
13484
13485 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13486 instructions.
13487 (aarch64_analyze_prologue_test): Add PACIASP test.
13488 (aarch64_prologue_prev_register): Unmask PC value.
13489
11e1b75f
AH
134902019-03-22 Alan Hayward <alan.hayward@arm.com>
13491 Jiong Wang <jiong.wang@arm.com>
13492
13493 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13494 (aarch64_dwarf2_prev_register): Unmask PC value.
13495 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13496 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13497 DW_CFA_AARCH64_negate_ra_state.
13498 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13499
34dcc7cf
AH
135002019-03-22 Alan Hayward <alan.hayward@arm.com>
13501 Jiong Wang <jiong.wang@arm.com>
13502
13503 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13504 registers.
13505 (aarch64_pseudo_register_name): Likewise.
13506 (aarch64_pseudo_register_type): Likewise.
13507 (aarch64_pseudo_register_reggroup_p): Likewise.
13508 (aarch64_gdbarch_init): Add pauth registers.
13509 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13510 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13511 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13512 (struct gdbarch_tdep): Add regnum for ra_state.
13513
1ef53e6b
AH
135142019-03-22 Alan Hayward <alan.hayward@arm.com>
13515 Jiong Wang <jiong.wang@arm.com>
13516
13517 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13518
76bed0fd
AH
135192019-03-22 Alan Hayward <alan.hayward@arm.com>
13520 Jiong Wang <jiong.wang@arm.com>
13521
13522 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13523 function.
13524 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13525 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13526 (aarch64_gdbarch_init): Add puth registers.
13527 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13528 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13529 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13530
ee4fbcfa
AH
135312019-03-22 Alan Hayward <alan.hayward@arm.com>
13532 Jiong Wang <jiong.wang@arm.com>
13533
13534 * aarch64-linux-nat.c
13535 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13536 * aarch64-linux-tdep.c
13537 (aarch64_linux_core_read_description): Likewise.
13538 (aarch64_linux_get_hwcap): New function.
13539 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13540 (aarch64_linux_get_hwcap): New declaration.
13541
6dc0ebde
AH
135422019-03-22 Alan Hayward <alan.hayward@arm.com>
13543 Jiong Wang <jiong.wang@arm.com>
13544
13545 * aarch64-linux-nat.c
13546 (aarch64_linux_nat_target::read_description): Add pauth param.
13547 * aarch64-linux-tdep.c
13548 (aarch64_linux_core_read_description): Likewise.
13549 * aarch64-tdep.c (struct target_desc): Add in pauth.
13550 (aarch64_read_description): Add pauth param.
13551 (aarch64_gdbarch_init): Likewise.
13552 * aarch64-tdep.h (aarch64_read_description): Likewise.
13553 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13554 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13555 * features/Makefile: Add new files.
13556 * features/aarch64-pauth.c: New file.
13557 * features/aarch64-pauth.xml: New file.
13558
595915c1
TT
135592019-03-20 Tom Tromey <tromey@adacore.com>
13560
13561 * infrun.c (handle_inferior_event): Rename from
13562 handle_inferior_event_1. Create a scoped_value_mark.
13563 (handle_inferior_event): Remove.
13564
4c7d57e7
TT
135652019-03-19 Tom Tromey <tromey@adacore.com>
13566
13567 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13568 * infrun.h (print_stop_event): Add "displays" parameter.
13569 * infrun.c (print_stop_event): Add "displays" parameter.
13570
cb246234
PA
135712019-03-19 Pedro Alves <palves@redhat.com>
13572
13573 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13574 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13575 to -1. Fix TABs vs spaces.
13576 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13577 * tui/tui-out.h (tui_ui_out) Add intro comments.
13578 <m_line, m_start_of_line>: In-class initialize, and add describing
13579 comment.
13580
3a0e45b2
AH
135812019-03-18 Alan Hayward <alan.hayward@arm.com>
13582
13583 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13584 variable names.
13585 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13586
5371b850
PA
135872019-03-18 Pedro Alves <palves@redhat.com>
13588 Eli Zaretskii <eliz@gnu.org>
13589
13590 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13591 m_line and m_start_of_line.
13592
b17c4cd0
EZ
135932019-03-18 Eli Zaretskii <eliz@gnu.org>
13594
13595 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13596 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13597 it returns a newline. This fixes a regression in TU mode, whereby
13598 the next line is output on the same screen line as the user input.
13599
4bd56d18
TT
136002019-03-18 Tom Tromey <tromey@adacore.com>
13601
13602 * minsyms.c (minimal_symbol_reader::install): Remove call to
13603 obstack_blank.
13604
55c10aca
PA
136052019-03-18 Pedro Alves <palves@redhat.com>
13606
13607 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13608 New globals.
13609 (apply_style): New, factored out from ...
13610 (apply_ansi_escape): ... this. Handle reverse video mode.
13611 (tui_set_reverse_mode): New function.
13612 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13613 * tui/tui-winsource.c (tui_show_source_line): Use
13614 tui_set_reverse_mode instead of setting A_STANDOUT.
13615 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13616 New setter methods.
13617
647bb750
HD
136182019-03-18 Hannes Domani <ssbssa@yahoo.de>
13619
13620 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13621 Handle tabs.
13622
bff8c71f
TT
136232019-03-18 Tom Tromey <tromey@adacore.com>
13624
13625 * ada-lang.c (empty_array): Add "high" parameter.
13626 (ada_evaluate_subexp): Update.
13627
58785d98
ST
136282019-03-17 Sergei Trofimovich <siarheit@google.com>
13629
13630 * unittests/string_view-selftests.c: Define
13631 _initialize_string_view_selftests unconditionally.
13632
d4cbef22
ВМ
136332019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13634
13635 PR gdb/24350
13636 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13637
fce4c071
ВМ
136382019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13639
13640 PR gdb/24351
13641 * windows-nat.c (display_selector): Fix format specifiers.
13642
f7f0a123
EZ
136432019-03-17 Eli Zaretskii <eliz@gnu.org>
13644
13645 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13646 tui_refill_source_window instead of tui_refresh_win, to update the
13647 current execution line. This fixes redisplay of the current line
13648 when stepping through the code with "next" or "step".
13649
ab42892f
EZ
136502019-03-16 Eli Zaretskii <eliz@gnu.org>
13651
13652 * source-cache.c (source_cache::get_source_lines): Call
13653 find_source_lines to initialize s->nlines. This fixes vertical
13654 scrolling of TUI source window when the DOWN arrow is pressed.
13655
8d8c087f
PW
136562019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13657
13658 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13659 linux-thread-db.c (_initialize_thread_db): Likewise.
13660
798e1c30
EZ
136612019-03-16 Eli Zaretskii <eliz@gnu.org>
13662
13663 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13664 wclrtoeol in tui_show_source_line". This reverts changes made in
13665 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13666
eefba3da
TT
136672019-03-15 Tom Tromey <tom@tromey.com>
13668
13669 * symtab.h (struct minimal_symbol): Derive from
13670 general_symbol_info.
13671 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13672 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13673 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13674 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13675 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13676 (MSYMBOL_SEARCH_NAME): Update.
13677 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13678 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13679 * minsyms.c (minimal_symbol_reader::record_full): Update.
13680
0de2420c
TT
136812019-03-15 Tom Tromey <tom@tromey.com>
13682
13683 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13684
042d75e4
TT
136852019-03-15 Tom Tromey <tom@tromey.com>
13686
13687 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13688 unique_xmalloc_ptr.
13689 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13690 Update.
13691 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13692 (build_minimal_symbol_hash_tables)
13693 (minimal_symbol_reader::install): Update.
13694
db92718b
TT
136952019-03-15 Tom Tromey <tom@tromey.com>
13696
13697 * symtab.c (create_demangled_names_hash): Update.
13698 (symbol_set_names): Update.
13699 * objfiles.h (struct objfile_per_bfd_storage)
13700 <demangled_names_hash>: Now an htab_up.
13701 * objfiles.c (objfile_per_bfd_storage): Simplify.
13702
d6797f46
TT
137032019-03-15 Tom Tromey <tom@tromey.com>
13704
13705 * objfiles.h (struct objfile_per_bfd_storage): Declare
13706 destructor.
13707 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13708 New.
13709 (get_objfile_bfd_data): Use new. Don't initialize
13710 language_of_main.
13711 (free_objfile_per_bfd_storage): Remove.
13712 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13713
741d7538
TT
137142019-03-15 Tom Tromey <tom@tromey.com>
13715
13716 * symfile.c (reread_symbols): Update.
13717 * objfiles.c (objfile::objfile): Update.
13718 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13719 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13720 comment.
13721 (minimal_symbol_reader::install): Update.
13722 (terminate_minimal_symbol_table): Remove.
13723 * jit.c (jit_object_close_impl): Update.
13724
788c80d1
TT
137252019-03-15 Tom Tromey <tom@tromey.com>
13726
13727 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13728 initializations.
13729
1b7a07cb
TT
137302019-03-15 Tom Tromey <tom@tromey.com>
13731
13732 * objfiles.h (struct objfile_per_bfd_storage)
13733 <demangled_hash_languages>: Now a bitset.
13734 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13735 (lookup_minimal_symbol): Update.
13736
3db066bc
TT
137372019-03-15 Tom Tromey <tom@tromey.com>
13738
13739 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13740 Don't return the symbol.
13741 * coffread.c (record_minimal_symbol): Use record_full.
13742
3fff2c37
EZ
137432019-03-14 Eli Zaretskii <eliz@gnu.org>
13744
13745 The MS-Windows port of ncurses fails to switch to a color pair if
13746 one or both of the colors are the implicit default colors. This
13747 change records the default colors when TUI is initialized, and
13748 then specifies them explicitly when a color pair uses the default
13749 colors. This allows color styling in TUI mode on MS-Windows.
13750
13751 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13752 ncurses_norm_attr.
13753 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13754 colors in ncurses_norm_attr.
13755 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13756 "none", replace it with the default color recorded in
13757 ncurses_norm_attr.
13758
3b336828
TT
137592019-03-14 Tom Tromey <tromey@adacore.com>
13760
13761 * source-cache.h (class source_cache) <get_source_lines>: Return
13762 std::string.
13763 * source-cache.c (source_cache::extract_lines): Handle case where
13764 first_pos==npos. Return std::string.
13765 (source_cache::get_source_lines): Update.
13766
d085f989
TT
137672019-03-14 Tom Tromey <tromey@adacore.com>
13768
13769 * NEWS: Add item for "style sources" commands.
13770 * source-cache.c (source_cache::get_source_lines): Check
13771 source_styling.
13772 * cli/cli-style.c (source_styling): New global.
13773 (_initialize_cli_style): Add "style sources" commands.
13774 (show_style_sources): New function.
13775 * cli/cli-style.h (source_styling): Declare.
13776
6f11e682
TT
137772019-03-14 Pedro Alves <palves@redhat.com>
13778 Tom Tromey <tromey@adacore.com>
13779
13780 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13781 * tui/tui-winsource.c (tui_refill_source_window): New function,
13782 from...
13783 (tui_horizontal_source_scroll): ... here. Move some logic.
13784 * cli/cli-style.c (set_style_enabled): Notify new observable.
13785 * tui/tui-hooks.c (tui_redisplay_source): New function.
13786 (tui_attach_detach_observers): Attach or detach
13787 tui_redisplay_source.
13788 * observable.h (source_styling_changed): New observable.
13789 * observable.c: Define source_styling_changed observable.
13790
a068643d
TT
137912019-03-13 Tom Tromey <tromey@adacore.com>
13792
13793 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13794 (i386_gnu_nat_target::store_registers): Update.
13795 * target-debug.h (target_debug_print_std_string): New macro.
13796 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13797 * windows-tdep.c (display_one_tib): Update.
13798 * tui/tui-stack.c (tui_make_status_line): Update.
13799 * top.c (print_inferior_quit_action): Update.
13800 * thread.c (thr_try_catch_cmd): Update.
13801 (add_thread_with_info): Update.
13802 (thread_target_id_str): Update.
13803 (thr_try_catch_cmd): Update.
13804 (thread_command): Update.
13805 (thread_find_command): Update.
13806 * record-btrace.c (record_btrace_target::info_record)
13807 (record_btrace_resume_thread, record_btrace_target::resume)
13808 (record_btrace_cancel_resume, record_btrace_step_thread)
13809 (record_btrace_target::wait, record_btrace_target::wait)
13810 (record_btrace_target::wait, record_btrace_target::stop): Update.
13811 * progspace.c (print_program_space): Update.
13812 * process-stratum-target.c
13813 (process_stratum_target::thread_address_space): Update.
13814 * linux-fork.c (linux_fork_mourn_inferior)
13815 (detach_checkpoint_command, info_checkpoints_command)
13816 (linux_fork_context): Update.
13817 (linux_fork_detach): Update.
13818 (class scoped_switch_fork_info): Update.
13819 (delete_checkpoint_command): Update.
13820 * infrun.c (follow_fork_inferior): Update.
13821 (follow_fork_inferior): Update.
13822 (proceed_after_vfork_done): Update.
13823 (handle_vfork_child_exec_or_exit): Update.
13824 (follow_exec): Update.
13825 (displaced_step_prepare_throw): Update.
13826 (displaced_step_restore): Update.
13827 (start_step_over): Update.
13828 (resume_1): Update.
13829 (clear_proceed_status_thread): Update.
13830 (proceed): Update.
13831 (print_target_wait_results): Update.
13832 (do_target_wait): Update.
13833 (context_switch): Update.
13834 (stop_all_threads): Update.
13835 (restart_threads): Update.
13836 (finish_step_over): Update.
13837 (handle_signal_stop): Update.
13838 (switch_back_to_stepped_thread): Update.
13839 (keep_going_pass_signal): Update.
13840 (print_exited_reason): Update.
13841 (normal_stop): Update.
13842 * inferior.c (inferior_pid_to_str): Change return type.
13843 (print_selected_inferior): Update.
13844 (add_inferior): Update.
13845 (detach_inferior): Update.
13846 * dummy-frame.c (fprint_dummy_frames): Update.
13847 * dcache.c (dcache_info_1): Update.
13848 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13849 (btrace_fetch, btrace_clear): Update.
13850 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13851 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13852 type.
13853 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13854 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13855 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13856 * gdbarch.c, gdbarch.h: Rebuild.
13857 * gdbarch.sh (core_pid_to_str): Change return type.
13858 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13859 return type.
13860 (windows_nat_target::pid_to_str): Change return type.
13861 (windows_delete_thread): Update.
13862 (windows_nat_target::attach): Update.
13863 (windows_nat_target::files_info): Update.
13864 * target-delegates.c: Rebuild.
13865 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13866 return type.
13867 (sol_thread_target::pid_to_str): Change return type.
13868 * remote.c (class remote_target) <pid_to_str>: Change return
13869 type.
13870 (remote_target::pid_to_str): Change return type.
13871 (extended_remote_target::attach, remote_target::remote_stop_ns)
13872 (remote_target::remote_notif_remove_queued_reply)
13873 (remote_target::push_stop_reply, remote_target::disable_btrace):
13874 Update.
13875 (extended_remote_target::attach): Update.
13876 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13877 type.
13878 (gdbsim_target::pid_to_str): Change return type.
13879 * ravenscar-thread.c (struct ravenscar_thread_target)
13880 <pid_to_str>: Change return type.
13881 (ravenscar_thread_target::pid_to_str): Change return type.
13882 * procfs.c (class procfs_target) <pid_to_str>: Change return
13883 type.
13884 (procfs_target::pid_to_str): Change return type.
13885 (procfs_target::attach): Update.
13886 (procfs_target::detach): Update.
13887 (procfs_target::fetch_registers): Update.
13888 (procfs_target::store_registers): Update.
13889 (procfs_target::wait): Update.
13890 (procfs_target::files_info): Update.
13891 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13892 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13893 return type.
13894 (nto_procfs_target::pid_to_str): Change return type.
13895 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13896 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13897 return type.
13898 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13899 (exit_lwp): Update.
13900 (attach_proc_task_lwp_callback, get_detach_signal)
13901 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13902 (linux_nat_target::resume, wait_lwp, stop_callback)
13903 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13904 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13905 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13906 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13907 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13908 type.
13909 (inf_ptrace_target::attach): Update.
13910 (inf_ptrace_target::files_info): Update.
13911 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13912 type.
13913 (go32_nat_target::pid_to_str): Change return type.
13914 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13915 (gnu_nat_target::wait): Update.
13916 (gnu_nat_target::wait): Update.
13917 (gnu_nat_target::resume): Update.
13918 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13919 (fbsd_nat_target::wait): Update.
13920 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13921 type.
13922 (darwin_nat_target::attach): Update.
13923 * corelow.c (class core_target) <pid_to_str>: Change return type.
13924 (core_target::pid_to_str): Change return type.
13925 * target.c (normal_pid_to_str): Change return type.
13926 (default_pid_to_str): Likewise.
13927 (target_pid_to_str): Change return type.
13928 (target_translate_tls_address): Update.
13929 (target_announce_detach): Update.
13930 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13931 return type.
13932 (bsd_uthread_target::pid_to_str): Change return type.
13933 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13934 type.
13935 (bsd_kvm_target::pid_to_str): Change return type.
13936 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13937 return type.
13938 (aix_thread_target::pid_to_str): Change return type.
13939 * target.h (struct target_ops) <pid_to_str>: Change return type.
13940 (target_pid_to_str, normal_pid_to_str): Likewise.
13941 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13942 type.
13943 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13944 type.
13945 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13946 return type.
13947 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13948 type.
13949 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13950 type.
13951 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13952 return type.
13953
b4be1b06
SM
139542019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13955
13956 * NEWS: Mention that the new default MI version is 3. Mention
13957 changes to the output of commands and events that deal with
13958 multi-location breakpoints.
13959 * breakpoint.c: Include "mi/mi-out.h".
13960 (print_one_breakpoint): Change output syntax if using MI version
13961 >= 3.
13962 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13963 New.
13964 (mi_multi_location_breakpoint_output_fixed): New.
13965 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13966 (mi_cmd_fix_multi_location_breakpoint_output): New.
13967 (mi_multi_location_breakpoint_output_fixed): New.
13968 * mi/mi-cmds.c (mi_cmds): Register command
13969 -fix-multi-location-breakpoint-output.
13970 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13971 interpreter "mi".
13972
8e5e5494
SM
139732019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13974
13975 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13976 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13977 instantiate mi_ui_out based on interpreter name.
13978 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13979 * mi/mi-main.c (mi_load_progress): Likewise.
13980
197df35e
JB
139812019-03-12 John Baldwin <jhb@FreeBSD.org>
13982
13983 * NEWS: Combine separate "New targets" sections for 8.3.
13984
8399425f
JB
139852019-03-12 John Baldwin <jhb@FreeBSD.org>
13986
13987 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13988 (ppcfbsd_init_abi): Install gdbarch
13989 "fetch_tls_load_module_address" and "get_thread_local_address"
13990 methods.
13991
b0f87ed0
JB
139922019-03-12 John Baldwin <jhb@FreeBSD.org>
13993
13994 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13995 (riscv_fbsd_init_abi): Install gdbarch
13996 "fetch_tls_load_module_address" and "get_thread_local_address"
13997 methods.
13998
ce25aa57
JB
139992019-03-12 John Baldwin <jhb@FreeBSD.org>
14000
14001 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
14002 (i386fbsd_init_abi): Install gdbarch
14003 "fetch_tls_load_module_address" and "get_thread_local_address"
14004 methods.
14005
f5424cfa
JB
140062019-03-12 John Baldwin <jhb@FreeBSD.org>
14007
14008 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
14009 (amd64fbsd_init_abi): Install gdbarch
14010 "fetch_tls_load_module_address" and "get_thread_local_address"
14011 methods.
14012
945f3901
JB
140132019-03-12 John Baldwin <jhb@FreeBSD.org>
14014
14015 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14016 (struct fbsd_pspace_data): New type.
14017 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14018 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14019 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14020 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14021 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14022
ef0bd204
JB
140232019-03-12 John Baldwin <jhb@FreeBSD.org>
14024
14025 * gdbtypes.c (lookup_struct_elt): New function.
14026 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14027 * gdbtypes.h (struct struct_elt): New type.
14028 (lookup_struct_elt): New prototype.
14029
36c53a02
JB
140302019-03-12 John Baldwin <jhb@FreeBSD.org>
14031
14032 * gdbtypes.c (lookup_struct_elt_type): Update comment and
14033 remove disabled code block.
14034
6e056c81
JB
140352019-03-12 John Baldwin <jhb@FreeBSD.org>
14036
14037 * gdbarch.sh (get_thread_local_address): New method.
14038 * gdbarch.h, gdbarch.c: Regenerate.
14039 * target.c (target_translate_tls_address): Use
14040 gdbarch_get_thread_local_address if present instead of
14041 target::get_thread_local_address.
14042
cd250a18
JB
140432019-03-12 John Baldwin <jhb@FreeBSD.org>
14044
14045 * target.h (target::get_thread_local_address): Update comment.
14046
df22c1e5
JB
140472019-03-12 John Baldwin <jhb@FreeBSD.org>
14048
14049 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14050 objfile->separate_debug_objfile_backlink if not NULL.
14051
dd6876c9
JB
140522019-03-12 John Baldwin <jhb@FreeBSD.org>
14053
14054 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14055 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14056 (amd64bsd_store_inferior_registers): Likewise.
14057 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14058 Enable segment base registers.
14059 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14060 PT_GETFSBASE and PT_GETGSBASE.
14061 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14062 PT_SETGSBASE.
14063 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14064 segment base registers.
14065 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14066
1163a4b7
JB
140672019-03-12 John Baldwin <jhb@FreeBSD.org>
14068
14069 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14070 Update calls to i386_target_description to add 'segments'
14071 parameter.
14072 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
14073 add segment base registers.
14074 * arch/i386.c (i386_create_target_description): Add 'segments'
14075 parameter to enable segment base registers.
14076 * arch/i386.h (i386_create_target_description): Likewise.
14077 * features/i386/32bit-segments.xml: New file.
14078 * features/i386/32bit-segments.c: Generate.
14079 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14080 call to i386_target_description to add 'segments' parameter.
14081 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14082 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14083 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14084 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14085 if feature is present.
14086 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14087 Add 'segments' parameter to call to i386_target_description.
14088 (i386_target_description): Add 'segments' parameter to enable
14089 segment base registers.
14090 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14091 to call to i386_target_description.
14092 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14093 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14094 Define I386_NUM_REGS.
14095 (i386_target_description): Add 'segments' parameter to enable
14096 segment base registers.
14097
3a350822
EZ
140982019-03-12 Eli Zaretskii <eliz@gnu.org>
14099
14100 PR/24325
14101 * source-cache.c: #undef open and close, to avoid unresolved
14102 externals during linking.
14103
ffdd69cf
TT
141042019-03-12 Tom Tromey <tromey@adacore.com>
14105
14106 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14107 const. Add initializers.
14108 (_initialize_remote): Don't initialize ptid globals.
14109
ec148c57
PA
141102019-03-12 Pedro Alves <palves@redhat.com>
14111
14112 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14113
32764270
PA
141142019-03-12 Pedro Alves <palves@redhat.com>
14115
14116 * cp-name-parser.y (main): Remove unused 'len' variable.
14117
17547186
TT
141182019-03-12 Tom Tromey <tromey@adacore.com>
14119
14120 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14121 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14122
d3a70e03
TT
141232019-03-12 Tom Tromey <tromey@adacore.com>
14124
14125 * linux-nat.c (iterate_over_lwps): Update.
14126 (stop_callback): Remove parameter.
14127 (stop_wait_callback, detach_callback, resume_set_callback)
14128 (select_singlestep_lwp_callback, set_ignore_sigint)
14129 (status_callback, resumed_callback, resume_clear_callback)
14130 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14131 data parameter.
14132 (linux_nat_target::detach, linux_nat_target::resume)
14133 (linux_stop_and_wait_all_lwps, select_event_lwp)
14134 (linux_nat_filter_event, linux_nat_wait_1)
14135 (linux_nat_target::kill, linux_nat_target::stop)
14136 (linux_nat_target::stop): Update.
14137 (linux_nat_resume_callback): Change type.
14138 (resume_stopped_resumed_lwps, count_events_callback)
14139 (select_event_lwp_callback): Likewise.
14140 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14141 * arm-linux-nat.c (struct update_registers_data): Remove.
14142 (update_registers_callback): Change type.
14143 (arm_linux_insert_hw_breakpoint1): Update.
14144 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14145 parameter.
14146 (x86_linux_dr_set_addr): Update.
14147 (x86_linux_dr_set_control): Update.
14148 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14149 (iterate_over_lwps): Use gdb::function_view.
14150 * nat/aarch64-linux-hw-point.c (struct
14151 aarch64_dr_update_callback_param): Remove.
14152 (debug_reg_change_callback): Change type.
14153 (aarch64_notify_debug_reg_change): Update.
14154 * s390-linux-nat.c (s390_refresh_per_info): Update.
14155
82cb27ff
TT
141562019-03-11 Tom Tromey <tromey@adacore.com>
14157
14158 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14159 redundant assignment to "this_cu".
14160
568c0683
SM
141612019-03-08 Simon Marchi <simon.marchi@efficios.com>
14162
14163 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14164
f09ce22d
SM
141652019-03-08 Simon Marchi <simon.marchi@efficios.com>
14166
14167 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14168 from...
14169 (rank_one_type): ... this.
14170
595f96a9
SM
141712019-03-08 Simon Marchi <simon.marchi@efficios.com>
14172
14173 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14174 from...
14175 (rank_one_type): ... this.
14176
2598a94b
SM
141772019-03-08 Simon Marchi <simon.marchi@efficios.com>
14178
14179 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14180 from...
14181 (rank_one_type): ... this.
14182
7f17b20d
SM
141832019-03-08 Simon Marchi <simon.marchi@efficios.com>
14184
14185 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14186 from...
14187 (rank_one_type): ... this.
14188
2c509035
SM
141892019-03-08 Simon Marchi <simon.marchi@efficios.com>
14190
14191 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14192 from...
14193 (rank_one_type): ... this.
14194
0dd322dc
SM
141952019-03-08 Simon Marchi <simon.marchi@efficios.com>
14196
14197 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14198 from...
14199 (rank_one_type): ... this.
14200
41ea4728
SM
142012019-03-08 Simon Marchi <simon.marchi@efficios.com>
14202
14203 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14204 from...
14205 (rank_one_type): ... this.
14206
793cd1d2
SM
142072019-03-08 Simon Marchi <simon.marchi@efficios.com>
14208
14209 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14210 from...
14211 (rank_one_type): ... this.
14212
34910087
SM
142132019-03-08 Simon Marchi <simon.marchi@efficios.com>
14214
14215 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14216 from...
14217 (rank_one_type): ... this.
14218
f1f832d6
SM
142192019-03-08 Simon Marchi <simon.marchi@efficios.com>
14220
14221 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14222 from...
14223 (rank_one_type): ... this.
14224
b9f4512f
SM
142252019-03-08 Simon Marchi <simon.marchi@efficios.com>
14226
14227 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14228 from...
14229 (rank_one_type): ... this.
14230
9293fc63
SM
142312019-03-08 Simon Marchi <simon.marchi@efficios.com>
14232
14233 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14234 from...
14235 (rank_one_type): ... this.
14236
e3abbe7e
PW
142372019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14238
14239 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14240 inferior-events' shows the example events.
14241
e4adb939
EZ
142422019-03-08 Eli Zaretskii <eliz@gnu.org>
14243
14244 Support styling on native MS-Windows console
14245
14246 PR/24315
14247 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14248 on MS-Windows if $TERM is not defined.
14249
14250 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14251
14252 * posix-hdep.c (gdb_console_fputs):
14253 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14254 functions.
14255 * ui-file.h (gdb_console_fputs): Add prototype.
14256
14257 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14258 back to fputs only if the former returns zero.
14259
25629dfd
TT
142602019-03-07 Tom Tromey <tom@tromey.com>
14261
14262 * symmisc.c (print_symbol_bcache_statistics): Update.
14263 (print_objfile_statistics): Update.
14264 * symfile.c (allocate_symtab): Update.
14265 * stabsread.c: Don't include bcache.h.
14266 * psymtab.h (struct psymbol_bcache): Don't declare.
14267 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14268 (psymbol_bcache_init, psymbol_bcache_free)
14269 (psymbol_bcache_get_bcache): Don't declare.
14270 * psymtab.c (struct psymbol_bcache): Remove.
14271 (psymtab_storage::psymtab_storage): Update.
14272 (psymtab_storage::~psymtab_storage): Update.
14273 (psymbol_bcache_init, psymbol_bcache_free)
14274 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14275 (add_psymbol_to_bcache): Update.
14276 (allocate_psymtab): Update.
14277 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14278 macro_cache>: No longer pointers.
14279 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14280 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14281 * macrotab.c (macro_bcache): Update.
14282 * macroexp.c: Don't include bcache.h.
14283 * gdbtypes.c (check_types_worklist): Update.
14284 (types_deeply_equal): Remove TRY/CATCH. Update.
14285 * elfread.c (elf_symtab_read): Update.
14286 * dwarf2read.c: Don't include bcache.h.
14287 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14288 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14289 (print_bcache_statistics, bcache_memory_used): Don't declare.
14290 (struct bcache): Move from bcache.c. Add constructor, destructor,
14291 methods. Rename all data members.
14292 * bcache.c (struct bcache): Move to bcache.h.
14293 (bcache::expand_hash_table): Rename from expand_hash_table.
14294 (bcache): Remove.
14295 (bcache::insert): Rename from bcache_full.
14296 (bcache::compare): Rename from bcache_compare.
14297 (bcache_xmalloc): Remove.
14298 (bcache::~bcache): Rename from bcache_xfree.
14299 (bcache::print_statistics): Rename from print_bcache_statistics.
14300 (bcache::memory_used): Rename from bcache_memory_used.
14301
fe726667
PA
143022019-03-07 Pedro Alves <palves@redhat.com>
14303
14304 * infrun.c (normal_stop): Also check for
14305 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14306
7584bb30
AB
143072019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14308
14309 * f-lang.c (value_from_host_double): Moved to...
14310 * value.c (value_from_host_double): ...here.
14311 * value.h (value_from_host_double): Declare.
14312 * guile/scm-math.c (vlscm_convert_typed_number): Use
14313 value_from_host_double.
14314 (vlscm_convert_number): Likewise.
14315 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14316 * python/py-value.c (convert_value_from_python): Likewise.
14317
a7b1986e
TT
143182019-03-06 Tom Tromey <tom@tromey.com>
14319
14320 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14321
0ccf4211
TT
143222019-03-06 Tom Tromey <tom@tromey.com>
14323
14324 * utils.h (free_current_contents): Don't declare.
14325 * utils.c (free_current_contents): Remove.
14326
fe7b42e5
TT
143272019-03-06 Tom Tromey <tom@tromey.com>
14328
14329 * top.c (quit_force): Update.
14330 * main.c (captured_command_loop): Update.
14331 * common/new-op.c (operator new): Update.
14332 * common/common-exceptions.c (struct catcher)
14333 <save_cleanup_chain>: Remove member.
14334 (exceptions_state_mc_init): Update.
14335 (exception_try_scope_entry): Return nullptr.
14336 (exception_try_scope_exit, exception_rethrow)
14337 (throw_exception_sjlj, throw_exception_cxx): Update.
14338 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14339 (all_cleanups, do_cleanups, discard_cleanups)
14340 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14341 (restore_cleanups, restore_final_cleanups): Don't declare.
14342 (do_final_cleanups): Remove parameter.
14343 * common/cleanups.c (cleanup_chain, make_cleanup)
14344 (make_cleanup_dtor, all_cleanups, do_cleanups)
14345 (discard_my_cleanups, discard_cleanups)
14346 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14347 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14348 (null_cleanup): Remove.
14349 (do_final_cleanups): Remove parameter.
14350
c6321f19
TT
143512019-03-06 Tom Tromey <tom@tromey.com>
14352
14353 * remote.c (remote_target::remote_parse_stop_reply): Use
14354 unique_xmalloc_ptr.
14355
61b30099
TT
143562019-03-06 Tom Tromey <tom@tromey.com>
14357
14358 * stabsread.c (struct stabs_field_info): Rename from field_info.
14359 <list, fnlist>: Add initializers.
14360 <obstack>: New member.
14361 (read_member_functions, read_struct_fields, read_baseclasses):
14362 Allocate on obstack. Don't use cleanups.
14363 (read_one_struct_field, read_member_functions, read_struct_fields)
14364 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14365 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14366 (read_struct_type): Update.
14367
6cceac94
TT
143682019-03-06 Tom Tromey <tom@tromey.com>
14369
14370 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14371 * common/filestuff.h (make_cleanup_close): Don't declare.
14372 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14373 Remove.
14374
72412762
TT
143752019-03-06 Tom Tromey <tom@tromey.com>
14376
14377 * solib-aix.c: Use make_scope_exit.
14378
2b6ff1c0
TT
143792019-03-06 Tom Tromey <tom@tromey.com>
14380
14381 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14382 Use make_scope_exit.
14383
d01c5877
TT
143842019-03-06 Tom Tromey <tom@tromey.com>
14385
14386 * solib-svr4.c (disable_probes_interface): Remove parameter.
14387 (svr4_handle_solib_event): Use make_scope_exit.
14388
32603266
TT
143892019-03-06 Tom Tromey <tom@tromey.com>
14390
14391 * remote.c (struct stop_reply_deleter): Remove.
14392 (stop_reply_up): Update.
14393 (struct stop_reply): Derive from notif_event. Don't typedef.
14394 <regcache>: Now a std::vector.
14395 (stop_reply_xfree): Remove.
14396 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14397 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14398 (remote_target::discard_pending_stop_replies): Use delete.
14399 (remote_target::remote_parse_stop_reply): Update.
14400 (remote_target::process_stop_reply): Update.
14401 * remote-notif.h (struct notif_event): Add virtual destructor.
14402 Remove "dtr" member.
14403 (struct notif_client) <alloc_event>: Return a unique_ptr.
14404 (notif_event_xfree): Don't declare.
14405 (notif_event_up): New typedef.
14406 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14407 (notif_event_xfree, do_notif_event_xfree): Remove.
14408 (remote_notif_state_xfree): Update.
14409
9799571e
TT
144102019-03-06 Tom Tromey <tom@tromey.com>
14411
14412 * infrun.c (displaced_step_clear_cleanup): Now a
14413 forward_scope_exit type.
14414 (displaced_step_prepare_throw): Update.
14415 (displaced_step_fixup): Update.
14416
09e3c4ca
TT
144172019-03-06 Tom Tromey <tom@tromey.com>
14418
14419 * inferior.h (class inferior): Update comment.
14420 * gdbthread.h (class thread_info): Update comment.
14421
e2a03548
TT
144222019-03-06 Joel Brobecker <brobecker@adacore.com>
14423 Tom Tromey <tom@tromey.com>
14424
14425 * stabsread.h (struct stab_section_list): Remove.
14426 (coffstab_build_psymtabs): Update.
14427 * dbxread.c (symbuf_sections): Now a std::vector.
14428 (sect_idx): New global.
14429 (fill_symbuf): Update.
14430 (coffstab_build_psymtabs): Change type of stabsects parameter.
14431 Update.
14432 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14433 std::vector.
14434 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14435 (coff_locate_sections): Update.
14436 (coff_symfile_read): Remove cleanups. Update.
14437 (init_stringtab): Add storage parameter.
14438 (free_stringtab, free_stringtab_cleanup): Remove.
14439 (init_lineno): Add storage parameter.
14440 (free_linetab, free_linetab_cleanup): Remove.
14441
b7e60d85
PA
144422019-03-06 Pedro Alves <palves@redhat.com>
14443
14444 * linux-fork.c (fork_info::clobber_regs): Delete.
14445 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14446 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14447 comment. Adjust.
14448 (scoped_switch_fork_info::scoped_switch_fork_info)
14449 (checkpoint_command, linux_fork_context): Adjust
14450 fork_save_infrun_state calls.
14451
e52c971f
PA
144522019-03-06 Pedro Alves <palves@redhat.com>
14453
14454 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14455 (inf_has_multiple_threads): Return 'bool' and rewrite using
14456 inferior_info::threads().
14457
06974e6c
PA
144582019-03-06 Pedro Alves <palves@redhat.com>
14459
14460 * linux-fork.c: Include <list>.
14461 (fork_list): Now a std::list instance.
14462 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14463 (forks_exist_p, find_last_fork): Adjust.
14464 (new_fork): Delete.
14465 (one_fork_p): New.
14466 (add_fork): Adjust.
14467 (free_fork): Delete, folded into fork_info::~fork_info().
14468 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14469 Adjust.
14470 (init_fork_list): Delete.
14471 (linux_fork_killall, linux_fork_mourn_inferior)
14472 (linux_fork_detach, info_checkpoints_command): Adjust.
14473 (_initialize_linux_fork): No longer call init_fork_list.
14474
72f31aea
PA
144752019-03-06 Pedro Alves <palves@redhat.com>
14476
14477 * linux-fork.c (new_fork): New, split out of ...
14478 (add_fork): ... this. Return void. Move "first fork" special
14479 case from here, to ...
14480 (checkpoint_command): ... here.
14481 * linux-linux.h (add_fork): Return void.
14482
efbecbc1
AB
144832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14484
14485 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14486
0841c79a
AB
144872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14488 Chris January <chris.january@arm.com>
14489 David Lecomber <david.lecomber@arm.com>
14490
14491 * f-exp.y: New token, UNOP_INTRINSIC.
14492 (exp): New pattern using UNOP_INTRINSIC token.
14493 (f77_keywords): Add 'abs' keyword.
14494 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14495 (value_from_host_double): New function.
14496 (evaluate_subexp_f): Support UNOP_ABS.
14497
4a270568
AB
144982019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14499
14500 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14501 types.
14502
067630bd
AB
145032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14504
14505 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14506 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14507 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14508
3be47f7a
AB
145092019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14510
14511 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14512
4d00f5d8
AB
145132019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14514 Chris January <chris.january@arm.com>
14515
14516 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14517 * f-exp.y: Define 'KIND' token.
14518 (exp): New pattern for KIND expressions.
14519 (ptype): Handle types with a kind extension.
14520 (direct_abs_decl): Extend to spot kind extensions.
14521 (f77_keywords): Add 'kind' to the list.
14522 (push_kind_type): New function.
14523 (convert_to_kind_type): New function.
14524 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14525 * parse.c (operator_length_standard): Likewise.
14526 * parser-defs.h (enum type_pieces): Add tp_kind.
14527 * std-operator.def: Add UNOP_KIND.
14528
e454224f
AB
145292019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14530
14531 * f-exp.y (f_parse): Set yydebug.
14532
9dad4a58
AB
145332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14534
14535 * f-lang.c (evaluate_subexp_f): New function.
14536 (exp_descriptor_f): New global.
14537 (f_language_defn): Use exp_descriptor_f instead of
14538 exp_descriptor_standard.
14539
c8f91604
AB
145402019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14541
14542 * f-exp.y (struct token): Add comments.
14543 (dot_ops): Remove uppercase versions and the end marker.
14544 (f77_keywords): Likewise.
14545 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14546 entries in the dot_ops array are case insensitive, and use
14547 strncasecmp to compare strings. Also some whitespace cleanup in
14548 this area. Similar for the f77_keywords array, except entries in
14549 this list might be case sensitive.
14550
dd9f2c76
AB
145512019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14552
14553 * f-exp.y (struct f77_boolean_val): Add comments.
14554 (boolean_values): Remove uppercase versions, and end marker.
14555 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14556 and use strncasecmp to achieve case insensitivity. Additionally,
14557 perform whitespace cleanup around this code.
14558
67a3048c
TT
145592019-03-06 Tom Tromey <tromey@adacore.com>
14560
14561 * remote-sim.c (gdbsim_target_open): Use result of
14562 gdb_argv::release.
14563
aa3cfbda
RB
145642019-03-06 Richard Bunt <richard.bunt@arm.com>
14565 Dirk Schubert <dirk.schubert@arm.com>
14566 Chris January <chris.january@arm.com>
14567
14568 * eval.c (evaluate_subexp_standard): Call Fortran argument
14569 wrapping logic.
14570 * f-lang.c (struct value): A value which can be passed into a
14571 Fortran function call.
14572 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14573 where appropriate.
14574 (struct type): Value ready for a Fortran function call.
14575 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14576 is needed.
14577 * f-lang.h (fortran_argument_convert): Declaration.
14578 (fortran_preserve_arg_pointer): Declaration.
14579 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14580
ea38e5df
TT
145812019-03-05 Tom Tromey <tromey@adacore.com>
14582
14583 * python/py-prettyprint.c (print_string_repr): Remove #if.
14584 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14585
06b5b831
TT
145862019-03-05 Tom Tromey <tromey@adacore.com>
14587
14588 * target.c (the_dummy_target): Move later. Change type to
14589 "dummy_target".
14590 (initialize_targets): Don't initialize the_dummy_target.
14591
edbd9e45
TT
145922019-03-05 Tom Tromey <tromey@adacore.com>
14593
14594 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14595 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14596
c119e040
TT
145972019-03-05 Tom Tromey <tromey@adacore.com>
14598
14599 * windows-nat.c (windows_nat_target::attach)
14600 (windows_nat_target::detach): Don't call gdb_flush.
14601 * valprint.c (generic_val_print, val_print, val_print_string):
14602 Don't call gdb_flush.
14603 * utils.c (defaulted_query): Don't call gdb_flush.
14604 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14605 * target.c (target_announce_detach): Don't call gdb_flush.
14606 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14607 * remote.c (extended_remote_target::attach): Don't call
14608 gdb_flush.
14609 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14610 * printcmd.c (do_examine): Don't call gdb_flush.
14611 (info_display_command): Don't call gdb_flush.
14612 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14613 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14614 * memattr.c (info_mem_command): Don't call gdb_flush.
14615 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14616 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14617 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14618 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14619 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14620 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14621 (gnu_nat_target::detach): Don't call gdb_flush.
14622 * f-valprint.c (f_val_print): Don't call gdb_flush.
14623 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14624 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14625 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14626 gdb_flush.
14627 * c-valprint.c (c_val_print): Don't call gdb_flush.
14628 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14629
895dafa6
TT
146302019-03-05 Tom Tromey <tromey@adacore.com>
14631
14632 * varobj.c (update_dynamic_varobj_children): Update.
14633 (install_default_visualizer): Use reset, not release.
14634 * value.c (set_internalvar): Update.
14635 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14636 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14637 ATTRIBUTE_UNUSED_RESULT.
14638
88a774b9
TT
146392019-03-05 Tom Tromey <tromey@adacore.com>
14640
14641 * remote.c (class scoped_remote_fd) <release>: Add
14642 ATTRIBUTE_UNUSED_RESULT.
14643
4e4a8b93
TT
146442019-03-05 Tom Tromey <tromey@adacore.com>
14645
14646 * macroexp.c (struct macro_buffer) <release>: Add
14647 ATTRIBUTE_UNUSED_RESULT.
14648
083eef1f
TT
146492019-03-05 Tom Tromey <tromey@adacore.com>
14650
14651 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14652 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14653 ATTRIBUTE_UNUSED_RESULT.
14654
3cabd438
TT
146552019-03-05 Tom Tromey <tromey@adacore.com>
14656
14657 * common/scoped_fd.h (class scoped_fd) <release>: Add
14658 ATTRIBUTE_UNUSED_RESULT.
14659
41e3300a
TT
146602019-03-05 Tom Tromey <tromey@adacore.com>
14661
14662 * parser-defs.h (struct parser_state) <release>: Add
14663 ATTRIBUTE_UNUSED_RESULT.
14664
18cb7c9f
TT
146652019-03-05 Tom Tromey <tromey@adacore.com>
14666
14667 * utils.h (class gdb_argv) <release>: Add
14668 ATTRIBUTE_UNUSED_RESULT.
14669 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14670
41fa577f
EZ
146712019-03-02 Eli Zaretskii <eliz@gnu.org>
14672
a6a4b2c6
EZ
14673 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14674 for-loop range, to avoid compiler warnings.
14675
14676 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14677 avoid compiler warnings about unused variables.
14678
742a7df5
EZ
14679 * NEWS: Mention end of support for native debugging on MS-Windows
14680 before XP.
14681
41fa577f
EZ
14682 PR gdb/24292
14683 * common/netstuff.c:
14684 * gdbserver/gdbreplay.c
14685 * gdbserver/remote-utils.c:
14686 * ser-tcp.c:
14687 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14688 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14689 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14690 'getaddrinfo' and 'freeaddrinfo' were not available before
14691 Windows XP, and mingw.org's MinGW headers by default define
14692 _WIN32_WINNT to 0x500.
14693
827f438f
GB
146942019-03-01 Gary Benson <gbenson@redhat.com>
14695
14696 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14697
92137da0
RO
146982019-02-28 Brian Vandenberg <phantall@gmail.com>
14699 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14700
14701 PR gdb/8527
14702 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14703 set_sigint_trap, clear_sigint_trap.
14704
799efbe8
PW
147052019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14706
14707 * target.c (target_detach): Clear the regcache and the
14708 frame cache.
14709
8ed25214
PA
147102019-02-27 Pedro Alves <palves@redhat.com>
14711
14712 * utils.c (set_screen_size): When we cap the height/width sizes,
14713 tweak the corresponding command variable to show "unlimited":
14714
23031e31
SJ
147152019-02-27 Saagar Jha <saagar@saagarjha.com>
14716 Pedro Alves <palves@redhat.com>
14717
14718 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14719 before calling rl_set_screen_size.
14720
6c28e44a
TT
147212019-02-27 Tom Tromey <tromey@adacore.com>
14722
14723 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14724 define.
14725 * python/py-value.c: Remove Python 2.4 workaround.
14726 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14727 workaround.
14728 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14729 Python 2.4 workaround.
14730 * python/python-internal.h: Remove Python 2.4 comment.
14731 (Py_ssize_t): Don't define.
14732 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14733 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14734 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14735 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14736 * python/python.c (do_start_initialization): Remove Python 2.4
14737 workaround.
14738 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14739 (print_children): Remove Python 2.4 workaround.
14740 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14741 workaround.
14742 (CHARBUFFERPROC_NAME): Remove.
14743 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14744 Python 2.4 workaround.
14745
2c3fc25d 147462019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14747
2c3fc25d
KB
14748 * NEWS: Note minimum Python version.
14749
6ca62222
KB
147502019-02-27 Kevin Buettner <kevinb@redhat.com>
14751
14752 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14753 code from these functions. Remove corresponding ifdefs. Use
14754 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14755 Remove gotos and target of gotos.
14756 (infpy_search_memory): Likewise.
14757
f4bc7d2c
AB
147582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14759
14760 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14761 (hppa_gdbarch_init): Don't register deleted functions with
14762 gdbarch.
14763
9734a586
AB
147642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14765
14766 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14767 (h8300_unwind_sp): Delete.
14768 (h8300_dummy_id): Delete.
14769 (h8300_gdbarch_init): Don't register deleted functions with
14770 gdbarch.
14771
68b867f3
AB
147722019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14773
14774 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14775 (ft32_unwind_pc): Delete.
14776 (ft32_unwind_sp): Delete.
14777 (ft32_gdbarch_init): Don't register deleted functions with
14778 gdbarch.
14779
2fbe7ad0
AB
147802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14781
14782 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14783 (frv_unwind_pc): Delete.
14784 (frv_unwind_sp): Delete.
14785 (frv_gdbarch_init): Don't register deleted functions with
14786 gdbarch.
14787
76055cbe
AB
147882019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14789
14790 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14791 (riscv_unwind_pc): Delete.
14792 (riscv_unwind_sp): Delete.
14793 (riscv_gdbarch_init): Don't register deleted functions with
14794 gdbarch.
14795
4133e5a1
AB
147962019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14797
14798 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14799 (csky_unwind_pc): Delete.
14800 (csky_unwind_sp): Delete.
14801 (csky_gdbarch_init): Don't register deleted functions with
14802 gdbarch.
14803
8010f576
AB
148042019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14805
14806 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14807 (cris_unwind_pc): Delete.
14808 (cris_unwind_sp): Delete.
14809 (cris_gdbarch_init): Don't register deleted functions with
14810 gdbarch.
14811
b56bf084
AB
148122019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14813
14814 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14815 (bfin_unwind_pc): Delete.
14816 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14817
a19a650f
AB
148182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14819
14820 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14821 (arm_unwind_pc): Delete.
14822 (arm_unwind_sp): Delete.
14823 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14824
f8278c3c
AB
148252019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14826
14827 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14828 (arc_unwind_pc): Delete.
14829 (arc_unwind_sp): Delete.
14830 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14831
480e46cf
AB
148322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14833
14834 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14835 (alpha_unwind_pc): Delete.
14836 (alpha_gdbarch_init): Don't register deleted functions with
14837 gdbarch.
14838
7a995095
AB
148392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14840
14841 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14842 (aarch64_unwind_pc): Delete.
14843 (aarch64_unwind_sp): Delete.
14844 (aarch64_gdbarch_init): Don't register deleted functions with
14845 gdbarch.
14846
bf9a735e
AB
148472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14848
14849 * gdbtypes.c (type_align): Don't consider static members when
14850 computing structure alignment.
14851
5561fc30
AB
148522019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14853
14854 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14855 return 0 for other types.
14856 * arch-utils.c (default_type_align): Always return 0.
14857 * gdbarch.h: Regenerate.
14858 * gdbarch.sh (type_align): Extend comment.
14859 * gdbtypes.c (type_align): Add additional comments, always call
14860 gdbarch_type_align before applying the default rules.
14861 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14862 generic code will then apply a suitable default.
14863 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14864 types, return 0 for other types.
14865
9335e75a
JB
148662019-02-27 Joel Brobecker <brobecker@adacore.com>
14867
14868 * NEWS: Create a new section for the next release branch.
14869 Rename the section of the current branch, now that it has
14870 been cut.
14871
3d34d8de
JB
148722019-02-27 Joel Brobecker <brobecker@adacore.com>
14873
14874 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14875 * version.in: Bump version to 8.3.50.DATE-git.
14876
143420fb
SM
148772019-02-26 Simon Marchi <simon.marchi@efficios.com>
14878
14879 * aix-thread.c (ptid_cmp): Remove unused variable.
14880 (get_signaled_thread): Likewise.
14881 (store_regs_user_thread): Likewise.
14882 (store_regs_kernel_thread): Likewise.
14883 (fetch_regs_kernel_thread): Remove shadowed variable.
14884
172fb711
AB
148852019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14886
14887 * features/riscv/32bit-cpu.xml: Add register numbers.
14888 * features/riscv/32bit-fpu.c: Regenerate.
14889 * features/riscv/32bit-fpu.xml: Add register numbers.
14890 * features/riscv/64bit-cpu.xml: Add register numbers.
14891 * features/riscv/64bit-fpu.c: Regenerate.
14892 * features/riscv/64bit-fpu.xml: Add register numbers.
14893
26c89782
KB
148942019-02-26 Kevin Buettner <kevinb@redhat.com>
14895
af54ade9 14896 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14897 * python/py-value.c (convert_buffer_and_type_to_value): New
14898 function.
14899 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14900 Add support for handling an optional second argument. Call
14901 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14902 * python/python-internal.h (Py_buffer_deleter): New struct.
14903 (Py_buffer_up): New typedef.
14904
0f58c9e8
JB
149052019-02-25 John Baldwin <jhb@FreeBSD.org>
14906
14907 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14908 instead of releasing ownership.
14909
0a0f4c01
JR
149102019-02-25 Jordan Rupprecht <rupprecht@google.com>
14911
14912 * dwarf2read.c (open_and_init_dwp_file): Call
14913 elf_numsections instead of bfd_count_sections to initialize
14914 dwp_file->num_sections.
14915
cd5a152c
TT
149162019-02-25 Tom Tromey <tromey@adacore.com>
14917
14918 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14919
8a6a8513
SDJ
149202019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14921
14922 * gcore.in: Add '--readnever' option when invoking GDB.
14923
04dcda9c
SM
149242019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14925
14926 * MAINTAINERS: Update my email address.
14927
07bc701d
SM
149282019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14929
14930 * build-id.c (build_id_to_debug_bfd_1): New function.
14931 (build_id_to_debug_bfd): Look for separate debug file in
14932 sysroot.
14933
c6f4a5d0
AB
149342019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14935
14936 * gdbarch.sh: Update the copyright year range that is placed into
14937 generated files.
14938
9600246d
KS
149392019-02-22 Keith Seitz <keiths@redhat.com>
14940
14941 PR symtab/23853
14942 * linespec.c (create_sals_line_offset): Search for the default
14943 symtab's filename instead of its fullname.
14944
7557a514
AH
149452019-02-21 Alan Hayward <alan.hayward@arm.com>
14946
14947 * NEWS: Update style defaults.
14948
ee2bcb0c
AH
149492019-02-21 Alan Hayward <alan.hayward@arm.com>
14950
14951 * main.c (captured_main_1): Disable styling in batch mode.
14952
0c95f9ed
TT
149532019-02-20 Tom Tromey <tom@tromey.com>
14954
14955 * symtab.c (symtab_symbol_info): Fix typos.
14956
c763b894
TT
149572019-02-20 Tom Tromey <tromey@adacore.com>
14958
14959 * findcmd.c (_initialize_mem_search): Use upper case for
14960 metasyntactic variables.
14961
0ef8a082
AH
149622019-02-20 Alan Hayward <alan.hayward@arm.com>
14963
14964 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14965 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14966
6caa91b6
SM
149672019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14968
14969 * top.h (source_file_name): Change to std::string.
14970 * top.c (source_file_name): Likewise.
14971 (command_line_input): Adjust.
14972 * cli/cli-script.c (script_from_file): Adjust.
14973
98814c6c
TT
149742019-02-19 Tom Tromey <tromey@adacore.com>
14975
14976 * ravenscar-thread.c
14977 (ravenscar_thread_target::update_thread_list): Don't call
14978 ada_build_task_list.
14979 * ada-lang.h (ada_build_task_list): Don't declare.
14980 * ada-tasks.c (struct ada_tasks_inferior_data)
14981 <task_list_valid_p>: Now bool.
14982 (read_known_tasks, ada_task_list_changed)
14983 (ada_tasks_invalidate_inferior_data): Update.
14984 (read_known_tasks_array): Return bool.
14985 (read_known_tasks_list): Likewise.
14986 (read_known_tasks): Return void.
14987 (ada_build_task_list): Now static.
14988
70cd633e
AB
149892019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14990
14991 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14992 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14993
040b3e95
PW
149942019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14995
14996 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14997 variant for ada_tasks_pspace_data_handle and
14998 ada_tasks_inferior_data_handle.
14999 (ada_tasks_pspace_data_cleanup): New function.
15000 (ada_tasks_inferior_data_cleanup): New function.
15001
9409233b
TT
150022019-02-17 Tom Tromey <tom@tromey.com>
15003
15004 * macrotab.h (macro_source_fullname): Return a std::string.
15005 * macrotab.c (macro_include, check_for_redefinition)
15006 (macro_undef, macro_lookup_definition, foreach_macro)
15007 (foreach_macro_in_scope): Update.
15008 (macro_source_fullname): Return a std::string.
15009 * macrocmd.c (show_pp_source_pos): Update.
15010
6506371f
TT
150112019-02-17 Tom Tromey <tom@tromey.com>
15012
15013 * macrocmd.c (show_pp_source_pos): Style the file names.
15014
0c820d67
TT
150152019-02-17 Tom Tromey <tom@tromey.com>
15016
15017 PR tui/24197:
15018 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15019
a0087920
TT
150202019-02-17 Tom Tromey <tom@tromey.com>
15021
15022 * ada-lang.c (user_select_syms): Use filtered printing.
15023 * utils.c (wrap_style): New global.
15024 (desired_style): Remove.
15025 (emit_style_escape): Add stream parameter.
15026 (set_output_style, reset_terminal_style, prompt_for_continue):
15027 Update.
15028 (flush_wrap_buffer): Only flush gdb_stdout.
15029 (wrap_here): Set wrap_style.
15030 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
15031 treat escape sequences as a character. Change when wrap buffer is
15032 flushed.
15033 (fputs_styled): Do not set the output style when the default is
15034 requested.
15035 * ui-style.h (struct ui_file_style) <is_default>: New method.
15036 * source.c (print_source_lines_base): Emit escape sequences in one
15037 piece.
15038
75ba10dc
JB
150392019-02-17 Joel Brobecker <brobecker@adacore.com>
15040
15041 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15042 integers and enumeration types.
15043
a2cd4f14
JB
150442019-02-17 Joel Brobecker <brobecker@adacore.com>
15045
15046 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15047 instead of lookup_symbol_in_language
15048 (do_exact_match): New function.
15049 (ada_get_symbol_name_matcher): Return do_exact_match when
15050 doing a verbatim match.
15051
485b851b
TT
150522019-02-15 Tom Tromey <tromey@adacore.com>
15053
15054 * ravenscar-thread.c (ravenscar_thread_target::resume)
15055 (ravenscar_thread_target::wait): Special case wildcard requests.
15056
0b790b1e
TT
150572019-02-15 Tom Tromey <tromey@adacore.com>
15058
15059 * ravenscar-thread.c (base_ptid): Remove.
15060 (struct ravenscar_thread_target) <close>: New method.
15061 <m_base_ptid>: New member.
15062 <update_inferior_ptid, active_task, task_is_currently_active,
15063 runtime_initialized>: Declare methods.
15064 <ravenscar_thread_target>: Add constructor.
15065 (ravenscar_thread_target::task_is_currently_active)
15066 (ravenscar_thread_target::update_inferior_ptid)
15067 (ravenscar_runtime_initialized): Rename. Now methods.
15068 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15069 (ravenscar_thread_target::update_thread_list): Update.
15070 (ravenscar_thread_target::active_task): Now method.
15071 (ravenscar_thread_target::store_registers)
15072 (ravenscar_thread_target::prepare_to_store)
15073 (ravenscar_thread_target::prepare_to_store)
15074 (ravenscar_thread_target::mourn_inferior): Update.
15075 (ravenscar_inferior_created): Use "new" to create target.
15076 (ravenscar_thread_target::get_ada_task_ptid): Update.
15077 (_initialize_ravenscar): Don't initialize base_ptid.
15078 (ravenscar_ops): Remove global.
15079
dea57a62
TT
150802019-02-15 Tom Tromey <tromey@adacore.com>
15081
15082 * target.h (push_target): Declare new overload.
15083 * target.c (push_target): New overload, taking an rvalue reference.
15084 * remote.c (remote_target::open_1): Use push_target overload.
15085 * corelow.c (core_target_open): Use push_target overload.
15086
989f3c58
TT
150872019-02-15 Tom Tromey <tromey@adacore.com>
15088
15089 * ravenscar-thread.c (is_ravenscar_task)
15090 (ravenscar_task_is_currently_active): Return bool.
15091 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15092 (_initialize_ravenscar): Remove "(void)".
15093 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15094 Return bool.
15095
6cbcc006
TT
150962019-02-15 Tom Tromey <tromey@adacore.com>
15097
15098 * ravenscar-thread.c (ravenscar_runtime_initializer)
15099 (has_ravenscar_runtime, get_running_thread_id)
15100 (ravenscar_thread_target::resume): Fix indentation.
15101
7657f14d
TT
151022019-02-15 Tom Tromey <tromey@adacore.com>
15103
15104 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15105 from ravenscar_arch_ops.
15106 (sparc_ravenscar_ops::fetch_registers)
15107 (sparc_ravenscar_ops::store_registers): Now methods.
15108 (sparc_ravenscar_prepare_to_store): Remove.
15109 (sparc_ravenscar_ops): Redefine.
15110 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15111 methods and destructor. Remove members.
15112 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15113 (ravenscar_thread_target::store_registers)
15114 (ravenscar_thread_target::prepare_to_store): Update.
15115 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15116 Remove.
15117 (struct ppc_ravenscar_powerpc_ops): Derive from
15118 ravenscar_arch_ops.
15119 (ppc_ravenscar_powerpc_ops::fetch_registers)
15120 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15121 (ppc_ravenscar_powerpc_ops): Redefine.
15122 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15123 (ppc_ravenscar_e500_ops::fetch_registers)
15124 (ppc_ravenscar_e500_ops::store_registers): Now methods.
15125 (ppc_ravenscar_e500_ops): Redefine.
15126 * aarch64-ravenscar-thread.c
15127 (aarch64_ravenscar_generic_prepare_to_store): Remove.
15128 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15129 (aarch64_ravenscar_fetch_registers)
15130 (aarch64_ravenscar_store_registers): Now methods.
15131 (aarch64_ravenscar_ops): Redefine.
15132
5b6ea500
TT
151332019-02-15 Tom Tromey <tromey@adacore.com>
15134
15135 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15136 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15137 (ravenscar_thread_target::stopped_by_watchpoint)
15138 (ravenscar_thread_target::stopped_data_address)
15139 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15140
e397fd39
TT
151412019-02-15 Tom Tromey <tromey@adacore.com>
15142
15143 * ravenscar-thread.c: Fix some typos.
15144
cc12f4a8
TT
151452019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15146 Tom Tromey <tromey@adacore.com>
15147
15148 * ada-lang.c (ada_exception_sal): Change addr_string to a
15149 std::string.
15150 (create_ada_exception_catchpoint): Update.
15151
5f486660
TT
151522019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15153 Tom Tromey <tromey@adacore.com>
15154
15155 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15156 (bp_location_ops): Remove.
15157 (base_breakpoint_allocate_location): Update.
15158 (free_bp_location): Update.
15159 * ada-lang.c (class ada_catchpoint_location)
15160 <ada_catchpoint_location>: Remove ops parameter.
15161 (ada_catchpoint_location_dtor): Remove.
15162 (ada_catchpoint_location_ops): Remove.
15163 (allocate_location_exception): Update.
15164 * breakpoint.h (struct bp_location_ops): Remove.
15165 (class bp_location) <bp_location>: Remove bp_location_ops
15166 parameter.
15167 <~bp_location>: Add destructor.
15168 <ops>: Remove.
15169
b671c7fb
TS
151702019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15171 Pedro Alves <palves@redhat.com>
15172
15173 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15174 'PATH_MAX'.
15175
8071c5ce
DM
151762019-02-14 David Michael <fedora.dm0@gmail.com>
15177 Samuel Thibault <samuel.thibault@gnu.org>
15178 Thomas Schwinge <thomas@codesourcery.com>
15179
15180 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15181 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15182
b1041ae0
TS
151832019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15184
924514e1
TS
15185 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15186 (check_empty): Use "const char *".
15187
c29ee8d4
TS
15188 * gnu-nat.c (gnu_nat_target::detach): Instead of
15189 'detach_inferior (pid)' call
15190 'detach_inferior (find_inferior_pid (pid))'.
15191
6c6ef69f
TS
15192 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15193 'nat/fork-inferior.o'.
15194 * gnu-nat.c: #include "nat/fork-inferior.h".
15195
2d0a338c
TS
15196 * gnu-nat.c (gnu_nat_target::detach): Instead of
15197 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15198 * gnu-nat.h: #include "inf-child.h".
15199 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15200 'i386_gnu_nat_target::fetch_registers'.
15201 (gnu_store_registers): Rename/move to
15202 'i386_gnu_nat_target::store_registers'.
15203
cabb5f06
TS
15204 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15205 * gnu-nat.h (mach_thread_info): New function.
15206 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15207
b1041ae0
TS
15208 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15209
2988d01e
KF
152102019-02-14 Frederic Konrad <konrad@adacore.com>
15211
15212 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15213
c559d709
JB
152142019-02-14 Joel Brobecker <brobecker@adacore.com>
15215
15216 * windows-nat.c (windows_add_thread): Add new parameter
15217 "main_thread_p" with default value set to false. Update
15218 function documentation as well as all callers.
15219 (windows_delete_thread): Likewise.
15220 (fake_create_process): Update call to windows_add_thread.
15221 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15222 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15223 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15224 call to windows_delete_thread.
15225
007024cc
SM
152262019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15227
15228 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15229
f62318e9
JB
152302019-02-12 John Baldwin <jhb@FreeBSD.org>
15231
15232 * symfile.c (find_separate_debug_file): Use canonical path of
15233 sysroot with child_path instead of gdb_sysroot if it is valid.
15234
cd4b7848
JB
152352019-02-12 John Baldwin <jhb@FreeBSD.org>
15236
15237 * symfile.c (find_separate_debug_file): Use child_path to
15238 determine if an object file is under a sysroot.
15239
efac4bfe
JB
152402019-02-12 John Baldwin <jhb@FreeBSD.org>
15241
15242 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15243 unittests/child-path-selftests.c.
15244 * common/pathstuff.c (child_path): New function.
15245 * common/pathstuff.h (child_path): New prototype.
15246 * unittests/child-path-selftests.c: New file.
15247
402d2bfe
JB
152482019-02-12 John Baldwin <jhb@FreeBSD.org>
15249
15250 * symfile.c (find_separate_debug_file): Look for separate debug
15251 files in debug directories under the sysroot.
15252
1ed9f74e
PW
152532019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15254
15255 * symtab.h (struct minimal_symbol data_p): New const method.
15256 (struct minimal_symbol text_p): Likewise.
15257 * symtab.c (output_source_filename): Use file name style
15258 to print file name.
15259 (print_symbol_info): Likewise.
15260 (print_msymbol_info): Use address style to print addresses.
15261 Use function name style to print executable text symbols.
15262 (expand_symtab_containing_pc): Use data_p.
15263 (find_pc_sect_compunit_symtab): Likewise.
15264
2636d81d
PW
152652019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15266
15267 * breakpoint.c (describe_other_breakpoints): Use address style
15268 to print addresses.
15269 (say_where): Likewise.
15270
ac8c53cc
PW
152712019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15272
15273 * ada-typeprint.c (print_func_type): Print function name
15274 style to print function name.
15275 * c-typeprint.c (c_print_type_1): Likewise.
15276
ea638c43
AH
152772019-02-11 Alan Hayward <alan.hayward@arm.com>
15278
15279 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15280 for execve.
15281
ab759ca8
PW
152822019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15283
15284 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15285 type_stack.
15286
aff29d1c
JB
152872019-02-10 Joel Brobecker <brobecker@adacore.com>
15288
15289 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15290 TYPE_CODE_REF types.
15291
617126bc
JW
152922019-02-08 Jim Wilson <jimw@sifive.com>
15293
15294 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15295 (riscv_linux_fregset): New.
15296 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15297
46e3ed7f
TT
152982019-02-07 Tom Tromey <tom@tromey.com>
15299
15300 * thread.c (thread_cancel_execution_command): Update.
15301 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15302 methods.
15303 (struct thread_fsm_ops): Remove.
15304 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15305 (thread_fsm_should_stop, thread_fsm_return_value)
15306 (thread_fsm_set_finished, thread_fsm_finished_p)
15307 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15308 Don't declare.
15309 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15310 * infrun.c (clear_proceed_status_thread)
15311 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15312 (print_stop_event): Update.
15313 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15314 Add constructor.
15315 (step_command_fsm_ops): Remove.
15316 (new_step_command_fsm): Remove.
15317 (step_1): Update.
15318 (step_command_fsm::should_stop): Rename from
15319 step_command_fsm_should_stop.
15320 (step_command_fsm::clean_up): Rename from
15321 step_command_fsm_clean_up.
15322 (step_command_fsm::do_async_reply_reason): Rename from
15323 step_command_fsm_async_reply_reason.
15324 (struct until_next_fsm): Inherit from thread_fsm. Add
15325 constructor.
15326 (until_next_fsm_ops): Remove.
15327 (new_until_next_fsm): Remove.
15328 (until_next_fsm::should_stop): Rename from
15329 until_next_fsm_should_stop.
15330 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15331 (until_next_fsm::do_async_reply_reason): Rename from
15332 until_next_fsm_async_reply_reason.
15333 (struct finish_command_fsm): Inherit from thread_fsm. Add
15334 constructor. Change type of breakpoint.
15335 (finish_command_fsm_ops): Remove.
15336 (new_finish_command_fsm): Remove.
15337 (finish_command_fsm::should_stop): Rename from
15338 finish_command_fsm_should_stop.
15339 (finish_command_fsm::clean_up): Rename from
15340 finish_command_fsm_clean_up.
15341 (finish_command_fsm::return_value): Rename from
15342 finish_command_fsm_return_value.
15343 (finish_command_fsm::do_async_reply_reason): Rename from
15344 finish_command_fsm_async_reply_reason.
15345 (finish_command): Update.
15346 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15347 Add constructor.
15348 (call_thread_fsm_ops): Remove.
15349 (call_thread_fsm::call_thread_fsm): Rename from
15350 new_call_thread_fsm.
15351 (call_thread_fsm::should_stop): Rename from
15352 call_thread_fsm_should_stop.
15353 (call_thread_fsm::should_notify_stop): Rename from
15354 call_thread_fsm_should_notify_stop.
15355 (run_inferior_call, call_function_by_hand_dummy): Update.
15356 * cli/cli-interp.c (should_print_stop_to_console): Update.
15357 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15358 Add constructor. Change type of location_breakpoint,
15359 caller_breakpoint.
15360 (until_break_fsm_ops): Remove.
15361 (new_until_break_fsm): Remove.
15362 (until_break_fsm::should_stop): Rename from
15363 until_break_fsm_should_stop.
15364 (until_break_fsm::clean_up): Rename from
15365 until_break_fsm_clean_up.
15366 (until_break_fsm::do_async_reply_reason): Rename from
15367 until_break_fsm_async_reply_reason.
15368 (until_break_command): Update.
15369 * thread-fsm.c: Remove.
15370 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15371
1a5c2598
TT
153722019-02-07 Tom Tromey <tom@tromey.com>
15373
15374 * yy-remap.h: Add include guard.
15375 * xtensa-tdep.h: Add include guard.
15376 * xcoffread.h: Rename include guard.
15377 * varobj-iter.h: Add include guard.
15378 * tui/tui.h: Rename include guard.
15379 * tui/tui-winsource.h: Rename include guard.
15380 * tui/tui-wingeneral.h: Rename include guard.
15381 * tui/tui-windata.h: Rename include guard.
15382 * tui/tui-win.h: Rename include guard.
15383 * tui/tui-stack.h: Rename include guard.
15384 * tui/tui-source.h: Rename include guard.
15385 * tui/tui-regs.h: Rename include guard.
15386 * tui/tui-out.h: Rename include guard.
15387 * tui/tui-layout.h: Rename include guard.
15388 * tui/tui-io.h: Rename include guard.
15389 * tui/tui-hooks.h: Rename include guard.
15390 * tui/tui-file.h: Rename include guard.
15391 * tui/tui-disasm.h: Rename include guard.
15392 * tui/tui-data.h: Rename include guard.
15393 * tui/tui-command.h: Rename include guard.
15394 * tic6x-tdep.h: Add include guard.
15395 * target/waitstatus.h: Rename include guard.
15396 * target/wait.h: Rename include guard.
15397 * target/target.h: Rename include guard.
15398 * target/resume.h: Rename include guard.
15399 * target-float.h: Rename include guard.
15400 * stabsread.h: Add include guard.
15401 * rs6000-tdep.h: Add include guard.
15402 * riscv-fbsd-tdep.h: Add include guard.
15403 * regformats/regdef.h: Rename include guard.
15404 * record.h: Rename include guard.
15405 * python/python.h: Rename include guard.
15406 * python/python-internal.h: Rename include guard.
15407 * python/py-stopevent.h: Rename include guard.
15408 * python/py-ref.h: Rename include guard.
15409 * python/py-record.h: Rename include guard.
15410 * python/py-record-full.h: Rename include guard.
15411 * python/py-record-btrace.h: Rename include guard.
15412 * python/py-instruction.h: Rename include guard.
15413 * python/py-events.h: Rename include guard.
15414 * python/py-event.h: Rename include guard.
15415 * procfs.h: Add include guard.
15416 * proc-utils.h: Add include guard.
15417 * p-lang.h: Add include guard.
15418 * or1k-tdep.h: Rename include guard.
15419 * observable.h: Rename include guard.
15420 * nto-tdep.h: Rename include guard.
15421 * nat/x86-linux.h: Rename include guard.
15422 * nat/x86-linux-dregs.h: Rename include guard.
15423 * nat/x86-gcc-cpuid.h: Add include guard.
15424 * nat/x86-dregs.h: Rename include guard.
15425 * nat/x86-cpuid.h: Rename include guard.
15426 * nat/ppc-linux.h: Rename include guard.
15427 * nat/mips-linux-watch.h: Rename include guard.
15428 * nat/linux-waitpid.h: Rename include guard.
15429 * nat/linux-ptrace.h: Rename include guard.
15430 * nat/linux-procfs.h: Rename include guard.
15431 * nat/linux-osdata.h: Rename include guard.
15432 * nat/linux-nat.h: Rename include guard.
15433 * nat/linux-namespaces.h: Rename include guard.
15434 * nat/linux-btrace.h: Rename include guard.
15435 * nat/glibc_thread_db.h: Rename include guard.
15436 * nat/gdb_thread_db.h: Rename include guard.
15437 * nat/gdb_ptrace.h: Rename include guard.
15438 * nat/fork-inferior.h: Rename include guard.
15439 * nat/amd64-linux-siginfo.h: Rename include guard.
15440 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15441 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15442 * nat/aarch64-linux.h: Rename include guard.
15443 * nat/aarch64-linux-hw-point.h: Rename include guard.
15444 * mn10300-tdep.h: Add include guard.
15445 * mips-linux-tdep.h: Add include guard.
15446 * mi/mi-parse.h: Rename include guard.
15447 * mi/mi-out.h: Rename include guard.
15448 * mi/mi-main.h: Rename include guard.
15449 * mi/mi-interp.h: Rename include guard.
15450 * mi/mi-getopt.h: Rename include guard.
15451 * mi/mi-console.h: Rename include guard.
15452 * mi/mi-common.h: Rename include guard.
15453 * mi/mi-cmds.h: Rename include guard.
15454 * mi/mi-cmd-break.h: Rename include guard.
15455 * m2-lang.h: Add include guard.
15456 * location.h: Rename include guard.
15457 * linux-record.h: Rename include guard.
15458 * linux-nat.h: Add include guard.
15459 * linux-fork.h: Add include guard.
15460 * i386-darwin-tdep.h: Rename include guard.
15461 * hppa-linux-offsets.h: Add include guard.
15462 * guile/guile.h: Rename include guard.
15463 * guile/guile-internal.h: Rename include guard.
15464 * gnu-nat.h: Rename include guard.
15465 * gdb-stabs.h: Rename include guard.
15466 * frv-tdep.h: Add include guard.
15467 * f-lang.h: Add include guard.
15468 * event-loop.h: Add include guard.
15469 * darwin-nat.h: Rename include guard.
15470 * cp-abi.h: Rename include guard.
15471 * config/sparc/nm-sol2.h: Rename include guard.
15472 * config/nm-nto.h: Rename include guard.
15473 * config/nm-linux.h: Add include guard.
15474 * config/i386/nm-i386gnu.h: Rename include guard.
15475 * config/djgpp/nl_types.h: Rename include guard.
15476 * config/djgpp/langinfo.h: Rename include guard.
15477 * compile/gcc-cp-plugin.h: Add include guard.
15478 * compile/gcc-c-plugin.h: Add include guard.
15479 * compile/compile.h: Rename include guard.
15480 * compile/compile-object-run.h: Rename include guard.
15481 * compile/compile-object-load.h: Rename include guard.
15482 * compile/compile-internal.h: Rename include guard.
15483 * compile/compile-cplus.h: Rename include guard.
15484 * compile/compile-c.h: Rename include guard.
15485 * common/xml-utils.h: Rename include guard.
15486 * common/x86-xstate.h: Rename include guard.
15487 * common/version.h: Rename include guard.
15488 * common/vec.h: Rename include guard.
15489 * common/tdesc.h: Rename include guard.
15490 * common/selftest.h: Rename include guard.
15491 * common/scoped_restore.h: Rename include guard.
15492 * common/scoped_mmap.h: Rename include guard.
15493 * common/scoped_fd.h: Rename include guard.
15494 * common/safe-iterator.h: Rename include guard.
15495 * common/run-time-clock.h: Rename include guard.
15496 * common/refcounted-object.h: Rename include guard.
15497 * common/queue.h: Rename include guard.
15498 * common/ptid.h: Rename include guard.
15499 * common/print-utils.h: Rename include guard.
15500 * common/preprocessor.h: Rename include guard.
15501 * common/pathstuff.h: Rename include guard.
15502 * common/observable.h: Rename include guard.
15503 * common/netstuff.h: Rename include guard.
15504 * common/job-control.h: Rename include guard.
15505 * common/host-defs.h: Rename include guard.
15506 * common/gdb_wait.h: Rename include guard.
15507 * common/gdb_vecs.h: Rename include guard.
15508 * common/gdb_unlinker.h: Rename include guard.
15509 * common/gdb_unique_ptr.h: Rename include guard.
15510 * common/gdb_tilde_expand.h: Rename include guard.
15511 * common/gdb_sys_time.h: Rename include guard.
15512 * common/gdb_string_view.h: Rename include guard.
15513 * common/gdb_splay_tree.h: Rename include guard.
15514 * common/gdb_setjmp.h: Rename include guard.
15515 * common/gdb_ref_ptr.h: Rename include guard.
15516 * common/gdb_optional.h: Rename include guard.
15517 * common/gdb_locale.h: Rename include guard.
15518 * common/gdb_assert.h: Rename include guard.
15519 * common/filtered-iterator.h: Rename include guard.
15520 * common/filestuff.h: Rename include guard.
15521 * common/fileio.h: Rename include guard.
15522 * common/environ.h: Rename include guard.
15523 * common/common-utils.h: Rename include guard.
15524 * common/common-types.h: Rename include guard.
15525 * common/common-regcache.h: Rename include guard.
15526 * common/common-inferior.h: Rename include guard.
15527 * common/common-gdbthread.h: Rename include guard.
15528 * common/common-exceptions.h: Rename include guard.
15529 * common/common-defs.h: Rename include guard.
15530 * common/common-debug.h: Rename include guard.
15531 * common/cleanups.h: Rename include guard.
15532 * common/buffer.h: Rename include guard.
15533 * common/btrace-common.h: Rename include guard.
15534 * common/break-common.h: Rename include guard.
15535 * cli/cli-utils.h: Rename include guard.
15536 * cli/cli-style.h: Rename include guard.
15537 * cli/cli-setshow.h: Rename include guard.
15538 * cli/cli-script.h: Rename include guard.
15539 * cli/cli-interp.h: Rename include guard.
15540 * cli/cli-decode.h: Rename include guard.
15541 * cli/cli-cmds.h: Rename include guard.
15542 * charset-list.h: Add include guard.
15543 * buildsym-legacy.h: Rename include guard.
15544 * bfin-tdep.h: Add include guard.
15545 * ax.h: Rename include guard.
15546 * arm-linux-tdep.h: Add include guard.
15547 * arm-fbsd-tdep.h: Add include guard.
15548 * arch/xtensa.h: Rename include guard.
15549 * arch/tic6x.h: Add include guard.
15550 * arch/i386.h: Add include guard.
15551 * arch/arm.h: Rename include guard.
15552 * arch/arm-linux.h: Rename include guard.
15553 * arch/arm-get-next-pcs.h: Rename include guard.
15554 * arch/amd64.h: Add include guard.
15555 * arch/aarch64-insn.h: Rename include guard.
15556 * arch-utils.h: Rename include guard.
15557 * annotate.h: Add include guard.
15558 * amd64-darwin-tdep.h: Rename include guard.
15559 * aarch64-linux-tdep.h: Add include guard.
15560 * aarch64-fbsd-tdep.h: Add include guard.
15561 * aarch32-linux-nat.h: Add include guard.
15562
ab9268d2
PW
155632019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15564
15565 * macrotab.c (macro_define_internal): New function that
15566 factorizes macro_define_object_internal and macro_define_function
15567 code.
15568 (macro_define_object_internal): Use macro_define_internal.
15569 (macro_define_function): Likewise.
15570
bb0da2b4
PW
155712019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15572
15573 * macrocmd.c (extract_identifier): Return
15574 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15575 callers.
15576
424eb552
JB
155772019-02-06 John Baldwin <jhb@FreeBSD.org>
15578
15579 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15580
1688cb29
TT
155812019-02-05 Tom Tromey <tom@tromey.com>
15582
15583 * target.c (target_stack::unpush): Move assertion earlier.
15584
b5eba2d8
TT
155852019-01-30 Tom Tromey <tom@tromey.com>
15586
15587 PR python/23615:
15588 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15589 (gdbpy_parse_and_eval): Likewise.
15590 * python/python-internal.h (gdbpy_allow_threads): New class.
15591
7054e2ff
JB
155922019-01-28 John Baldwin <jhb@FreeBSD.org>
15593
15594 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15595 (aarch64_fbsd_fpregmap): Move earlier.
15596 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15597 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15598 instead of individual calls to trad_frame_set_reg_addr.
15599 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15600 earlier.
15601 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15602 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15603 instead of individual calls to trad_frame_set_reg_addr.
15604
36c25ffa
AH
156052019-01-28 Alan Hayward <alan.hayward@arm.com>
15606
15607 * CONTRIBUTE: Replace contribution list with wiki link.
15608
a0707f3c
TT
156092019-01-25 Tom Tromey <tom@tromey.com>
15610
15611 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15612
0747795c
TT
156132019-01-25 Tom Tromey <tom@tromey.com>
15614
15615 * xtensa-linux-nat.c: Fix common/ includes.
15616 * xml-support.h: Fix common/ includes.
15617 * xml-support.c: Fix common/ includes.
15618 * x86-linux-nat.c: Fix common/ includes.
15619 * windows-nat.c: Fix common/ includes.
15620 * varobj.h: Fix common/ includes.
15621 * varobj.c: Fix common/ includes.
15622 * value.c: Fix common/ includes.
15623 * valops.c: Fix common/ includes.
15624 * utils.c: Fix common/ includes.
15625 * unittests/xml-utils-selftests.c: Fix common/ includes.
15626 * unittests/utils-selftests.c: Fix common/ includes.
15627 * unittests/unpack-selftests.c: Fix common/ includes.
15628 * unittests/tracepoint-selftests.c: Fix common/ includes.
15629 * unittests/style-selftests.c: Fix common/ includes.
15630 * unittests/string_view-selftests.c: Fix common/ includes.
15631 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15632 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15633 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15634 * unittests/rsp-low-selftests.c: Fix common/ includes.
15635 * unittests/parse-connection-spec-selftests.c: Fix common/
15636 includes.
15637 * unittests/optional-selftests.c: Fix common/ includes.
15638 * unittests/offset-type-selftests.c: Fix common/ includes.
15639 * unittests/observable-selftests.c: Fix common/ includes.
15640 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15641 * unittests/memrange-selftests.c: Fix common/ includes.
15642 * unittests/memory-map-selftests.c: Fix common/ includes.
15643 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15644 * unittests/function-view-selftests.c: Fix common/ includes.
15645 * unittests/environ-selftests.c: Fix common/ includes.
15646 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15647 * unittests/common-utils-selftests.c: Fix common/ includes.
15648 * unittests/cli-utils-selftests.c: Fix common/ includes.
15649 * unittests/array-view-selftests.c: Fix common/ includes.
15650 * ui-file.c: Fix common/ includes.
15651 * tui/tui-io.c: Fix common/ includes.
15652 * tracepoint.h: Fix common/ includes.
15653 * tracepoint.c: Fix common/ includes.
15654 * tracefile-tfile.c: Fix common/ includes.
15655 * top.h: Fix common/ includes.
15656 * top.c: Fix common/ includes.
15657 * thread.c: Fix common/ includes.
15658 * target/waitstatus.h: Fix common/ includes.
15659 * target/waitstatus.c: Fix common/ includes.
15660 * target.h: Fix common/ includes.
15661 * target.c: Fix common/ includes.
15662 * target-memory.c: Fix common/ includes.
15663 * target-descriptions.c: Fix common/ includes.
15664 * symtab.h: Fix common/ includes.
15665 * symfile.c: Fix common/ includes.
15666 * stap-probe.c: Fix common/ includes.
15667 * spu-linux-nat.c: Fix common/ includes.
15668 * sparc-nat.c: Fix common/ includes.
15669 * source.c: Fix common/ includes.
15670 * solib.c: Fix common/ includes.
15671 * solib-target.c: Fix common/ includes.
15672 * ser-unix.c: Fix common/ includes.
15673 * ser-tcp.c: Fix common/ includes.
15674 * ser-pipe.c: Fix common/ includes.
15675 * ser-base.c: Fix common/ includes.
15676 * selftest-arch.c: Fix common/ includes.
15677 * s12z-tdep.c: Fix common/ includes.
15678 * rust-exp.y: Fix common/ includes.
15679 * rs6000-aix-tdep.c: Fix common/ includes.
15680 * riscv-tdep.c: Fix common/ includes.
15681 * remote.c: Fix common/ includes.
15682 * remote-notif.h: Fix common/ includes.
15683 * remote-fileio.h: Fix common/ includes.
15684 * remote-fileio.c: Fix common/ includes.
15685 * regcache.h: Fix common/ includes.
15686 * regcache.c: Fix common/ includes.
15687 * record-btrace.c: Fix common/ includes.
15688 * python/python.c: Fix common/ includes.
15689 * python/py-type.c: Fix common/ includes.
15690 * python/py-inferior.c: Fix common/ includes.
15691 * progspace.h: Fix common/ includes.
15692 * producer.c: Fix common/ includes.
15693 * procfs.c: Fix common/ includes.
15694 * proc-api.c: Fix common/ includes.
15695 * printcmd.c: Fix common/ includes.
15696 * ppc-linux-nat.c: Fix common/ includes.
15697 * parser-defs.h: Fix common/ includes.
15698 * osdata.c: Fix common/ includes.
15699 * obsd-nat.c: Fix common/ includes.
15700 * nat/x86-linux.c: Fix common/ includes.
15701 * nat/x86-linux-dregs.c: Fix common/ includes.
15702 * nat/x86-dregs.h: Fix common/ includes.
15703 * nat/x86-dregs.c: Fix common/ includes.
15704 * nat/ppc-linux.c: Fix common/ includes.
15705 * nat/mips-linux-watch.h: Fix common/ includes.
15706 * nat/mips-linux-watch.c: Fix common/ includes.
15707 * nat/linux-waitpid.c: Fix common/ includes.
15708 * nat/linux-ptrace.h: Fix common/ includes.
15709 * nat/linux-ptrace.c: Fix common/ includes.
15710 * nat/linux-procfs.c: Fix common/ includes.
15711 * nat/linux-personality.c: Fix common/ includes.
15712 * nat/linux-osdata.c: Fix common/ includes.
15713 * nat/linux-namespaces.c: Fix common/ includes.
15714 * nat/linux-btrace.h: Fix common/ includes.
15715 * nat/linux-btrace.c: Fix common/ includes.
15716 * nat/fork-inferior.c: Fix common/ includes.
15717 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15718 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15719 * nat/aarch64-linux.c: Fix common/ includes.
15720 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15721 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15722 * namespace.h: Fix common/ includes.
15723 * mips-linux-tdep.c: Fix common/ includes.
15724 * minsyms.c: Fix common/ includes.
15725 * mi/mi-parse.h: Fix common/ includes.
15726 * mi/mi-main.c: Fix common/ includes.
15727 * mi/mi-cmd-env.c: Fix common/ includes.
15728 * memrange.h: Fix common/ includes.
15729 * memattr.c: Fix common/ includes.
15730 * maint.h: Fix common/ includes.
15731 * maint.c: Fix common/ includes.
15732 * main.c: Fix common/ includes.
15733 * machoread.c: Fix common/ includes.
15734 * location.c: Fix common/ includes.
15735 * linux-thread-db.c: Fix common/ includes.
15736 * linux-nat.c: Fix common/ includes.
15737 * linux-fork.c: Fix common/ includes.
15738 * inline-frame.c: Fix common/ includes.
15739 * infrun.c: Fix common/ includes.
15740 * inflow.c: Fix common/ includes.
15741 * inferior.h: Fix common/ includes.
15742 * inferior.c: Fix common/ includes.
15743 * infcmd.c: Fix common/ includes.
15744 * inf-ptrace.c: Fix common/ includes.
15745 * inf-child.c: Fix common/ includes.
15746 * ia64-linux-nat.c: Fix common/ includes.
15747 * i387-tdep.c: Fix common/ includes.
15748 * i386-tdep.c: Fix common/ includes.
15749 * i386-linux-tdep.c: Fix common/ includes.
15750 * i386-linux-nat.c: Fix common/ includes.
15751 * i386-go32-tdep.c: Fix common/ includes.
15752 * i386-fbsd-tdep.c: Fix common/ includes.
15753 * i386-fbsd-nat.c: Fix common/ includes.
15754 * guile/scm-type.c: Fix common/ includes.
15755 * guile/guile.c: Fix common/ includes.
15756 * go32-nat.c: Fix common/ includes.
15757 * gnu-nat.c: Fix common/ includes.
15758 * gdbthread.h: Fix common/ includes.
15759 * gdbarch-selftests.c: Fix common/ includes.
15760 * gdb_usleep.c: Fix common/ includes.
15761 * gdb_select.h: Fix common/ includes.
15762 * gdb_bfd.c: Fix common/ includes.
15763 * gcore.c: Fix common/ includes.
15764 * fork-child.c: Fix common/ includes.
15765 * findvar.c: Fix common/ includes.
15766 * fbsd-nat.c: Fix common/ includes.
15767 * event-top.c: Fix common/ includes.
15768 * event-loop.c: Fix common/ includes.
15769 * dwarf2read.c: Fix common/ includes.
15770 * dwarf2loc.c: Fix common/ includes.
15771 * dwarf2-frame.c: Fix common/ includes.
15772 * dwarf-index-cache.c: Fix common/ includes.
15773 * dtrace-probe.c: Fix common/ includes.
15774 * disasm-selftests.c: Fix common/ includes.
15775 * defs.h: Fix common/ includes.
15776 * csky-tdep.c: Fix common/ includes.
15777 * cp-valprint.c: Fix common/ includes.
15778 * cp-support.h: Fix common/ includes.
15779 * cp-support.c: Fix common/ includes.
15780 * corelow.c: Fix common/ includes.
15781 * completer.h: Fix common/ includes.
15782 * completer.c: Fix common/ includes.
15783 * compile/compile.c: Fix common/ includes.
15784 * compile/compile-loc2c.c: Fix common/ includes.
15785 * compile/compile-cplus-types.c: Fix common/ includes.
15786 * compile/compile-cplus-symbols.c: Fix common/ includes.
15787 * command.h: Fix common/ includes.
15788 * cli/cli-dump.c: Fix common/ includes.
15789 * cli/cli-cmds.c: Fix common/ includes.
15790 * charset.c: Fix common/ includes.
15791 * build-id.c: Fix common/ includes.
15792 * btrace.h: Fix common/ includes.
15793 * btrace.c: Fix common/ includes.
15794 * breakpoint.h: Fix common/ includes.
15795 * breakpoint.c: Fix common/ includes.
15796 * ax.h:
15797 (enum agent_op): Fix common/ includes.
15798 * ax-general.c (struct aop_map): Fix common/ includes.
15799 * ax-gdb.c: Fix common/ includes.
15800 * auxv.c: Fix common/ includes.
15801 * auto-load.c: Fix common/ includes.
15802 * arm-tdep.c: Fix common/ includes.
15803 * arch/riscv.c: Fix common/ includes.
15804 * arch/ppc-linux-common.c: Fix common/ includes.
15805 * arch/i386.c: Fix common/ includes.
15806 * arch/arm.c: Fix common/ includes.
15807 * arch/arm-linux.c: Fix common/ includes.
15808 * arch/arm-get-next-pcs.c: Fix common/ includes.
15809 * arch/amd64.c: Fix common/ includes.
15810 * arch/aarch64.c: Fix common/ includes.
15811 * arch/aarch64-insn.c: Fix common/ includes.
15812 * arch-utils.c: Fix common/ includes.
15813 * amd64-windows-tdep.c: Fix common/ includes.
15814 * amd64-tdep.c: Fix common/ includes.
15815 * amd64-sol2-tdep.c: Fix common/ includes.
15816 * amd64-obsd-tdep.c: Fix common/ includes.
15817 * amd64-nbsd-tdep.c: Fix common/ includes.
15818 * amd64-linux-tdep.c: Fix common/ includes.
15819 * amd64-linux-nat.c: Fix common/ includes.
15820 * amd64-fbsd-tdep.c: Fix common/ includes.
15821 * amd64-fbsd-nat.c: Fix common/ includes.
15822 * amd64-dicos-tdep.c: Fix common/ includes.
15823 * amd64-darwin-tdep.c: Fix common/ includes.
15824 * agent.c: Fix common/ includes.
15825 * ada-lang.h: Fix common/ includes.
15826 * ada-lang.c: Fix common/ includes.
15827 * aarch64-tdep.c: Fix common/ includes.
15828
2f5c153e
TT
158292019-01-25 Tom Tromey <tom@tromey.com>
15830
15831 * common/create-version.sh: Use common/version.h.
15832
adc6a863
PA
158332019-01-24 Pedro Alves <palves@redhat.com>
15834
15835 * infrun.c (signal_stop, signal_print, signal_program)
15836 (signal_catch, signal_pass): Now arrays instead of pointers.
15837 (update_signals_program_target, do_target_resume)
15838 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15839 * linux-nat.c (linux_nat_target::pass_signals)
15840 (linux_nat_target::create_inferior, linux_nat_target::attach):
15841 Adjust.
15842 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15843 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15844 * procfs.c (procfs_target::pass_signals): Adjust.
15845 * record-full.c (record_full_target::resume): Adjust.
15846 * remote.c (remote_target::pass_signals)
15847 (remote_target::program_signals): Adjust.
15848 * target-debug.h (target_debug_print_signals): Now takes a
15849 gdb::array_view as parameter. Adjust.
15850 * target.h (target_ops) <pass_signals, program_signals>: Replace
15851 pointer and length parameters with gdb::array_view.
15852 (target_pass_signals, target_program_signals): Likewise.
15853 * target-delegates.c: Regenerate.
15854
3046d67a
PA
158552019-01-24 Pedro Alves <palves@redhat.com>
15856
15857 * common/forward-scope-exit.h
15858 (forward_scope_exit::forward_scope_exit): Pass arguments to
15859 m_bind_function directly, instead of creating a std::bind and
15860 copying that.
15861
353229bf
AH
158622019-01-24 Alan Hayward <alan.hayward@arm.com>
15863
15864 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15865 for static members.
15866 (pass_in_v_vfp_candidate): Likewise.
15867
311dc83a
TT
158682019-01-23 Tom Tromey <tom@tromey.com>
15869 Pedro Alves <palves@redhat.com>
15870
15871 * regcache.c (class regcache_invalidator): Remove.
15872 (regcache::raw_write): Use make_scope_exit.
15873
296bd123
TT
158742019-01-23 Tom Tromey <tom@tromey.com>
15875
15876 * ui-out.h (class ui_out_emit_type): Update comment.
15877
979a0d13
TT
158782019-01-23 Tom Tromey <tom@tromey.com>
15879
15880 * infrun.c (fetch_inferior_event): Update comment.
15881
d238133d
TT
158822019-01-23 Tom Tromey <tom@tromey.com>
15883 Pedro Alves <palves@redhat.com>
15884
15885 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15886 parameter.
15887 (fetch_inferior_event): Use SCOPE_EXIT.
15888
15889
9885e6bb
TT
158902019-01-23 Tom Tromey <tom@tromey.com>
15891 Pedro Alves <palves@redhat.com>
15892
15893 * infrun.c (disable_thread_events): Delete.
15894 (stop_all_threads): Use SCOPE_EXIT.
15895
286526c1
TT
158962019-01-23 Tom Tromey <tom@tromey.com>
15897 Pedro Alves <palves@redhat.com>
15898
15899 * symfile.c: Include forward-scope-exit.h.
15900 (clear_symtab_users_cleanup): Replace forward declaration with
15901 a FORWARD_SCOPE_EXIT.
15902 (syms_from_objfile_1): Use the forward_scope_exit and
15903 gdb::optional instead of cleanup_function.
15904 (reread_symbols): Use the forward_scope_exit instead of
15905 cleanup_function.
15906 (clear_symtab_users_cleanup): Remove function.
15907
1db93f14
TT
159082019-01-23 Tom Tromey <tom@tromey.com>
15909 Pedro Alves <palves@redhat.com>
15910
15911 * linux-nat.c: Include scope-exit.h.
15912 (cleanup_target_stop): Remove.
15913 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15914 SCOPE_EXIT.
15915
2cc83d1e
TT
159162019-01-23 Tom Tromey <tom@tromey.com>
15917 Pedro Alves <palves@redhat.com>
15918
15919 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15920 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15921
694c6bf5
TT
159222019-01-23 Tom Tromey <tom@tromey.com>
15923 Andrew Burgess <andrew.burgess@embecosm.com>
15924 Pedro Alves <palves@redhat.com>
15925
15926 * infrun.c (fetch_inferior_event): Use scope_exit.
15927 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15928 * top.c (execute_command): Use scope_exit.
15929 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15930 * utils.c (do_bpstat_clear_actions_cleanup)
15931 (make_bpstat_clear_actions_cleanup): Remove.
15932
4c41382a
TT
159332019-01-23 Tom Tromey <tom@tromey.com>
15934 Pedro Alves <palves@redhat.com>
15935
15936 * infrun.c: Include "common/scope-exit.h"
15937 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15938 (wait_for_inferior): Use SCOPE_EXIT.
15939 (fetch_inferior_event): Use scope_exit.
15940
89f8fb50
TT
159412019-01-23 Tom Tromey <tom@tromey.com>
15942 Pedro Alves <palves@redhat.com>
15943
15944 * breakpoint.c (create_breakpoint): Remove cleanup.
15945
5419bdae
TT
159462019-01-23 Tom Tromey <tom@tromey.com>
15947 Andrew Burgess <andrew.burgess@embecosm.com>
15948 Pedro Alves <palves@redhat.com>
15949
e587ef42
PA
159502019-01-23 Pedro Alves <palves@redhat.com>
15951
15952 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15953
77f0e74c
PA
159542019-01-23 Pedro Alves <palves@redhat.com>
15955 Andrew Burgess <andrew.burgess@embecosm.com>
15956
15957 * gdbthread.h: Include "common/forward-scope-exit.h".
15958 (scoped_finish_thread_state): Redefine custom class in terms of
15959 forward_scope_exit.
15960
5b9b3e53
PA
159612019-01-23 Pedro Alves <palves@redhat.com>
15962 Andrew Burgess <andrew.burgess@embecosm.com>
15963
15964 * common/forward-scope-exit.h: New file.
15965
54b65c9b
PA
159662019-01-23 Pedro Alves <palves@redhat.com>
15967 Andrew Burgess <andrew.burgess@embecosm.com>
15968 Tom Tromey <tom@tromey.com>
15969
15970 * common/scope-exit.h: New file.
15971
cf08fb29
PA
159722019-01-23 Pedro Alves <palves@redhat.com>
15973
15974 * common/preprocessor.h (ESC): Rename to ...
15975 (ESC_PARENS): ... this.
15976 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15977 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15978
ae73e2e2
TT
159792019-01-23 Tom Tromey <tom@tromey.com>
15980
15981 * language.h (class scoped_switch_to_sym_language_if_auto):
15982 Initialize m_lang in both cases.
15983
6594e122
AH
159842019-01-23 Alan Hayward <alan.hayward@arm.com>
15985
15986 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15987 with XCNEW.
15988
a7c9855d
TT
159892019-01-22 Tom Tromey <tom@tromey.com>
15990
15991 * corelow.c: Do not include sys/file.h.
15992
93cc1d53
TT
159932019-01-22 Tom Tromey <tom@tromey.com>
15994
15995 * tui/tui-wingeneral.h: Include gdb_curses.h.
15996
38561778
TT
159972019-01-22 Tom Tromey <tom@tromey.com>
15998
15999 * source-cache.h (class source_cache) <get_source_lines,
16000 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
16001
37b3ab5b
TT
160022019-01-22 Tom Tromey <tom@tromey.com>
16003
16004 * remote-fileio.h (struct remote_target): Declare.
16005
3fabc016
TT
160062019-01-22 Tom Tromey <tom@tromey.com>
16007
16008 * python/py-arch.c: Do not include py-ref.h.
16009 * python/py-bpevent.c: Do not include py-ref.h.
16010 * python/py-cmd.c: Do not include py-ref.h.
16011 * python/py-continueevent.c: Do not include py-ref.h.
16012 * python/py-event.h: Do not include py-ref.h.
16013 * python/py-evtregistry.c: Do not include py-ref.h.
16014 * python/py-finishbreakpoint.c: Do not include py-ref.h.
16015 * python/py-frame.c: Do not include py-ref.h.
16016 * python/py-framefilter.c: Do not include py-ref.h.
16017 * python/py-function.c: Do not include py-ref.h.
16018 * python/py-infevents.c: Do not include py-ref.h.
16019 * python/py-linetable.c: Do not include py-ref.h.
16020 * python/py-objfile.c: Do not include py-ref.h.
16021 * python/py-param.c: Do not include py-ref.h.
16022 * python/py-prettyprint.c: Do not include py-ref.h.
16023 * python/py-progspace.c: Do not include py-ref.h.
16024 * python/py-symbol.c: Do not include py-ref.h.
16025 * python/py-symtab.c: Do not include py-ref.h.
16026 * python/py-type.c: Do not include py-ref.h.
16027 * python/py-unwind.c: Do not include py-ref.h.
16028 * python/py-utils.c: Do not include py-ref.h.
16029 * python/py-value.c: Do not include py-ref.h.
16030 * python/py-varobj.c: Do not include py-ref.h.
16031 * python/py-xmethods.c: Do not include py-ref.h.
16032 * python/python.c: Do not include py-ref.h.
16033 * varobj.c: Do not include py-ref.h.
16034
6b4d7774
TT
160352019-01-22 Tom Tromey <tom@tromey.com>
16036
16037 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16038 keyword for bcache.
16039
7af7e9b5
TT
160402019-01-22 Tom Tromey <tom@tromey.com>
16041
16042 * compile/compile-cplus-types.c: Remove a comment by #include.
16043
951d1049
TT
160442019-01-22 Tom Tromey <tom@tromey.com>
16045
16046 * compile/gcc-c-plugin.h: Include compile-internal.h.
16047
d65d5705
TT
160482019-01-22 Tom Tromey <tom@tromey.com>
16049
16050 * stabsread.c (EXTERN): Do not define.
16051 (symnum, next_symbol_text_func, processing_gcc_compilation)
16052 (within_function, global_sym_chain, global_stabs)
16053 (previous_stab_code, this_object_header_files)
16054 (n_this_object_header_files)
16055 (n_allocated_this_object_header_files): Define.
16056 * stabsread.h (EXTERN): Never define. Use "extern".
16057
b6fb1ee5
PW
160582019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16059
16060 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16061 history_value.
16062
be6d4f74
TT
160632019-01-21 Tom Tromey <tom@tromey.com>
16064
16065 * ui-out.c: Fix includes.
16066 * tui/tui-source.c: Fix includes.
16067 * target.c: Fix includes.
16068 * remote.c: Fix includes.
16069 * regcache.c: Fix includes.
16070 * python/py-block.c: Fix includes.
16071 * printcmd.c: Fix includes.
16072 * or1k-tdep.c: Fix includes.
16073 * mi/mi-main.c: Fix includes.
16074 * m32r-tdep.c: Fix includes.
16075 * csky-tdep.c: Fix includes.
16076 * compile/compile-cplus-types.c: Fix includes.
16077 * cli/cli-interp.c: Fix includes.
16078
73021deb
AH
160792019-01-21 Alan Hayward <alan.hayward@arm.com>
16080
16081 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16082 for padding.
16083
7932255d
TT
160842019-01-16 Tom Tromey <tom@tromey.com>
16085
16086 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
16087 earlier.
16088 (struct objfile) <msymbols_range>: Move from top level.
16089 <msymbols>: New method.
16090 (class objfile_msymbols): Remove.
16091 * symtab.c (default_collect_symbol_completion_matches_break_on):
16092 Update.
16093 * symmisc.c (dump_msymbols): Update.
16094 * stabsread.c (scan_file_globals): Update.
16095 * objc-lang.c (info_selectors_command, info_classes_command)
16096 (find_methods): Update.
16097 * minsyms.c (find_solib_trampoline_target): Update.
16098 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16099 * coffread.c (coff_symfile_read): Update.
16100 * ada-lang.c (ada_lookup_simple_minsym)
16101 (ada_collect_symbol_completion_matches): Update.
16102
604b1bfb
TT
161032019-01-16 Tom Tromey <tom@tromey.com>
16104
16105 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16106 type. Remove no-argument constructor.
16107 <iterator::operator++>: Simplify.
16108 <begin>: Update.
16109 <end>: Use minimal_symbol_count.
16110
f252c6d5
TT
161112019-01-16 Tom Tromey <tom@tromey.com>
16112
16113 * objfiles.h (struct objfile) <psymtabs>: New method.
16114 (class objfile_psymtabs): Remove.
16115 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16116 typedef.
16117 <range>: New method.
16118 (require_partial_symbols): Change return type.
16119 * psymtab.c (require_partial_symbols)
16120 (psym_expand_symtabs_matching): Update.
16121 * mdebugread.c (parse_partial_symbols): Update.
16122 * dbxread.c (dbx_end_psymtab): Update.
16123
b669c953
TT
161242019-01-15 Tom Tromey <tom@tromey.com>
16125
16126 * symtab.c (lookup_objfile_from_block)
16127 (lookup_symbol_in_objfile_symtabs)
16128 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16129 (find_line_symtab, info_sources_command)
16130 (default_collect_symbol_completion_matches_break_on)
16131 (make_source_files_completion_list): Update.
16132 * symmisc.c (print_objfile_statistics, dump_objfile)
16133 (maintenance_print_symbols, maintenance_info_symtabs)
16134 (maintenance_check_symtabs, maintenance_info_line_tables):
16135 Update.
16136 * source.c (select_source_symtab)
16137 (forget_cached_source_info_for_objfile): Update.
16138 * objfiles.h (class objfile_compunits): Remove.
16139 (struct objfile) <compunits_range>: New typedef.
16140 (compunits): New method.
16141 * objfiles.c (objfile_relocate1): Update.
16142 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16143 * maint.c (count_symtabs_and_blocks): Update.
16144 * linespec.c (iterate_over_all_matching_symtabs): Update.
16145 * cp-support.c (add_symbol_overload_list_qualified): Update.
16146 * coffread.c (coff_symtab_read): Update.
16147 * ada-lang.c (add_nonlocal_symbols)
16148 (ada_collect_symbol_completion_matches)
16149 (ada_add_global_exceptions): Update.
16150
7e955d83
TT
161512019-01-15 Tom Tromey <tom@tromey.com>
16152
16153 * progspace.h (program_space) <objfiles_safe_range>: New
16154 typedef.
16155 <objfiles_safe>: New method.
16156 * objfiles.h (class all_objfiles_safe): Remove.
16157 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16158 * jit.c (jit_inferior_exit_hook): Update.
16159
2030c079
TT
161602019-01-17 Tom Tromey <tom@tromey.com>
16161
16162 * progspace.h (program_space) <objfiles_range>: New typedef.
16163 <objfiles>: New method.
16164 <objfiles_head>: Rename from objfiles.
16165 (object_files): Update.
16166 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16167 * guile/scm-pretty-print.c
16168 (ppscm_find_pretty_printer_from_objfiles): Update.
16169 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16170 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16171 Update.
16172 * python/py-progspace.c (pspy_get_objfiles): Update.
16173 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16174 Update.
16175 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16176 (objfpy_lookup_objfile_by_build_id): Update.
16177 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16178 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16179 Update.
16180 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16181 (expand_symtab_containing_pc, lookup_objfile_from_block)
16182 (lookup_static_symbol, basic_lookup_transparent_type)
16183 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16184 (find_line_symtab, info_sources_command)
16185 (default_collect_symbol_completion_matches_break_on)
16186 (make_source_files_completion_list, find_main_name): Update.
16187 * symmisc.c (print_symbol_bcache_statistics)
16188 (print_objfile_statistics, maintenance_print_symbols)
16189 (maintenance_print_msymbols, maintenance_print_objfiles)
16190 (maintenance_info_symtabs, maintenance_check_symtabs)
16191 (maintenance_expand_symtabs, maintenance_info_line_tables):
16192 Update.
16193 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16194 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16195 (map_overlay_command, unmap_overlay_command)
16196 (simple_overlay_update, expand_symtabs_matching)
16197 (map_symbol_filenames): Update.
16198 * symfile-debug.c (set_debug_symfile): Update.
16199 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16200 Update.
16201 * source.c (select_source_symtab, forget_cached_source_info):
16202 Update.
16203 * solib.c (solib_read_symbols): Update.
16204 * solib-spu.c (append_ocl_sos): Update.
16205 * psymtab.c (maintenance_print_psymbols)
16206 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16207 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16208 * printcmd.c (info_symbol_command): Update.
16209 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16210 Update.
16211 * objfiles.h (class all_objfiles): Remove.
16212 * objfiles.c (have_partial_symbols, have_full_symbols)
16213 (have_minimal_symbols, qsort_cmp, update_section_map)
16214 (shared_objfile_contains_address_p)
16215 (default_iterate_over_objfiles_in_search_order): Update.
16216 * objc-lang.c (info_selectors_command, info_classes_command)
16217 (find_methods): Update.
16218 * minsyms.c (find_solib_trampoline_target): Update.
16219 * maint.c (maintenance_info_sections)
16220 (maintenance_translate_address, count_symtabs_and_blocks):
16221 Update.
16222 * main.c (captured_main_1): Update.
16223 * linux-thread-db.c (try_thread_db_load_from_pdir)
16224 (has_libpthread): Update.
16225 * linespec.c (iterate_over_all_matching_symtabs)
16226 (search_minsyms_for_name): Update.
16227 * jit.c (jit_find_objf_with_entry_addr): Update.
16228 * hppa-tdep.c (find_unwind_entry)
16229 (hppa_lookup_stub_minimal_symbol): Update.
16230 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16231 Update.
16232 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16233 (elf_gnu_ifunc_resolve_by_got): Update.
16234 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16235 * dwarf-index-write.c (save_gdb_index_command): Update.
16236 * cp-support.c (add_symbol_overload_list_qualified): Update.
16237 * breakpoint.c (create_overlay_event_breakpoint)
16238 (create_longjmp_master_breakpoint)
16239 (create_std_terminate_master_breakpoint)
16240 (create_exception_master_breakpoint): Update.
16241 * blockframe.c (find_pc_partial_function): Update.
16242 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16243 (ada_collect_symbol_completion_matches)
16244 (ada_add_global_exceptions): Update.
16245
776489e0
TT
162462019-01-17 Tom Tromey <tom@tromey.com>
16247
16248 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16249 declare VEC.
16250 (solib_target_parse_libraries): Change return type.
16251 (library_list_start_segment, library_list_start_section)
16252 (library_list_end_library, library_list_start_library); Update.
16253 (solib_target_free_library_list): Remove.
16254 (solib_target_parse_libraries): Remove cleanup. Change return
16255 type.
16256 (solib_target_current_sos): Update.
16257
6471e7d2
TT
162582019-01-17 Tom Tromey <tromey@bapiya>
16259
16260 * valprint.c: Replace "the the" with "the".
16261 * symtab.c: Replace "the the" with "the".
16262 * solib.c: Replace "the the" with "the".
16263 * solib-dsbt.c: Replace "the the" with "the".
16264 * linespec.c: Replace "the the" with "the".
16265 * dwarf2loc.h: Replace "the the" with "the".
16266 * amd64-windows-tdep.c: Replace "the the" with "the".
16267 * aarch64-tdep.c: Replace "the the" with "the".
16268
c24bdb02
KS
162692019-01-16 Keith Seitz <keiths@redhat.com>
16270
16271 PR gdb/23773
16272 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16273 <builder>: Rename to ..
16274 <m_builder>: ... this and make private.
16275 (dwarf2_cu::get_builder): New method. Change all users of
16276 `builder' to use this method.
16277 (dwarf2_start_symtab): Move to ...
16278 (dwarf2_cu::start_symtab): ... here. Update all callers
16279 (setup_type_unit_groups): Move to ...
16280 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16281 callers.
16282 (dwarf2_cu::reset_builder): New method.
16283 (process_full_compunit, process_full_type_unit): Use
16284 dwarf2_cu::reset_builder.
16285 (follow_die_offset): Record the ancestor CU if it is different
16286 from the followed DIE's CU.
16287 (follow_die_sig_1): Likewise.
16288
8d64371b
TT
162892019-01-15 Tom Tromey <tom@tromey.com>
16290
16291 * remote.c (class remote_state) <buf>: Now a char_vector.
16292 <buf_size>: Remove.
16293 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16294 parameter.
16295 (remote_target::getpkt_or_notif_sane_1)
16296 (remote_target::getpkt_sane)
16297 (remote_target::getpkt_or_notif_sane): Likewise.
16298 (class remote_target) <putpkt>: New overload.
16299 (remote_target::read_frame): Change type of "buf_p". Remove
16300 sizeof_p parameter.
16301 (packet_ok): New overload.
16302 (packet_check_result): New overload.
16303 Update all uses.
16304
bb277751
TT
163052019-01-14 Tom Tromey <tom@tromey.com>
16306
16307 * remote-notif.c (handle_notification, remote_notif_ack)
16308 (remote_notif_parse): Make "buf" const.
16309 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16310 const.
16311 (remote_notif_parse, remote_notif_ack, handle_notification):
16312 Likewise.
16313 * remote.c (remote_notif_stop_parse): Make "buf" const.
16314 (remote_target::remote_parse_stop_reply): Make "buf" const.
16315 (remote_notif_stop_ack): Make "buf" const.
16316
05be00a8
TT
163172019-01-14 Tom Tromey <tom@tromey.com>
16318
16319 * remote.c (remote_console_output): Make parameter const.
16320
491adeca
TT
163212019-01-14 Tom Tromey <tom@tromey.com>
16322
16323 * target-debug.h (target_debug_print_signals): Constify.
16324 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16325 * procfs.c (procfs_target::pass_signals): Update.
16326 * linux-nat.c (linux_nat_target::pass_signals): Update.
16327 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16328 * target-delegates.c: Rebuild.
16329 * remote.c (remote_target::program_signals): Update.
16330 (remote_target::pass_signals): Update.
16331 * target.c (target_pass_signals): Constify argument.
16332 (target_program_signals): Likewise.
16333 * target.h (struct target_ops) <pass_signals, program_signals>:
16334 Constify argument.
16335 (target_pass_signals, target_program_signals): Constify argument.
16336
bbd94648
TT
163372019-01-14 Tom Tromey <tom@tromey.com>
16338
16339 PR tui/28819:
16340 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16341
6f072a10
PFC
163422019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16343
16344 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16345 field.
16346 * rs6000-tdep.c: Include reggroups.h.
16347 (IS_V_ALIAS_PSEUDOREG): Define.
16348 (rs6000_register_name): Return names for the "vX" aliases.
16349 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16350 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16351 aliases. Call default_register_reggroup_p for all other
16352 pseudo-registers.
16353 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16354 New functions.
16355 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16356 Handle "vX" aliases.
16357 (v_alias_pseudo_register_collect): New function.
16358 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16359 (rs6000_gdbarch_init): Initialize "vX" aliases as
16360 pseudo-registers. Restore registration of
16361 rs6000_pseudo_register_reggroup_p with
16362 set_tdesc_pseudo_register_reggroup_p.
16363
1a782351
MF
163642019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16365
16366 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16367 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16368 set_gdbarch_num_pseudo_regs.
16369
d73cff18
PW
163702019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16371
16372 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16373 Remove arg prefixname, add do_set and do_show.
16374 Add member functions set_list and show_list.
16375 * cli/cli-style.c (class cli_style_option): Update accordingly.
16376 (style_set_list): Move to file scope.
16377 (style_show_list): Likewise.
16378 (set_style): Call help_list.
16379 (show_style): Call cmd_show_list.
16380 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16381 Update to use the new macro.
16382
60a90376
JB
163832019-10-12 Joel Brobecker <brobecker@adacore.com>
16384
16385 * ada-lang.c (_initialize_ada_language): Expand the help text
16386 for the "catch exception" command.
16387
9d7c67bf
PW
163882019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16389
16390 * symtab.c (matching_obj_sections): Initialize obj,
16391 declare it closer to its usage.
16392
7cf47dc4
TT
163932019-01-10 Tom Tromey <tom@tromey.com>
16394
16395 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16396 (basic_inf_threads_range): Remove.
16397 (inf_threads_range, inf_non_exited_threads_range)
16398 (safe_inf_threads_range): Use next_adapter.
16399
d3cb6808
KS
164002019-01-10 Keith Seitz <keiths@redhat.com>
16401
16402 PR gdb/23712
16403 PR symtab/23010
16404 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16405 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16406
63a20375
KS
164072019-01-10 Keith Seitz <keiths@redhat.com>
16408
16409 PR gdb/23712
16410 PR symtab/23010
16411 * dictionary.c (pending_to_vector): Remove.
16412 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16413 Remove _1 suffix, replacing functions of the same name. Update
16414 all callers.
16415 (dict_create_hashed, dict_create_hashed_expandable)
16416 (dict_create_linear, dict_create_linear_expandable, dict_free)
16417 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16418 Make functions static.
16419
b026f593
KS
164202019-01-10 Keith Seitz <keiths@redhat.com>
16421
16422 PR gdb/23712
16423 PR symtab/23010
16424 * dictionary.h (struct dictionary): Replace declaration with
16425 multidictionary.
16426 (dict_create_hashed, dict_create_hashed_expandable)
16427 (dict_create_linear, dict_create_linear_expandable)
16428 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16429 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16430 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16431 taking multidictionary argument.
16432 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16433 * block.h (struct block) <dict>: Change to multidictionary
16434 and rename `multidict'.
16435 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16436 symmisc.c: Update all dictionary references to multidictionary.
16437
c7748ee9
KS
164382019-01-10 Keith Seitz <keiths@redhat.com>
16439
16440 PR gdb/23712
16441 PR symtab/23010
16442 * dictionary.c: Include unordered_map.
16443 (pending_to_vector): New function.
16444 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16445 Rewrite the non-"_1" functions to take vector instead
16446 of linked list.
16447 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16448 "new" _1 versions of the same name.
16449 (multidictionary): Define.
16450 (std::hash<enum language): New definition.
16451 (collate_pending_symbols_by_language, mdict_create_hashed)
16452 (mdict_create_hashed_expandable, mdict_create_linear)
16453 (mdict_create_linear_expandable, mdict_free)
16454 (find_language_dictionary, create_new_language_dictionary)
16455 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16456 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16457 (mdict_size, mdict_empty): New functions.
16458 * dictionary.h (mdict_iterator): Define.
16459
67aa1f3c
PA
164602019-01-10 Pedro Alves <palves@redhat.com>
16461
16462 * breakpoint.c (read_uploaded_action)
16463 (create_tracepoint_from_upload): Adjust to use
16464 gdb::unique_xmalloc_ptr.
16465 * ctf.c (ctf_write_uploaded_tp):
16466 (SET_ARRAY_FIELD): Use emplace_back.
16467 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16468 * tracefile-tfile.c (tfile_write_uploaded_tp):
16469 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16470 gdb::unique_xmalloc_ptr.
16471 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16472 at_string, cond_string, cmd_strings>: Replace char pointers
16473 with gdb::unique_xmalloc_ptr.
16474
2f667667
PA
164752019-01-10 Pedro Alves <palves@redhat.com>
16476
16477 * solib-target.c (library_list_start_library): Don't xstrdup name.
16478
36cb7237
PA
164792019-01-10 Pedro Alves <palves@redhat.com>
16480
16481 * mdebugread.c (parse_partial_symbols): Use
16482 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16483
da584958
AB
164842019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16485
16486 * linux-fork.c (scoped_switch_fork_info)
16487 <~scoped_switch_fork_info>: Fix incorrect variable name.
16488
1ef8573c
AB
164892019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16490
16491 * linux-fork.c (scoped_switch_fork_info)
16492 <scoped_switch_fork_info>: Make explicit.
16493 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16494
8d7bcccb
TT
164952019-01-10 Tom Tromey <tom@tromey.com>
16496
16497 * objfiles.h (objfile::reset_psymtabs): Update.
16498 * objfiles.c (objfile::objfile): Update.
16499 * psymtab.h (psymtab_storage::obstack): Update.
16500 (psymtab_storage::m_obstack): Use gdb::optional.
16501 (class psymtab_storage): Update comment. Remove objfile
16502 parameter.
16503 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16504
b596a3c7
TT
165052019-01-10 Tom Tromey <tom@tromey.com>
16506
16507 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16508 <free_psymtabs>: Now private.
16509 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16510 (allocate_psymtab): Use new method.
16511
a9342b62
TT
165122019-01-10 Tom Tromey <tom@tromey.com>
16513
16514 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16515 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16516 * mdebugread.c (parse_partial_symbols): Use
16517 allocate_dependencies.
16518 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16519 allocate_dependencies.
16520 (process_psymtab_comp_unit_reader)
16521 (build_type_psymtab_dependencies): Likewise.
16522 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16523
5af70966
TT
165242019-01-10 Tom Tromey <tom@tromey.com>
16525
16526 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16527 PSYMBOL_SET_LANGUAGE.
16528 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16529
5923a04c
TT
165302019-01-10 Tom Tromey <tom@tromey.com>
16531
16532 * psymtab.h (psymtab_storage::obstack): New method.
16533 <m_obstack>: Rename from obstack; now private.
16534 * psymtab.c (psymtab_storage): Update.
16535 * dwarf2read.c (create_addrmap_from_index)
16536 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16537 Update.
16538
6d6a12bf
TT
165392019-01-10 Tom Tromey <tom@tromey.com>
16540
16541 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16542 * objfiles.h (objfile::reset_psymtabs): New method.
16543
d320c2b5
TT
165442019-01-10 Tom Tromey <tom@tromey.com>
16545
16546 * symmisc.c (print_symbol_bcache_statistics): Update.
16547 (print_objfile_statistics): Update.
16548 * symfile.c (reread_symbols): Update.
16549 * psymtab.h (class psymtab_storage): New.
16550 * psymtab.c (psymtab_storage): New constructor.
16551 (~psymtab_storage): New destructor.
16552 (require_partial_symbols): Update.
16553 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16554 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16555 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16556 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16557 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16558 (start_psymtab_common, end_psymtab_common)
16559 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16560 (allocate_psymtab): Update.
16561 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16562 Update.
16563 (dump_psymtab_addrmap, maintenance_print_psymbols)
16564 (maintenance_check_psymtabs): Update.
16565 (class objfile_psymtabs): Move to objfiles.h.
16566 * psympriv.h (discard_psymtab): Now inline.
16567 (psymtab_discarder::psymtab_discarder): Update.
16568 (psymtab_discarder::~psymtab_discarder): Update.
16569 (ALL_OBJFILE_PSYMTABS): Rewrite.
16570 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16571 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16572 Remove fields.
16573 <partial_symtabs>: New field.
16574 (class objfile_psymtabs): Move from psymtab.h. Update.
16575 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16576 psymbol_cache.
16577 (objfile::~objfile): Don't destroy psymbol_cache.
16578 * mdebugread.c (parse_partial_symbols): Update.
16579 * dwarf2read.c (create_addrmap_from_index)
16580 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16581 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16582 (add_partial_subprogram, dwarf2_ranges_read): Update.
16583 * dwarf-index-write.c (write_address_map)
16584 (write_one_signatured_type, recursively_write_psymbols)
16585 (class debug_names, class debug_names, write_psymtabs_to_index):
16586 Update.
16587
1d94a5a3
TT
165882019-01-10 Tom Tromey <tom@tromey.com>
16589
16590 * symtab.h (SYMBOL_SET_NAMES): Update.
16591 (symbol_set_names): Update.
16592 (MSYMBOL_SET_NAMES): Update.
16593 * symtab.c (symbol_set_names): Change argument to be an
16594 objfile_per_bfd_storage.
16595 * psymtab.c (add_psymbol_to_bcache): Update.
16596 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16597
0f14768a
TT
165982019-01-10 Tom Tromey <tom@tromey.com>
16599
16600 * symtab.c (create_demangled_names_hash): Change argument to be an
16601 objfile_per_bfd_storage.
16602 (symbol_set_names): Update.
16603
6eee24ce
TT
166042019-01-10 Tom Tromey <tom@tromey.com>
16605
16606 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16607 init_psymbol_list.
16608 * psymtab.c (init_psymbol_list): Do nothing if already called.
16609 * psympriv.h (init_psymbol_list): Add comment.
16610 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16611 init_psymbol_list.
16612 * dbxread.c (dbx_symfile_read): Unconditionally call
16613 init_psymbol_list.
16614
75aedd27
TT
166152019-01-10 Tom Tromey <tom@tromey.com>
16616
16617 * xcoffread.c (scan_xcoff_symtab): Update.
16618 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16619 "where".
16620 * mdebugread.c (parse_partial_symbols)
16621 (handle_psymbol_enumerators): Update.
16622 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16623 * dbxread.c (read_dbx_symtab): Update.
16624 * psympriv.h (psymbol_placement): New enum.
16625 (add_psymbol_to_list): Update.
16626
939652a5
TT
166272019-01-10 Tom Tromey <tom@tromey.com>
16628
16629 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16630 static_psymbols parameters.
16631 (scan_xcoff_symtab): Update.
16632 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16633 static_psymbols parameters.
16634 * psympriv.h (start_psymtab_common): Update.
16635 * mdebugread.c (parse_partial_symbols): Update.
16636 * dwarf2read.c (create_partial_symtab): Update.
16637 * dbxread.c (read_dbx_symtab): Update.
16638 (start_psymtab): Remove global_psymbols and static_psymbols
16639 parameters.
16640
baa62830
TT
166412019-01-10 Tom Tromey <tom@tromey.com>
16642
16643 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16644 * psymtab.c (allocate_psymtab): Add comment.
16645 * psympriv.h (allocate_psymtab): Add comment.
16646 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16647 initializations.
16648 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16649
0e8f53ba
TT
166502019-01-10 Tom Tromey <tom@tromey.com>
16651
16652 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16653 Don't declare.
16654 * mipsread.c: Include mdebugread.h.
16655 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16656 Declare.
16657 * elfread.c: Include mdebugread.h.
16658
b22a7c6a
TT
166592019-01-09 Tom Tromey <tom@tromey.com>
16660
16661 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16662 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16663 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16664 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16665 (psym_lookup_symbol, psym_find_last_source_symtab)
16666 (psym_forget_cached_source_info, psym_print_stats)
16667 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16668 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16669 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16670 (psym_find_compunit_symtab_by_address)
16671 (maintenance_print_psymbols, maintenance_info_psymtabs)
16672 (maintenance_check_psymtabs): Use ranged for.
16673 * psymtab.h (class objfile_psymtabs): New.
16674 (require_partial_symbols): Return objfile_psymtabs.
16675 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16676
3b9d3ac2
TT
166772019-01-09 Tom Tromey <tom@tromey.com>
16678
16679 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16680 (find_pc_mapped_section, list_overlays_command)
16681 (map_overlay_command, unmap_overlay_command)
16682 (simple_overlay_update): Use all_objfiles.
16683 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16684 * printcmd.c (info_symbol_command): Use all_objfiles.
16685 * objfiles.h (ALL_OBJSECTIONS): Remove.
16686 * maint.c (maintenance_translate_address): Use all_objfiles.
16687 * gcore.c (gcore_create_callback): Use all_objfiles.
16688 (objfile_find_memory_regions): Likewise.
16689
8b31193a
TT
166902019-01-09 Tom Tromey <tom@tromey.com>
16691
16692 * symtab.c (find_line_symtab, info_sources_command)
16693 (make_source_files_completion_list): Use objfile_compunits.
16694 * source.c (select_source_symtab): Use objfile_compunits.
16695 * objfiles.h (struct objfile): Update comment.
16696 (ALL_OBJFILES): Remove.
16697 (ALL_FILETABS): Remove.
16698 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16699 objfile_compunits.
16700
d5da8b3c
TT
167012019-01-09 Tom Tromey <tom@tromey.com>
16702
16703 * symmisc.c (print_objfile_statistics, dump_objfile)
16704 (maintenance_print_symbols): Use compunit_filetabs.
16705 * source.c (forget_cached_source_info_for_objfile): Use
16706 compunit_filetabs.
16707 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16708 (ALL_FILETABS): Use compunit_filetabs.
16709 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16710 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16711
5accd1a0
TT
167122019-01-09 Tom Tromey <tom@tromey.com>
16713
16714 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16715 (compunit_filetabs): New.
16716 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16717 compunit_filetabs.
16718 (info_sources_command, make_source_files_completion_list): Remove
16719 declaration.
16720 * symmisc.c (print_objfile_statistics, dump_objfile)
16721 (maintenance_print_symbols): Remove declaration.
16722 (maintenance_info_symtabs): Use compunit_filetabs.
16723 (maintenance_info_line_tables): Likewise.
16724 * source.c (select_source_symtab): Change local variable name.
16725 (forget_cached_source_info_for_objfile): Remove declaration.
16726 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16727 * objfiles.c (objfile_relocate1): Remove declaration.
16728 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16729 declaration.
16730 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16731 * coffread.c (coff_symtab_read): Remove declaration.
16732 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16733 compunit_filetabs.
16734
d8aeb77f
TT
167352019-01-09 Tom Tromey <tom@tromey.com>
16736
16737 * symtab.c (lookup_objfile_from_block)
16738 (find_pc_sect_compunit_symtab, search_symbols)
16739 (default_collect_symbol_completion_matches_break_on): Use
16740 objfile_compunits.
16741 * objfiles.h (ALL_COMPUNITS): Remove.
16742 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16743 * cp-support.c (add_symbol_overload_list_qualified): Use
16744 objfile_compunits.
16745 * ada-lang.c (ada_collect_symbol_completion_matches)
16746 (ada_add_global_exceptions): Use objfile_compunits.
16747
592553c4
TT
167482019-01-09 Tom Tromey <tom@tromey.com>
16749
16750 * source.c (select_source_symtab)
16751 (forget_cached_source_info_for_objfile): Remove declaration.
16752 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16753 declaration.
16754 * maint.c (count_symtabs_and_blocks): Remove declaration.
16755 * cp-support.c (add_symbol_overload_list_qualified): Remove
16756 declaration.
16757 * coffread.c (coff_symtab_read): Remove declaration.
16758 * symtab.c (lookup_symbol_in_objfile_symtabs)
16759 (basic_lookup_transparent_type_1): Use objfile_compunits.
16760 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16761 (info_sources_command, search_symbols)
16762 (default_collect_symbol_completion_matches_break_on)
16763 (make_source_files_completion_list): Remove declaration.
16764 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16765 (ada_collect_symbol_completion_matches)
16766 (ada_add_global_exceptions): Remove declaration.
16767 * linespec.c (iterate_over_all_matching_symtabs): Use
16768 objfile_compunits.
16769 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16770 (class objfile_compunits): New.
16771 (ALL_COMPUNITS): Use objfile_compunits.
16772 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16773 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16774 objfile_compunits.
16775 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16776
5325b9bf
TT
167772019-01-09 Tom Tromey <tom@tromey.com>
16778
16779 * symtab.c (search_symbols)
16780 (default_collect_symbol_completion_matches_break_on): Use
16781 objfile_msymbols.
16782 * ada-lang.c (ada_lookup_simple_minsym)
16783 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16784 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16785 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16786 objfile_msymbols.
16787 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16788 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16789 * objc-lang.c (find_methods): Use objfile_msymbols.
16790 (info_selectors_command, info_classes_command): Likewise.
16791 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16792 * objfiles.h (class objfile_msymbols): New.
16793 (ALL_OBJFILE_MSYMBOLS): Remove.
16794 (ALL_MSYMBOLS): Remove.
16795
cac85af2
TT
167962019-01-09 Tom Tromey <tom@tromey.com>
16797
16798 * common/next-iterator.h (next_adapter): Add Iterator template
16799 parameter.
16800 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16801 (class all_objfiles_safe): New.
16802 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16803 * objfiles.c (put_objfile_before): Update comment.
16804 (add_separate_debug_objfile): Likewise.
16805 (free_all_objfiles): Use all_objfiles_safe.
16806 (objfile_purge_solibs): Likewise.
16807
aed57c53
TT
168082019-01-09 Tom Tromey <tom@tromey.com>
16809
16810 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16811 (expand_symtab_containing_pc, lookup_static_symbol)
16812 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16813 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16814 all_objfiles.
16815 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16816 * breakpoint.c (create_overlay_event_breakpoint)
16817 (create_longjmp_master_breakpoint)
16818 (create_std_terminate_master_breakpoint)
16819 (create_exception_master_breakpoint): Use all_objfiles.
16820 * linux-thread-db.c (try_thread_db_load_from_pdir)
16821 (has_libpthread): Use all_objfiles.
16822 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16823 * linespec.c (iterate_over_all_matching_symtabs)
16824 (search_minsyms_for_name): Use all_objfiles.
16825 * maint.c (maintenance_info_sections): Use all_objfiles.
16826 * main.c (captured_main_1): Use all_objfiles.
16827 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16828 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16829 * guile/scm-pretty-print.c
16830 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16831 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16832 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16833 (maintenance_print_msymbols): Use all_objfiles.
16834 * source.c (select_source_symtab): Use all_objfiles.
16835 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16836 * symfile.c (remove_symbol_file_command)
16837 (expand_symtabs_matching, map_symbol_filenames): Use
16838 all_objfiles.
16839 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16840 all_objfiles.
16841 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16842 * objc-lang.c (find_methods): Use all_objfiles.
16843 * objfiles.c (have_partial_symbols, have_full_symbols)
16844 (have_minimal_symbols, qsort_cmp)
16845 (default_iterate_over_objfiles_in_search_order): Use
16846 all_objfiles.
16847 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16848 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16849 (maintenance_check_psymtabs): Use all_objfiles.
16850 (ALL_PSYMTABS): Remove.
16851 * compile/compile-object-run.c (do_module_cleanup): Use
16852 all_objfiles.
16853 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16854 * cp-support.c (add_symbol_overload_list_qualified): Use
16855 all_objfiles.
16856 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16857 Use all_objfiles.
16858 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16859 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16860 all_objfiles.
16861 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16862 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16863 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16864 Uses all_objfiles.
16865 * solib.c (solib_read_symbols): Use all_objfiles
16866
99d89cde
TT
168672019-01-09 Tom Tromey <tom@tromey.com>
16868
16869 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16870 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16871 all_objfiles.
16872 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16873 * symmisc.c (print_symbol_bcache_statistics)
16874 (print_objfile_statistics, maintenance_print_objfiles)
16875 (maintenance_info_symtabs, maintenance_check_symtabs)
16876 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16877 all_objfiles.
16878 * source.c (forget_cached_source_info): Use all_objfiles.
16879 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16880 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16881 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16882 * objfiles.c (update_section_map): Use all_objfiles.
16883 (shared_objfile_contains_address_p): Likewise.
16884 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16885 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16886
21708325
TT
168872019-01-09 Tom Tromey <tom@tromey.com>
16888
16889 * common/next-iterator.h: New file.
16890 * objfiles.h (class all_objfiles): New.
16891 (struct objfile_iterator): New.
16892
669e09f6
PW
168932019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16894
16895 * NEWS: Move the description of the changed "frame", "select-frame",
16896 and "info frame" commands to the Changed commands section.
16897
041be526
SM
168982019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16899
16900 * gdbtypes.c (check_stub_method_group): Remove handling of old
16901 mangling schemes.
16902 * linespec.c (find_methods): Likewise.
16903 * stabsread.c (read_member_functions): Likewise.
16904 * valops.c (search_struct_method): Likewise.
16905 (value_struct_elt_for_reference): Likewise.
16906 * NEWS: Mention this change.
16907
0e2a2133
AB
169082019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16909
16910 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16911 print_source_lines.
16912 * source.c (print_source_lines_base): Update line number check.
16913 (print_source_lines): New function.
16914 (source_lines_range::source_lines_range): New function.
16915 * source.h (class source_lines_range): New class.
16916 (print_source_lines): New declaration.
16917
1055a3b4
PW
169182019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16919
16920 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16921
cfeadda5
TT
169222019-01-08 Tom Tromey <tom@tromey.com>
16923 Simon Marchi <simon.marchi@ericsson.com>
16924
16925 PR gdb/24060
16926 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16927 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16928 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16929 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16930 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16931 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16932
583068ca
AB
169332019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16934
16935 * source.c (select_source_symtab): Move header comment to
16936 declaration in source.h.
16937 (forget_cached_source_info_for_objfile): Likewise.
16938 (forget_cached_source_info): Likewise.
16939 (identify_source_line): Likewise.
16940 * source.h (identify_source_line): Move declaration from symtab.h
16941 and add comment from source.c
16942 (print_source_lines): Likewise.
16943 (forget_cached_source_info_for_objfile): Likewise.
16944 (forget_cached_source_info): Likewise.
16945 (select_source_symtab): Likewise.
16946 (enum print_source_lines_flag): Move definition from symtab.h.
16947 * symtab.h (identify_source_line): Move declaration to source.h.
16948 (print_source_lines): Likewise.
16949 (forget_cached_source_info_for_objfile): Likewise.
16950 (forget_cached_source_info): Likewise.
16951 (select_source_symtab): Likewise.
16952 (enum print_source_lines_flag): Move definition to source.h.
16953 * tui/tui-hooks.c: Add 'source.h' include.
16954
ec98a4ad
AB
169552019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16956
16957 * source.c (print_source_lines_base): Handle requests to print
16958 reverse line number sequences, and guard against empty lines
16959 string.
16960
62ea19c1
AB
169612019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16962
16963 * source.c (print_source_lines_base): Fix skip of '\r' if next
16964 character is '\n'.
16965
9d30e1fd
TT
169662019-01-06 Tom Tromey <tom@tromey.com>
16967
16968 * c-exp.y (struct c_parse_state) <macro_original_text,
16969 expansion_obstack>: New member.
16970 (macro_original_text, expansion_obstack): Remove globals.
16971 (scan_macro_expansion, scanning_macro_expansion)
16972 (finished_macro_expansion): Update.
16973 (scan_macro_cleanup): Remove.
16974 (yylex, c_parse): Update.
16975
c65bac38
TT
169762019-01-06 Tom Tromey <tom@tromey.com>
16977
16978 * c-exp.y (struct c_parse_state) <strings>: New member.
16979 (operator_stoken): Update.
16980
02e12e38
TT
169812019-01-06 Tom Tromey <tom@tromey.com>
16982
16983 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16984 (union type_stack_elt) <typelist_val>: Now a pointer to
16985 std::vector.
16986 (type_stack_cleanup): Don't declare.
16987 (push_typelist): Update.
16988 * parse.c (pop_typelist): Return a std::vector.
16989 (push_typelist): Take a std::vector.
16990 (follow_types): Update. Do not free args.
16991 (type_stack_cleanup): Remove.
16992 * c-exp.y (struct c_parse_state): New.
16993 (cpstate): New global.
16994 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16995 (nonempty_typelist): Update.
16996 (func_mod): Create a new vector.
16997 (c_parse): Create a c_parse_state.
16998 (check_parameter_typelist): Do not delete params.
16999 (function_method): Update. Do not delete type_list.
17000
f097f5ad
TT
170012019-01-06 Tom Tromey <tom@tromey.com>
17002
17003 PR gdb/28155:
17004 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
17005 check_typedef.
17006 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
17007 (print_return_value): Likewise.
17008
d2adf9f1
TT
170092019-01-05 Tom Tromey <tom@tromey.com>
17010
17011 * contrib/cleanup_check.py: Remove.
17012 * contrib/gcc-with-excheck: Remove.
17013 * contrib/exsummary.py: Remove.
17014 * contrib/excheck.py: Remove.
17015
2eab46b1
JB
170162019-01-05 Joel Brobecker <brobecker@adacore.com>
17017
17018 * thread.c (delete_thread_1): Add gdb_assert that THR is not
17019 NULL. Initialize tpprev to NULL instead of assigning it
17020 to NULL on the next statement.
17021 * windows-nat.c (windows_delete_thread): Remove check for
17022 main_thread_id before printing thread exit notifications.
17023 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17024 Remove thread ID check against main_thread_id.
17025 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17026 windows_delete_thread.
17027 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17028
48c5e7e2
TT
170292019-01-04 Tom Tromey <tom@tromey.com>
17030
17031 * compile/compile.c (_initialize_compile): Use upper case for
17032 metasyntactic variables.
17033 * symmisc.c (_initialize_symmisc): Use upper case for
17034 metasyntactic variables.
17035 * psymtab.c (_initialize_psymtab): Use upper case for
17036 metasyntactic variables.
17037 * demangle.c (demangle_command): Use upper case for metasyntactic
17038 variables.
17039 (_initialize_demangler): Likewise.
17040 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17041 variables.
17042
986041cd
TT
170432019-01-03 Tom Tromey <tom@tromey.com>
17044
17045 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17046
7c711119
TT
170472019-01-03 Tom Tromey <tom@tromey.com>
17048
17049 * python/py-symtab.c (salpy_str): Update.
17050 (struct salpy_sal_object) <symtab>: Now a PyObject.
17051 (salpy_dealloc): Update.
17052 (del_objfile_sal): Use gdbpy_ref.
17053
1b20edf0
TT
170542019-01-03 Tom Tromey <tom@tromey.com>
17055
17056 * python/py-type.c (convert_field): Use new_reference. Return
17057 gdbpy_ref.
17058 (make_fielditem): Return gdbpy_ref.
17059 (typy_fields): Update.
17060 (typy_getitem): Update.
17061 (field_name): Return gdbpy_ref. Use new_reference.
17062 (typy_iterator_iternext): Update.
17063
ea41325b
TT
170642019-01-03 Tom Tromey <tom@tromey.com>
17065
17066 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17067
2a3c71d6
TT
170682019-01-03 Tom Tromey <tom@tromey.com>
17069
17070 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17071 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17072 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17073 (pspy_set_frame_filters, pspy_set_frame_unwinders)
17074 (pspy_set_type_printers): Likewise.
17075 * python/py-function.c (fnpy_init): Use gdbpy_ref.
17076 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17077 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17078 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17079 (objfpy_set_type_printers): Likewise.
17080
5c329e6a
TT
170812019-01-03 Tom Tromey <tom@tromey.com>
17082
17083 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17084 (gdbpy_print_stack): Use gdbpy_err_fetch.
17085 * python/python-internal.h (class gdbpy_err_fetch): New class.
17086 (class gdbpy_enter) <m_error_type, m_error_value,
17087 m_error_traceback>: Remove.
17088 <m_error>: New member.
17089 (gdbpy_exception_to_string): Don't declare.
17090 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17091 * python/py-value.c (convert_value_from_python): Use
17092 gdbpy_err_fetch.
17093 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17094 gdbpy_exception_to_string.
17095 (gdbpy_handle_exception): Use gdbpy_err_fetch.
17096 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17097 gdbpy_err_fetch.
17098
169bb27b
AB
170992019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17100
17101 * linux-nat.c (delete_lwp_cleanup): Delete.
17102 (struct lwp_deleter): New struct.
17103 (lwp_info_up): New typedef.
17104 (linux_nat_target::follow_fork): Delete cleanup, and make use of
17105 lwp_info_up.
17106
a07c8880
AB
171072019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17108
17109 * linux-fork.c (class scoped_switch_fork_info): New class.
17110 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17111
26089c49
AB
171122019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17113
17114 * valops.c (find_overload_match): Remove use of null_cleanup, and
17115 calls to do_cleanups.
17116
06d3e5b0
AB
171172019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17118
17119 * compile/compile-cplus-types.c
17120 (compile_cplus_instance::decl_name): Handle changes to
17121 cp_func_name.
17122 * cp-support.c (cp_func_name): Update header comment, update
17123 return type.
17124 * cp-support.h (cp_func_name): Update return type in declaration.
17125 * valops.c (find_overload_match): Move temp_func local to top
17126 level of function and change its type. Use temp_func to hold and
17127 delete temporary string obtained from cp_func_name.
17128
66644cd3
AB
171292019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17130
17131 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17132 gdb::char_vector, remove cleanup, and update uses of `msg`.
17133
592d8c0a
JW
171342019-01-03 Jim Wilson <jimw@sifive.com>
17135
17136 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17137
c55d06ec
TT
171382019-01-02 Tom Tromey <tom@tromey.com>
17139
17140 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17141 (tdesc_parse_xml): Remove cleanups.
17142 * target-descriptions.h (make_cleanup_free_target_description):
17143 Don't declare.
17144 (target_desc_deleter): New struct.
17145 (target_desc_up): New typedef.
17146 * target-descriptions.c (target_desc_deleter::operator()): Rename
17147 from free_target_description.
17148 (make_cleanup_free_target_description): Remove.
17149
3a6ae42d
TT
171502019-01-02 Tom Tromey <tom@tromey.com>
17151
17152 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17153 constructor, destructor.
17154 (linespec_parser): Remove typedef.
17155 (~linespec_parser): Rename from linespec_parser_delete.
17156 (linespec_lex_to_end, linespec_complete_label)
17157 (linespec_complete): Update.
17158 (decode_line_full): Remove cleanups.
17159 (decode_line_1): Update.
17160
61fd3e73
TT
171612019-01-02 Tom Tromey <tom@tromey.com>
17162
17163 * python/python-internal.h (inferior_to_inferior_object): Change
17164 return type.
17165 * python/py-exitedevent.c (create_exited_event_object): Update.
17166 * python/py-inferior.c (inferior_to_inferior_object): Return
17167 gdbpy_ref.
17168 (python_new_inferior, python_inferior_deleted)
17169 (thread_to_thread_object, delete_thread_object)
17170 (build_inferior_list, gdbpy_selected_inferior): Update.
17171 * python/py-infthread.c (create_thread_object): Update. Also fail
17172 if inferior_to_inferior_object fails.
17173
d20172fc
SM
171742019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17175
17176 * inferior.h (class inferior) <displaced_step_state>: New field.
17177 * infrun.h (struct displaced_step_state): Move here from
17178 infrun.c. Initialize fields, add constructor.
17179 <inf>: Remove field.
17180 <reset>: New method.
17181 * infrun.c (struct displaced_step_inferior_state): Move to
17182 infrun.h.
17183 (displaced_step_inferior_states): Remove.
17184 (get_displaced_stepping_state): Adust.
17185 (displaced_step_in_progress_any_inferior): Adjust.
17186 (displaced_step_in_progress_thread): Adjust.
17187 (displaced_step_in_progress): Adjust.
17188 (add_displaced_stepping_state): Remove.
17189 (get_displaced_step_closure_by_addr): Adjust.
17190 (remove_displaced_stepping_state): Remove.
17191 (infrun_inferior_exit): Call displaced_step_state.reset.
17192 (use_displaced_stepping): Don't check for NULL.
17193 (displaced_step_prepare_throw): Call
17194 get_displaced_stepping_state.
17195 (displaced_step_fixup): Don't check for NULL.
17196 (prepare_for_detach): Don't check for NULL.
17197
e3319240
PW
171982019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17199
17200 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17201 in case of call that did not complete.
17202
5d36dfb9
AU
172032019-01-02 Andrey Utkin <autkin@undo.io>
17204
17205 * symfile.c (find_separate_debug_file): Fix search of debug files for
17206 remote debuggee.
17207
8833fbf0
TT
172082019-01-02 Tom Tromey <tom@tromey.com>
17209
17210 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17211 indentation.
17212 * python/py-frame.c (frapy_older): Remove cast.
17213 (frapy_newer): Likewise.
17214 * python/py-breakpoint.c (local_setattro): Remove cast.
17215 * python/py-arch.c (archpy_name): Remove local variable.
17216 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17217
4ada3dfd
JB
172182019-01-02 Joel Brobecker <brobecker@adacore.com>
17219
17220 * unittests/basic_string_view/element_access/char/empty.cc:
17221 Fix year range in copyright header.
17222
113b7b81
AB
172232019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17224
17225 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17226 Delete.
17227 <operator==>: Update with for removed field.
17228 <hash>: Likewise.
17229 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17230 <isa_features>: ...this.
17231 <abi_features>: New field.
17232 (riscv_isa_flen): Update comment.
17233 (riscv_abi_xlen): New declaration.
17234 (riscv_abi_flen): New declaration.
17235 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17236 isa_features.
17237 (riscv_abi_xlen): New function.
17238 (riscv_isa_flen): Update to get answer from isa_features.
17239 (riscv_abi_flen): New function.
17240 (riscv_has_fp_abi): Update to get answer from abi_features.
17241 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17242 xlen and flen.
17243 (riscv_call_info) <xlen, flen>: Update comment.
17244 (riscv_call_arg_struct): Remove invalid assertions
17245 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17246 is removed.
17247 (riscv_gdbarch_init): Gather isa features and abi features
17248 separately, ensure both match on the gdbarch when reusing an old
17249 gdbarch. Relax an error check to allow 32-bit abi float to run on
17250 a target with 64-bit float hardware.
17251
b18ca514
PW
172522019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17253
17254 * source.c (search_command_helper): Stop reverse search
17255 when line 1 has been searched.
17256
ec70d8db
PW
172572019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17258
17259 * record-full.c (record_full_base_target::close): Rewrite
17260 record_full_core_buf_list free logic.
17261
5b38f9c1
PW
172622019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17263
17264 * break-catch-syscall.c (print_one_catch_syscall): xfree
17265 the last text.
17266
66d91b39
JB
172672019-01-01 Joel Brobecker <brobecker@adacore.com>
17268
17269 * top.c (print_gdb_version): Update Copyright year in version
17270 message.
17271
42a4f53d
JB
172722019-01-01 Joel Brobecker <brobecker@adacore.com>
17273
17274 Update copyright year range in all GDB files.
17275
7e955d83 172762019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 17277
5bbd631d 17278 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 17279
5bbd631d 17280For older changes see ChangeLog-2018.
c906108c
SS
17281\f
17282Local Variables:
17283mode: change-log
17284left-margin: 8
17285fill-column: 74
17286version-control: never
57da7796 17287coding: utf-8
c906108c 17288End:
5bbd631d 17289
This page took 4.433249 seconds and 4 git commands to generate.